pi-web-ui 0.8.6 → 0.8.7

package/dist/server/agent-service.js

@@ -988,6 +988,41 @@ export class ClientSession {
             });
         }
     }
+    /**
+     * After `npm i -g`, confirm the on-disk package this process serves from
+     * actually changed to the new version and is complete. Windows npm updates
+     * can fail partway (locked files / Defender / npm rollback) and leave the
+     * global install without its bin links — restarting into that is a silent
+     * crash (web/dist missing + `pi-web-ui` no longer on PATH). Returns null
+     * when OK, else a human-readable problem description.
+     */
+    static verifyGlobalInstall() {
+        try {
+            const here = dirname(fileURLToPath(import.meta.url));
+            const pkgRoot = resolve(here, "..", "..");
+            const pkg = JSON.parse(readFileSync(join(pkgRoot, "package.json"), "utf8"));
+            if (!pkg.version || pkg.version === ClientSession.currentAppVersion()) {
+                return `安装目录版本未变化（${pkg.version ?? "未知"}）`;
+            }
+            if (!existsSync(join(pkgRoot, "web", "dist", "index.html"))) {
+                return "web/dist/index.html 缺失（前端产物未安装完整）";
+            }
+            if (!existsSync(join(pkgRoot, "bin", "pi-web-ui.mjs"))) {
+                return "bin/pi-web-ui.mjs 缺失";
+            }
+            if (process.platform === "win32") {
+                const prefix = dirname(process.execPath);
+                const hasShim = existsSync(join(prefix, "pi-web-ui.cmd")) ||
+                    existsSync(join(prefix, "pi-web-ui.ps1"));
+                if (!hasShim)
+                    return "pi-web-ui 命令入口（bin 链接）未生成";
+            }
+            return null;
+        }
+        catch (err) {
+            return `读取安装目录失败：${err.message}`;
+        }
+    }
     /** npm i -g pi-web-ui@latest — the new code only takes effect after a restart. */
     async updateApp() {
         try {
@@ -997,34 +1032,50 @@ export class ClientSession {
                 text: "正在更新 pi-web-ui（npm i -g pi-web-ui@latest）…",
             });
             const { code, out } = await this.runAsync("npm", ["i", "-g", "pi-web-ui@latest"], 180_000);
-            if (code === 0) {
-                this.pendingRestart = true;
+            if (code !== 0) {
                 this.emit({
                     type: "update_result",
-                    ok: true,
-                    detail: out.slice(0, 400),
+                    ok: false,
+                    detail: `npm i 失败（${code ?? "timeout"}）：${out.slice(0, 400)}`,
                 });
-                const autoRestart = this.onUpdateReady?.() ?? false;
                 this.emit({
                     type: "notice",
-                    level: "info",
-                    text: autoRestart
-                        ? "✅ 已更新 pi-web-ui，正在自动重启…"
-                        : "✅ 已更新 pi-web-ui，重启服务后生效（pi-web-ui server restart）",
+                    level: "error",
+                    text: `更新 pi-web-ui 失败（${code ?? "timeout"}）：${out.slice(0, 300)}`,
                 });
+                return;
             }
-            else {
+            // npm reported success, but on Windows the replacement can be partial
+            // (locked files, rollback) — restarting into a broken install is a
+            // crash with no hint. Verify before handing over.
+            const problem = ClientSession.verifyGlobalInstall();
+            if (problem) {
                 this.emit({
                     type: "update_result",
                     ok: false,
-                    detail: `npm i 失败（${code ?? "timeout"}）：${out.slice(0, 400)}`,
+                    detail: `npm i 成功但安装不完整（${problem}）。请手动执行 npm i -g pi-web-ui@latest 修复后再重启服务。`,
                 });
                 this.emit({
                     type: "notice",
                     level: "error",
-                    text: `更新 pi-web-ui 失败（${code ?? "timeout"}）：${out.slice(0, 300)}`,
+                    text: `更新未完整生效（${problem}）。请手动执行 npm i -g pi-web-ui@latest 修复`,
                 });
+                return;
             }
+            this.pendingRestart = true;
+            this.emit({
+                type: "update_result",
+                ok: true,
+                detail: out.slice(0, 400),
+            });
+            const autoRestart = this.onUpdateReady?.() ?? false;
+            this.emit({
+                type: "notice",
+                level: "info",
+                text: autoRestart
+                    ? "✅ 已更新 pi-web-ui，正在自动重启…"
+                    : "✅ 已更新 pi-web-ui，重启服务后生效（pi-web-ui server restart）",
+            });
         }
         catch (err) {
             this.emit({

package/dist/server/index.js

@@ -89,13 +89,31 @@ app.get("/api/file", async (req, res) => {
 // from the repo root. In dev, Vite serves the UI on :5173 and proxies /ws.
 const here = dirname(fileURLToPath(import.meta.url)); // <pkg>/dist/server or <pkg>/server
 const pkgRoot = resolve(here, "..", "..");
+/** Set in the env of the replacement child spawned by a self-update restart. */
+const RESTART_CHILD_ENV = "PI_WEB_RESTART_CHILD";
 const webDist = join(pkgRoot, "web", "dist");
 if (existsSync(webDist)) {
     app.use(express.static(webDist));
     app.get(/^\/(?!api\/|ws).*/, (_req, res) => {
-        res.sendFile(join(webDist, "index.html"));
+        // Callback form: a failed stat here (npm i -g is mid-replacement of the
+        // package dir) responds 503 instead of crashing the request pipeline
+        // with an unhandled ENOENT stack trace.
+        res.sendFile(join(webDist, "index.html"), (err) => {
+            if (err && !res.headersSent) {
+                res.status(503).send("正在更新 pi-web-ui，请稍后刷新…");
+            }
+        });
     });
 }
+else if (process.env[RESTART_CHILD_ENV]) {
+    // Auto-restart replacement of a self-update whose npm install did not
+    // complete (Windows: locked files / rollback can leave the global package
+    // without web/dist). Fail loudly with a repair hint instead of serving a
+    // UI-less 404 with no explanation.
+    console.error("✖ 更新后的安装不完整（缺少 web/dist/index.html）。\n" +
+        "  请手动执行 npm i -g pi-web-ui@latest 修复后重新启动。");
+    process.exit(1);
+}
 const httpServer = createServer(app);
 const wss = new WebSocketServer({ server: httpServer, path: "/ws" });
 // Heartbeat: lets clients detect half-open connections (server killed without
@@ -120,7 +138,6 @@ join(DATA_DIR, "client-state.json"));
 //   foreground runs get a replacement child that waits for our port to free.
 // Docker containers can't self-restart (the orchestrator owns that), so they
 // keep the manual-restart notice.
-const RESTART_CHILD_ENV = "PI_WEB_RESTART_CHILD";
 function scheduleUpdateRestart() {
     const isLaunchd = process.platform === "darwin" && process.ppid === 1;
     const isSystemd = process.platform === "linux" && !!process.env.INVOCATION_ID;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-web-ui",
-  "version": "0.8.6",
+  "version": "0.8.7",
   "description": "Web chat interface for the pi coding agent, powered by the pi SDK (@earendil-works/pi-coding-agent) — one-command run, Docker/systemd/launchd deployable",
   "license": "MIT",
   "type": "module",