pi-web-ui 0.6.0 → 0.6.2

package/dist/server/agent-service.js

@@ -11,7 +11,7 @@
  */
 import { spawn } from "node:child_process";
 import { existsSync, readFileSync, statSync, writeFileSync, mkdirSync, } from "node:fs";
-import { dirname, join, resolve } from "node:path";
+import { dirname, join, relative, resolve, sep } from "node:path";
 import { fileURLToPath } from "node:url";
 import { createAgentSessionFromServices, createAgentSessionRuntime, createAgentSessionServices, getAgentDir, SessionManager, } from "@earendil-works/pi-coding-agent";
 import { serializeMessage, serializeStreamingMessage, } from "./serialize.js";
@@ -429,6 +429,18 @@ function extractPartialText(partial) {
     }
     return null;
 }
+/**
+ * Resolve a workspace-relative path against a root, refusing traversal
+ * (".." escapes). Returns { abs, rel } — rel is normalized and slash-
+ * separated — or null when the path leaves the workspace.
+ */
+export function workspacePath(root, raw) {
+    const abs = resolve(root, raw);
+    const rel = relative(root, abs);
+    if (rel.startsWith("..") || rel.includes(`${sep}..`))
+        return null;
+    return { abs, rel };
+}
 /**
  * Persists which workspace each browser client last used + which workspaces it
  * has opened, so a server restart / page reload restores the same project and
@@ -1810,11 +1822,9 @@ export class ClientSession {
     async readFile(relPath) {
         try {
             const fs = await import("node:fs/promises");
-            const { resolve, sep, relative } = await import("node:path");
             const root = resolve(this.cwd);
-            const abs = resolve(root, relPath);
-            const rel = relative(root, abs);
-            if (rel.startsWith("..") || rel.includes(`${sep}..`)) {
+            const wp = workspacePath(root, relPath);
+            if (!wp) {
                 this.emit({
                     type: "notice",
                     level: "warning",
@@ -1822,6 +1832,7 @@ export class ClientSession {
                 });
                 return;
             }
+            const { abs, rel } = wp;
             const stat = await fs.stat(abs);
             if (!stat.isFile()) {
                 this.emit({

package/dist/server/index.js

@@ -15,13 +15,13 @@
 import { existsSync } from "node:fs";
 import { stat } from "node:fs/promises";
 import { createServer } from "node:http";
-import { basename, dirname, join, relative, resolve, sep } from "node:path";
+import { basename, dirname, join, resolve } from "node:path";
 import { fileURLToPath } from "node:url";
 import { randomUUID } from "node:crypto";
 import express from "express";
 import { WebSocket, WebSocketServer } from "ws";
 import { VERSION } from "@earendil-works/pi-coding-agent";
-import { AgentService, previewKind } from "./agent-service.js";
+import { AgentService, previewKind, workspacePath } from "./agent-service.js";
 const PORT = Number(process.env.PORT ?? 8787);
 const CWD = resolve(process.env.PI_WEB_CWD ?? process.cwd());
 const DATA_DIR = resolve(process.env.PI_WEB_DATA_DIR ?? join(CWD, ".pi-web"));
@@ -40,12 +40,18 @@ app.get("/api/health", (_req, res) => {
 app.get("/api/file", async (req, res) => {
     try {
         const raw = typeof req.query.path === "string" ? req.query.path : "";
-        const abs = resolve(CWD, raw);
-        const rel = relative(CWD, abs);
-        if (rel.startsWith("..") || rel.includes(`${sep}..`)) {
+        // Resolve against the requesting client's workspace (the opened
+        // project), not the server's startup cwd — they can differ when the
+        // client switched projects or restored a previous workspace. Fall
+        // back to the server cwd for requests without a known client.
+        const cid = typeof req.query.clientId === "string" ? req.query.clientId : "";
+        const cs = cid ? service.get(cid) : undefined;
+        const wp = workspacePath(cs?.cwd ?? CWD, raw);
+        if (!wp) {
             res.status(400).end("path outside workspace");
             return;
         }
+        const abs = wp.abs;
         const name = basename(abs);
         const kind = previewKind(name);
         if (kind !== "image" && kind !== "video") {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-web-ui",
-  "version": "0.6.0",
+  "version": "0.6.2",
   "description": "Web chat interface for the pi coding agent, powered by the pi SDK (@earendil-works/pi-coding-agent) — one-command run, Docker/systemd/launchd deployable",
   "license": "MIT",
   "type": "module",