pi-vault-mind 0.16.25 → 0.16.28

package/CHANGELOG.md

@@ -1,6 +1,32 @@
 # Changelog
 
 
+## 0.16.28 — 2026-08-09
+
+### Fixed
+
+- **CLI setup no longer invents vault folder structure.** `/vm setup` (and `scaffold.ts`'s fallback scaffolding) used to default `vaultMind.folders` to a guessed `Agent/Inbox`/`Agent/Library`/`Agent/Presentations`/`Agent/Journal` convention. In a real vault with its own organization scheme (PARA-style numbered folders, an existing inbox elsewhere, etc.) this silently created a stray top-level `Agent/` folder and misfiled real auto-synced content into it. The interactive wizard now shows a real folder picker — built from the vault's actual existing directories (walked up to 2 levels deep) — with explicit "Type a custom path..." and "Skip — configure later" options, matching the Obsidian plugin's existing `FoldersStep` folder-browser behavior. Headless `/vm setup` (CLI flags) and `scaffoldVaultConfig()` no longer populate a guessed folders block at all; `folders` stays unset until deliberately configured.
+
+### Verification
+
+- Full build + `node --test dist/test/**/*.test.js`: 894/894 passing.
+- Added a regression test asserting a fresh headless `/vm setup` leaves `vaultMind.folders` unset rather than reinventing the old default.
+- Reproduced the failure mode live: a real vault's auto-sync wrote 5 real notes into a newly-created `Agent/Inbox/` instead of the vault's actual `00-system/00.01-inbox/`.
+
+## 0.16.27 — 2026-08-09
+
+### Fixed
+
+- **CLI setup drift — root cause of a real 404.** `vaultMind.dataDir` defaulted to bare `.lancedb` (leaks outside `.vault-mind/`) in `DEFAULT_CONFIG`/`scaffold.ts`; only the Obsidian plugin's wizard got this fix previously (`a8475d9`). Now `.vault-mind/.lancedb` in both.
+- **Broken local Ollama URL.** The interactive `/vm setup` wizard's "Local (Ollama)" branch wrote `localUrl` as `http://127.0.0.1:11434/v1`; the OpenAI-compatible embedding provider then appends `/v1/embeddings` regardless, producing `.../v1/v1/embeddings` — a deterministic 404 on every embed, not the transient failure it looked like. Now writes the bare host, matching `DEFAULT_CONFIG` and the wizard's own Ollama probe three lines above the bug.
+- **Missing vault folders in CLI setup.** `/vm setup` never asked about or defaulted `vaultMind.folders` (inbox/library/presentations/journal). Added a wizard step (with reconfigure pre-fill) and matching defaults in `scaffold.ts` and the headless CLI-args path, aligned with the Obsidian wizard's defaults.
+- **`vault-pi.sh` Terminal.app detection** on macOS versions where it moved to `/System/Applications/Utilities/`.
+
+### Verification
+
+- Full build + `node --test dist/test/**/*.test.js`: 894/894 passing.
+- Reproduced the `/v1/v1/embeddings` 404 live against a running Ollama instance before and after the fix.
+
 ## 0.16.12 / 0.6.16 — 2026-07-20
 
 ### Fixed

package/dist/src/scaffold.js

@@ -166,7 +166,7 @@ export const scaffoldVaultConfig = (vaultPath, collectionOverride) => {
                 },
             },
             vaultMind: {
-                dataDir: ".lancedb",
+                dataDir: ".vault-mind/.lancedb",
                 ftsEnabled: true,
                 graph: { enabled: true, canvasSync: false },
             },

package/dist/src/settings-ui.js

@@ -458,7 +458,7 @@ export const setupWizard = async (ctx, cliArgs) => {
         return;
     }
     if (provider.startsWith("Local")) {
-        localUrl = "http://127.0.0.1:11434/v1";
+        localUrl = "http://127.0.0.1:11434";
         // Let user pick from detected Ollama embedding models
         const modelChoice = await ctx.ui.select("Select embedding model:", ollamaModels.map((m) => m.name));
         if (!modelChoice) {
@@ -514,6 +514,62 @@ export const setupWizard = async (ctx, cliArgs) => {
         model = "Xenova/all-MiniLM-L6-v2";
         dim = 384;
     }
+    // ── Step 2.5: Vault folders ──────────────────────────────────────────────
+    // Lists real existing folders rather than guessing a convention (e.g.
+    // "Agent/Inbox") — a blind default silently creates the wrong structure
+    // in vaults that already have their own organization scheme.
+    const FOLDER_IGNORE = new Set([
+        ".git",
+        ".obsidian",
+        ".vault-mind",
+        ".pi",
+        "node_modules",
+        ".trash",
+        ".DS_Store",
+    ]);
+    const listVaultFolders = (root) => {
+        const results = [];
+        const walk = (dir, rel, depth) => {
+            if (depth > 2)
+                return;
+            let entries;
+            try {
+                entries = fs.readdirSync(dir, { withFileTypes: true });
+            }
+            catch {
+                return;
+            }
+            for (const entry of entries) {
+                if (!entry.isDirectory() || entry.name.startsWith(".") || FOLDER_IGNORE.has(entry.name))
+                    continue;
+                const relPath = rel ? `${rel}/${entry.name}` : entry.name;
+                results.push(relPath);
+                walk(path.join(dir, entry.name), relPath, depth + 1);
+            }
+        };
+        walk(root, "", 0);
+        return results.sort();
+    };
+    const SKIP_FOLDER = "(skip — configure later)";
+    const CUSTOM_FOLDER = "→ Type a custom path...";
+    const pickFolder = async (label, current) => {
+        const options = [SKIP_FOLDER, CUSTOM_FOLDER, ...vaultFolders];
+        const prompt = current ? `${label} (current: ${current})` : label;
+        const choice = await ctx.ui.select(prompt, options);
+        if (!choice || choice === SKIP_FOLDER)
+            return "";
+        if (choice === CUSTOM_FOLDER)
+            return (await ctx.ui.input(`${label} — path:`, current || "")) || "";
+        return choice;
+    };
+    const existingFolders = existingConfigFile
+        ? (JSON.parse(fs.readFileSync(getConfigPath(ctx.cwd), "utf-8")).vaultMind?.folders ?? {})
+        : {};
+    const vaultFolders = fs.existsSync(vaultPath) ? listVaultFolders(vaultPath) : [];
+    const inboxFolder = await pickFolder("Inbox folder (agent capture target)", existingFolders.inbox);
+    const libraryFolder = await pickFolder("Library folder (durable knowledge notes)", existingFolders.library);
+    const presentationsFolder = await pickFolder("Presentations folder", existingFolders.presentations);
+    const journalFolder = await pickFolder("Journal folder", existingFolders.journal);
     // ── Step 3: Deterministic runtime settings ──────────────────────────────
     const enableContextAutomation = await ctx.ui.confirm("Context automation", "Enable pi-context integration with auto-/acm trigger and event indexing?");
     const enableAutoStart = await ctx.ui.confirm("Vault auto-start", "Auto-start watcher/server for this vault when pi session starts?");
@@ -522,6 +578,7 @@ export const setupWizard = async (ctx, cliArgs) => {
         `Remote URL: ${remoteUrl || "none"}`,
         `Local URL: ${localUrl || "none"}`,
         `Model: ${model || "(auto/server default)"}`,
+        `Folders: inbox=${inboxFolder || "(unset)"}, library=${libraryFolder || "(unset)"}, presentations=${presentationsFolder || "(unset)"}, journal=${journalFolder || "(unset)"}`,
         `Context automation: ${enableContextAutomation ? "enabled" : "disabled"}`,
         `Vault auto-start: ${enableAutoStart ? "enabled" : "disabled"}`,
     ].join("\n"));
@@ -552,6 +609,22 @@ export const setupWizard = async (ctx, cliArgs) => {
         autoSync: true,
         autoStart: enableAutoStart,
     };
+    const chosenFolders = {};
+    if (inboxFolder)
+        chosenFolders.inbox = inboxFolder;
+    if (libraryFolder)
+        chosenFolders.library = libraryFolder;
+    if (presentationsFolder)
+        chosenFolders.presentations = presentationsFolder;
+    if (journalFolder)
+        chosenFolders.journal = journalFolder;
+    if (Object.keys(chosenFolders).length > 0) {
+        config.vaultMind.folders = chosenFolders;
+    }
+    else if (Object.keys(existingFolders).length > 0) {
+        // All skipped during a reconfigure — preserve what was already set.
+        config.vaultMind.folders = existingFolders;
+    }
     config.vaultMind.graph = config.vaultMind.graph || { enabled: true, canvasSync: true };
     config.vaultMind.ftsEnabled = config.vaultMind.ftsEnabled !== false;
     // Extension-compatibility (pi-context) now lives in the single consolidated

package/dist/src/types.js

@@ -26,7 +26,7 @@ export const DEFAULT_CONFIG = {
         },
     ],
     vaultMind: {
-        dataDir: ".lancedb",
+        dataDir: ".vault-mind/.lancedb",
         agentLLM: {
             remoteUrl: "http://127.0.0.1:11434/v1",
         },

package/dist/test/settings-ui.test.js

@@ -182,6 +182,11 @@ describe("/vm setup collection scaffolding (regression)", () => {
         assert.equal(cfg.vaultMind?.embedding?.remoteUrl, "https://example.test");
         assert.equal(cfg.vaultMind?.embedding?.model, "embeddinggemma");
         assert.ok(cfg.vaultMind?.vaults?.default?.path, "vaults.default.path should be written");
+        // Regression: headless setup used to invent an "Agent/Inbox" etc.
+        // folders block on a fresh vault. Guessing a folder convention that
+        // doesn't match the vault's actual structure silently misfiles
+        // content — folders must stay unset until deliberately configured.
+        assert.equal(cfg.vaultMind?.folders, undefined, "fresh headless setup should not invent a folders block");
         fs.rmSync(vault, { recursive: true, force: true });
     });
     it("preserves an explicit empty injector array during subsequent setup runs", async () => {

package/dist/test/utils.test.js

@@ -374,7 +374,7 @@ describe("loadConfig", () => {
         assert.equal(cfg.version, 2);
         // mergeConfigLayer overwrites collections with resolved (empty) when no layer provides them
         assert.deepEqual(cfg.collections, {});
-        assert.equal(cfg.vaultMind.dataDir, ".lancedb");
+        assert.equal(cfg.vaultMind.dataDir, ".vault-mind/.lancedb");
         assert.equal(cfg.vaultMind.embedding.localUrl, "http://127.0.0.1:11434");
     });
     it("merges user config over defaults", () => {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-vault-mind",
-	"version": "0.16.25",
+	"version": "0.16.28",
 	"description": "Passive Obsidian vault extension for pi. Watches @agent markers, dispatches forked subagents (Miner, Broadcaster, Heavy-Lifter), stores in LanceDB with vector + FTS + graph. Multi-agent 'Drop & Forget' workflow for the pi agent ecosystem.",
 	"main": "dist/index.js",
 	"types": "dist/index.d.ts",

package/scripts/vault-pi.sh

@@ -49,7 +49,7 @@ PI_CMD="PI_CODING_AGENT_DIR='${PI_DIR}' pi ${OP_ENV_ARG}; rm -f '${PID_FILE}'"
 
 if [ -d "/Applications/iTerm.app" ]; then
 	open -a iTerm --args --detach bash -c "echo \$\$ > '${PID_FILE}'; cd '${VAULT}'; ${PI_CMD}"
-elif [ -d "/Applications/Utilities/Terminal.app" ]; then
+elif [ -d "/Applications/Utilities/Terminal.app" ] || [ -d "/System/Applications/Utilities/Terminal.app" ]; then
 	osascript -e "tell application \"Terminal\" to do script \"echo \$\$ > '${PID_FILE}'; cd '${VAULT}'; ${PI_CMD}\""
 else
 	echo "[vault-pi] No supported terminal found (iTerm or Terminal.app)"