pi-vault-mind 0.14.2 → 0.16.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (164) hide show
  1. package/CHANGELOG.md +293 -0
  2. package/README.md +5 -5
  3. package/agents/broadcaster.agent.md +2 -2
  4. package/agents/heavy-lifter.agent.md +1 -1
  5. package/agents/main.agent.md +29 -0
  6. package/agents/manager.agent.md +1 -1
  7. package/agents/miner.agent.md +1 -1
  8. package/dist/packages/obsidian/src/client.js +331 -0
  9. package/dist/packages/obsidian/src/types.js +1 -0
  10. package/dist/src/activity.d.ts +49 -0
  11. package/dist/src/activity.js +175 -0
  12. package/dist/src/agent-bus/Agent.d.ts +9 -1
  13. package/dist/src/agent-bus/Agent.js +18 -2
  14. package/dist/src/agent-bus/index.d.ts +5 -5
  15. package/dist/src/agent-bus/index.js +1 -1
  16. package/dist/src/agent-queue.js +12 -3
  17. package/dist/src/agents/BroadcasterAgent.d.ts +1 -1
  18. package/dist/src/agents/BroadcasterAgent.js +2 -2
  19. package/dist/src/agents/HeavyLifterAgent.d.ts +1 -1
  20. package/dist/src/agents/HeavyLifterAgent.js +2 -2
  21. package/dist/src/agents/ManagerAgent.js +1 -1
  22. package/dist/src/agents/MinerAgent.d.ts +1 -1
  23. package/dist/src/agents/MinerAgent.js +2 -2
  24. package/dist/src/agents/index.d.ts +2 -2
  25. package/dist/src/agents/index.js +2 -2
  26. package/dist/src/auth.d.ts +17 -15
  27. package/dist/src/auth.js +26 -37
  28. package/dist/src/autosync.js +2 -2
  29. package/dist/src/commands.d.ts +2 -19
  30. package/dist/src/commands.js +301 -231
  31. package/dist/src/config-keys.d.ts +16 -0
  32. package/dist/src/config-keys.js +45 -0
  33. package/dist/src/discover-schema.js +4 -4
  34. package/dist/src/edits.d.ts +21 -0
  35. package/dist/src/edits.js +75 -0
  36. package/dist/src/embedding-probe.d.ts +34 -0
  37. package/dist/src/embedding-probe.js +142 -0
  38. package/dist/src/embedding-providers.d.ts +133 -0
  39. package/dist/src/embedding-providers.js +173 -0
  40. package/dist/src/embedding-secrets.d.ts +38 -0
  41. package/dist/src/embedding-secrets.js +291 -0
  42. package/dist/src/engine.d.ts +6 -0
  43. package/dist/src/engine.js +78 -6
  44. package/dist/src/events.js +7 -10
  45. package/dist/src/extension-packages.d.ts +9 -0
  46. package/dist/src/extension-packages.js +14 -0
  47. package/dist/src/git.d.ts +19 -0
  48. package/dist/src/git.js +78 -0
  49. package/dist/src/graph.d.ts +2 -1
  50. package/dist/src/graph.js +47 -13
  51. package/dist/src/identities-config.d.ts +6 -0
  52. package/dist/src/identities-config.js +39 -0
  53. package/dist/src/identity-injector.js +1 -1
  54. package/dist/src/index.js +9 -26
  55. package/dist/src/lance.d.ts +9 -0
  56. package/dist/src/lance.js +143 -203
  57. package/dist/src/modal-client.d.ts +16 -0
  58. package/dist/src/modal-client.js +16 -0
  59. package/dist/src/modal-config.d.ts +37 -14
  60. package/dist/src/modal-config.js +59 -32
  61. package/dist/src/model-router.d.ts +27 -0
  62. package/dist/src/model-router.js +67 -0
  63. package/dist/src/models.d.ts +42 -0
  64. package/dist/src/models.js +78 -0
  65. package/dist/src/personalize.js +17 -3
  66. package/dist/src/scaffold.d.ts +48 -0
  67. package/dist/src/scaffold.js +246 -0
  68. package/dist/src/server.d.ts +47 -4
  69. package/dist/src/server.js +988 -221
  70. package/dist/src/session-search.d.ts +63 -0
  71. package/dist/src/session-search.js +379 -0
  72. package/dist/src/settings-ui.d.ts +2 -2
  73. package/dist/src/settings-ui.js +76 -135
  74. package/dist/src/sync.d.ts +3 -3
  75. package/dist/src/sync.js +19 -15
  76. package/dist/src/tool-catalog.d.ts +18 -0
  77. package/dist/src/tool-catalog.js +232 -0
  78. package/dist/src/tools/marksman.js +1 -1
  79. package/dist/src/tools.js +111 -65
  80. package/dist/src/types.d.ts +127 -71
  81. package/dist/src/utils.d.ts +57 -6
  82. package/dist/src/utils.js +114 -28
  83. package/dist/src/vault-tools.d.ts +34 -0
  84. package/dist/src/vault-tools.js +99 -0
  85. package/dist/src/vault-writer.js +4 -1
  86. package/dist/src/vm-handlers.js +140 -43
  87. package/dist/src/watcher.js +9 -9
  88. package/dist/test/activity-tool.test.js +54 -0
  89. package/dist/test/agent-bus/Agent.test.js +174 -0
  90. package/dist/test/agent-bus/AgentLoader.test.js +180 -0
  91. package/dist/test/agent-bus/AgentRegistry.test.js +86 -0
  92. package/dist/test/agent-bus/LLMProvider.test.js +162 -0
  93. package/dist/test/agent-bus/TaskQueue.test.js +256 -0
  94. package/dist/test/agent-dispatch-context.test.js +73 -0
  95. package/dist/test/agent-queue.test.js +1 -1
  96. package/dist/test/agents/Agents.test.js +282 -0
  97. package/dist/test/auth.test.js +57 -56
  98. package/dist/test/bridge-identity.test.js +34 -3
  99. package/dist/test/classify-search-mode.test.js +51 -0
  100. package/dist/test/commands.test.js +410 -0
  101. package/dist/test/config-merge.test.js +98 -0
  102. package/dist/test/context-capture.test.js +56 -0
  103. package/dist/test/discover-schema.test.js +8 -5
  104. package/dist/test/dispatch.test.js +45 -91
  105. package/dist/test/edits.test.js +144 -0
  106. package/dist/test/embedding-probe.test.js +424 -0
  107. package/dist/test/embedding-providers.test.js +157 -0
  108. package/dist/test/embedding-secrets.test.js +210 -0
  109. package/dist/test/engine-identity.test.js +1 -1
  110. package/dist/test/events.test.js +675 -0
  111. package/dist/test/git-bridge.test.js +160 -0
  112. package/dist/test/graph.test.js +464 -0
  113. package/dist/test/helpers/server.js +81 -0
  114. package/dist/test/identity-injector.test.js +197 -0
  115. package/dist/test/index.test.js +5 -7
  116. package/dist/test/lance-modal.test.js +67 -2
  117. package/dist/test/lance.test.js +429 -0
  118. package/dist/test/modal-client.test.js +1 -1
  119. package/dist/test/modal-config.test.js +92 -79
  120. package/dist/test/model-readiness.test.js +122 -0
  121. package/dist/test/model-router.test.js +99 -0
  122. package/dist/test/obsidian-client.test.js +42 -0
  123. package/dist/test/personalize.test.js +1 -1
  124. package/dist/test/rest-models.test.js +153 -0
  125. package/dist/test/rest-queue.test.js +135 -87
  126. package/dist/test/rest-setup.test.js +625 -115
  127. package/dist/test/rest-vm.test.js +355 -94
  128. package/dist/test/server-cors.test.js +48 -0
  129. package/dist/test/server-ws.test.js +61 -34
  130. package/dist/test/session-crud.test.js +323 -0
  131. package/dist/test/session-search.test.js +139 -0
  132. package/dist/test/settings-ui.test.js +113 -4
  133. package/dist/test/sync.test.js +12 -12
  134. package/dist/test/tombstone.test.js +8 -10
  135. package/dist/test/tool-catalog.test.js +86 -0
  136. package/dist/test/utils.test.js +588 -0
  137. package/dist/test/vault-tools.test.js +103 -12
  138. package/dist/test/vault-writer.test.js +371 -0
  139. package/dist/test/vm-handlers.test.js +620 -0
  140. package/extension-packages.json +9 -0
  141. package/package.json +107 -90
  142. package/pi-vault-mind.config.example.json +24 -2
  143. package/scripts/check-deps.sh +35 -32
  144. package/scripts/cli-e2e.mjs +215 -0
  145. package/scripts/configuration-e2e.mjs +783 -0
  146. package/scripts/e2e-commands.mjs +391 -0
  147. package/scripts/e2e-ws.mjs +3 -2
  148. package/scripts/fetch-modal-token.sh +4 -3
  149. package/scripts/generate-config-keys-json.mjs +45 -0
  150. package/scripts/generate-extension-packages-json.mjs +55 -0
  151. package/scripts/pi-session-query +0 -0
  152. package/scripts/publish-obsidian-plugin.sh +0 -0
  153. package/scripts/reset-test-vault.sh +2 -2
  154. package/scripts/setup-test-config.sh +0 -0
  155. package/scripts/setup-vault-pi.sh +48 -9
  156. package/scripts/test-slash-commands.mjs +2 -2
  157. package/scripts/vault-pi.sh +12 -3
  158. package/skills/github-release-notes-file/SKILL.md +42 -0
  159. package/skills/obsidian-guided-test-session/SKILL.md +110 -0
  160. package/skills/obsidian-interactive-test/SKILL.md +88 -0
  161. package/skills/obsidian-plugin-publish/SKILL.md +58 -0
  162. package/skills/pi-vault-mind-release/SKILL.md +141 -0
  163. package/skills/pre-test-release/SKILL.md +116 -0
  164. package/dist/test/auto-indexer.test.js +0 -2
@@ -0,0 +1,81 @@
1
+ import { once } from "node:events";
2
+ import * as fs from "node:fs";
3
+ import * as path from "node:path";
4
+ import { createServerState, startServer, stopServer, } from "../../src/server.js";
5
+ import { createWatcherState } from "../../src/watcher.js";
6
+ /** Bearer token shared by the auth-gated REST/WS tests. */
7
+ export const TEST_TOKEN = "test-token";
8
+ /**
9
+ * Create an isolated scratch vault under the repo root. The `.tmp-*` prefix is
10
+ * gitignored; the timestamp+random suffix keeps repeated or parallel runs from
11
+ * colliding. Pass a short, test-specific `prefix` (e.g. "rest-vm").
12
+ */
13
+ export const makeVault = (prefix) => {
14
+ const p = path.join(process.cwd(), `.tmp-${prefix}-${Date.now()}-${Math.random().toString(36).slice(2)}`);
15
+ if (fs.existsSync(p))
16
+ fs.rmSync(p, { recursive: true });
17
+ fs.mkdirSync(p, { recursive: true });
18
+ return p;
19
+ };
20
+ /**
21
+ * Write a vault-scoped config so the server resolves its `vaultPath`. Defaults
22
+ * to the minimal `{ vaultMind: { vaults: { default } } }`; pass `config` to
23
+ * write a richer one.
24
+ */
25
+ export const writeVaultConfig = (vaultPath, config) => {
26
+ const dir = path.join(vaultPath, ".vault-mind");
27
+ fs.mkdirSync(dir, { recursive: true });
28
+ fs.writeFileSync(path.join(dir, "vault-mind.config.json"), JSON.stringify(config ?? { vaultMind: { vaults: { default: { path: vaultPath } } } }), "utf-8");
29
+ };
30
+ /** No-op `ExtensionAPI` stub covering the surface the server touches in tests. */
31
+ export const fakePi = {
32
+ sendUserMessage: () => { },
33
+ events: { emit: () => { } },
34
+ getAllTools: () => [],
35
+ registerCommand: () => { },
36
+ registerTool: () => { },
37
+ };
38
+ /**
39
+ * Boot the extension HTTP/WS server on an OS-assigned port and resolve once it
40
+ * is listening. The caller owns env setup and `process.chdir` into the vault.
41
+ * Pass `readinessCallback` to wire `GET /vault-mind/model-readiness`.
42
+ */
43
+ export const startTestServer = async (pi = fakePi, readinessCallback) => {
44
+ const watcherState = createWatcherState();
45
+ const serverState = createServerState(0);
46
+ startServer(pi, serverState, watcherState, readinessCallback);
47
+ const srv = serverState.server;
48
+ if (!srv)
49
+ throw new Error("server not created");
50
+ if (!srv.listening)
51
+ await once(srv, "listening");
52
+ const addr = srv.address();
53
+ const port = typeof addr === "object" && addr ? addr.port : 0;
54
+ return { port, serverState, watcherState, stop: () => stopServer(serverState) };
55
+ };
56
+ /**
57
+ * JSON HTTP client for the test server. `opts.token` adds a bearer header;
58
+ * `opts.body` is JSON-encoded. Returns the parsed JSON body (or raw text when
59
+ * the response is not JSON).
60
+ */
61
+ export const fetchJson = async (port, method, routePath, opts = {}) => {
62
+ const headers = { "Content-Type": "application/json" };
63
+ if (opts.token)
64
+ headers.Authorization = `Bearer ${opts.token}`;
65
+ if (opts.headers)
66
+ Object.assign(headers, opts.headers);
67
+ const res = await fetch(`http://127.0.0.1:${port}${routePath}`, {
68
+ method,
69
+ headers,
70
+ body: opts.body !== undefined ? JSON.stringify(opts.body) : undefined,
71
+ });
72
+ const text = await res.text();
73
+ let body;
74
+ try {
75
+ body = text ? JSON.parse(text) : {};
76
+ }
77
+ catch {
78
+ body = text;
79
+ }
80
+ return { status: res.status, body };
81
+ };
@@ -0,0 +1,197 @@
1
+ import { strict as assert } from "node:assert";
2
+ import { describe, it } from "node:test";
3
+ import { registerIdentityInjector } from "../src/identity-injector.js";
4
+ /** Create a mock pi that captures the before_agent_start handler. */
5
+ function mockPi() {
6
+ const captured = { current: null };
7
+ const pi = {
8
+ on(event, handler) {
9
+ if (event === "before_agent_start") {
10
+ captured.current = handler;
11
+ }
12
+ },
13
+ };
14
+ return {
15
+ pi,
16
+ get handler() {
17
+ return captured.current;
18
+ },
19
+ };
20
+ }
21
+ /** Build a minimal BeforeAgentStartEvent with optional skills. */
22
+ function makeEvent(opts) {
23
+ return {
24
+ type: "before_agent_start",
25
+ prompt: "test prompt",
26
+ systemPrompt: opts.systemPrompt ?? "base system prompt",
27
+ systemPromptOptions: {
28
+ cwd: "/test",
29
+ skills: opts.skills,
30
+ },
31
+ };
32
+ }
33
+ /** Build a Skill with a given name. */
34
+ function skill(name) {
35
+ return {
36
+ name,
37
+ description: "",
38
+ filePath: `/skills/${name}.md`,
39
+ baseDir: "/skills",
40
+ sourceInfo: { source: "test" },
41
+ disableModelInvocation: false,
42
+ };
43
+ }
44
+ // ── Tests ─────────────────────────────────────────────────────────────────────
45
+ describe("registerIdentityInjector", () => {
46
+ it("registers a before_agent_start hook on the pi instance", () => {
47
+ const mock = mockPi();
48
+ registerIdentityInjector(mock.pi);
49
+ assert.ok(mock.handler, "handler should be registered");
50
+ });
51
+ it("the hook returns undefined for non-vault-mind sessions (no matching skill)", async () => {
52
+ const mock = mockPi();
53
+ registerIdentityInjector(mock.pi);
54
+ assert.ok(mock.handler);
55
+ const event = makeEvent({
56
+ skills: [skill("some-other-skill"), skill("another-skill")],
57
+ });
58
+ const result = await mock.handler(event);
59
+ assert.strictEqual(result, undefined);
60
+ });
61
+ it("the hook returns undefined when skills array is empty", async () => {
62
+ const mock = mockPi();
63
+ registerIdentityInjector(mock.pi);
64
+ assert.ok(mock.handler);
65
+ const event = makeEvent({ skills: [] });
66
+ const result = await mock.handler(event);
67
+ assert.strictEqual(result, undefined);
68
+ });
69
+ it("the hook returns undefined when skills is undefined (no skills at all)", async () => {
70
+ const mock = mockPi();
71
+ registerIdentityInjector(mock.pi);
72
+ assert.ok(mock.handler);
73
+ const event = makeEvent({});
74
+ const result = await mock.handler(event);
75
+ assert.strictEqual(result, undefined);
76
+ });
77
+ it("the hook injects boundary prompt for heavy-lifter role", async () => {
78
+ const mock = mockPi();
79
+ registerIdentityInjector(mock.pi);
80
+ assert.ok(mock.handler);
81
+ const event = makeEvent({
82
+ skills: [skill("vault-mind-heavy-lifter")],
83
+ systemPrompt: "base prompt",
84
+ });
85
+ const result = await mock.handler(event);
86
+ assert.ok(result);
87
+ assert.ok("systemPrompt" in result);
88
+ assert.ok(result.systemPrompt.includes("base prompt"));
89
+ assert.ok(result.systemPrompt.includes("IDENTITY BOUNDARY: Heavy-Lifter"));
90
+ assert.ok(result.systemPrompt.includes("durable knowledge store"));
91
+ });
92
+ it("the hook injects boundary prompt for miner role", async () => {
93
+ const mock = mockPi();
94
+ registerIdentityInjector(mock.pi);
95
+ assert.ok(mock.handler);
96
+ const event = makeEvent({
97
+ skills: [skill("vault-mind-miner")],
98
+ systemPrompt: "base prompt",
99
+ });
100
+ const result = await mock.handler(event);
101
+ assert.ok(result);
102
+ assert.ok("systemPrompt" in result);
103
+ assert.ok(result.systemPrompt.includes("base prompt"));
104
+ assert.ok(result.systemPrompt.includes("IDENTITY BOUNDARY: Miner"));
105
+ assert.ok(result.systemPrompt.includes("'main' and 'research'"));
106
+ });
107
+ it("the hook injects boundary prompt for broadcaster role", async () => {
108
+ const mock = mockPi();
109
+ registerIdentityInjector(mock.pi);
110
+ assert.ok(mock.handler);
111
+ const event = makeEvent({
112
+ skills: [skill("vault-mind-broadcaster")],
113
+ systemPrompt: "base prompt",
114
+ });
115
+ const result = await mock.handler(event);
116
+ assert.ok(result);
117
+ assert.ok("systemPrompt" in result);
118
+ assert.ok(result.systemPrompt.includes("base prompt"));
119
+ assert.ok(result.systemPrompt.includes("IDENTITY BOUNDARY: Broadcaster"));
120
+ assert.ok(result.systemPrompt.includes("Agent/Presentations"));
121
+ });
122
+ it("the hook injects boundary prompt for manager role", async () => {
123
+ const mock = mockPi();
124
+ registerIdentityInjector(mock.pi);
125
+ assert.ok(mock.handler);
126
+ const event = makeEvent({
127
+ skills: [skill("vault-mind-manager")],
128
+ systemPrompt: "base prompt",
129
+ });
130
+ const result = await mock.handler(event);
131
+ assert.ok(result);
132
+ assert.ok("systemPrompt" in result);
133
+ assert.ok(result.systemPrompt.includes("base prompt"));
134
+ assert.ok(result.systemPrompt.includes("IDENTITY BOUNDARY: Manager"));
135
+ assert.ok(result.systemPrompt.includes("publish to the human-facing vault"));
136
+ });
137
+ // ── Fallback: XML-based role detection ────────────────────────────────────
138
+ it("detects role via XML fallback when no skills match", async () => {
139
+ const mock = mockPi();
140
+ registerIdentityInjector(mock.pi);
141
+ assert.ok(mock.handler);
142
+ const event = makeEvent({
143
+ skills: [skill("unrelated-skill")],
144
+ systemPrompt: "base prompt\n<available_skills>\n<name>vault-mind-miner</name>\n</available_skills>",
145
+ });
146
+ const result = await mock.handler(event);
147
+ assert.ok(result);
148
+ assert.ok("systemPrompt" in result);
149
+ assert.ok(result.systemPrompt.includes("IDENTITY BOUNDARY: Miner"));
150
+ });
151
+ it("detects role via XML fallback when skills is undefined", async () => {
152
+ const mock = mockPi();
153
+ registerIdentityInjector(mock.pi);
154
+ assert.ok(mock.handler);
155
+ const event = makeEvent({
156
+ systemPrompt: "base prompt\n<available_skills>\n<name>vault-mind-broadcaster</name>\n</available_skills>",
157
+ });
158
+ const result = await mock.handler(event);
159
+ assert.ok(result);
160
+ assert.ok("systemPrompt" in result);
161
+ assert.ok(result.systemPrompt.includes("IDENTITY BOUNDARY: Broadcaster"));
162
+ });
163
+ it("returns undefined when XML fallback has no vault-mind role", async () => {
164
+ const mock = mockPi();
165
+ registerIdentityInjector(mock.pi);
166
+ assert.ok(mock.handler);
167
+ const event = makeEvent({
168
+ systemPrompt: "base prompt\n<available_skills>\n<name>some-other-skill</name>\n</available_skills>",
169
+ });
170
+ const result = await mock.handler(event);
171
+ assert.strictEqual(result, undefined);
172
+ });
173
+ // ── Case insensitivity ────────────────────────────────────────────────────
174
+ it("matches role case-insensitively (HEAVY-LIFTER)", async () => {
175
+ const mock = mockPi();
176
+ registerIdentityInjector(mock.pi);
177
+ assert.ok(mock.handler);
178
+ const event = makeEvent({
179
+ skills: [skill("vault-mind-HEAVY-LIFTER")],
180
+ });
181
+ const result = await mock.handler(event);
182
+ assert.ok(result);
183
+ assert.ok("systemPrompt" in result);
184
+ assert.ok(result.systemPrompt.includes("IDENTITY BOUNDARY: Heavy-Lifter"));
185
+ });
186
+ // ── Unknown role ──────────────────────────────────────────────────────────
187
+ it("returns undefined for an unknown vault-mind role", async () => {
188
+ const mock = mockPi();
189
+ registerIdentityInjector(mock.pi);
190
+ assert.ok(mock.handler);
191
+ const event = makeEvent({
192
+ skills: [skill("vault-mind-unknown-role")],
193
+ });
194
+ const result = await mock.handler(event);
195
+ assert.strictEqual(result, undefined);
196
+ });
197
+ });
@@ -4,6 +4,7 @@ import * as fs from "node:fs";
4
4
  import { tmpdir } from "node:os";
5
5
  import * as path from "node:path";
6
6
  import { afterEach, beforeEach, describe, it } from "node:test";
7
+ import { planGitignore } from "../src/scaffold.js";
7
8
  describe("pi-vault-mind", () => {
8
9
  let testDir;
9
10
  beforeEach(() => {
@@ -56,7 +57,9 @@ describe("pi-vault-mind", () => {
56
57
  const cwd = process.cwd();
57
58
  process.chdir(testDir);
58
59
  try {
59
- const configPath = path.join(testDir, "pi-vault-mind.config.json");
60
+ const vaultMindDir = path.join(testDir, ".vault-mind");
61
+ fs.mkdirSync(vaultMindDir, { recursive: true });
62
+ const configPath = path.join(vaultMindDir, "vault-mind.config.json");
60
63
  const collectionsDir = path.join(testDir, "collections");
61
64
  fs.mkdirSync(collectionsDir, { recursive: true });
62
65
  fs.writeFileSync(path.join(collectionsDir, "main.jsonl"), '{"id":"1","domain":"test","fact":"hello world","tag":"test"}\n');
@@ -365,14 +368,12 @@ describe("pi-vault-mind", () => {
365
368
  }
366
369
  });
367
370
  it("planGitignore creates a vault .gitignore when none exists", async () => {
368
- const { planGitignore } = await import("../src/commands.js");
369
371
  const plan = planGitignore(null);
370
372
  assert.equal(plan.action, "create");
371
373
  assert.ok(plan.content.includes(".lancedb/"), "must ignore the binary index");
372
374
  assert.ok(plan.content.includes(".obsidian/workspace*.json"), "must ignore churny workspace state");
373
375
  });
374
376
  it("planGitignore appends only missing entries, tolerating slash-format differences", async () => {
375
- const { planGitignore } = await import("../src/commands.js");
376
377
  // obsidian-git already ignores the index, but in a different slash format
377
378
  // (leading slash, no trailing slash) and without the workspace-state rule.
378
379
  const plan = planGitignore("node_modules/\n/.lancedb\n");
@@ -381,19 +382,16 @@ describe("pi-vault-mind", () => {
381
382
  assert.ok(!plan.content.includes(".lancedb"), "should not duplicate an entry already present under a different slash format");
382
383
  });
383
384
  it("planGitignore skips when all entries are already present", async () => {
384
- const { planGitignore } = await import("../src/commands.js");
385
- const plan = planGitignore(".lancedb/\n.obsidian/workspace*.json\n");
385
+ const plan = planGitignore(".vault-mind/*\n!.vault-mind/vault-mind.config.json\n.lancedb/\n.obsidian/workspace*.json\n");
386
386
  assert.equal(plan.action, "skip");
387
387
  assert.equal(plan.content, "");
388
388
  });
389
389
  it("planGitignore avoids gluing a new entry onto an unterminated last line", async () => {
390
- const { planGitignore } = await import("../src/commands.js");
391
390
  const plan = planGitignore("node_modules/"); // no trailing newline
392
391
  assert.equal(plan.action, "append");
393
392
  assert.ok(plan.content.startsWith("\n"), "should insert a separating newline first");
394
393
  });
395
394
  it("planGitignore appends to an empty file without a leading blank line", async () => {
396
- const { planGitignore } = await import("../src/commands.js");
397
395
  const plan = planGitignore("");
398
396
  assert.equal(plan.action, "append");
399
397
  assert.ok(!plan.content.startsWith("\n"), "empty file needs no leading blank line");
@@ -4,7 +4,7 @@ import * as fs from "node:fs";
4
4
  import { tmpdir } from "node:os";
5
5
  import * as path from "node:path";
6
6
  import { afterEach, beforeEach, describe, it } from "node:test";
7
- import { connect, resetConnection, searchFts, searchHybrid, upsertPrecomputed, } from "../src/lance.js";
7
+ import { connect, resetConnection, searchFts, searchHybrid, upsertEntry, upsertPrecomputed, } from "../src/lance.js";
8
8
  import { MODAL_TOKEN_ENV } from "../src/modal-config.js";
9
9
  const MODEL = "testmodel";
10
10
  const DIM = 3;
@@ -12,7 +12,7 @@ const makeCfg = (dataDir) => ({
12
12
  dataDir,
13
13
  embedding: {
14
14
  remoteUrl: "https://pvm.modal.run",
15
- modal: { baseUrl: "https://pvm.modal.run", model: MODEL },
15
+ model: MODEL,
16
16
  coalesce: { debounceMs: 5, maxBatchSize: 1, maxConcurrentFlushes: 1 },
17
17
  },
18
18
  ftsEnabled: true,
@@ -93,3 +93,68 @@ describe("Modal lance path (precomputed + search + fallback)", () => {
93
93
  assert.ok(Array.isArray(results));
94
94
  });
95
95
  });
96
+ describe("upsertEntry Modal path", () => {
97
+ let dir;
98
+ let origToken;
99
+ let origFetch;
100
+ beforeEach(() => {
101
+ dir = path.join(tmpdir(), `pvm-lance-upsert-${randomUUID()}`);
102
+ fs.mkdirSync(dir, { recursive: true });
103
+ origToken = process.env[MODAL_TOKEN_ENV];
104
+ process.env[MODAL_TOKEN_ENV] = "tok";
105
+ origFetch = globalThis.fetch;
106
+ resetConnection();
107
+ });
108
+ afterEach(() => {
109
+ if (origToken === undefined)
110
+ delete process.env[MODAL_TOKEN_ENV];
111
+ else
112
+ process.env[MODAL_TOKEN_ENV] = origToken;
113
+ globalThis.fetch = origFetch;
114
+ resetConnection();
115
+ fs.rmSync(dir, { recursive: true, force: true });
116
+ });
117
+ it("embeds via Modal and inserts into the namespaced table", async () => {
118
+ const cfg = makeCfg(dir);
119
+ globalThis.fetch = (async () => ({
120
+ ok: true,
121
+ status: 200,
122
+ json: async () => ({ model: MODEL, dim: DIM, vectors: [[1, 0, 0]] }),
123
+ text: async () => "",
124
+ }));
125
+ await upsertEntry(dir, "main", { id: "modal-1", fact: "modal entry", domain: "test" }, cfg);
126
+ const conn = await connect(dir);
127
+ const table = await conn.openTable(`col_main__${MODEL}__${DIM}`);
128
+ assert.equal(await table.countRows(), 1);
129
+ const rows = await table.query().limit(1).toArray();
130
+ assert.equal(rows[0].id, "modal-1");
131
+ assert.equal(rows[0].fact, "modal entry");
132
+ });
133
+ it("skips vector indexing gracefully when Modal is offline and no fallback is configured", async () => {
134
+ const cfg = makeCfg(dir);
135
+ globalThis.fetch = (async () => {
136
+ throw new Error("network unreachable");
137
+ });
138
+ await assert.doesNotReject(async () => {
139
+ await upsertEntry(dir, "main", { id: "offline-1", fact: "offline entry", domain: "test" }, cfg);
140
+ });
141
+ const conn = await connect(dir);
142
+ const tableNames = await conn.tableNames();
143
+ assert.ok(!tableNames.includes(`col_main__${MODEL}__${DIM}`), "no table created when embed fails");
144
+ });
145
+ it("skips vector indexing gracefully when Modal returns an error response", async () => {
146
+ const cfg = makeCfg(dir);
147
+ globalThis.fetch = (async () => ({
148
+ ok: false,
149
+ status: 500,
150
+ json: async () => ({ error: "server error" }),
151
+ text: async () => "server error",
152
+ }));
153
+ await assert.doesNotReject(async () => {
154
+ await upsertEntry(dir, "main", { id: "err-1", fact: "error entry", domain: "test" }, cfg);
155
+ });
156
+ const conn = await connect(dir);
157
+ const tableNames = await conn.tableNames();
158
+ assert.ok(!tableNames.includes(`col_main__${MODEL}__${DIM}`), "no table created when embed fails");
159
+ });
160
+ });