pi-usereq 0.6.0 → 0.10.0

package/pi.dev-src/pi-mono/coding-agent/test/session-selector-path-delete.test.ts

@@ -0,0 +1,315 @@
+import { mkdirSync, mkdtempSync, rmSync, symlinkSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { setKeybindings } from "@mariozechner/pi-tui";
+import { afterEach, beforeAll, beforeEach, describe, expect, it } from "vitest";
+import { KeybindingsManager } from "../src/core/keybindings.js";
+import type { SessionInfo } from "../src/core/session-manager.js";
+import { SessionSelectorComponent } from "../src/modes/interactive/components/session-selector.js";
+import { initTheme } from "../src/modes/interactive/theme/theme.js";
+
+type Deferred<T> = {
+	promise: Promise<T>;
+	resolve: (value: T) => void;
+	reject: (err: unknown) => void;
+};
+
+function createDeferred<T>(): Deferred<T> {
+	let resolve: (value: T) => void = () => {};
+	let reject: (err: unknown) => void = () => {};
+	const promise = new Promise<T>((res, rej) => {
+		resolve = res;
+		reject = rej;
+	});
+	return { promise, resolve, reject };
+}
+
+async function flushPromises(): Promise<void> {
+	await new Promise<void>((resolve) => {
+		setImmediate(resolve);
+	});
+}
+
+function stripAnsi(text: string): string {
+	return text.replace(/\x1B\[[0-?]*[ -/]*[@-~]/g, "");
+}
+
+function makeSession(overrides: Partial<SessionInfo> & { id: string }): SessionInfo {
+	return {
+		path: overrides.path ?? `/tmp/${overrides.id}.jsonl`,
+		id: overrides.id,
+		cwd: overrides.cwd ?? "",
+		name: overrides.name,
+		parentSessionPath: overrides.parentSessionPath,
+		created: overrides.created ?? new Date(0),
+		modified: overrides.modified ?? new Date(0),
+		messageCount: overrides.messageCount ?? 1,
+		firstMessage: overrides.firstMessage ?? "hello",
+		allMessagesText: overrides.allMessagesText ?? "hello",
+	};
+}
+
+function createSymlinkedSessionPaths(): {
+	baseDir: string;
+	parentAliasA: string;
+	parentAliasB: string;
+	childAliasB: string;
+} {
+	const baseDir = mkdtempSync(join(tmpdir(), "pi-session-selector-"));
+	const realDir = join(baseDir, "real");
+	const aliasADir = join(baseDir, "alias-a");
+	const aliasBDir = join(baseDir, "alias-b");
+	mkdirSync(realDir, { recursive: true });
+	mkdirSync(aliasADir, { recursive: true });
+	mkdirSync(aliasBDir, { recursive: true });
+
+	const sharedDir = join(realDir, "sessions");
+	mkdirSync(sharedDir, { recursive: true });
+	const aliasASessions = join(aliasADir, "sessions");
+	const aliasBSessions = join(aliasBDir, "sessions");
+	symlinkSync(sharedDir, aliasASessions);
+	symlinkSync(sharedDir, aliasBSessions);
+
+	const parentRealPath = join(sharedDir, "parent.jsonl");
+	const childRealPath = join(sharedDir, "child.jsonl");
+	writeFileSync(parentRealPath, "parent\n");
+	writeFileSync(childRealPath, "child\n");
+
+	return {
+		baseDir,
+		parentAliasA: join(aliasASessions, "parent.jsonl"),
+		parentAliasB: join(aliasBSessions, "parent.jsonl"),
+		childAliasB: join(aliasBSessions, "child.jsonl"),
+	};
+}
+
+const CTRL_D = "\x04";
+const CTRL_BACKSPACE = "\x1b[127;5u";
+
+describe("session selector path/delete interactions", () => {
+	const keybindings = new KeybindingsManager();
+	const tempDirs: string[] = [];
+
+	afterEach(() => {
+		for (const dir of tempDirs.splice(0)) {
+			rmSync(dir, { recursive: true, force: true });
+		}
+	});
+
+	beforeEach(() => {
+		// Ensure test isolation: keybindings are a global singleton
+		setKeybindings(new KeybindingsManager());
+	});
+
+	beforeAll(() => {
+		// session selector uses the global theme instance
+		initTheme("dark");
+	});
+	it("does not treat Ctrl+Backspace as delete when search query is non-empty", async () => {
+		const sessions = [makeSession({ id: "a" }), makeSession({ id: "b" })];
+
+		const selector = new SessionSelectorComponent(
+			async () => sessions,
+			async () => [],
+			() => {},
+			() => {},
+			() => {},
+			() => {},
+			{ keybindings },
+		);
+		await flushPromises();
+
+		const list = selector.getSessionList();
+		const confirmationChanges: Array<string | null> = [];
+		list.onDeleteConfirmationChange = (path) => confirmationChanges.push(path);
+
+		list.handleInput("a");
+		list.handleInput(CTRL_BACKSPACE);
+
+		expect(confirmationChanges).toEqual([]);
+	});
+
+	it("enters confirmation mode on Ctrl+D even with a non-empty search query", async () => {
+		const sessions = [makeSession({ id: "a" }), makeSession({ id: "b" })];
+
+		const selector = new SessionSelectorComponent(
+			async () => sessions,
+			async () => [],
+			() => {},
+			() => {},
+			() => {},
+			() => {},
+			{ keybindings },
+		);
+		await flushPromises();
+
+		const list = selector.getSessionList();
+		const confirmationChanges: Array<string | null> = [];
+		list.onDeleteConfirmationChange = (path) => confirmationChanges.push(path);
+
+		list.handleInput("a");
+		list.handleInput(CTRL_D);
+
+		expect(confirmationChanges).toEqual([sessions[0]!.path]);
+	});
+
+	it("enters confirmation mode on Ctrl+Backspace when search query is empty", async () => {
+		const sessions = [makeSession({ id: "a" }), makeSession({ id: "b" })];
+
+		const selector = new SessionSelectorComponent(
+			async () => sessions,
+			async () => [],
+			() => {},
+			() => {},
+			() => {},
+			() => {},
+			{ keybindings },
+		);
+		await flushPromises();
+
+		const list = selector.getSessionList();
+		const confirmationChanges: Array<string | null> = [];
+		list.onDeleteConfirmationChange = (path) => confirmationChanges.push(path);
+
+		let deletedPath: string | null = null;
+		list.onDeleteSession = async (sessionPath) => {
+			deletedPath = sessionPath;
+		};
+
+		list.handleInput(CTRL_BACKSPACE);
+		expect(confirmationChanges).toEqual([sessions[0]!.path]);
+
+		list.handleInput("\r");
+		expect(confirmationChanges).toEqual([sessions[0]!.path, null]);
+		expect(deletedPath).toBe(sessions[0]!.path);
+	});
+
+	it("does not switch scope back to All when All load resolves after toggling back to Current", async () => {
+		const currentSessions = [makeSession({ id: "current" })];
+		const allDeferred = createDeferred<SessionInfo[]>();
+		let allLoadCalls = 0;
+
+		const selector = new SessionSelectorComponent(
+			async () => currentSessions,
+			async () => {
+				allLoadCalls++;
+				return allDeferred.promise;
+			},
+			() => {},
+			() => {},
+			() => {},
+			() => {},
+			{ keybindings },
+		);
+		await flushPromises();
+
+		const list = selector.getSessionList();
+		list.handleInput("\t"); // current -> all (starts async load)
+		list.handleInput("\t"); // all -> current
+
+		allDeferred.resolve([makeSession({ id: "all" })]);
+		await flushPromises();
+
+		expect(allLoadCalls).toBe(1);
+		const output = selector.render(120).join("\n");
+		expect(output).toContain("Resume Session (Current Folder)");
+		expect(output).not.toContain("Resume Session (All)");
+	});
+
+	it("does not start redundant All loads when toggling scopes while All is already loading", async () => {
+		const currentSessions = [makeSession({ id: "current" })];
+		const allDeferred = createDeferred<SessionInfo[]>();
+		let allLoadCalls = 0;
+
+		const selector = new SessionSelectorComponent(
+			async () => currentSessions,
+			async () => {
+				allLoadCalls++;
+				return allDeferred.promise;
+			},
+			() => {},
+			() => {},
+			() => {},
+			() => {},
+			{ keybindings },
+		);
+		await flushPromises();
+
+		const list = selector.getSessionList();
+		list.handleInput("\t"); // current -> all (starts async load)
+		list.handleInput("\t"); // all -> current
+		list.handleInput("\t"); // current -> all again while load pending
+
+		expect(allLoadCalls).toBe(1);
+
+		allDeferred.resolve([makeSession({ id: "all" })]);
+		await flushPromises();
+	});
+
+	it("threads sessions when parent and child paths use different symlink aliases", async () => {
+		const paths = createSymlinkedSessionPaths();
+		tempDirs.push(paths.baseDir);
+
+		const sessions = [
+			makeSession({
+				id: "parent",
+				path: paths.parentAliasB,
+				name: "Parent",
+				modified: new Date("2026-01-01T00:00:00.000Z"),
+			}),
+			makeSession({
+				id: "child",
+				path: paths.childAliasB,
+				parentSessionPath: paths.parentAliasA,
+				name: "Child",
+				modified: new Date("2025-12-31T00:00:00.000Z"),
+			}),
+		];
+
+		const selector = new SessionSelectorComponent(
+			async () => sessions,
+			async () => [],
+			() => {},
+			() => {},
+			() => {},
+			() => {},
+			{ keybindings },
+		);
+		await flushPromises();
+
+		const output = stripAnsi(selector.render(120).join("\n"));
+		expect(output).toContain("Parent");
+		expect(output).toContain("└─ Child");
+	});
+
+	it("treats the current session as active across symlink aliases", async () => {
+		const paths = createSymlinkedSessionPaths();
+		tempDirs.push(paths.baseDir);
+
+		const sessions = [makeSession({ id: "parent", path: paths.parentAliasB, name: "Parent" })];
+		const selector = new SessionSelectorComponent(
+			async () => sessions,
+			async () => [],
+			() => {},
+			() => {},
+			() => {},
+			() => {},
+			{ keybindings },
+			paths.parentAliasA,
+		);
+		await flushPromises();
+
+		const list = selector.getSessionList();
+		const confirmationChanges: Array<string | null> = [];
+		let errorMessage: string | undefined;
+		list.onDeleteConfirmationChange = (path) => confirmationChanges.push(path);
+		list.onError = (message) => {
+			errorMessage = message;
+		};
+
+		list.handleInput(CTRL_D);
+
+		expect(confirmationChanges).toEqual([]);
+		expect(errorMessage).toBe("Cannot delete the currently active session");
+	});
+});

package/pi.dev-src/pi-mono/coding-agent/test/session-selector-rename.test.ts

@@ -0,0 +1,111 @@
+import { setKeybindings } from "@mariozechner/pi-tui";
+import { beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
+import { KeybindingsManager } from "../src/core/keybindings.js";
+import type { SessionInfo } from "../src/core/session-manager.js";
+import { SessionSelectorComponent } from "../src/modes/interactive/components/session-selector.js";
+import { initTheme } from "../src/modes/interactive/theme/theme.js";
+
+async function flushPromises(): Promise<void> {
+	await new Promise<void>((resolve) => {
+		setImmediate(resolve);
+	});
+}
+
+function makeSession(overrides: Partial<SessionInfo> & { id: string }): SessionInfo {
+	return {
+		path: overrides.path ?? `/tmp/${overrides.id}.jsonl`,
+		id: overrides.id,
+		cwd: overrides.cwd ?? "",
+		name: overrides.name,
+		created: overrides.created ?? new Date(0),
+		modified: overrides.modified ?? new Date(0),
+		messageCount: overrides.messageCount ?? 1,
+		firstMessage: overrides.firstMessage ?? "hello",
+		allMessagesText: overrides.allMessagesText ?? "hello",
+	};
+}
+
+// Kitty keyboard protocol encoding for Ctrl+R
+const CTRL_R = "\x1b[114;5u";
+
+describe("session selector rename", () => {
+	beforeAll(() => {
+		initTheme("dark");
+	});
+
+	beforeEach(() => {
+		// Ensure test isolation: keybindings are a global singleton
+		setKeybindings(new KeybindingsManager());
+	});
+
+	it("shows rename hint in interactive /resume picker configuration", async () => {
+		const sessions = [makeSession({ id: "a" })];
+		const keybindings = new KeybindingsManager();
+		const selector = new SessionSelectorComponent(
+			async () => sessions,
+			async () => [],
+			() => {},
+			() => {},
+			() => {},
+			() => {},
+			{ showRenameHint: true, keybindings },
+		);
+		await flushPromises();
+
+		const output = selector.render(120).join("\n");
+		expect(output).toContain("ctrl+r");
+		expect(output).toContain("rename");
+	});
+
+	it("does not show rename hint in --resume picker configuration", async () => {
+		const sessions = [makeSession({ id: "a" })];
+		const keybindings = new KeybindingsManager();
+		const selector = new SessionSelectorComponent(
+			async () => sessions,
+			async () => [],
+			() => {},
+			() => {},
+			() => {},
+			() => {},
+			{ showRenameHint: false, keybindings },
+		);
+		await flushPromises();
+
+		const output = selector.render(120).join("\n");
+		expect(output).not.toContain("ctrl+r");
+		expect(output).not.toContain("rename");
+	});
+
+	it("enters rename mode on Ctrl+R and submits with Enter", async () => {
+		const sessions = [makeSession({ id: "a", name: "Old" })];
+		const renameSession = vi.fn(async () => {});
+
+		const keybindings = new KeybindingsManager();
+		const selector = new SessionSelectorComponent(
+			async () => sessions,
+			async () => [],
+			() => {},
+			() => {},
+			() => {},
+			() => {},
+			{ renameSession, showRenameHint: true, keybindings },
+		);
+		await flushPromises();
+
+		selector.getSessionList().handleInput(CTRL_R);
+		await flushPromises();
+
+		// Rename mode layout
+		const output = selector.render(120).join("\n");
+		expect(output).toContain("Rename Session");
+		expect(output).not.toContain("Resume Session");
+
+		// Type and submit
+		selector.handleInput("X");
+		selector.handleInput("\r");
+		await flushPromises();
+
+		expect(renameSession).toHaveBeenCalledTimes(1);
+		expect(renameSession).toHaveBeenCalledWith(sessions[0]!.path, "XOld");
+	});
+});

package/pi.dev-src/pi-mono/coding-agent/test/session-selector-search.test.ts

@@ -0,0 +1,195 @@
+import { describe, expect, it } from "vitest";
+import type { SessionInfo } from "../src/core/session-manager.js";
+import { filterAndSortSessions } from "../src/modes/interactive/components/session-selector-search.js";
+
+function makeSession(
+	overrides: Partial<SessionInfo> & { id: string; modified: Date; allMessagesText: string },
+): SessionInfo {
+	return {
+		path: `/tmp/${overrides.id}.jsonl`,
+		id: overrides.id,
+		cwd: overrides.cwd ?? "",
+		name: overrides.name,
+		created: overrides.created ?? new Date(0),
+		modified: overrides.modified,
+		messageCount: overrides.messageCount ?? 1,
+		firstMessage: overrides.firstMessage ?? "(no messages)",
+		allMessagesText: overrides.allMessagesText,
+	};
+}
+
+describe("session selector search", () => {
+	it("filters by quoted phrase with whitespace normalization", () => {
+		const sessions: SessionInfo[] = [
+			makeSession({
+				id: "a",
+				modified: new Date("2026-01-01T00:00:00.000Z"),
+				allMessagesText: "node\n\n   cve was discussed",
+			}),
+			makeSession({
+				id: "b",
+				modified: new Date("2026-01-02T00:00:00.000Z"),
+				allMessagesText: "node something else",
+			}),
+		];
+
+		const result = filterAndSortSessions(sessions, '"node cve"', "recent");
+		expect(result.map((s) => s.id)).toEqual(["a"]);
+	});
+
+	it("filters by regex (re:) and is case-insensitive", () => {
+		const sessions: SessionInfo[] = [
+			makeSession({
+				id: "a",
+				modified: new Date("2026-01-02T00:00:00.000Z"),
+				allMessagesText: "Brave is great",
+			}),
+			makeSession({
+				id: "b",
+				modified: new Date("2026-01-03T00:00:00.000Z"),
+				allMessagesText: "bravery is not the same",
+			}),
+		];
+
+		const result = filterAndSortSessions(sessions, "re:\\bbrave\\b", "recent");
+		expect(result.map((s) => s.id)).toEqual(["a"]);
+	});
+
+	it("recent sort preserves input order", () => {
+		const sessions: SessionInfo[] = [
+			makeSession({
+				id: "newer",
+				modified: new Date("2026-01-03T00:00:00.000Z"),
+				allMessagesText: "brave",
+			}),
+			makeSession({
+				id: "older",
+				modified: new Date("2026-01-01T00:00:00.000Z"),
+				allMessagesText: "brave",
+			}),
+			makeSession({
+				id: "nomatch",
+				modified: new Date("2026-01-04T00:00:00.000Z"),
+				allMessagesText: "something else",
+			}),
+		];
+
+		const result = filterAndSortSessions(sessions, '"brave"', "recent");
+		expect(result.map((s) => s.id)).toEqual(["newer", "older"]);
+	});
+
+	it("relevance sort orders by score and tie-breaks by modified desc", () => {
+		const sessions: SessionInfo[] = [
+			makeSession({
+				id: "late",
+				modified: new Date("2026-01-03T00:00:00.000Z"),
+				allMessagesText: "xxxx brave",
+			}),
+			makeSession({
+				id: "early",
+				modified: new Date("2026-01-01T00:00:00.000Z"),
+				allMessagesText: "brave xxxx",
+			}),
+		];
+
+		const result1 = filterAndSortSessions(sessions, '"brave"', "relevance");
+		expect(result1.map((s) => s.id)).toEqual(["early", "late"]);
+
+		const tieSessions: SessionInfo[] = [
+			makeSession({
+				id: "newer",
+				modified: new Date("2026-01-03T00:00:00.000Z"),
+				allMessagesText: "brave",
+			}),
+			makeSession({
+				id: "older",
+				modified: new Date("2026-01-01T00:00:00.000Z"),
+				allMessagesText: "brave",
+			}),
+		];
+
+		const result2 = filterAndSortSessions(tieSessions, '"brave"', "relevance");
+		expect(result2.map((s) => s.id)).toEqual(["newer", "older"]);
+	});
+
+	it("returns empty list for invalid regex", () => {
+		const sessions: SessionInfo[] = [
+			makeSession({
+				id: "a",
+				modified: new Date("2026-01-01T00:00:00.000Z"),
+				allMessagesText: "brave",
+			}),
+		];
+
+		const result = filterAndSortSessions(sessions, "re:(", "recent");
+		expect(result).toEqual([]);
+	});
+
+	describe("name filter", () => {
+		const sessions: SessionInfo[] = [
+			makeSession({
+				id: "named1",
+				name: "My Project",
+				modified: new Date("2026-01-03T00:00:00.000Z"),
+				allMessagesText: "blueberry",
+			}),
+			makeSession({
+				id: "named2",
+				name: "Another Named",
+				modified: new Date("2026-01-02T00:00:00.000Z"),
+				allMessagesText: "blueberry",
+			}),
+			makeSession({
+				id: "other1",
+				modified: new Date("2026-01-04T00:00:00.000Z"),
+				allMessagesText: "blueberry",
+			}),
+			makeSession({
+				id: "other2",
+				modified: new Date("2026-01-01T00:00:00.000Z"),
+				allMessagesText: "blueberry",
+			}),
+		];
+
+		it("returns all sessions when nameFilter is 'all'", () => {
+			const result = filterAndSortSessions(sessions, "", "recent", "all");
+			expect(result.map((session) => session.id)).toEqual(["named1", "named2", "other1", "other2"]);
+		});
+
+		it("returns only named sessions when nameFilter is 'named'", () => {
+			const result = filterAndSortSessions(sessions, "", "recent", "named");
+			expect(result.map((session) => session.id)).toEqual(["named1", "named2"]);
+		});
+
+		it("applies name filter before search query", () => {
+			const result = filterAndSortSessions(sessions, "blueberry", "recent", "named");
+			expect(result.map((session) => session.id)).toEqual(["named1", "named2"]);
+		});
+
+		it("excludes whitespace-only names from named filter", () => {
+			const sessionsWithWhitespace: SessionInfo[] = [
+				makeSession({
+					id: "whitespace",
+					name: "   ",
+					modified: new Date("2026-01-01T00:00:00.000Z"),
+					allMessagesText: "test",
+				}),
+				makeSession({
+					id: "empty",
+					name: "",
+					modified: new Date("2026-01-02T00:00:00.000Z"),
+					allMessagesText: "test",
+				}),
+				makeSession({
+					id: "named",
+					name: "Real Name",
+					modified: new Date("2026-01-03T00:00:00.000Z"),
+					allMessagesText: "test",
+				}),
+			];
+
+			const result = filterAndSortSessions(sessionsWithWhitespace, "", "recent", "named");
+			expect(result.map((session) => session.id)).toEqual(["named"]);
+		});
+	});
+});