pi-usereq 0.49.0 → 0.51.0

package/pi.dev-src/pi-mono/tui/test/tui-render.test.ts

@@ -1,509 +0,0 @@
-import assert from "node:assert";
-import { describe, it } from "node:test";
-import type { Terminal as XtermTerminalType } from "@xterm/headless";
-import { type Component, TUI } from "../src/tui.js";
-import { VirtualTerminal } from "./virtual-terminal.js";
-
-class TestComponent implements Component {
-	lines: string[] = [];
-	render(_width: number): string[] {
-		return this.lines;
-	}
-	invalidate(): void {}
-}
-
-class LoggingVirtualTerminal extends VirtualTerminal {
-	private writes: string[] = [];
-
-	override write(data: string): void {
-		this.writes.push(data);
-		super.write(data);
-	}
-
-	getWrites(): string {
-		return this.writes.join("");
-	}
-
-	clearWrites(): void {
-		this.writes = [];
-	}
-}
-
-async function withEnv<T>(updates: Record<string, string | undefined>, run: () => Promise<T>): Promise<T> {
-	const previousValues = new Map<string, string | undefined>();
-	for (const [key, value] of Object.entries(updates)) {
-		previousValues.set(key, process.env[key]);
-		if (value === undefined) {
-			delete process.env[key];
-		} else {
-			process.env[key] = value;
-		}
-	}
-
-	try {
-		return await run();
-	} finally {
-		for (const [key, value] of previousValues) {
-			if (value === undefined) {
-				delete process.env[key];
-			} else {
-				process.env[key] = value;
-			}
-		}
-	}
-}
-
-function getCellItalic(terminal: VirtualTerminal, row: number, col: number): number {
-	const xterm = (terminal as unknown as { xterm: XtermTerminalType }).xterm;
-	const buffer = xterm.buffer.active;
-	const line = buffer.getLine(buffer.viewportY + row);
-	assert.ok(line, `Missing buffer line at row ${row}`);
-	const cell = line.getCell(col);
-	assert.ok(cell, `Missing cell at row ${row} col ${col}`);
-	return cell.isItalic();
-}
-
-describe("TUI resize handling", () => {
-	it("triggers full re-render when terminal height changes", async () => {
-		await withEnv({ TERMUX_VERSION: undefined }, async () => {
-			const terminal = new VirtualTerminal(40, 10);
-			const tui = new TUI(terminal);
-			const component = new TestComponent();
-			tui.addChild(component);
-
-			component.lines = ["Line 0", "Line 1", "Line 2"];
-			tui.start();
-			await terminal.waitForRender();
-
-			const initialRedraws = tui.fullRedraws;
-
-			// Resize height
-			terminal.resize(40, 15);
-			await terminal.waitForRender();
-
-			// Should have triggered a full redraw
-			assert.ok(tui.fullRedraws > initialRedraws, "Height change should trigger full redraw");
-
-			const viewport = terminal.getViewport();
-			assert.ok(viewport[0]?.includes("Line 0"), "Content preserved after height change");
-
-			tui.stop();
-		});
-	});
-
-	it("skips full re-render on height changes in Termux", async () => {
-		await withEnv({ TERMUX_VERSION: "1" }, async () => {
-			const terminal = new LoggingVirtualTerminal(40, 10);
-			const tui = new TUI(terminal);
-			const component = new TestComponent();
-			tui.addChild(component);
-
-			component.lines = Array.from({ length: 20 }, (_, i) => `Line ${i}`);
-			tui.start();
-			await terminal.waitForRender();
-			terminal.clearWrites();
-
-			const initialRedraws = tui.fullRedraws;
-			for (const height of [15, 8, 14, 11]) {
-				terminal.resize(40, height);
-				await terminal.waitForRender();
-			}
-
-			assert.strictEqual(tui.fullRedraws, initialRedraws, "Height change should not trigger full redraw");
-			assert.ok(!terminal.getWrites().includes("\x1b[2J"), "Height change should not clear the screen");
-			assert.ok(!terminal.getWrites().includes("\x1b[3J"), "Height change should not clear scrollback");
-
-			const viewport = terminal.getViewport();
-			assert.ok(viewport.join("\n").includes("Line 19"), "Latest content remains visible after resize");
-
-			tui.stop();
-		});
-	});
-
-	it("triggers full re-render when terminal width changes", async () => {
-		const terminal = new VirtualTerminal(40, 10);
-		const tui = new TUI(terminal);
-		const component = new TestComponent();
-		tui.addChild(component);
-
-		component.lines = ["Line 0", "Line 1", "Line 2"];
-		tui.start();
-		await terminal.waitForRender();
-
-		const initialRedraws = tui.fullRedraws;
-
-		// Resize width
-		terminal.resize(60, 10);
-		await terminal.waitForRender();
-
-		// Should have triggered a full redraw
-		assert.ok(tui.fullRedraws > initialRedraws, "Width change should trigger full redraw");
-
-		tui.stop();
-	});
-});
-
-describe("TUI content shrinkage", () => {
-	it("clears empty rows when content shrinks significantly", async () => {
-		const terminal = new VirtualTerminal(40, 10);
-		const tui = new TUI(terminal);
-		tui.setClearOnShrink(true); // Explicitly enable (may be disabled via env var)
-		const component = new TestComponent();
-		tui.addChild(component);
-
-		// Start with many lines
-		component.lines = ["Line 0", "Line 1", "Line 2", "Line 3", "Line 4", "Line 5"];
-		tui.start();
-		await terminal.waitForRender();
-
-		const initialRedraws = tui.fullRedraws;
-
-		// Shrink to fewer lines
-		component.lines = ["Line 0", "Line 1"];
-		tui.requestRender();
-		await terminal.waitForRender();
-
-		// Should have triggered a full redraw to clear empty rows
-		assert.ok(tui.fullRedraws > initialRedraws, "Content shrinkage should trigger full redraw");
-
-		const viewport = terminal.getViewport();
-		assert.ok(viewport[0]?.includes("Line 0"), "First line preserved");
-		assert.ok(viewport[1]?.includes("Line 1"), "Second line preserved");
-		// Lines below should be empty (cleared)
-		assert.strictEqual(viewport[2]?.trim(), "", "Line 2 should be cleared");
-		assert.strictEqual(viewport[3]?.trim(), "", "Line 3 should be cleared");
-
-		tui.stop();
-	});
-
-	it("handles shrink to single line", async () => {
-		const terminal = new VirtualTerminal(40, 10);
-		const tui = new TUI(terminal);
-		tui.setClearOnShrink(true); // Explicitly enable (may be disabled via env var)
-		const component = new TestComponent();
-		tui.addChild(component);
-
-		component.lines = ["Line 0", "Line 1", "Line 2", "Line 3"];
-		tui.start();
-		await terminal.waitForRender();
-
-		// Shrink to single line
-		component.lines = ["Only line"];
-		tui.requestRender();
-		await terminal.waitForRender();
-
-		const viewport = terminal.getViewport();
-		assert.ok(viewport[0]?.includes("Only line"), "Single line rendered");
-		assert.strictEqual(viewport[1]?.trim(), "", "Line 1 should be cleared");
-
-		tui.stop();
-	});
-
-	it("handles shrink to empty", async () => {
-		const terminal = new VirtualTerminal(40, 10);
-		const tui = new TUI(terminal);
-		tui.setClearOnShrink(true); // Explicitly enable (may be disabled via env var)
-		const component = new TestComponent();
-		tui.addChild(component);
-
-		component.lines = ["Line 0", "Line 1", "Line 2"];
-		tui.start();
-		await terminal.waitForRender();
-
-		// Shrink to empty
-		component.lines = [];
-		tui.requestRender();
-		await terminal.waitForRender();
-
-		const viewport = terminal.getViewport();
-		// All lines should be empty
-		assert.strictEqual(viewport[0]?.trim(), "", "Line 0 should be cleared");
-		assert.strictEqual(viewport[1]?.trim(), "", "Line 1 should be cleared");
-
-		tui.stop();
-	});
-});
-
-describe("TUI differential rendering", () => {
-	it("tracks cursor correctly when content shrinks with unchanged remaining lines", async () => {
-		const terminal = new VirtualTerminal(40, 10);
-		const tui = new TUI(terminal);
-		const component = new TestComponent();
-		tui.addChild(component);
-
-		// Initial render: 5 identical lines
-		component.lines = ["Line 0", "Line 1", "Line 2", "Line 3", "Line 4"];
-		tui.start();
-		await terminal.waitForRender();
-
-		// Shrink to 3 lines, all identical to before (no content changes in remaining lines)
-		component.lines = ["Line 0", "Line 1", "Line 2"];
-		tui.requestRender();
-		await terminal.waitForRender();
-
-		// cursorRow should be 2 (last line of new content)
-		// Verify by doing another render with a change on line 1
-		component.lines = ["Line 0", "CHANGED", "Line 2"];
-		tui.requestRender();
-		await terminal.waitForRender();
-
-		const viewport = terminal.getViewport();
-		// Line 1 should show "CHANGED", proving cursor tracking was correct
-		assert.ok(viewport[1]?.includes("CHANGED"), `Expected "CHANGED" on line 1, got: ${viewport[1]}`);
-
-		tui.stop();
-	});
-
-	it("renders correctly when only a middle line changes (spinner case)", async () => {
-		const terminal = new VirtualTerminal(40, 10);
-		const tui = new TUI(terminal);
-		const component = new TestComponent();
-		tui.addChild(component);
-
-		// Initial render
-		component.lines = ["Header", "Working...", "Footer"];
-		tui.start();
-		await terminal.waitForRender();
-
-		// Simulate spinner animation - only middle line changes
-		const spinnerFrames = ["|", "/", "-", "\\"];
-		for (const frame of spinnerFrames) {
-			component.lines = ["Header", `Working ${frame}`, "Footer"];
-			tui.requestRender();
-			await terminal.waitForRender();
-
-			const viewport = terminal.getViewport();
-			assert.ok(viewport[0]?.includes("Header"), `Header preserved: ${viewport[0]}`);
-			assert.ok(viewport[1]?.includes(`Working ${frame}`), `Spinner updated: ${viewport[1]}`);
-			assert.ok(viewport[2]?.includes("Footer"), `Footer preserved: ${viewport[2]}`);
-		}
-
-		tui.stop();
-	});
-
-	it("resets styles after each rendered line", async () => {
-		const terminal = new VirtualTerminal(20, 6);
-		const tui = new TUI(terminal);
-		const component = new TestComponent();
-		tui.addChild(component);
-
-		component.lines = ["\x1b[3mItalic", "Plain"];
-		tui.start();
-		await terminal.waitForRender();
-
-		assert.strictEqual(getCellItalic(terminal, 1, 0), 0);
-		tui.stop();
-	});
-
-	it("renders correctly when first line changes but rest stays same", async () => {
-		const terminal = new VirtualTerminal(40, 10);
-		const tui = new TUI(terminal);
-		const component = new TestComponent();
-		tui.addChild(component);
-
-		component.lines = ["Line 0", "Line 1", "Line 2", "Line 3"];
-		tui.start();
-		await terminal.waitForRender();
-
-		// Change only first line
-		component.lines = ["CHANGED", "Line 1", "Line 2", "Line 3"];
-		tui.requestRender();
-		await terminal.waitForRender();
-
-		const viewport = terminal.getViewport();
-		assert.ok(viewport[0]?.includes("CHANGED"), `First line changed: ${viewport[0]}`);
-		assert.ok(viewport[1]?.includes("Line 1"), `Line 1 preserved: ${viewport[1]}`);
-		assert.ok(viewport[2]?.includes("Line 2"), `Line 2 preserved: ${viewport[2]}`);
-		assert.ok(viewport[3]?.includes("Line 3"), `Line 3 preserved: ${viewport[3]}`);
-
-		tui.stop();
-	});
-
-	it("renders correctly when last line changes but rest stays same", async () => {
-		const terminal = new VirtualTerminal(40, 10);
-		const tui = new TUI(terminal);
-		const component = new TestComponent();
-		tui.addChild(component);
-
-		component.lines = ["Line 0", "Line 1", "Line 2", "Line 3"];
-		tui.start();
-		await terminal.waitForRender();
-
-		// Change only last line
-		component.lines = ["Line 0", "Line 1", "Line 2", "CHANGED"];
-		tui.requestRender();
-		await terminal.waitForRender();
-
-		const viewport = terminal.getViewport();
-		assert.ok(viewport[0]?.includes("Line 0"), `Line 0 preserved: ${viewport[0]}`);
-		assert.ok(viewport[1]?.includes("Line 1"), `Line 1 preserved: ${viewport[1]}`);
-		assert.ok(viewport[2]?.includes("Line 2"), `Line 2 preserved: ${viewport[2]}`);
-		assert.ok(viewport[3]?.includes("CHANGED"), `Last line changed: ${viewport[3]}`);
-
-		tui.stop();
-	});
-
-	it("renders correctly when multiple non-adjacent lines change", async () => {
-		const terminal = new VirtualTerminal(40, 10);
-		const tui = new TUI(terminal);
-		const component = new TestComponent();
-		tui.addChild(component);
-
-		component.lines = ["Line 0", "Line 1", "Line 2", "Line 3", "Line 4"];
-		tui.start();
-		await terminal.waitForRender();
-
-		// Change lines 1 and 3, keep 0, 2, 4 the same
-		component.lines = ["Line 0", "CHANGED 1", "Line 2", "CHANGED 3", "Line 4"];
-		tui.requestRender();
-		await terminal.waitForRender();
-
-		const viewport = terminal.getViewport();
-		assert.ok(viewport[0]?.includes("Line 0"), `Line 0 preserved: ${viewport[0]}`);
-		assert.ok(viewport[1]?.includes("CHANGED 1"), `Line 1 changed: ${viewport[1]}`);
-		assert.ok(viewport[2]?.includes("Line 2"), `Line 2 preserved: ${viewport[2]}`);
-		assert.ok(viewport[3]?.includes("CHANGED 3"), `Line 3 changed: ${viewport[3]}`);
-		assert.ok(viewport[4]?.includes("Line 4"), `Line 4 preserved: ${viewport[4]}`);
-
-		tui.stop();
-	});
-
-	it("handles transition from content to empty and back to content", async () => {
-		const terminal = new VirtualTerminal(40, 10);
-		const tui = new TUI(terminal);
-		const component = new TestComponent();
-		tui.addChild(component);
-
-		// Start with content
-		component.lines = ["Line 0", "Line 1", "Line 2"];
-		tui.start();
-		await terminal.waitForRender();
-
-		let viewport = terminal.getViewport();
-		assert.ok(viewport[0]?.includes("Line 0"), "Initial content rendered");
-
-		// Clear to empty
-		component.lines = [];
-		tui.requestRender();
-		await terminal.waitForRender();
-
-		// Add content back - this should work correctly even after empty state
-		component.lines = ["New Line 0", "New Line 1"];
-		tui.requestRender();
-		await terminal.waitForRender();
-
-		viewport = terminal.getViewport();
-		assert.ok(viewport[0]?.includes("New Line 0"), `New content rendered: ${viewport[0]}`);
-		assert.ok(viewport[1]?.includes("New Line 1"), `New content line 1: ${viewport[1]}`);
-
-		tui.stop();
-	});
-
-	it("full re-renders when deleted lines move the viewport upward", async () => {
-		const terminal = new VirtualTerminal(20, 5);
-		const tui = new TUI(terminal);
-		const component = new TestComponent();
-		tui.addChild(component);
-
-		component.lines = Array.from({ length: 12 }, (_, i) => `Line ${i}`);
-		tui.start();
-		await terminal.waitForRender();
-
-		const initialRedraws = tui.fullRedraws;
-
-		component.lines = Array.from({ length: 7 }, (_, i) => `Line ${i}`);
-		tui.requestRender();
-		await terminal.waitForRender();
-
-		assert.ok(tui.fullRedraws > initialRedraws, "Shrink should trigger a full redraw");
-		assert.deepStrictEqual(terminal.getViewport(), ["Line 2", "Line 3", "Line 4", "Line 5", "Line 6"]);
-
-		tui.stop();
-	});
-
-	it("appends after a shrink without another full redraw once the viewport is reset", async () => {
-		const terminal = new VirtualTerminal(20, 5);
-		const tui = new TUI(terminal);
-		const component = new TestComponent();
-		tui.addChild(component);
-
-		component.lines = Array.from({ length: 8 }, (_, i) => `Line ${i}`);
-		tui.start();
-		await terminal.waitForRender();
-
-		const initialRedraws = tui.fullRedraws;
-
-		component.lines = ["Line 0", "Line 1"];
-		tui.requestRender();
-		await terminal.waitForRender();
-
-		assert.ok(tui.fullRedraws > initialRedraws, "Shrink should reset the viewport with a full redraw");
-		const redrawsAfterShrink = tui.fullRedraws;
-
-		component.lines = ["Line 0", "Line 1", "Line 2"];
-		tui.requestRender();
-		await terminal.waitForRender();
-
-		assert.strictEqual(tui.fullRedraws, redrawsAfterShrink, "Append should stay on the differential path");
-		assert.deepStrictEqual(terminal.getViewport(), ["Line 0", "Line 1", "Line 2", "", ""]);
-
-		tui.stop();
-	});
-
-	it("clears stale content when maxLinesRendered was inflated by a transient component", async () => {
-		const terminal = new VirtualTerminal(40, 10);
-		const tui = new TUI(terminal);
-		const chat = new TestComponent();
-		const editor = new TestComponent();
-		tui.addChild(chat);
-		tui.addChild(editor);
-
-		const longChat = Array.from({ length: 15 }, (_, i) => `Chat ${i}`);
-		const shortChat = Array.from({ length: 12 }, (_, i) => `Chat ${i}`);
-		const editorLines = ["Editor 0", "Editor 1", "Editor 2"];
-		const selectorLines = Array.from({ length: 8 }, (_, i) => `Selector ${i}`);
-
-		chat.lines = longChat;
-		editor.lines = editorLines;
-		tui.start();
-		await terminal.waitForRender();
-
-		editor.lines = selectorLines;
-		tui.requestRender();
-		await terminal.waitForRender();
-
-		editor.lines = editorLines;
-		tui.requestRender();
-		await terminal.waitForRender();
-
-		const redrawsBeforeSwitch = tui.fullRedraws;
-		chat.lines = shortChat;
-		tui.requestRender();
-		await terminal.waitForRender();
-
-		assert.ok(tui.fullRedraws > redrawsBeforeSwitch, "Branch switch should trigger a full redraw");
-
-		const viewport = terminal.getViewport();
-		for (let i = 0; i < 10; i++) {
-			const line = viewport[i] ?? "";
-			assert.ok(!line.includes("Chat 12"), `Stale "Chat 12" at viewport row ${i}`);
-			assert.ok(!line.includes("Chat 13"), `Stale "Chat 13" at viewport row ${i}`);
-			assert.ok(!line.includes("Chat 14"), `Stale "Chat 14" at viewport row ${i}`);
-		}
-
-		assert.deepStrictEqual(viewport, [
-			"Chat 5",
-			"Chat 6",
-			"Chat 7",
-			"Chat 8",
-			"Chat 9",
-			"Chat 10",
-			"Chat 11",
-			"Editor 0",
-			"Editor 1",
-			"Editor 2",
-		]);
-
-		tui.stop();
-	});
-});

package/pi.dev-src/pi-mono/tui/test/viewport-overwrite-repro.ts

@@ -1,106 +0,0 @@
-/**
- * TUI viewport overwrite repro
- *
- * Place this file at: packages/tui/test/viewport-overwrite-repro.ts
- * Run from repo root: npx tsx packages/tui/test/viewport-overwrite-repro.ts
- *
- * For reliable repro, run in a small terminal (8-12 rows) or a tmux session:
- *   tmux new-session -d -s tui-bug -x 80 -y 12
- *   tmux send-keys -t tui-bug "npx tsx packages/tui/test/viewport-overwrite-repro.ts" Enter
- *   tmux attach -t tui-bug
- *
- * Expected behavior:
- * - PRE-TOOL lines remain visible above tool output.
- * - POST-TOOL lines append after tool output without overwriting earlier content.
- *
- * Actual behavior (bug):
- * - When content exceeds the viewport and new lines arrive after a tool-call pause,
- *   some earlier PRE-TOOL lines near the bottom are overwritten by POST-TOOL lines.
- */
-import { ProcessTerminal } from "../src/terminal.js";
-import { type Component, TUI } from "../src/tui.js";
-
-const sleep = (ms: number): Promise<void> => new Promise((resolve) => setTimeout(resolve, ms));
-
-class Lines implements Component {
-	private lines: string[] = [];
-
-	set(lines: string[]): void {
-		this.lines = lines;
-	}
-
-	append(lines: string[]): void {
-		this.lines.push(...lines);
-	}
-
-	render(width: number): string[] {
-		return this.lines.map((line) => {
-			if (line.length > width) return line.slice(0, width);
-			return line.padEnd(width, " ");
-		});
-	}
-
-	invalidate(): void {}
-}
-
-async function streamLines(buffer: Lines, label: string, count: number, delayMs: number, ui: TUI): Promise<void> {
-	for (let i = 1; i <= count; i += 1) {
-		buffer.append([`${label} ${String(i).padStart(2, "0")}`]);
-		ui.requestRender();
-		await sleep(delayMs);
-	}
-}
-
-async function main(): Promise<void> {
-	const ui = new TUI(new ProcessTerminal());
-	const buffer = new Lines();
-	ui.addChild(buffer);
-	ui.start();
-
-	const height = ui.terminal.rows;
-	const preCount = height + 8; // Ensure content exceeds viewport
-	const toolCount = height + 12; // Tool output pushes further into scrollback
-	const postCount = 6;
-
-	buffer.set([
-		"TUI viewport overwrite repro",
-		`Viewport rows detected: ${height}`,
-		"(Resize to ~8-12 rows for best repro)",
-		"",
-		"=== PRE-TOOL STREAM ===",
-	]);
-	ui.requestRender();
-	await sleep(300);
-
-	// Phase 1: Stream pre-tool text until viewport is exceeded.
-	await streamLines(buffer, "PRE-TOOL LINE", preCount, 30, ui);
-
-	// Phase 2: Simulate tool call pause and tool output.
-	buffer.append(["", "--- TOOL CALL START ---", "(pause...)", ""]);
-	ui.requestRender();
-	await sleep(700);
-
-	await streamLines(buffer, "TOOL OUT", toolCount, 20, ui);
-
-	// Phase 3: Post-tool streaming. This is where overwrite often appears.
-	buffer.append(["", "=== POST-TOOL STREAM ==="]);
-	ui.requestRender();
-	await sleep(300);
-	await streamLines(buffer, "POST-TOOL LINE", postCount, 40, ui);
-
-	// Leave the output visible briefly, then restore terminal state.
-	await sleep(1500);
-	ui.stop();
-}
-
-main().catch((error) => {
-	// Ensure terminal is restored if something goes wrong.
-	try {
-		const ui = new TUI(new ProcessTerminal());
-		ui.stop();
-	} catch {
-		// Ignore restore errors.
-	}
-	process.stderr.write(`${String(error)}\n`);
-	process.exitCode = 1;
-});