pi-usereq 0.49.0 → 0.50.0

package/pi.dev-src/pi-mono/coding-agent/test/suite/harness.ts

@@ -1,208 +0,0 @@
-/**
- * Local test harness for the new coding-agent test suite.
- */
-
-import { existsSync, mkdirSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import type { AgentMessage, AgentTool } from "@mariozechner/pi-agent-core";
-import { Agent } from "@mariozechner/pi-agent-core";
-import type { FauxModelDefinition, FauxProviderRegistration, FauxResponseStep, Model } from "@mariozechner/pi-ai";
-import { registerFauxProvider } from "@mariozechner/pi-ai";
-import { AgentSession, type AgentSessionEvent } from "../../src/core/agent-session.js";
-import { AuthStorage } from "../../src/core/auth-storage.js";
-import type { ExtensionRunner } from "../../src/core/extensions/index.js";
-import { convertToLlm } from "../../src/core/messages.js";
-import { ModelRegistry } from "../../src/core/model-registry.js";
-import { SessionManager } from "../../src/core/session-manager.js";
-import type { Settings } from "../../src/core/settings-manager.js";
-import { SettingsManager } from "../../src/core/settings-manager.js";
-import type { ExtensionFactory, ResourceLoader } from "../../src/index.js";
-import {
-	type CreateTestExtensionsResultInput,
-	createTestExtensionsResult,
-	createTestResourceLoader,
-} from "../utilities.js";
-
-type MessageTextPart = { type: "text"; text: string };
-
-export function getMessageText(message: unknown): string {
-	if (!message || typeof message !== "object" || !("content" in message)) {
-		return "";
-	}
-	const content = (message as { content?: string | Array<{ type: string; text?: string }> }).content;
-	if (content === undefined) {
-		return "";
-	}
-	if (typeof content === "string") {
-		return content;
-	}
-	return content
-		.filter((part): part is MessageTextPart => part.type === "text")
-		.map((part) => part.text)
-		.join("\n");
-}
-
-export function getUserTexts(harness: Harness): string[] {
-	return harness.session.messages
-		.filter((message) => message.role === "user")
-		.map((message) => getMessageText(message));
-}
-
-export function getAssistantTexts(harness: Harness): string[] {
-	return harness.session.messages
-		.filter((message) => message.role === "assistant")
-		.map((message) => getMessageText(message));
-}
-
-export interface HarnessOptions {
-	models?: FauxModelDefinition[];
-	settings?: Partial<Settings>;
-	systemPrompt?: string;
-	tools?: AgentTool[];
-	resourceLoader?: ResourceLoader;
-	extensionFactories?: Array<ExtensionFactory | CreateTestExtensionsResultInput>;
-	withConfiguredAuth?: boolean;
-}
-
-export interface Harness {
-	session: AgentSession;
-	sessionManager: SessionManager;
-	settingsManager: SettingsManager;
-	authStorage: AuthStorage;
-	faux: FauxProviderRegistration;
-	models: [Model<string>, ...Model<string>[]];
-	getModel(): Model<string>;
-	getModel(modelId: string): Model<string> | undefined;
-	setResponses: (responses: FauxResponseStep[]) => void;
-	appendResponses: (responses: FauxResponseStep[]) => void;
-	getPendingResponseCount: () => number;
-	events: AgentSessionEvent[];
-	eventsOfType<T extends AgentSessionEvent["type"]>(type: T): Extract<AgentSessionEvent, { type: T }>[];
-	tempDir: string;
-	cleanup: () => void;
-}
-
-function createTempDir(): string {
-	const tempDir = join(tmpdir(), `pi-suite-${Date.now()}-${Math.random().toString(36).slice(2)}`);
-	mkdirSync(tempDir, { recursive: true });
-	return tempDir;
-}
-
-export async function createHarness(options: HarnessOptions = {}): Promise<Harness> {
-	const tempDir = createTempDir();
-	const fauxProvider: FauxProviderRegistration = registerFauxProvider({
-		models: options.models,
-	});
-	fauxProvider.setResponses([]);
-	const model = fauxProvider.getModel();
-	const toolMap = options.tools ? Object.fromEntries(options.tools.map((tool) => [tool.name, tool])) : undefined;
-	const withConfiguredAuth = options.withConfiguredAuth ?? true;
-	const extensionRunnerRef: { current?: ExtensionRunner } = {};
-
-	const sessionManager = SessionManager.inMemory();
-	const settingsManager = SettingsManager.inMemory(options.settings);
-
-	const authStorage = AuthStorage.inMemory();
-	if (withConfiguredAuth) {
-		authStorage.setRuntimeApiKey(model.provider, "faux-key");
-	}
-	const modelRegistry = ModelRegistry.inMemory(authStorage);
-	if (withConfiguredAuth) {
-		modelRegistry.registerProvider(model.provider, {
-			baseUrl: model.baseUrl,
-			apiKey: "faux-key",
-			api: fauxProvider.api,
-			models: fauxProvider.models.map((registeredModel) => ({
-				id: registeredModel.id,
-				name: registeredModel.name,
-				api: registeredModel.api,
-				reasoning: registeredModel.reasoning,
-				input: registeredModel.input,
-				cost: registeredModel.cost,
-				contextWindow: registeredModel.contextWindow,
-				maxTokens: registeredModel.maxTokens,
-				baseUrl: registeredModel.baseUrl,
-			})),
-		});
-	}
-
-	const agent = new Agent({
-		getApiKey: () => (withConfiguredAuth ? "faux-key" : undefined),
-		initialState: {
-			model,
-			systemPrompt: options.systemPrompt ?? "You are a test assistant.",
-			tools: [],
-		},
-		convertToLlm,
-		onPayload: async (payload) => {
-			const runner = extensionRunnerRef.current;
-			if (!runner?.hasHandlers("before_provider_request")) {
-				return payload;
-			}
-			return runner.emitBeforeProviderRequest(payload);
-		},
-		onResponse: async (response) => {
-			const runner = extensionRunnerRef.current;
-			if (!runner?.hasHandlers("after_provider_response")) {
-				return;
-			}
-			await runner.emit({
-				type: "after_provider_response",
-				status: response.status,
-				headers: response.headers,
-			});
-		},
-		transformContext: async (messages: AgentMessage[]) => {
-			const runner = extensionRunnerRef.current;
-			if (!runner) return messages;
-			return runner.emitContext(messages);
-		},
-	});
-	const extensionsResult = options.extensionFactories
-		? await createTestExtensionsResult(options.extensionFactories, tempDir)
-		: undefined;
-	const resourceLoader =
-		options.resourceLoader ?? createTestResourceLoader(extensionsResult ? { extensionsResult } : undefined);
-
-	const session = new AgentSession({
-		agent,
-		sessionManager,
-		settingsManager,
-		cwd: tempDir,
-		modelRegistry,
-		resourceLoader,
-		baseToolsOverride: toolMap,
-		extensionRunnerRef,
-	});
-
-	const events: AgentSessionEvent[] = [];
-	session.subscribe((event) => {
-		events.push(event);
-	});
-
-	return {
-		session,
-		sessionManager,
-		settingsManager,
-		authStorage,
-		faux: fauxProvider,
-		models: fauxProvider.models,
-		getModel: fauxProvider.getModel,
-		setResponses: fauxProvider.setResponses,
-		appendResponses: fauxProvider.appendResponses,
-		getPendingResponseCount: fauxProvider.getPendingResponseCount,
-		events,
-		eventsOfType<T extends AgentSessionEvent["type"]>(type: T) {
-			return events.filter((event): event is Extract<AgentSessionEvent, { type: T }> => event.type === type);
-		},
-		tempDir,
-		cleanup() {
-			session.dispose();
-			fauxProvider.unregister();
-			if (existsSync(tempDir)) {
-				rmSync(tempDir, { recursive: true });
-			}
-		},
-	};
-}

package/pi.dev-src/pi-mono/coding-agent/test/suite/regressions/2023-queued-slash-command-followup.test.ts

@@ -1,80 +0,0 @@
-import type { AgentTool } from "@mariozechner/pi-agent-core";
-import { fauxAssistantMessage, fauxToolCall } from "@mariozechner/pi-ai";
-import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
-import { Type } from "typebox";
-import { afterEach, describe, expect, it } from "vitest";
-import { createHarness, getAssistantTexts, getUserTexts, type Harness } from "../harness.js";
-
-describe("issue #2023 queued slash-command follow-up", () => {
-	const harnesses: Harness[] = [];
-
-	afterEach(() => {
-		while (harnesses.length > 0) {
-			harnesses.pop()?.cleanup();
-		}
-	});
-
-	it("treats extension-origin queued slash-command follow-ups as raw user text instead of dispatching the command", async () => {
-		let extensionApi: ExtensionAPI | undefined;
-		const commandRuns: string[] = [];
-		let releaseToolExecution: (() => void) | undefined;
-		const toolRelease = new Promise<void>((resolve) => {
-			releaseToolExecution = resolve;
-		});
-		const waitTool: AgentTool = {
-			name: "wait",
-			label: "Wait",
-			description: "Wait for the test to release execution",
-			parameters: Type.Object({}),
-			execute: async () => {
-				await toolRelease;
-				return {
-					content: [{ type: "text", text: "released" }],
-					details: {},
-				};
-			},
-		};
-		const harness = await createHarness({
-			tools: [waitTool],
-			extensionFactories: [
-				(pi) => {
-					extensionApi = pi;
-					pi.registerCommand("testcmd", {
-						description: "Test command",
-						handler: async (args) => {
-							commandRuns.push(args);
-						},
-					});
-				},
-			],
-		});
-		harnesses.push(harness);
-
-		harness.setResponses([
-			fauxAssistantMessage(fauxToolCall("wait", {}), { stopReason: "toolUse" }),
-			fauxAssistantMessage("first turn complete"),
-			fauxAssistantMessage("queued follow-up handled by model"),
-		]);
-
-		const sawToolStart = new Promise<void>((resolve) => {
-			const unsubscribe = harness.session.subscribe((event) => {
-				if (event.type === "tool_execution_start" && event.toolName === "wait") {
-					unsubscribe();
-					resolve();
-				}
-			});
-		});
-
-		const promptPromise = harness.session.prompt("start");
-		await sawToolStart;
-		await new Promise((resolve) => setTimeout(resolve, 0));
-
-		extensionApi?.sendUserMessage("/testcmd queued", { deliverAs: "followUp" });
-		releaseToolExecution?.();
-		await promptPromise;
-
-		expect(commandRuns).toEqual([]);
-		expect(getUserTexts(harness)).toEqual(["start", "/testcmd queued"]);
-		expect(getAssistantTexts(harness)).toContain("queued follow-up handled by model");
-	});
-});

package/pi.dev-src/pi-mono/coding-agent/test/suite/regressions/2753-reload-stale-resource-settings.test.ts

@@ -1,100 +0,0 @@
-import { existsSync, mkdirSync, rmSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import { registerFauxProvider } from "@mariozechner/pi-ai";
-import { afterEach, describe, expect, it } from "vitest";
-import {
-	type CreateAgentSessionRuntimeFactory,
-	createAgentSessionFromServices,
-	createAgentSessionRuntime,
-	createAgentSessionServices,
-} from "../../../src/core/agent-session-runtime.js";
-import { AuthStorage } from "../../../src/core/auth-storage.js";
-import { SessionManager } from "../../../src/core/session-manager.js";
-
-describe("issue #2753 reload stale resource settings", () => {
-	const cleanups: Array<() => void> = [];
-
-	afterEach(() => {
-		while (cleanups.length > 0) {
-			cleanups.pop()?.();
-		}
-	});
-
-	it("applies updated top-level prompt settings on reload after startup", async () => {
-		const tempDir = join(tmpdir(), `pi-2753-${Date.now()}-${Math.random().toString(36).slice(2)}`);
-		const agentDir = join(tempDir, "agent");
-		const promptsDir = join(agentDir, "prompts");
-		mkdirSync(promptsDir, { recursive: true });
-		writeFileSync(join(promptsDir, "test.md"), "Echo test prompt\n");
-
-		const faux = registerFauxProvider({
-			models: [{ id: "faux-1", reasoning: false }],
-		});
-		const authStorage = AuthStorage.inMemory();
-		authStorage.setRuntimeApiKey(faux.getModel().provider, "faux-key");
-
-		const createRuntime: CreateAgentSessionRuntimeFactory = async ({ cwd, sessionManager, sessionStartEvent }) => {
-			const services = await createAgentSessionServices({
-				cwd,
-				agentDir,
-				authStorage,
-				resourceLoaderOptions: {
-					extensionFactories: [
-						(pi) => {
-							pi.registerProvider(faux.getModel().provider, {
-								baseUrl: faux.getModel().baseUrl,
-								apiKey: "faux-key",
-								api: faux.api,
-								models: faux.models.map((registeredModel) => ({
-									id: registeredModel.id,
-									name: registeredModel.name,
-									api: registeredModel.api,
-									reasoning: registeredModel.reasoning,
-									input: registeredModel.input,
-									cost: registeredModel.cost,
-									contextWindow: registeredModel.contextWindow,
-									maxTokens: registeredModel.maxTokens,
-								})),
-							});
-						},
-					],
-					noSkills: true,
-					noThemes: true,
-				},
-			});
-			return {
-				...(await createAgentSessionFromServices({
-					services,
-					sessionManager,
-					sessionStartEvent,
-					model: faux.getModel(),
-				})),
-				services,
-				diagnostics: services.diagnostics,
-			};
-		};
-		const runtime = await createAgentSessionRuntime(createRuntime, {
-			cwd: tempDir,
-			agentDir,
-			sessionManager: SessionManager.create(tempDir),
-		});
-
-		cleanups.push(() => {
-			runtime.session.dispose();
-			faux.unregister();
-			if (existsSync(tempDir)) {
-				rmSync(tempDir, { recursive: true, force: true });
-			}
-		});
-
-		expect(runtime.session.promptTemplates.map((prompt) => prompt.name)).toContain("test");
-
-		writeFileSync(join(agentDir, "settings.json"), `${JSON.stringify({ prompts: ["-prompts/test.md"] }, null, 2)}\n`);
-
-		await runtime.session.reload();
-
-		expect(runtime.services.settingsManager.getGlobalSettings().prompts).toEqual(["-prompts/test.md"]);
-		expect(runtime.session.promptTemplates.map((prompt) => prompt.name)).not.toContain("test");
-	});
-});

package/pi.dev-src/pi-mono/coding-agent/test/suite/regressions/2781-skill-collision-precedence.test.ts

@@ -1,120 +0,0 @@
-import { mkdirSync, rmSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import { afterEach, beforeEach, describe, expect, it } from "vitest";
-import { DefaultResourceLoader } from "../../../src/core/resource-loader.js";
-
-describe("issue #2781 skill collision precedence: user skills should override package skills", () => {
-	let tempDir: string;
-	let agentDir: string;
-	let cwd: string;
-
-	beforeEach(() => {
-		tempDir = join(tmpdir(), `pi-2781-${Date.now()}-${Math.random().toString(36).slice(2)}`);
-		agentDir = join(tempDir, "agent");
-		cwd = join(tempDir, "project");
-		mkdirSync(agentDir, { recursive: true });
-		mkdirSync(cwd, { recursive: true });
-	});
-
-	afterEach(() => {
-		rmSync(tempDir, { recursive: true, force: true });
-	});
-
-	function createPackageWithSkill(name: string, description: string): string {
-		const pkgDir = join(tempDir, `fake-package-${name}`);
-		const skillDir = join(pkgDir, "skills", name);
-		mkdirSync(skillDir, { recursive: true });
-		writeFileSync(
-			join(pkgDir, "package.json"),
-			JSON.stringify({ name: `fake-pkg-${name}`, version: "1.0.0", pi: { skills: [`skills/${name}`] } }, null, 2),
-		);
-		writeFileSync(
-			join(skillDir, "SKILL.md"),
-			`---\nname: ${name}\ndescription: ${description}\n---\nPackage skill content`,
-		);
-		return pkgDir;
-	}
-
-	function createUserSkill(name: string, description: string): string {
-		const skillDir = join(agentDir, "skills", name);
-		mkdirSync(skillDir, { recursive: true });
-		const skillPath = join(skillDir, "SKILL.md");
-		writeFileSync(skillPath, `---\nname: ${name}\ndescription: ${description}\n---\nUser skill content`);
-		return skillPath;
-	}
-
-	function createProjectSkill(name: string, description: string): string {
-		const skillDir = join(cwd, ".pi", "skills", name);
-		mkdirSync(skillDir, { recursive: true });
-		const skillPath = join(skillDir, "SKILL.md");
-		writeFileSync(skillPath, `---\nname: ${name}\ndescription: ${description}\n---\nProject skill content`);
-		return skillPath;
-	}
-
-	function createSettingsWithPackage(pkgDir: string, scope: "user" | "project"): void {
-		const settingsDir = scope === "user" ? agentDir : join(cwd, ".pi");
-		mkdirSync(settingsDir, { recursive: true });
-		writeFileSync(join(settingsDir, "settings.json"), JSON.stringify({ packages: [pkgDir] }, null, 2));
-	}
-
-	it("user auto-discovered skill should override package skill with same name", async () => {
-		const pkgDir = createPackageWithSkill("web-fetch", "Package web-fetch skill");
-		const userSkillPath = createUserSkill("web-fetch", "User web-fetch override");
-		createSettingsWithPackage(pkgDir, "user");
-
-		const loader = new DefaultResourceLoader({ cwd, agentDir });
-		await loader.reload();
-
-		const { skills } = loader.getSkills();
-		const webFetch = skills.find((s) => s.name === "web-fetch");
-		expect(webFetch).toBeDefined();
-		expect(webFetch!.filePath).toBe(userSkillPath);
-		expect(webFetch!.description).toBe("User web-fetch override");
-	});
-
-	it("project auto-discovered skill should override package skill with same name", async () => {
-		const pkgDir = createPackageWithSkill("web-fetch", "Package web-fetch skill");
-		const projectSkillPath = createProjectSkill("web-fetch", "Project web-fetch override");
-		createSettingsWithPackage(pkgDir, "user");
-
-		const loader = new DefaultResourceLoader({ cwd, agentDir });
-		await loader.reload();
-
-		const { skills } = loader.getSkills();
-		const webFetch = skills.find((s) => s.name === "web-fetch");
-		expect(webFetch).toBeDefined();
-		expect(webFetch!.filePath).toBe(projectSkillPath);
-		expect(webFetch!.description).toBe("Project web-fetch override");
-	});
-
-	it("project skill should override user skill which should override package skill", async () => {
-		const pkgDir = createPackageWithSkill("web-fetch", "Package web-fetch skill");
-		createUserSkill("web-fetch", "User web-fetch override");
-		const projectSkillPath = createProjectSkill("web-fetch", "Project web-fetch override");
-		createSettingsWithPackage(pkgDir, "user");
-
-		const loader = new DefaultResourceLoader({ cwd, agentDir });
-		await loader.reload();
-
-		const { skills } = loader.getSkills();
-		const webFetch = skills.find((s) => s.name === "web-fetch");
-		expect(webFetch).toBeDefined();
-		expect(webFetch!.filePath).toBe(projectSkillPath);
-		expect(webFetch!.description).toBe("Project web-fetch override");
-	});
-
-	it("collision diagnostics should report package skill as loser when user skill wins", async () => {
-		const pkgDir = createPackageWithSkill("web-fetch", "Package web-fetch skill");
-		createUserSkill("web-fetch", "User web-fetch override");
-		createSettingsWithPackage(pkgDir, "user");
-
-		const loader = new DefaultResourceLoader({ cwd, agentDir });
-		await loader.reload();
-
-		const { diagnostics } = loader.getSkills();
-		const collision = diagnostics.find((d) => d.type === "collision" && d.collision?.name === "web-fetch");
-		expect(collision).toBeDefined();
-		expect(collision!.collision!.loserPath).toContain("fake-package");
-	});
-});

package/pi.dev-src/pi-mono/coding-agent/test/suite/regressions/2791-fswatch-error-crash.test.ts

@@ -1,106 +0,0 @@
-import { execFileSync } from "node:child_process";
-import { mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import { afterEach, beforeEach, describe, expect, it } from "vitest";
-
-/**
- * Regression test for https://github.com/badlogic/pi-mono/issues/2791
- *
- * fs.watch() returns an FSWatcher (EventEmitter). If the watcher emits an
- * 'error' event after creation and no error handler is attached, Node.js
- * treats it as an uncaught exception and terminates the process.
- *
- * We test this by spawning a child process that:
- * 1. Sets up a custom theme with the watcher enabled
- * 2. Finds the FSWatcher via process._getActiveHandles()
- * 3. Emits a synthetic 'error' event on it
- * 4. If the watcher has no error handler -> crash (exit != 0) -> bug present
- * 5. If the watcher has an error handler -> clean exit (exit 0) -> bug fixed
- */
-describe("issue #2791 fs.watch error event crashes process", () => {
-	let tempRoot: string;
-
-	beforeEach(() => {
-		tempRoot = mkdtempSync(join(tmpdir(), "pi-2791-"));
-		const agentDir = join(tempRoot, "agent");
-		const themesDir = join(agentDir, "themes");
-		mkdirSync(themesDir, { recursive: true });
-
-		// Copy dark.json as "custom-test" theme
-		const darkThemePath = join(__dirname, "../../../src/modes/interactive/theme/dark.json");
-		const darkTheme = JSON.parse(readFileSync(darkThemePath, "utf-8"));
-		darkTheme.name = "custom-test";
-		writeFileSync(join(themesDir, "custom-test.json"), JSON.stringify(darkTheme, null, 2));
-	});
-
-	afterEach(() => {
-		rmSync(tempRoot, { recursive: true, force: true });
-	});
-
-	it("process should survive an error event on the theme FSWatcher", () => {
-		const themeModulePath = join(__dirname, "../../../src/modes/interactive/theme/theme.js").replace(/\\/g, "/");
-		const agentDir = join(tempRoot, "agent").replace(/\\/g, "/");
-
-		// Script that sets up the watcher and emits a synthetic error on it.
-		// If no .on('error') handler is attached, EventEmitter.emit('error')
-		// throws, which either crashes the process or gets caught by our try/catch.
-		const scriptPath = join(tempRoot, "test-watcher-error.mts");
-		writeFileSync(
-			scriptPath,
-			`
-import { setTheme, stopThemeWatcher } from "${themeModulePath}";
-
-process.env.PI_CODING_AGENT_DIR = "${agentDir}";
-
-setTheme("custom-test", true);
-
-// Find the FSWatcher among active handles
-const handles = (process as any)._getActiveHandles();
-const fsWatcher = handles.find((h: any) => h.constructor?.name === "FSWatcher");
-
-if (!fsWatcher) {
-	process.stderr.write("no FSWatcher found among active handles\\n");
-	process.exit(2);
-}
-
-const errorListenerCount = fsWatcher.listenerCount("error");
-if (errorListenerCount === 0) {
-	process.stderr.write("BUG: FSWatcher has no error handler (issue #2791)\\n");
-}
-
-// Emitting 'error' on an EventEmitter with no error listener throws.
-// This simulates an async OS error (e.g. ReadDirectoryChangesW invalidation).
-try {
-	fsWatcher.emit("error", new Error("simulated OS watcher failure"));
-} catch {
-	process.stderr.write("error event was unhandled and threw\\n");
-	process.exit(1);
-}
-
-stopThemeWatcher();
-process.exit(0);
-`,
-		);
-
-		let _stdout = "";
-		let stderr = "";
-		let exitCode: number;
-		try {
-			_stdout = execFileSync("npx", ["tsx", scriptPath], {
-				timeout: 10000,
-				encoding: "utf-8",
-				env: { ...process.env, PI_CODING_AGENT_DIR: agentDir },
-				stdio: ["pipe", "pipe", "pipe"],
-			});
-			exitCode = 0;
-		} catch (err: unknown) {
-			const e = err as { status: number; stdout: string; stderr: string };
-			_stdout = e.stdout ?? "";
-			stderr = e.stderr ?? "";
-			exitCode = e.status ?? 1;
-		}
-
-		expect(exitCode, `Child crashed (exit ${exitCode}). stderr: ${stderr.trim()}`).toBe(0);
-	});
-});