pi-usereq 0.48.0 → 0.50.0

package/pi.dev-src/pi-mono/coding-agent/test/skills.test.ts

@@ -1,432 +0,0 @@
-import { homedir } from "os";
-import { join, resolve } from "path";
-import { describe, expect, it } from "vitest";
-import type { ResourceDiagnostic } from "../src/core/diagnostics.js";
-import { formatSkillsForPrompt, loadSkills, loadSkillsFromDir, type Skill } from "../src/core/skills.js";
-import { createSyntheticSourceInfo } from "../src/core/source-info.js";
-
-const fixturesDir = resolve(__dirname, "fixtures/skills");
-const collisionFixturesDir = resolve(__dirname, "fixtures/skills-collision");
-
-function createTestSkill(options: {
-	name: string;
-	description: string;
-	filePath: string;
-	baseDir: string;
-	disableModelInvocation?: boolean;
-	source?: string;
-}): Skill {
-	return {
-		name: options.name,
-		description: options.description,
-		filePath: options.filePath,
-		baseDir: options.baseDir,
-		sourceInfo: createSyntheticSourceInfo(options.filePath, { source: options.source ?? "test" }),
-		disableModelInvocation: options.disableModelInvocation ?? false,
-	};
-}
-
-describe("skills", () => {
-	describe("loadSkillsFromDir", () => {
-		it("should load a valid skill", () => {
-			const { skills, diagnostics } = loadSkillsFromDir({
-				dir: join(fixturesDir, "valid-skill"),
-				source: "test",
-			});
-
-			expect(skills).toHaveLength(1);
-			expect(skills[0].name).toBe("valid-skill");
-			expect(skills[0].description).toBe("A valid skill for testing purposes.");
-			expect(skills[0].sourceInfo.source).toBe("test");
-			expect(diagnostics).toHaveLength(0);
-		});
-
-		it("should warn when name doesn't match parent directory", () => {
-			const { skills, diagnostics } = loadSkillsFromDir({
-				dir: join(fixturesDir, "name-mismatch"),
-				source: "test",
-			});
-
-			expect(skills).toHaveLength(1);
-			expect(skills[0].name).toBe("different-name");
-			expect(
-				diagnostics.some((d: ResourceDiagnostic) => d.message.includes("does not match parent directory")),
-			).toBe(true);
-		});
-
-		it("should warn when name contains invalid characters", () => {
-			const { skills, diagnostics } = loadSkillsFromDir({
-				dir: join(fixturesDir, "invalid-name-chars"),
-				source: "test",
-			});
-
-			expect(skills).toHaveLength(1);
-			expect(diagnostics.some((d: ResourceDiagnostic) => d.message.includes("invalid characters"))).toBe(true);
-		});
-
-		it("should warn when name exceeds 64 characters", () => {
-			const { skills, diagnostics } = loadSkillsFromDir({
-				dir: join(fixturesDir, "long-name"),
-				source: "test",
-			});
-
-			expect(skills).toHaveLength(1);
-			expect(diagnostics.some((d: ResourceDiagnostic) => d.message.includes("exceeds 64 characters"))).toBe(true);
-		});
-
-		it("should warn and skip skill when description is missing", () => {
-			const { skills, diagnostics } = loadSkillsFromDir({
-				dir: join(fixturesDir, "missing-description"),
-				source: "test",
-			});
-
-			expect(skills).toHaveLength(0);
-			expect(diagnostics.some((d: ResourceDiagnostic) => d.message.includes("description is required"))).toBe(true);
-		});
-
-		it("should ignore unknown frontmatter fields", () => {
-			const { skills, diagnostics } = loadSkillsFromDir({
-				dir: join(fixturesDir, "unknown-field"),
-				source: "test",
-			});
-
-			expect(skills).toHaveLength(1);
-			expect(diagnostics).toHaveLength(0);
-		});
-
-		it("should load nested skills recursively", () => {
-			const { skills, diagnostics } = loadSkillsFromDir({
-				dir: join(fixturesDir, "nested"),
-				source: "test",
-			});
-
-			expect(skills).toHaveLength(1);
-			expect(skills[0].name).toBe("child-skill");
-			expect(diagnostics).toHaveLength(0);
-		});
-
-		it("should prefer a directory's root SKILL.md over nested SKILL.md files", () => {
-			const { skills, diagnostics } = loadSkillsFromDir({
-				dir: join(fixturesDir, "root-skill-preferred"),
-				source: "test",
-			});
-
-			expect(skills).toHaveLength(1);
-			expect(skills[0].name).toBe("root-skill-preferred");
-			expect(skills[0].description).toBe("Root skill should win.");
-			expect(diagnostics).toHaveLength(0);
-		});
-
-		it("should skip files without frontmatter", () => {
-			const { skills, diagnostics } = loadSkillsFromDir({
-				dir: join(fixturesDir, "no-frontmatter"),
-				source: "test",
-			});
-
-			// no-frontmatter has no description, so it should be skipped
-			expect(skills).toHaveLength(0);
-			expect(diagnostics.some((d: ResourceDiagnostic) => d.message.includes("description is required"))).toBe(true);
-		});
-
-		it("should warn and skip skill when YAML frontmatter is invalid", () => {
-			const { skills, diagnostics } = loadSkillsFromDir({
-				dir: join(fixturesDir, "invalid-yaml"),
-				source: "test",
-			});
-
-			expect(skills).toHaveLength(0);
-			expect(diagnostics.some((d: ResourceDiagnostic) => d.message.includes("at line"))).toBe(true);
-		});
-
-		it("should preserve multiline descriptions from YAML", () => {
-			const { skills, diagnostics } = loadSkillsFromDir({
-				dir: join(fixturesDir, "multiline-description"),
-				source: "test",
-			});
-
-			expect(skills).toHaveLength(1);
-			expect(skills[0].description).toContain("\n");
-			expect(skills[0].description).toContain("This is a multiline description.");
-			expect(diagnostics).toHaveLength(0);
-		});
-
-		it("should warn when name contains consecutive hyphens", () => {
-			const { skills, diagnostics } = loadSkillsFromDir({
-				dir: join(fixturesDir, "consecutive-hyphens"),
-				source: "test",
-			});
-
-			expect(skills).toHaveLength(1);
-			expect(diagnostics.some((d: ResourceDiagnostic) => d.message.includes("consecutive hyphens"))).toBe(true);
-		});
-
-		it("should load all skills from fixture directory", () => {
-			const { skills } = loadSkillsFromDir({
-				dir: fixturesDir,
-				source: "test",
-			});
-
-			// Should load all skills that have descriptions (even with warnings)
-			// valid-skill, name-mismatch, invalid-name-chars, long-name, unknown-field, nested/child-skill, consecutive-hyphens
-			// NOT: missing-description, no-frontmatter (both missing descriptions)
-			expect(skills.length).toBeGreaterThanOrEqual(6);
-		});
-
-		it("should return empty for non-existent directory", () => {
-			const { skills, diagnostics } = loadSkillsFromDir({
-				dir: "/non/existent/path",
-				source: "test",
-			});
-
-			expect(skills).toHaveLength(0);
-			expect(diagnostics).toHaveLength(0);
-		});
-
-		it("should use parent directory name when name not in frontmatter", () => {
-			// The no-frontmatter fixture has no name in frontmatter, so it should use "no-frontmatter"
-			// But it also has no description, so it won't load
-			// Let's test with a valid skill that relies on directory name
-			const { skills } = loadSkillsFromDir({
-				dir: join(fixturesDir, "valid-skill"),
-				source: "test",
-			});
-
-			expect(skills).toHaveLength(1);
-			expect(skills[0].name).toBe("valid-skill");
-		});
-
-		it("should parse disable-model-invocation frontmatter field", () => {
-			const { skills, diagnostics } = loadSkillsFromDir({
-				dir: join(fixturesDir, "disable-model-invocation"),
-				source: "test",
-			});
-
-			expect(skills).toHaveLength(1);
-			expect(skills[0].name).toBe("disable-model-invocation");
-			expect(skills[0].disableModelInvocation).toBe(true);
-			// Should not warn about unknown field
-			expect(diagnostics.some((d: ResourceDiagnostic) => d.message.includes("unknown frontmatter field"))).toBe(
-				false,
-			);
-		});
-
-		it("should default disableModelInvocation to false when not specified", () => {
-			const { skills } = loadSkillsFromDir({
-				dir: join(fixturesDir, "valid-skill"),
-				source: "test",
-			});
-
-			expect(skills).toHaveLength(1);
-			expect(skills[0].disableModelInvocation).toBe(false);
-		});
-	});
-
-	describe("formatSkillsForPrompt", () => {
-		it("should return empty string for no skills", () => {
-			const result = formatSkillsForPrompt([]);
-			expect(result).toBe("");
-		});
-
-		it("should format skills as XML", () => {
-			const skills: Skill[] = [
-				createTestSkill({
-					name: "test-skill",
-					description: "A test skill.",
-					filePath: "/path/to/skill/SKILL.md",
-					baseDir: "/path/to/skill",
-				}),
-			];
-
-			const result = formatSkillsForPrompt(skills);
-
-			expect(result).toContain("<available_skills>");
-			expect(result).toContain("</available_skills>");
-			expect(result).toContain("<skill>");
-			expect(result).toContain("<name>test-skill</name>");
-			expect(result).toContain("<description>A test skill.</description>");
-			expect(result).toContain("<location>/path/to/skill/SKILL.md</location>");
-		});
-
-		it("should include intro text before XML", () => {
-			const skills: Skill[] = [
-				createTestSkill({
-					name: "test-skill",
-					description: "A test skill.",
-					filePath: "/path/to/skill/SKILL.md",
-					baseDir: "/path/to/skill",
-				}),
-			];
-
-			const result = formatSkillsForPrompt(skills);
-			const xmlStart = result.indexOf("<available_skills>");
-			const introText = result.substring(0, xmlStart);
-
-			expect(introText).toContain("The following skills provide specialized instructions");
-			expect(introText).toContain("Use the read tool to load a skill's file");
-		});
-
-		it("should escape XML special characters", () => {
-			const skills: Skill[] = [
-				createTestSkill({
-					name: "test-skill",
-					description: 'A skill with <special> & "characters".',
-					filePath: "/path/to/skill/SKILL.md",
-					baseDir: "/path/to/skill",
-				}),
-			];
-
-			const result = formatSkillsForPrompt(skills);
-
-			expect(result).toContain("&lt;special&gt;");
-			expect(result).toContain("&amp;");
-			expect(result).toContain("&quot;characters&quot;");
-		});
-
-		it("should format multiple skills", () => {
-			const skills: Skill[] = [
-				createTestSkill({
-					name: "skill-one",
-					description: "First skill.",
-					filePath: "/path/one/SKILL.md",
-					baseDir: "/path/one",
-				}),
-				createTestSkill({
-					name: "skill-two",
-					description: "Second skill.",
-					filePath: "/path/two/SKILL.md",
-					baseDir: "/path/two",
-				}),
-			];
-
-			const result = formatSkillsForPrompt(skills);
-
-			expect(result).toContain("<name>skill-one</name>");
-			expect(result).toContain("<name>skill-two</name>");
-			expect((result.match(/<skill>/g) || []).length).toBe(2);
-		});
-
-		it("should exclude skills with disableModelInvocation from prompt", () => {
-			const skills: Skill[] = [
-				createTestSkill({
-					name: "visible-skill",
-					description: "A visible skill.",
-					filePath: "/path/visible/SKILL.md",
-					baseDir: "/path/visible",
-				}),
-				createTestSkill({
-					name: "hidden-skill",
-					description: "A hidden skill.",
-					filePath: "/path/hidden/SKILL.md",
-					baseDir: "/path/hidden",
-					disableModelInvocation: true,
-				}),
-			];
-
-			const result = formatSkillsForPrompt(skills);
-
-			expect(result).toContain("<name>visible-skill</name>");
-			expect(result).not.toContain("<name>hidden-skill</name>");
-			expect((result.match(/<skill>/g) || []).length).toBe(1);
-		});
-
-		it("should return empty string when all skills have disableModelInvocation", () => {
-			const skills: Skill[] = [
-				createTestSkill({
-					name: "hidden-skill",
-					description: "A hidden skill.",
-					filePath: "/path/hidden/SKILL.md",
-					baseDir: "/path/hidden",
-					disableModelInvocation: true,
-				}),
-			];
-
-			const result = formatSkillsForPrompt(skills);
-			expect(result).toBe("");
-		});
-	});
-
-	describe("loadSkills with options", () => {
-		const emptyAgentDir = resolve(__dirname, "fixtures/empty-agent");
-		const emptyCwd = resolve(__dirname, "fixtures/empty-cwd");
-
-		it("should load from explicit skillPaths", () => {
-			const { skills, diagnostics } = loadSkills({
-				agentDir: emptyAgentDir,
-				cwd: emptyCwd,
-				skillPaths: [join(fixturesDir, "valid-skill")],
-				includeDefaults: true,
-			});
-			expect(skills).toHaveLength(1);
-			expect(skills[0].sourceInfo.scope).toBe("temporary");
-			expect(diagnostics).toHaveLength(0);
-		});
-
-		it("should warn when skill path does not exist", () => {
-			const { skills, diagnostics } = loadSkills({
-				agentDir: emptyAgentDir,
-				cwd: emptyCwd,
-				skillPaths: ["/non/existent/path"],
-				includeDefaults: true,
-			});
-			expect(skills).toHaveLength(0);
-			expect(diagnostics.some((d: ResourceDiagnostic) => d.message.includes("does not exist"))).toBe(true);
-		});
-
-		it("should expand ~ in skillPaths", () => {
-			const homeSkillsDir = join(homedir(), ".pi/agent/skills");
-			const { skills: withTilde } = loadSkills({
-				agentDir: emptyAgentDir,
-				cwd: emptyCwd,
-				skillPaths: ["~/.pi/agent/skills"],
-				includeDefaults: true,
-			});
-			const { skills: withoutTilde } = loadSkills({
-				agentDir: emptyAgentDir,
-				cwd: emptyCwd,
-				skillPaths: [homeSkillsDir],
-				includeDefaults: true,
-			});
-			expect(withTilde.length).toBe(withoutTilde.length);
-		});
-	});
-
-	describe("collision handling", () => {
-		it("should detect name collisions and keep first skill", () => {
-			// Load from first directory
-			const first = loadSkillsFromDir({
-				dir: join(collisionFixturesDir, "first"),
-				source: "first",
-			});
-
-			const second = loadSkillsFromDir({
-				dir: join(collisionFixturesDir, "second"),
-				source: "second",
-			});
-
-			// Simulate the collision behavior from loadSkills()
-			const skillMap = new Map<string, Skill>();
-			const collisionWarnings: Array<{ skillPath: string; message: string }> = [];
-
-			for (const skill of first.skills) {
-				skillMap.set(skill.name, skill);
-			}
-
-			for (const skill of second.skills) {
-				const existing = skillMap.get(skill.name);
-				if (existing) {
-					collisionWarnings.push({
-						skillPath: skill.filePath,
-						message: `name collision: "${skill.name}" already loaded from ${existing.filePath}`,
-					});
-				} else {
-					skillMap.set(skill.name, skill);
-				}
-			}
-
-			expect(skillMap.size).toBe(1);
-			expect(skillMap.get("calendar")?.sourceInfo.source).toBe("first");
-			expect(collisionWarnings).toHaveLength(1);
-			expect(collisionWarnings[0].message).toContain("name collision");
-		});
-	});
-});

package/pi.dev-src/pi-mono/coding-agent/test/stdout-cleanliness.test.ts

@@ -1,103 +0,0 @@
-import { spawn } from "node:child_process";
-import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join, resolve } from "node:path";
-import { afterEach, describe, expect, it } from "vitest";
-import { ENV_AGENT_DIR } from "../src/config.js";
-
-const cliPath = resolve(__dirname, "../src/cli.ts");
-const tsxPath = resolve(__dirname, "../../../node_modules/tsx/dist/cli.mjs");
-
-const tempDirs: string[] = [];
-
-afterEach(() => {
-	for (const dir of tempDirs.splice(0)) {
-		rmSync(dir, { recursive: true, force: true });
-	}
-});
-
-function createTempDir(): string {
-	const dir = mkdtempSync(join(tmpdir(), "pi-stdout-clean-"));
-	tempDirs.push(dir);
-	return dir;
-}
-
-async function runCli(args: string[]): Promise<{ stdout: string; stderr: string; code: number | null }> {
-	const tempRoot = createTempDir();
-	const agentDir = join(tempRoot, "agent");
-	const projectDir = join(tempRoot, "project");
-	const projectConfigDir = join(projectDir, ".pi");
-	mkdirSync(agentDir, { recursive: true });
-	mkdirSync(projectConfigDir, { recursive: true });
-
-	const fakeNpmPath = join(tempRoot, "fake-npm.mjs");
-	writeFileSync(
-		fakeNpmPath,
-		[
-			'console.log("changed 1 package in 471ms");',
-			'console.log("found 0 vulnerabilities");',
-			"process.exit(0);",
-		].join("\n"),
-		"utf-8",
-	);
-
-	writeFileSync(
-		join(projectConfigDir, "settings.json"),
-		JSON.stringify(
-			{
-				packages: ["npm:fake-package"],
-				npmCommand: [process.execPath, fakeNpmPath],
-			},
-			null,
-			2,
-		),
-		"utf-8",
-	);
-
-	return await new Promise((resolvePromise, reject) => {
-		const child = spawn(process.execPath, [tsxPath, cliPath, ...args], {
-			cwd: projectDir,
-			env: {
-				...process.env,
-				[ENV_AGENT_DIR]: agentDir,
-				TSX_TSCONFIG_PATH: resolve(__dirname, "../../../tsconfig.json"),
-			},
-			stdio: ["ignore", "pipe", "pipe"],
-		});
-
-		let stdout = "";
-		let stderr = "";
-		child.stdout.on("data", (chunk) => {
-			stdout += chunk.toString();
-		});
-		child.stderr.on("data", (chunk) => {
-			stderr += chunk.toString();
-		});
-		child.on("error", reject);
-		child.on("close", (code) => {
-			resolvePromise({ stdout, stderr, code });
-		});
-	});
-}
-
-describe("stdout cleanliness in non-interactive modes", () => {
-	it("keeps stdout empty for --mode json --help while routing startup chatter to stderr", async () => {
-		const result = await runCli(["--mode", "json", "--help"]);
-
-		expect(result.code).toBe(0);
-		expect(result.stdout).toBe("");
-		expect(result.stderr).toContain("changed 1 package in 471ms");
-		expect(result.stderr).toContain("found 0 vulnerabilities");
-		expect(result.stderr).toContain("Usage:");
-	});
-
-	it("keeps stdout empty for -p --help while routing startup chatter to stderr", async () => {
-		const result = await runCli(["-p", "--help"]);
-
-		expect(result.code).toBe(0);
-		expect(result.stdout).toBe("");
-		expect(result.stderr).toContain("changed 1 package in 471ms");
-		expect(result.stderr).toContain("found 0 vulnerabilities");
-		expect(result.stderr).toContain("Usage:");
-	});
-});

package/pi.dev-src/pi-mono/coding-agent/test/streaming-render-debug.ts

@@ -1,97 +0,0 @@
-/**
- * Debug script to reproduce streaming rendering issues.
- * Uses real fixture data that caused the bug.
- * Run with: npx tsx test/streaming-render-debug.ts
- */
-
-import type { AssistantMessage } from "@mariozechner/pi-ai";
-import { ProcessTerminal, TUI } from "@mariozechner/pi-tui";
-import { readFileSync } from "fs";
-import { dirname, join } from "path";
-import { fileURLToPath } from "url";
-import { AssistantMessageComponent } from "../src/modes/interactive/components/assistant-message.js";
-import { initTheme } from "../src/modes/interactive/theme/theme.js";
-
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = dirname(__filename);
-
-// Initialize dark theme with full color support
-process.env.COLORTERM = "truecolor";
-initTheme("dark");
-
-// Load the real fixture that caused the bug
-const fixtureMessage: AssistantMessage = JSON.parse(
-	readFileSync(join(__dirname, "fixtures/assistant-message-with-thinking-code.json"), "utf-8"),
-);
-
-// Extract thinking and text content
-const thinkingContent = fixtureMessage.content.find((c) => c.type === "thinking");
-const textContent = fixtureMessage.content.find((c) => c.type === "text");
-
-if (!thinkingContent || thinkingContent.type !== "thinking") {
-	console.error("No thinking content in fixture");
-	process.exit(1);
-}
-
-const fullThinkingText = thinkingContent.thinking;
-const fullTextContent = textContent && textContent.type === "text" ? textContent.text : "";
-
-async function sleep(ms: number): Promise<void> {
-	return new Promise((resolve) => setTimeout(resolve, ms));
-}
-
-async function main() {
-	const terminal = new ProcessTerminal();
-	const tui = new TUI(terminal);
-
-	// Start with empty message
-	const message = {
-		role: "assistant",
-		content: [{ type: "thinking", thinking: "" }],
-	} as AssistantMessage;
-
-	const component = new AssistantMessageComponent(message, false);
-	tui.addChild(component);
-	tui.start();
-
-	// Simulate streaming thinking content
-	let thinkingBuffer = "";
-	const chunkSize = 10; // characters per "token"
-
-	for (let i = 0; i < fullThinkingText.length; i += chunkSize) {
-		thinkingBuffer += fullThinkingText.slice(i, i + chunkSize);
-
-		// Update message content
-		const updatedMessage = {
-			role: "assistant",
-			content: [{ type: "thinking", thinking: thinkingBuffer }],
-		} as AssistantMessage;
-
-		component.updateContent(updatedMessage);
-		tui.requestRender();
-
-		await sleep(15); // Simulate token delay
-	}
-
-	// Now add the text content
-	await sleep(500);
-
-	const finalMessage = {
-		role: "assistant",
-		content: [
-			{ type: "thinking", thinking: fullThinkingText },
-			{ type: "text", text: fullTextContent },
-		],
-	} as AssistantMessage;
-
-	component.updateContent(finalMessage);
-	tui.requestRender();
-
-	// Keep alive for a moment to see the result
-	await sleep(3000);
-
-	tui.stop();
-	process.exit(0);
-}
-
-main().catch(console.error);