pi-usereq 0.43.0 → 0.45.0

package/tests/extension-registration.test.ts

@@ -3633,7 +3633,7 @@ test("worktree-enabled prompt commands honor overridden worktree prefixes", asyn
   }
 });
 
-test("worktree-backed prompt failures skip merge, restore base-path, and retain worktree", async () => {
+test("worktree-backed prompt failures keep the worktree session, retain worktree, and park in error", async () => {
   const { projectBase } = initFixtureRepo({ fixtures: [] });
   const previousCwd = process.cwd();
   try {
@@ -3658,8 +3658,11 @@ test("worktree-backed prompt failures skip merge, restore base-path, and retain
       messages: [{ role: "assistant", stopReason: "error", content: [] }],
     }, ctx);
 
-    assert.equal(process.cwd(), projectBase);
-    assert.equal(ctx.cwd, projectBase);
+    // The original base-path session MUST NOT be resumed on failure; the
+    // client stays on the worktree execution session so the failure stays
+    // visible until req-reset restores base-path and removes the worktree.
+    assert.equal(process.cwd(), executionBasePath);
+    assert.equal(ctx.cwd, executionBasePath);
     assert.equal(fs.existsSync(executionBasePath), true);
     assert.equal(fs.existsSync(path.join(projectBase, "src", "failed.ts")), false);
     assert.equal(
@@ -3674,8 +3677,8 @@ test("worktree-backed prompt failures skip merge, restore base-path, and retain
     assert.equal(
       ctx.__state.statuses.get("pi-usereq"),
       buildExpectedFakeStatusText({
-        workflowState: "idle",
-        basePath: buildExpectedFakeBasePath(projectBase),
+        workflowState: "error",
+        basePath: buildExpectedFakeBasePath(executionBasePath),
         docsDir: DEFAULT_DOCS_DIR,
         testsDir: "tests",
         srcDir: ["src"],
@@ -6689,10 +6692,17 @@ test("configuration menu omits removed static-check raw-spec and reference actio
   const renderedStaticCheckMenu = (ctx.__state.customRenderLines[1] ?? []).join("\n");
   const staticCheckItems = ctx.__state.selectCalls[1]?.items ?? [];
   assert.match(renderedStaticCheckMenu, /Add static code checker/);
+  assert.match(renderedStaticCheckMenu, /View static code checker/);
   assert.match(renderedStaticCheckMenu, /Remove static code checker/);
-  assert.deepEqual(staticCheckItems.slice(0, 2), ["Add static code checker", "Remove static code checker"]);
+  assert.match(renderedStaticCheckMenu, /Reset static code checker/);
+  assert.deepEqual(staticCheckItems.slice(0, 4), [
+    "Add static code checker",
+    "View static code checker",
+    "Remove static code checker",
+    "Reset static code checker",
+  ]);
   assert.deepEqual(
-    staticCheckItems.slice(2, 22),
+    staticCheckItems.slice(4, 24),
     getSupportedStaticCheckLanguageSupport().map((entry) => entry.language),
   );
   assert.deepEqual(staticCheckItems.slice(-1), ["Reset defaults"]);