pi-umbra 0.3.1 → 0.5.0

package/node_modules/pi-umbra-skill-matcher/checks/umbra-skill-matcher.check.ts

@@ -1,94 +0,0 @@
-// Runs skill-fuzzy against pi's REAL built-in provider, so a change in pi's prefix/value
-// contract fails here instead of silently in the TUI.
-//   bun run umbra-skill-matcher.check.ts
-import assert from "node:assert";
-import { CombinedAutocompleteProvider } from "@earendil-works/pi-tui";
-import skillFuzzy, { midPromptWord } from "../extensions/umbra-skill-matcher.ts";
-
-const COMMANDS = [
-    { name: "huh", source: "skill", description: "Restate the last message plainly." },
-    { name: "hula-hola", source: "skill", description: "dance" },
-    { name: "what-the-hex", source: "skill", description: "hex" },
-    { name: "picasso", source: "skill", description: "frontend" },
-    { name: "call-council", source: "skill", description: "council skill" },
-    { name: "call-council", source: "extension", description: "council extension" },
-    { name: "help", source: "builtin", description: "help" },
-];
-
-let wrap: (current: unknown) => any;
-const pi = {
-    getCommands: () => COMMANDS,
-    on: (_event: string, handler: (e: unknown, ctx: unknown) => void) =>
-        handler({}, { ui: { addAutocompleteProvider: (factory: typeof wrap) => (wrap = factory) } }),
-};
-skillFuzzy(pi as never);
-
-const builtin = new CombinedAutocompleteProvider(COMMANDS as never, process.cwd());
-const provider = wrap!(builtin);
-const labels = async (typed: string) => {
-    const got = await provider.getSuggestions([typed], 0, typed.length, { signal: AbortSignal.timeout(5000) });
-    return (got?.items ?? []).map((item: { label: string }) => item.label);
-};
-
-// The user's three examples: a shorter query lists more skills, all in the runnable form.
-// pi's matcher is subsequence-based, not contains, so "/huh" also reaches "hula-hola" (h-u-h).
-// That is pi's own ranking to own; all this checks is that the exact match leads.
-assert.equal((await labels("/huh"))[0], "skill:huh");
-assert.ok((await labels("/hu")).includes("skill:huh"), "/hu must offer skill:huh");
-assert.ok((await labels("/hu")).includes("skill:hula-hola"), "/hu must offer skill:hula-hola");
-assert.ok((await labels("/h")).includes("skill:what-the-hex"), "/h must reach a mid-word match");
-
-// A skill is never offered under the bare name that does not run.
-assert.ok(!(await labels("/pic")).includes("picasso"), "bare picasso must be gone");
-assert.deepEqual(await labels("/pic"), ["skill:picasso"]);
-
-// "skill:" typed by hand still finds it, which plain fuzzy on the bare name cannot.
-assert.ok((await labels("/skill:pic")).includes("skill:picasso"), "explicit prefix must still match");
-
-// call-council belongs to an extension too, so its bare form stays runnable and untouched.
-assert.ok((await labels("/call")).includes("call-council"), "extension command must survive");
-
-// Browsing the whole list with a bare "/" must show the runnable form too, not just a search.
-const all = await labels("/");
-assert.ok(all.includes("skill:huh"), "bare / must list skills in runnable form");
-assert.ok(!all.includes("huh"), "bare / must not leak the name that does not run");
-assert.ok(all.includes("help"), "bare / must keep non-skill commands");
-
-// Selecting the row writes exactly "/skill:huh " — one slash, one trailing space.
-const item = { value: "skill:huh", label: "skill:huh" };
-const applied = provider.applyCompletion(["/huh"], 0, 4, item, "/huh");
-assert.equal(applied.lines[0], "/skill:huh ");
-assert.equal(applied.cursorCol, 11);
-
-console.log("umbra-skill-matcher: all checks passed");
-
-// --- mid-sentence ---------------------------------------------------------------------------
-// The token test, first on its own. These are the shapes the repatch entries also decide with,
-// so a change here without a change there means the menu opens on something it cannot fill.
-assert.equal(midPromptWord("run this /pic"), "pic", "a token after real text is ours");
-assert.equal(midPromptWord("run this /"), "", "an empty token is ours - that is the keystroke");
-assert.equal(midPromptWord("/pic"), null, "the line-start form belongs to the built-in provider");
-assert.equal(midPromptWord("   /pic"), null, "an indented line start is still a line start");
-assert.equal(midPromptWord("open src/pic"), null, "a path is not a command");
-assert.equal(midPromptWord("open ~/pic"), null, "nor is a home path");
-assert.equal(midPromptWord("run /pic then"), null, "the token must end at the cursor");
-
-// Mid-sentence rows carry the bare skill name, because nothing dispatches them: pi runs a command
-// only when the message starts with a slash. The name is what pi's own <available_skills> block
-// lists, so it is the form the model can act on.
-const mid = async (typed: string) => {
-    const got = await provider.getSuggestions([typed], 0, typed.length, { signal: AbortSignal.timeout(5000) });
-    return (got?.items ?? []).map((item: { value: string }) => item.value);
-};
-assert.deepEqual(await mid("use the /pic"), ["/picasso"]);
-assert.ok(!(await mid("use the /pic")).includes("/skill:picasso"), "no dispatcher prefix mid-sentence");
-assert.ok((await mid("use the /call")).includes("/call-council"), "skills only, once");
-assert.equal((await mid("use the /call")).length, 1, "the extension twin must not double the row");
-assert.equal((await mid("use the /zzz")).length, 0, "no match means no menu");
-
-// Selecting a mid-sentence row keeps the sentence and writes one slash.
-const midItem = { value: "/picasso", label: "picasso" };
-const midApplied = provider.applyCompletion(["use the /pic"], 0, 12, midItem, "/pic");
-assert.equal(midApplied.lines[0], "use the /picasso");
-
-console.log("umbra-skill-matcher: mid-sentence checks passed");

package/node_modules/pi-umbra-skill-matcher/extensions/umbra-skill-matcher.ts

@@ -1,124 +0,0 @@
-// pi registers a skill in the completion list under its bare name ("huh"), but only
-// "/skill:huh" actually runs one. So the built-in dropdown offers "/huh", the user presses
-// enter, and pi answers "Unknown command". The matching itself is already fuzzy; the name it
-// matches against is what is wrong.
-//
-// This wraps the built-in provider and rewrites every skill row to the form that runs. It also
-// re-runs the match against the prefixed name, so typing "/skill:hu" still finds "skill:huh"
-// after the built-in fuzzy pass has given up on it.
-//
-// It also fills the mid-sentence slash menu that two repatch entries open. pi's editor gates the
-// menu on the line starting with "/", so a "/name" written inside a sentence never reached a
-// provider at all; the patches lift that gate and the branch below decides what appears.
-//
-// Contract taken from pi-tui's CombinedAutocompleteProvider: `prefix` is the text before the
-// cursor INCLUDING the leading slash, and `item.value` is the bare command name — applyCompletion
-// writes `${before}/${value} ` itself, so the value carries neither slash nor trailing space.
-// That holds only while the token starts the line. Mid-sentence the same method falls through to
-// `${before}${value}`, which is why those rows carry their own slash.
-import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
-
-const SKILL_PREFIX = "skill:";
-const MAX_ROWS = 12;
-
-type Item = { value: string; label: string; description?: string };
-type Suggestions = { items: Item[]; prefix: string } | null;
-
-// Only complete while the command word is the whole line: "/pic" completes, "/skill:picasso go"
-// does not, because there the user is writing the argument.
-const commandWord = (before: string): string | null => {
-    const match = /^\/(\S*)$/.exec(before);
-    return match ? match[1] : null;
-};
-
-// The same token test the two repatch entries use to open the slash menu mid-sentence, so the
-// menu and its contents agree on what counts: last token on the line, no space in it, and real
-// text before it that ends in whitespace. "src/foo" and an indented "  /foo" both fail, which
-// leaves paths and line-start commands to the built-in provider.
-export const midPromptWord = (before: string): string | null => {
-    const slash = before.lastIndexOf("/");
-    if (slash < 1 || before.slice(slash + 1).includes(" ")) return null;
-    const head = before.slice(0, slash);
-    return head.trim() === "" || head === head.trimEnd() ? null : before.slice(slash + 1);
-};
-
-export default function skillFuzzy(pi: ExtensionAPI) {
-    pi.on("session_start", (_event, ctx: ExtensionContext) => {
-        ctx.ui.addAutocompleteProvider((current) => ({
-            triggerCharacters: ["/"],
-
-            async getSuggestions(lines: string[], line: number, col: number, options: never) {
-                const before = (lines[line] ?? "").slice(0, col);
-
-                // pi dispatches a command only when the whole message starts with a slash, so a
-                // "/name" written mid-sentence is never run - it is text the model reads. pi's
-                // system prompt already lists every skill and tells the model to open the
-                // matching SKILL.md, so the bare name is what belongs here. The "skill:" form
-                // below exists for the dispatcher, and the dispatcher never sees this one.
-                const midWord = midPromptWord(before);
-                if (midWord !== null) {
-                    const query = midWord.toLowerCase();
-                    const items = pi
-                        .getCommands()
-                        .filter((command) => command.source === "skill" && command.name.toLowerCase().includes(query))
-                        .slice(0, MAX_ROWS)
-                        .map((command) => ({
-                            // applyCompletion writes `${before}${value}` for a token that does not
-                            // start the line, so the value carries its own slash.
-                            value: `/${command.name}`,
-                            label: command.name,
-                            description: command.description ?? "skill",
-                        }));
-                    return items.length === 0 ? null : { items, prefix: `/${midWord}` };
-                }
-
-                const base = (await current.getSuggestions(lines, line, col, options)) as Suggestions;
-                const typed = commandWord(before);
-                if (typed === null) return base;
-
-                const commands = pi.getCommands();
-                // "call-council" is both a skill and an extension command, and there the bare
-                // "/call-council" is the real one. Only touch a name nothing else claims.
-                const taken = new Set(
-                    commands.filter((command) => command.source !== "skill").map((command) => command.name),
-                );
-                const skills = commands.filter(
-                    (command) => command.source === "skill" && !taken.has(command.name),
-                );
-                const byName = new Map(skills.map((command) => [command.name, command]));
-
-                const asSkill = (name: string, description?: string): Item => ({
-                    value: `${SKILL_PREFIX}${name}`,
-                    label: `${SKILL_PREFIX}${name}`,
-                    description: description ?? byName.get(name)?.description ?? "skill",
-                });
-
-                const fixed = (base?.items ?? []).map((item) =>
-                    byName.has(item.value) ? asSkill(item.value, item.description) : item,
-                );
-
-                const query = typed.toLowerCase().replace(/^skill:/, "");
-                const shown = new Set(fixed.map((item) => item.value));
-                const extra = query
-                    ? skills
-                          .filter((command) => command.name.toLowerCase().includes(query))
-                          .map((command) => asSkill(command.name))
-                          .filter((item) => !shown.has(item.value))
-                          .slice(0, MAX_ROWS)
-                    : [];
-
-                const items = [...fixed, ...extra];
-                if (items.length === 0) return null;
-                return { items, prefix: base?.prefix ?? `/${typed}` };
-            },
-
-            applyCompletion(lines: string[], line: number, col: number, item: Item, prefix: string) {
-                return current.applyCompletion(lines, line, col, item, prefix);
-            },
-
-            shouldTriggerFileCompletion(lines: string[], line: number, col: number) {
-                return current.shouldTriggerFileCompletion?.(lines, line, col) ?? true;
-            },
-        }));
-    });
-}

package/node_modules/pi-umbra-skill-matcher/package.json

@@ -1,37 +0,0 @@
-{
-  "name": "pi-umbra-skill-matcher",
-  "version": "0.1.4",
-  "description": "Type /huh and reach skill:huh. pi lists every skill under its bare name, which is not the name that dispatches.",
-  "keywords": [
-    "pi-package",
-    "pi-extension",
-    "autocomplete",
-    "skills"
-  ],
-  "author": "grkn",
-  "license": "MIT",
-  "repository": {
-    "type": "git",
-    "url": "git+https://github.com/grknbyk/pi-umbra.git",
-    "directory": "pi-umbra-skill-matcher"
-  },
-  "homepage": "https://github.com/grknbyk/pi-umbra/tree/main/pi-umbra-skill-matcher#readme",
-  "bugs": "https://github.com/grknbyk/pi-umbra/issues",
-  "type": "module",
-  "files": [
-    "extensions",
-    "checks",
-    "README.md",
-    "patch.mjs",
-    "LICENSE"
-  ],
-  "pi": {
-    "extensions": [
-      "./extensions"
-    ]
-  },
-  "peerDependencies": {
-    "@earendil-works/pi-coding-agent": "*",
-    "@earendil-works/pi-tui": "*"
-  }
-}

package/node_modules/pi-umbra-skill-matcher/patch.mjs

@@ -1,129 +0,0 @@
-// pi-umbra-skill-matcher needs 4 seams that pi's extension API does not expose, so it edits
-// pi's built bundle. Run it after installing, and again after every pi update:
-//
-//   node <this file>           apply
-//   node <this file> --check   report only, write nothing, exit 1 if anything is missing
-//
-// pi runs dist/bundle/cli.js, a self-contained bundle, and the chunk names are content-hashed,
-// so every patch finds its own place by matching its own text rather than by line number.
-//
-// Nothing here is destructive. Each patch is additive, a patch whose text no longer matches is
-// reported instead of forced, and reinstalling pi returns the bundle to stock. A pi upgrade
-// replaces the bundle and drops every patch silently, which is what --check is for.
-import { execSync } from "node:child_process";
-import { createRequire } from "node:module";
-import { existsSync, realpathSync, readdirSync, readFileSync, writeFileSync } from "node:fs";
-import { homedir } from "node:os";
-import { dirname, join } from "node:path";
-
-// PI_UMBRA_PI points this at another pi tree. Otherwise the pi that runs is the one to patch:
-// the `pi` on PATH, followed through its symlink. Windows puts a .cmd shim there instead, so
-// npm's global root (%APPDATA%\npm\node_modules) comes next, then bun's. The copy npm installs
-// beside this package as a peer dependency is last: pi never runs it. The first that has a built
-// bundle wins.
-const resolvePi = () => {
-	if (process.env.PI_UMBRA_PI) return process.env.PI_UMBRA_PI;
-	const quiet = { encoding: "utf8", stdio: ["ignore", "pipe", "ignore"], timeout: 20_000 };
-	const candidates = [];
-	try {
-		const bin = execSync(process.platform === "win32" ? "where pi" : "command -v pi", quiet).split(/\r?\n/)[0].trim();
-		for (let dir = dirname(realpathSync(bin)); dir !== dirname(dir); dir = dirname(dir)) candidates.push(dir);
-	} catch {}
-	try {
-		const root = execSync("npm root -g", quiet).trim();
-		if (root) candidates.push(join(root, "@earendil-works", "pi-coding-agent"));
-	} catch {}
-	candidates.push(join(homedir(), ".bun", "install", "global", "node_modules", "@earendil-works", "pi-coding-agent"));
-	try {
-		candidates.push(dirname(createRequire(import.meta.url).resolve("@earendil-works/pi-coding-agent/package.json")));
-	} catch {}
-	return candidates.find((dir) => existsSync(join(dir, "dist", "bundle"))) ?? candidates[0];
-};
-
-const BUNDLE = join(resolvePi(), "dist/bundle");
-if (!existsSync(BUNDLE)) {
-	console.error(`no pi bundle at ${BUNDLE} - set PI_UMBRA_PI to your pi install`);
-	process.exit(1);
-}
-
-const PATCHES = [
-	{
-		// A skill is reachable as /skill:huh only. The prefix is hardcoded at both sites below,
-		// with no setting for it. The dispatch map now holds each skill under both names, so
-		// /huh works and any /skill:huh already in muscle memory or in a doc keeps working.
-		// Only the bare name is offered in autocomplete, to keep the list one line per skill.
-		reason: "/huh instead of /skill:huh",
-		from: "let commandName=`skill:${skill.name}`;this.skillCommands.set(commandName,skill.filePath),skillCommandList.push({name:commandName,",
-		to: "let commandName=skill.name;this.skillCommands.set(`skill:${skill.name}`,skill.filePath),this.skillCommands.set(commandName,skill.filePath),skillCommandList.push({name:commandName,",
-	},
-	{
-		reason: "the command list names skills without the prefix too",
-		from: "skills=this._resourceLoader.getSkills().skills.map(skill=>({name:`skill:${skill.name}`,",
-		to: "skills=this._resourceLoader.getSkills().skills.map(skill=>({name:skill.name,",
-	},
-	{
-		// The slash menu only ever opens on a line that starts with "/": `isAtStartOfMessage`
-		// gates the keystroke and `isInSlashCommandContext` gates every letter after it. A
-		// "/name" written in the middle of a sentence therefore reaches no provider at all, and
-		// an extension cannot fix that - it is never asked. These two open the door;
-		// umbra-skill-matcher decides what stands behind it.
-		//
-		// `umbraMidSlash` is deliberately narrow, so a path keeps behaving like a path: the
-		// token must be the last one on the line, hold no space, and sit after real text that
-		// ends in whitespace. "src/foo" fails on the last clause, "  /foo" on the one before it.
-		// `head!==head.trimEnd()` is how "ends in a space or a tab" is written without putting an
-		// escape inside a patch string.
-		reason: "a mid-sentence /name opens the slash menu",
-		from: `isInSlashCommandContext(textBeforeCursor){return this.isSlashMenuAllowed()&&textBeforeCursor.trimStart().startsWith("/")}`,
-		to: `isInSlashCommandContext(textBeforeCursor){return this.isSlashMenuAllowed()&&textBeforeCursor.trimStart().startsWith("/")||this.umbraMidSlash(textBeforeCursor)}umbraMidSlash(t){let i=t.lastIndexOf("/");if(i<1)return!1;if(t.slice(i+1).indexOf(" ")>=0)return!1;let head=t.slice(0,i);return head.trim()!==""&&head!==head.trimEnd()}`,
-	},
-	{
-		// The companion to the patch above: without it the menu opens on the second character
-		// rather than on the slash, because typing "/" is handled by its own branch that ends at
-		// `isAtStartOfMessage`. At that moment the token after the slash is still empty, which is
-		// exactly the shape `umbraMidSlash` accepts.
-		reason: "typing a mid-sentence slash opens the menu on the slash",
-		from: `char==="/"&&this.isAtStartOfMessage()`,
-		to: `char==="/"&&(this.isAtStartOfMessage()||this.umbraMidSlash((this.state.lines[this.state.cursorLine]||"").slice(0,this.state.cursorCol)))`,
-	},
-];
-
-const files = [join(BUNDLE, "cli.js"), ...readdirSync(join(BUNDLE, "chunks")).map((name) => join(BUNDLE, "chunks", name))];
-const CHECK = process.argv.includes("--check");
-const unapplied = [];
-const gone = [];
-
-for (const patch of PATCHES) {
-	let done = false;
-	for (const path of files) {
-		const source = readFileSync(path, "utf8");
-		// A multi-line patch is written with newline escapes; match whatever line ending the file uses.
-		const eol = source.includes("\r\n") ? "\r\n" : "\n";
-		const from = patch.from.split("\n").join(eol);
-		const to = patch.to.split("\n").join(eol);
-		if (source.includes(to)) {
-			if (!CHECK) console.log(`already patched: ${patch.reason}`);
-			done = true;
-			break;
-		}
-		if (!source.includes(from)) continue;
-		if (CHECK) {
-			unapplied.push(patch.reason);
-			done = true;
-			break;
-		}
-		writeFileSync(path, source.replace(from, to));
-		console.log(`patched: ${patch.reason}`);
-		done = true;
-		break;
-	}
-	// Neither the original text nor the patched text is there, so pi changed the code this
-	// patch names. Report it rather than force anything.
-	if (!done) gone.push(patch.reason);
-}
-
-for (const reason of unapplied) console.log(`NOT APPLIED: ${reason}`);
-for (const reason of gone) console.log(`SEAM GONE:   ${reason}`);
-const bad = unapplied.length + gone.length;
-console.log(bad ? `${bad} of ${PATCHES.length} not in place` : `all ${PATCHES.length} patches applied`);
-process.exit(bad ? 1 : 0);