pi-ui-extend 1.0.21 → 1.0.22

package/external/pi-tools-suite/README.md

@@ -247,10 +247,10 @@ For an oh-my-openagent-style workflow, run `/ultrawork` or `/ulw` to ask the par
 
 ### Private browser QA and project auth
 
-The built-in `browser-qa` role runs on `antigravity/gemini-3-flash-preview`, with
-`openai-codex/gpt-5.4-mini` as its fallback. Its browser workflow is an explicit
-private skill under `src/async-subagents/private-skills/`, outside normal Pi skill
-discovery. The role's first-class `isolatedSkills` setting launches the child with
+The built-in `browser-qa` role runs on `openai-codex/gpt-5.4-mini`, with
+`antigravity/gemini-3-flash-preview` and then `zai/glm-5.3` as fallbacks. Its browser
+workflow is an explicit private skill under `src/async-subagents/private-skills/`,
+outside normal Pi skill discovery. The role's first-class `isolatedSkills` setting launches the child with
 `--no-skills` plus one self-contained private workflow. It bundles the relevant
 scenario-design, locator, waiting, assertion, evidence, and cleanup guidance next
 to its trusted runner, so browser QA does not depend on a separately installed
@@ -288,10 +288,13 @@ blocked. Example:
 }
 ```
 
-Do not place credential values in prompts, QA flows, shell arguments, reports,
-or evidence. The helper reads JSONC internally, emits only redacted statuses, and
-caches generated storage state under `.pi/qa-auth-state`. The launcher provides
-each browser QA process with its own
+Do not place credential values in prompts, QA flows, shell arguments, or reports.
+The helper reads JSONC internally and emits only redacted statuses. For form auth,
+video recording begins on the login page and captures the field-filling and submit
+sequence; password inputs remain browser-masked, but the private video may show
+other visible login identifiers and must be treated as sensitive evidence. Tracing
+starts only after login succeeds and is sanitized before retention. The launcher
+provides each browser QA process with its own
 `.pi/subagents/<run>/<agent-id>/browser-qa/` workspace. Declarative flows,
 screenshots, video, sanitized traces, and result manifests stay there, so normal
 session shutdown or `subagents cleanup` removes them with the run directory.

package/external/pi-tools-suite/src/async-subagents/async-subagents.sample.jsonc

@@ -116,7 +116,7 @@
         "research": { "model": "zai/glm-5-turbo", "thinking": "low" },
         "docs": { "model": "zai/glm-4.5-air", "thinking": "low" },
         "frontend": { "model": "antigravity/gemini-3-flash-preview", "fallbackModels": ["zai/glm-5.3"], "thinking": "medium" },
-        "browser-qa": { "model": "antigravity/gemini-3-flash-preview", "fallbackModels": ["openai-codex/gpt-5.4-mini"], "thinking": "medium" },
+        "browser-qa": { "model": "openai-codex/gpt-5.4-mini", "fallbackModels": ["antigravity/gemini-3-flash-preview", "zai/glm-5.3"], "thinking": "medium" },
         "tests": { "model": "zai/glm-5-turbo", "thinking": "medium" },
         "review": { "model": "zai/glm-5.3", "thinking": "high" },
         "implement": { "model": "zai/glm-5.3", "thinking": "high" },
@@ -132,7 +132,7 @@
         "research": { "model": "openai-codex/gpt-5.6-terra", "fallbackModels": ["zai/glm-5-turbo"], "thinking": "low" },
         "docs": { "model": "openai-codex/gpt-5.6-luna", "fallbackModels": ["zai/glm-4.5-air"], "thinking": "low" },
         "frontend": { "model": "openai-codex/gpt-5.6-terra", "fallbackModels": ["antigravity/gemini-3-flash-preview", "zai/glm-5.3"], "thinking": "medium" },
-        "browser-qa": { "model": "antigravity/gemini-3-flash-preview", "fallbackModels": ["openai-codex/gpt-5.4-mini"], "thinking": "medium" },
+        "browser-qa": { "model": "openai-codex/gpt-5.4-mini", "fallbackModels": ["antigravity/gemini-3-flash-preview", "zai/glm-5.3"], "thinking": "medium" },
         "tests": { "model": "openai-codex/gpt-5.6-terra", "fallbackModels": ["zai/glm-5-turbo"], "thinking": "medium" },
         "review": { "model": "openai-codex/gpt-5.6-sol", "fallbackModels": ["zai/glm-5.3"], "thinking": "high" },
         "implement": { "model": "openai-codex/gpt-5.6-sol", "fallbackModels": ["zai/glm-5.3"], "thinking": "high" },
@@ -148,7 +148,7 @@
         "research": { "model": "antigravity/gemini-3.1-pro-preview", "fallbackModels": ["openai-codex/gpt-5.4-mini", "zai/glm-5-turbo"], "thinking": "medium" },
         "docs": { "model": "antigravity/gemini-2.5-flash", "fallbackModels": ["openai-codex/gpt-5.3-codex-spark", "zai/glm-4.5-air"], "thinking": "medium" },
         "frontend": { "model": "antigravity/gemini-3.1-pro-preview-customtools", "fallbackModels": ["openai-codex/gpt-5.4-mini", "zai/glm-5.3"], "thinking": "low" },
-        "browser-qa": { "model": "antigravity/gemini-3-flash-preview", "fallbackModels": ["openai-codex/gpt-5.4-mini"], "thinking": "medium" },
+        "browser-qa": { "model": "openai-codex/gpt-5.4-mini", "fallbackModels": ["antigravity/gemini-3-flash-preview", "zai/glm-5.3"], "thinking": "medium" },
         "tests": { "model": "antigravity/antigravity-claude-sonnet-4-6", "fallbackModels": ["openai-codex/gpt-5.4-mini", "zai/glm-5-turbo"], "thinking": "high" },
         "review": { "model": "antigravity/antigravity-claude-sonnet-4-6", "fallbackModels": ["openai-codex/gpt-5.6-sol", "zai/glm-5.3"], "thinking": "high" },
         "implement": { "model": "openai-codex/gpt-5.6-sol", "fallbackModels": ["zai/glm-5.3"], "thinking": "high" },
@@ -199,8 +199,8 @@
 
     "browser-qa": {
       "description": "Use for browser-based visual QA: reproduce UI bugs and verify fixes with deterministic assertions, screenshots, video, and traces.",
-      "model": "antigravity/gemini-3-flash-preview",
-      "fallbackModels": ["openai-codex/gpt-5.4-mini"],
+      "model": "openai-codex/gpt-5.4-mini",
+      "fallbackModels": ["antigravity/gemini-3-flash-preview", "zai/glm-5.3"],
       "thinking": "medium",
       "tools": ["read", "grep", "bash"]
     },

package/external/pi-tools-suite/src/async-subagents/core/config.ts

@@ -207,8 +207,8 @@ const BUILTIN_CONFIG: SubagentConfig = {
 		},
 		"browser-qa": {
 			description: "Use for browser-based visual QA: reproduce UI bugs and verify fixes with deterministic assertions, screenshots, video, and traces.",
-			model: "antigravity/gemini-3-flash-preview",
-			fallbackModels: ["openai-codex/gpt-5.4-mini"],
+			model: "openai-codex/gpt-5.4-mini",
+			fallbackModels: ["antigravity/gemini-3-flash-preview", "zai/glm-5.3"],
 			thinking: "medium",
 			tools: ["read", "grep", "bash"],
 			isolatedSkills: [getBrowserQaSkillPath()],

package/external/pi-tools-suite/src/async-subagents/private-skills/browser-qa/SKILL.md

@@ -101,8 +101,10 @@ isolated browser context and exclusive evidence directory; the runner closes
 all owned browser resources on success and failure. Flows, screenshots, video,
 sanitized traces, and runner result manifests remain under
 `$PI_SUBAGENT_AGENT_DIR/browser-qa/` so normal sub-agent shutdown or cleanup
-deletes them with the run directory. `.pi/qa_auth.jsonc` and reusable
-`.pi/qa-auth-state/` remain project-local and persistent.
+deletes them with the run directory. For form auth, recording starts on the login
+page and includes field filling and submission; password inputs remain masked,
+but the private video may show visible login identifiers. Tracing starts only
+after login succeeds so credentials are not captured in the trace.
 
 ## Credentials and blocked runs
 

package/external/pi-tools-suite/src/async-subagents/private-skills/browser-qa/references/qa-design.md

@@ -55,13 +55,16 @@ stale credentials into an explicit update request instead of misreporting a
 product regression.
 
 Do not encode credentials, tokens, storage values, or login form secrets in the
-flow. The trusted runner applies the selected profile internally and removes
-secret-bearing evidence if it detects disclosure.
+flow. The trusted runner applies the selected profile internally. For form auth,
+video starts on the login page and includes field filling and submission; password
+inputs remain masked, but visible identifiers can appear, so treat the video as
+sensitive private evidence. Tracing starts only after login succeeds and is
+sanitized before retention.
 
 ## Evidence strategy
 
-The runner always attempts a final or failure screenshot, records video, and
-creates a sanitized trace once the browser launches. Add named `screenshot`
+The runner always attempts a final or failure screenshot, records video from the
+first page, and creates a sanitized post-auth trace. Add named `screenshot`
 steps only at states that materially help explain the result—for example before
 and after a destructive interaction, or when a transient success message is
 the oracle.
@@ -102,5 +105,5 @@ result manifest inside `$PI_SUBAGENT_AGENT_DIR/browser-qa/`. The launcher owns
 that path and the runner validates it before opening a browser. Do not override
 the environment path or copy evidence into shared `.pi/qa-runs`/`.pi/qa-flows`
 directories: the agent-local workspace is intentionally removed by the normal
-sub-agent shutdown and cleanup lifecycle. Authentication config and reusable
-auth state are separate persistent inputs and stay under project `.pi/`.
+sub-agent shutdown and cleanup lifecycle. Authentication config remains a
+separate persistent input under project `.pi/`.

package/external/pi-tools-suite/src/async-subagents/private-skills/browser-qa/scripts/browser-qa-runner.mjs

@@ -1,6 +1,5 @@
 #!/usr/bin/env node
 
-import { createHash } from "node:crypto";
 import fs from "node:fs";
 import path from "node:path";
 import { createRequire } from "node:module";
@@ -9,10 +8,10 @@ import { parse as parseJsonc, printParseErrorCode } from "jsonc-parser";
 import { strFromU8, strToU8, unzipSync, zipSync } from "../vendor/fflate.mjs";
 
 const CONFIG_RELATIVE = ".pi/qa_auth.jsonc";
-const STATE_RELATIVE = path.join(".pi", "qa-auth-state");
 const SUBAGENT_AGENT_DIR_ENV = "PI_SUBAGENT_AGENT_DIR";
 const QA_WORKSPACE_RELATIVE = "browser-qa";
 const EVIDENCE_RELATIVE = "evidence";
+const FORM_VIDEO_STEP_DELAY_MS = 250;
 const EXIT_AUTH_UPDATE_REQUIRED = 42;
 const EXIT_PROFILE_REQUIRED = 43;
 const PROFILE_ID = /^[A-Za-z0-9._-]+$/;
@@ -112,7 +111,7 @@ async function runQa({ cwd, agentDir, args, profileId, profile }) {
 	const runtimeSecrets = collectSecrets(profile.auth);
 	const tracePath = path.join(evidenceDir, "trace.zip");
 	try {
-		const contextOptions = await contextOptionsForAuth({ cwd, profileId, profile, allowedOrigins, browser });
+		const contextOptions = await contextOptionsForAuth({ cwd, profileId, profile, allowedOrigins });
 		context = await browser.newContext({
 			...contextOptions,
 			baseURL,
@@ -122,10 +121,11 @@ async function runQa({ cwd, agentDir, args, profileId, profile }) {
 		});
 		await installOriginGuard(context, allowedOrigins, profile.auth);
 		await applyContextAuth(context, profile.auth, allowedOrigins, baseURL, profileId);
-		runtimeSecrets.push(...collectStorageStateSecrets(await context.storageState()));
-		await context.tracing.start({ screenshots: true, snapshots: true, sources: false });
 		page = await context.newPage();
 		video = page.video();
+		await applyFormAuth(page, profile.auth, allowedOrigins, profileId);
+		runtimeSecrets.push(...collectStorageStateSecrets(await context.storageState()));
+		await context.tracing.start({ screenshots: true, snapshots: true, sources: false });
 		await executeFlow({ page, context, baseURL, evidenceDir, flow, allowedOrigins, profileId, secrets: runtimeSecrets });
 		await assertPageDoesNotExposeSecrets(page, runtimeSecrets, profileId);
 		await page.screenshot({ path: path.join(evidenceDir, "final.png"), fullPage: true });
@@ -465,7 +465,7 @@ function isStringArray(value) {
 	return Array.isArray(value) && value.length > 0 && value.every((item) => typeof item === "string");
 }
 
-async function contextOptionsForAuth({ cwd, profileId, profile, allowedOrigins, browser }) {
+async function contextOptionsForAuth({ cwd, profileId, profile, allowedOrigins }) {
 	const auth = profile.auth;
 	if (auth.type === "storageState") {
 		if (typeof auth.path !== "string") throw authError(profileId, "storageState path is missing");
@@ -473,16 +473,7 @@ async function contextOptionsForAuth({ cwd, profileId, profile, allowedOrigins,
 		return { storageState: filteredStorageState(statePath, allowedOrigins, profileId) };
 	}
 	if (auth.type === "form") {
-		const stateDirectory = path.join(cwd, STATE_RELATIVE);
-		const statePath = path.join(stateDirectory, `${profileId}-${authCacheKey(auth, allowedOrigins)}.json`);
-		if (!fs.existsSync(statePath)) {
-			ensurePrivateDirectory(cwd, stateDirectory);
-			for (const name of fs.readdirSync(stateDirectory)) {
-				if (name.startsWith(`${profileId}-`) && name.endsWith(".json")) fs.rmSync(path.join(stateDirectory, name), { force: true });
-			}
-			await createFormState({ statePath, auth, allowedOrigins, browser, profileId });
-		}
-		return { storageState: filteredStorageState(statePath, allowedOrigins, profileId) };
+		return {};
 	}
 	if (!["cookie", "localStorage", "sessionStorage", "bearer"].includes(auth.type)) {
 		throw authError(profileId, `unsupported auth type: ${auth.type}`);
@@ -490,39 +481,36 @@ async function contextOptionsForAuth({ cwd, profileId, profile, allowedOrigins,
 	return {};
 }
 
-async function createFormState({ statePath, auth, allowedOrigins, browser, profileId }) {
+async function applyFormAuth(page, auth, allowedOrigins, profileId) {
+	if (auth.type !== "form") return;
 	if (typeof auth.loginUrl !== "string" || !isAllowedUrl(auth.loginUrl, allowedOrigins)) {
 		throw authError(profileId, "form loginUrl is missing or outside allowedOrigins");
 	}
 	if (!Array.isArray(auth.fields) || auth.fields.length === 0 || typeof auth.submitSelector !== "string") {
 		throw authError(profileId, "form fields or submitSelector are missing");
 	}
-	const context = await browser.newContext();
 	try {
-		await installOriginGuard(context, allowedOrigins, auth);
-		const page = await context.newPage();
-		await page.goto(auth.loginUrl);
+		const timeout = Math.min(finitePositive(auth.timeoutMs) ?? 15_000, 60_000);
+		page.setDefaultTimeout(timeout);
+		page.setDefaultNavigationTimeout(timeout);
+		await page.goto(auth.loginUrl, { timeout });
+		await page.waitForTimeout(FORM_VIDEO_STEP_DELAY_MS);
 		for (const field of auth.fields) {
 			if (!isObject(field) || typeof field.selector !== "string" || typeof field.value !== "string") {
 				throw authError(profileId, "form fields must contain selector/value strings");
 			}
 			await page.locator(field.selector).fill(field.value);
+			await page.waitForTimeout(FORM_VIDEO_STEP_DELAY_MS);
 		}
 		await page.locator(auth.submitSelector).click();
-		const timeout = finitePositive(auth.timeoutMs) ?? 15_000;
 		if (isObject(auth.success) && typeof auth.success.url === "string") await page.waitForURL(auth.success.url, { timeout });
 		if (isObject(auth.success) && typeof auth.success.selector === "string") await page.locator(auth.success.selector).waitFor({ timeout });
 		if (!isObject(auth.success) || (typeof auth.success.url !== "string" && typeof auth.success.selector !== "string")) {
 			throw authError(profileId, "form success.url or success.selector is required");
 		}
-		fs.mkdirSync(path.dirname(statePath), { recursive: true, mode: 0o700 });
-		await context.storageState({ path: statePath });
-		fs.chmodSync(statePath, 0o600);
 	} catch (error) {
 		if (error instanceof QaStatusError) throw error;
 		throw authError(profileId, "form login was rejected or did not reach the configured success condition");
-	} finally {
-		await context.close().catch(() => {});
 	}
 }
 
@@ -550,10 +538,6 @@ async function applyContextAuth(context, auth, allowedOrigins, baseURL, profileI
 	}
 }
 
-function authCacheKey(auth, allowedOrigins) {
-	return createHash("sha256").update(JSON.stringify({ auth, allowedOrigins })).digest("hex").slice(0, 16);
-}
-
 async function installOriginGuard(context, allowedOrigins, auth) {
 	await context.route("**/*", async (route) => {
 		const request = route.request();
@@ -890,10 +874,6 @@ function createExclusivePrivateDirectory(cwd, target) {
 	createPrivateDirectory(cwd, target, true);
 }
 
-function ensurePrivateDirectory(cwd, target) {
-	createPrivateDirectory(cwd, target, false);
-}
-
 function createPrivateDirectory(cwd, target, exclusive) {
 	const root = fs.realpathSync(cwd);
 	const resolved = path.resolve(target);

package/external/pi-tools-suite/src/default-pi-tools-suite-config.ts

@@ -300,6 +300,13 @@ export const DEFAULT_PI_TOOLS_SUITE_CONFIG_JSONC = String.raw`{
           "When no mockup exists, choose a clear aesthetic direction and explain it briefly. Verify with targeted build/lint/tests or screenshot-relevant checks when possible."
         ]
       },
+      "browser-qa": {
+        "description": "Use for browser-based visual QA: reproduce UI bugs and verify fixes with deterministic assertions, screenshots, video, and traces.",
+        "model": "openai-codex/gpt-5.4-mini",
+        "fallbackModels": ["antigravity/gemini-3-flash-preview", "zai/glm-5.3"],
+        "thinking": "medium",
+        "tools": ["read", "grep", "bash"]
+      },
       "tests": {
         "description": "Use for tests: locate coverage, find gaps, run/check targeted test commands, diagnose failing tests.",
         "model": "zai/glm-5-turbo",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-ui-extend",
-  "version": "1.0.21",
+  "version": "1.0.22",
   "description": "Pix: a workspace-first terminal UI for Pi with tabs, readable tool activity, voice input, and bundled agent tools.",
   "private": false,
   "repository": {