pi-tandem 0.3.0 → 0.3.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (2) hide show
  1. package/package.json +1 -1
  2. package/skills/code-review/SKILL.md +6 -12
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "pi-tandem",
3
- "version": "0.3.0",
3
+ "version": "0.3.1",
4
4
  "repository": {
5
5
  "type": "git",
6
6
  "url": "git+https://github.com/skhoroshavin/tandem-skills.git"
package/skills/code-review/SKILL.md CHANGED
@@ -3,19 +3,13 @@ name: code-review
3
3
  description: Use when asked to do a code review.
4
4
  ---
5
5
 
6
- Read the full diff and everything it touches before judging; the worst review
7
- mistakes come from reviewing the diff only.
6
+ Read the full diff and everything it touches before judging; the worst review mistakes come from reviewing the diff only. The review is read-only: never modify tracked files, the index, HEAD, or branch state; running builds and tests to verify the change is fine.
7
+
8
+ Review as a lazy senior engineer: besides bugs, flag NIH syndrome, overengineering, unnecessary dependencies, obvious copy paste and other similar code bloats. Give accompanying tests the same, if not higher, level of attention: unreadable, overcomplicated tests explain nothing, and a test that would also pass without the change proves nothing.
8
9
 
9
10
  Report rules:
10
11
 
11
- - Actionable findings only, ordered by severity: ones requiring changes, or
12
- at least explicit decisions; "checked and fine" does not qualify.
13
- - Each finding: what is wrong and why it matters in 1-3 lines, then the
14
- smallest fix - as a diff if it fits within 50 LoC, otherwise described
15
- generally, asking for a decision.
16
- - No praise, no diff summary, no restating the request, no advice beyond
17
- findings.
12
+ - Actionable findings only, ordered by severity: ones requiring changes, or at least explicit decisions; "checked and fine" does not qualify.
13
+ - Each finding: what is wrong and why it matters in 1-3 lines, then the smallest fix as a concrete diff, or set of diffs; if not diffable, describe generally and ask for a decision.
14
+ - No praise, no diff summary, no restating the request, no advice beyond findings.
18
15
  - If nothing actionable: say exactly that, plus one line on what was checked.
19
- - Before writing, verify: grep for references to removed or renamed
20
- identifiers; where the repo has rendered build output, check it is in sync;
21
- diff the commit message claims against the actual change.