pi-system-one 1.2.0 → 1.2.3

package/src/tool.ts

@@ -114,6 +114,13 @@ const INSTRUCTIONS_ALIASES = [
   "task",
 ];
 
+/**
+ * Names that can hold the question map. Inside a question map one of these
+ * is a leftover echo of the argument wrapper, never a question in its own
+ * right — the value is what matters.
+ */
+const QUESTION_NAME_ALIASES = new Set(["questions", "question", "queries"]);
+
 /**
  * Question-level keys that are never part of the schema (naming metadata
  * from array-form questions, or hallucinated documentation fields).
@@ -176,18 +183,293 @@ function pickAlias(
   return undefined;
 }
 
+/**
+ * An ordered rubric is an ARRAY. Models overwhelmingly hand it over as an
+ * object instead, in one of two shapes:
+ *
+ *   {"item": ["low", "high"]}          a single wrapper key around the levels
+ *   {"low": "desc", "high": "desc"}     the levels as keys of a map
+ *
+ * Both are representation-only differences: a rubric's meaning is its ordered
+ * levels, and JS object key order is insertion order for string keys, so
+ * folding recovers exactly that order. The single-key wrapper case is only
+ * unwrapped when its value really is an array — a one-level rubric
+ * (`{"low": "..."}`) keeps its level instead of being unwrapped to a string.
+ *
+ * Level labels survive as far as the shape allows: a described level keeps its
+ * description, and a bare level (`{"low": null}`) falls back to its key.
+ */
+function foldScoreCriteria(criteria: unknown): unknown {
+  if (Array.isArray(criteria) || !isRecord(criteria)) return criteria;
+  const keys = Object.keys(criteria);
+  if (keys.length === 0) return criteria;
+  if (keys.length === 1) {
+    const [only] = keys;
+    const wrapped = criteria[only];
+    if (Array.isArray(wrapped) && wrapped.length >= 2) return wrapped;
+    // The same wrapper, one level deeper: `{"item": {"item": [...]}}`. A key
+    // that holds a single nested object names a container, not a level, so
+    // keep peeling until an array or a real multi-level map is reached. Only
+    // records are peeled, so a one-level rubric (`{"low": "bad"}`) is left
+    // alone and still reports the one-level error rather than being unwrapped
+    // into a bare string.
+    if (isRecord(wrapped)) {
+      const peeled = foldScoreCriteria(wrapped);
+      if (Array.isArray(peeled) && peeled.length >= 2) return peeled;
+    }
+  }
+  // TypeSafe's own levels stand on their own: the cookbook writes them as
+  // "Moderate: access and correction rights, but limited means to act", not
+  // as a bare "moderate". So when a model gives both a label and a
+  // description, keep both — dropping the label for the description alone
+  // loses which level the judge picked.
+  const levels: unknown[] = [];
+  for (const key of keys) {
+    const value = criteria[key];
+    if (value === null || value === undefined) {
+      levels.push(key);
+      continue;
+    }
+    if (typeof value === "string") {
+      const text = value.trim();
+      // An empty or absent description means the key IS the level; a
+      // description that already names its level is left alone rather than
+      // prefixed twice.
+      if (text === "" || key === text || text.includes(key)) {
+        levels.push(text === "" ? key : text);
+      } else {
+        levels.push(`${key}: ${text}`);
+      }
+      continue;
+    }
+    levels.push(value);
+  }
+  return levels;
+}
+
+/**
+ * Copy-on-write canonicality check for one question. Returns true when
+ * running the builder below would produce a key-for-key, value-for-value
+ * identical record — in which case the caller reuses the input by
+ * reference instead of allocating a copy. Any doubt returns false (the
+ * builder then produces the correct output); false negatives only cost an
+ * allocation, never correctness.
+ *
+ * Deliberately allocation-free itself (own-key probes, no entries/keys
+ * arrays) so the defensive second normalization in execute() stays cheap.
+ */
+function isCanonicalQuestion(input: Record<string, unknown>): boolean {
+  const hasType = Object.hasOwn(input, "type");
+  // Probe only: an exact canonical spelling (alias-map value identical to
+  // the key) needs no work. Near-miss spellings report non-canonical
+  // WITHOUT running full normalization here — the builder below runs it
+  // exactly once. Non-string types pass (the builder copies them verbatim),
+  // so doubt always errs toward a wasted rebuild, never a wrong share.
+  if (
+    hasType &&
+    typeof input.type === "string" &&
+    QUESTION_TYPE_ALIASES.get(input.type) !== input.type
+  ) {
+    return false;
+  }
+  // Strings reaching here are already canonical, so the raw type doubles
+  // as the normalized one for the criteria decisions below.
+  const normalizedType = hasType ? input.type : undefined;
+  const instructions = pickAlias(input, INSTRUCTIONS_ALIASES);
+  // NOTE: no `else` for an own defined "instructions" slot — "instructions"
+  // is the first alias, so pickAlias would have returned it above; reaching
+  // here with one means it is undefined and the builder omits it too.
+  if (instructions !== undefined) {
+    // The builder emits own "instructions" with this value; canonical only
+    // if it already sits there and no sibling alias key lingers (dropped).
+    if (
+      !Object.hasOwn(input, "instructions") ||
+      input.instructions !== instructions
+    ) {
+      return false;
+    }
+  }
+  for (const alias of INSTRUCTIONS_ALIASES) {
+    if (alias !== "instructions" && Object.hasOwn(input, alias)) return false;
+  }
+  let criteria = pickAlias(input, CRITERIA_ALIASES);
+  if (normalizedType === "noul" && criteria === null) {
+    // The builder drops it; canonical only if no own alias key is dropped.
+    for (const alias of CRITERIA_ALIASES) {
+      if (Object.hasOwn(input, alias)) return false;
+    }
+    criteria = undefined;
+  }
+  if (
+    normalizedType === "choice" &&
+    Array.isArray(criteria) &&
+    (criteria as unknown[]).every((item) => typeof item === "string")
+  ) {
+    return false; // The builder folds string arrays to an object.
+  }
+  if (normalizedType === "score" && isRecord(criteria)) {
+    return false; // The builder folds an object rubric to an ordered array.
+  }
+  if (
+    normalizedType === "noul" &&
+    (Object.hasOwn(input, "true") || Object.hasOwn(input, "false"))
+  ) {
+    return false; // The builder lifts bare true/false keys into criteria.
+  }
+  if (criteria !== undefined) {
+    if (!Object.hasOwn(input, "criteria") || input.criteria !== criteria) {
+      return false;
+    }
+  } else if (Object.hasOwn(input, "criteria")) {
+    return false; // Own undefined criteria is dropped by the builder.
+  }
+  for (const alias of CRITERIA_ALIASES) {
+    if (alias !== "criteria" && Object.hasOwn(input, alias)) return false;
+  }
+  for (const key of QUESTION_JUNK_KEYS) {
+    if (Object.hasOwn(input, key)) return false;
+  }
+  for (const key of Object.keys(input)) {
+    // Any extra is merged (choice labels) or dropped, and a missing `type`
+    // may be salvaged from one.
+    if (isQuestionExtra(key)) return false;
+  }
+  // `true`/`false` are lifted into `criteria` on a noul question and mean
+  // nothing anywhere else. On any other type the builder drops them, so a
+  // question carrying them is not already canonical and must be rebuilt -
+  // otherwise the copy-on-write fast path would ship them to the provider.
+  if (
+    normalizedType !== "noul" &&
+    (Object.hasOwn(input, "true") || Object.hasOwn(input, "false"))
+  ) {
+    return false;
+  }
+  // Any other own key is preserved by reference, so it cannot differ.
+  return true;
+}
+
+/**
+ * A sibling key carrying no value. Models leave these beside a question for
+ * two different reasons, and which reason applies is decided by the type.
+ */
+function isEmptyValue(value: unknown): boolean {
+  return value === "" || value === null || value === undefined;
+}
+
+/**
+ * A question object holds exactly `type`, `instructions` and `criteria`.
+ * Anything else is an extra: the model's own name for the question, a
+ * prediction, or metadata it invented. The provider can never interpret one,
+ * so extras are dropped rather than rejected — a rejected extra teaches the
+ * model nothing it did not already know and costs a retry.
+ */
+/**
+ * The names `state` can travel under at the top level of a request. A model
+ * that puts one of them INSIDE a question meant it as the request state, not
+ * as part of the question: a question is judged, it never carries what it is
+ * judged against. Kept through normalization so the value survives long enough
+ * to be lifted back out.
+ */
+const STATE_KEYS = ["state", "context", "evidence"];
+
+/**
+ * A question object holds exactly `type`, `instructions` and `criteria`.
+ * Anything else is an extra: the model's own name for the question, a
+ * prediction, or metadata it invented. The provider can never interpret one,
+ * so extras are dropped rather than rejected — a rejected extra teaches the
+ * model nothing it did not already know and costs a retry.
+ */
+function isQuestionExtra(key: string): boolean {
+  return (
+    key !== "type" &&
+    !INSTRUCTIONS_ALIASES.includes(key) &&
+    !CRITERIA_ALIASES.includes(key) &&
+    !QUESTION_JUNK_KEYS.has(key) &&
+    !STATE_KEYS.includes(key) &&
+    key !== "true" &&
+    key !== "false"
+  );
+}
+
+/**
+ * Repair option labels the model spilled out of `criteria`.
+ *
+ * A choice question that ends up with empty-valued siblings is the model
+ * listing its options one level too high: `criteria: {"sre_oncall": ""}` with
+ * `account_team: ""` and `ingest_service_owner: ""` beside it. Those siblings
+ * are options, not metadata, so they go back where the contract says options
+ * live. A label already present in `criteria` keeps its existing value.
+ */
+function mergeSpilledChoiceLabels(
+  siblings: Array<[string, unknown]>,
+  criteria: unknown,
+): unknown {
+  const base: Record<string, unknown> = isRecord(criteria) ? criteria : {};
+  let changed = !isRecord(criteria);
+  for (const [label, value] of siblings) {
+    if (Object.hasOwn(base, label)) continue;
+    setOwn(base, label, value);
+    changed = true;
+  }
+  return changed ? base : criteria;
+}
+
+/**
+ * Some model providers serialize nested tool arguments as JSON-encoded
+ * strings (e.g. `questions: "{\"q1\": {...}}"`). If the string looks like
+ * a JSON object or array, decode it so it can be normalized; anything else
+ * passes through untouched and still reports a clear validation error.
+ */
+function tryParseJson(input: string): unknown {
+  try {
+    return JSON.parse(input);
+  } catch {
+    return input;
+  }
+}
+
+/** Decode a JSON-encoded question value; any non-string passes through. */
+function decodeJsonInput(value: unknown): unknown {
+  return typeof value === "string" ? tryParseJson(value) : value;
+}
+
 /**
  * Coerce one question into the flat schema shape: canonical `type`,
  * `instructions` / `criteria` resolved through aliases, array-form choice
  * criteria (`["a", "b"]`) folded to `{"a": null, "b": null}`, and
  * naming/junk keys stripped.
+ *
+ * Pure, idempotent, non-mutating, with structural sharing: canonical input
+ * is returned by reference; only repaired questions allocate.
  */
 function normalizeQuestion(input: unknown): unknown {
   if (!isRecord(input)) return input;
+  if (isCanonicalQuestion(input)) return input;
   const out: Record<string, unknown> = {};
-  if (Object.hasOwn(input, "type"))
-    out.type = normalizeQuestionType(input.type);
-  const instructions = pickAlias(input, INSTRUCTIONS_ALIASES);
+  // A question object holds exactly three keys, so its `type` is whatever an
+  // EXTRA key holding a known kind is worth: `{"approach": "yes_no", ...}`
+  // states the kind under a different name. Adopt it, then drop the key.
+  let rawType = input.type;
+  if (rawType === undefined) {
+    for (const [key, value] of Object.entries(input)) {
+      if (!isQuestionExtra(key) || typeof value !== "string") continue;
+      const kind = normalizeQuestionType(value);
+      if (kind === "choice" || kind === "noul" || kind === "score") {
+        rawType = value;
+        break;
+      }
+    }
+  }
+  if (rawType !== undefined) out.type = normalizeQuestionType(rawType);
+  let instructions = pickAlias(input, INSTRUCTIONS_ALIASES);
+  // `description` is naming metadata, so it is normally dropped. But a model
+  // that writes its question text under `description` and nowhere else HAS
+  // supplied instructions — and dropping it produces the actively misleading
+  // error "needs instructions" for a question that carries one. Only taken as
+  // a fallback, so a real `instructions` always wins.
+  if (instructions === undefined && input.description !== undefined) {
+    instructions = input.description;
+  }
   if (instructions !== undefined) out.instructions = instructions;
   else if (Object.hasOwn(input, "instructions"))
     out.instructions = input.instructions;
@@ -195,6 +477,20 @@ function normalizeQuestion(input: unknown): unknown {
   // `null` is this schema's idiom for "no content"; on noul it reads as
   // "omitted" rather than a degenerate value worth a backend round trip.
   if (out.type === "noul" && criteria === null) criteria = undefined;
+  // A noul question that spells its outcomes as bare `true`/`false` keys
+  // beside `instructions` means exactly the documented `criteria: {true,
+  // false}` — the same two keys, one level up. Lift them back down so the
+  // question object keeps its three-key shape.
+  if (
+    out.type === "noul" &&
+    criteria === undefined &&
+    (Object.hasOwn(input, "true") || Object.hasOwn(input, "false"))
+  ) {
+    const outcomes: Record<string, unknown> = {};
+    if (Object.hasOwn(input, "true")) setOwn(outcomes, "true", input.true);
+    if (Object.hasOwn(input, "false")) setOwn(outcomes, "false", input.false);
+    criteria = outcomes;
+  }
   if (
     out.type === "choice" &&
     Array.isArray(criteria) &&
@@ -204,24 +500,275 @@ function normalizeQuestion(input: unknown): unknown {
     for (const item of criteria as string[]) setOwn(folded, item, null);
     criteria = folded;
   }
-  if (criteria !== undefined) out.criteria = criteria;
-  // Preserve any other non-junk keys so genuinely new fields still surface
-  // in validation instead of being silently dropped.
+  if (out.type === "score") criteria = foldScoreCriteria(criteria);
+  // Siblings that carry no value: option labels for a choice, the question's
+  // own name or a prediction for noul/score. Only the first kind is data.
+  const emptySiblings: Array<[string, unknown]> = [];
   for (const [key, value] of Object.entries(input)) {
-    if (
+    if (!isQuestionExtra(key) || !isEmptyValue(value)) continue;
+    emptySiblings.push([key, value]);
+  }
+  if (emptySiblings.length > 0 && out.type === "choice") {
+    criteria = mergeSpilledChoiceLabels(emptySiblings, criteria);
+  }
+  if (criteria !== undefined) out.criteria = criteria;
+  // Everything not part of the three-key contract is dropped on purpose — with
+  // one exception: a `state` the model nested here is request state, and
+  // prepareSystemOneArgs lifts it back to the top level.
+  for (const key of STATE_KEYS) {
+    if (Object.hasOwn(input, key)) setOwn(out, key, input[key]);
+  }
+  return out;
+}
+
+/**
+ * Move a `state` the model nested inside a question up to the top level of the
+ * request, and remove it from the question it was found in.
+ *
+ * Only the question's own keys are examined. A `state` key nested inside
+ * `criteria` is user data — an option literally labelled "state" — and is left
+ * exactly where it is.
+ */
+function liftNestedState(
+  questions: unknown,
+  fallback: unknown,
+): { questions: unknown; state: unknown } {
+  if (!isRecord(questions)) return { questions, state: fallback };
+  // Every state key is stripped from every question in one pass, and the first
+  // one found (by question order, then by STATE_KEYS priority) becomes the
+  // request state. Stripping only the match would take two passes for a
+  // question carrying two of them, which is not idempotent — and idempotence
+  // is what lets execute() re-normalize defensively for free.
+  let found: unknown;
+  const rebuilt: Record<string, unknown> = {};
+  let changed = false;
+  for (const [name, question] of Object.entries(questions)) {
+    if (!isRecord(question)) {
+      setOwn(rebuilt, name, question);
+      continue;
+    }
+    const kept: Record<string, unknown> = {};
+    for (const own of Object.keys(question)) {
+      if (STATE_KEYS.includes(own)) {
+        if (found === undefined) found = question[own];
+        changed = true;
+        continue;
+      }
+      setOwn(kept, own, question[own]);
+    }
+    setOwn(rebuilt, name, changed ? kept : question);
+  }
+  if (!changed) return { questions, state: fallback };
+  return {
+    questions: rebuilt,
+    state: fallback !== undefined ? fallback : found,
+  };
+}
+
+/**
+ * A record-valued question-map entry is only a question if it looks like one.
+ * A record holding none of the contract keys is a question FIELD that landed
+ * in the name slot (`{"choice_under_test": "...", "criteria": {...}}`), not a
+ * question.
+ */
+function looksLikeQuestion(value: unknown): boolean {
+  if (!isRecord(value)) return false;
+  if (typeof value.type === "string") return true;
+  for (const alias of INSTRUCTIONS_ALIASES) {
+    if (Object.hasOwn(value, alias)) return true;
+  }
+  for (const alias of CRITERIA_ALIASES) {
+    if (Object.hasOwn(value, alias)) return true;
+  }
+  return false;
+}
+
+/**
+ * Record a question-map entry that had to be discarded, so the caller can be
+ * told rather than silently handed an answer to a smaller question set.
+ *
+ * The contract is one-directional: a choice cannot pick an option omitted
+ * from its criteria, and a batch cannot report on a question that was never
+ * sent. Every repair here is allowed to reshape or drop a malformed entry,
+ * but none of them may do it invisibly — a dropped entry means the model asked
+ * something that was quietly not judged, which is exactly the kind of mistake
+ * a typed output cannot surface.
+ */
+function noteDrop(
+  drops: string[] | undefined,
+  name: string,
+  value: unknown,
+): void {
+  if (!drops) return;
+  const shown =
+    typeof value === "string" ? value : value === null ? "null" : "";
+  drops.push(shown === "" ? name : `${name} (${truncateForNote(shown)})`);
+}
+
+function truncateForNote(text: string): string {
+  const clean = text.replace(/\s+/g, " ").trim();
+  return clean.length <= 60 ? clean : `${clean.slice(0, 57)}...`;
+}
+
+/**
+ * Some models write a batch of questions as parallel arrays — one entry per
+ * field, aligned by position:
+ *
+ *   {"item": ["a", "b"], "type": ["choice", "noul"],
+ *    "instructions": ["...", "..."], "criteria": [{...}, null]}
+ *
+ * That is a question list with the nesting flattened one level. Transposing it
+ * loses nothing: position is the only thing tying the arrays together, and the
+ * model clearly meant `a` to be the first question. Only fires when every own
+ * value is an array of the same non-zero length AND at least one key is a
+ * contract key, so a name-to-array map (`{"fixes": [...], "risks": [...]}`)
+ * and a single wrapped array are both left to their own rules.
+ */
+function transposeParallelQuestions(input: Record<string, unknown>): unknown {
+  const keys = Object.keys(input);
+  if (keys.length < 2) return undefined;
+  const hasContractKey = keys.some(
+    (key) =>
       key === "type" ||
       INSTRUCTIONS_ALIASES.includes(key) ||
-      CRITERIA_ALIASES.includes(key) ||
-      QUESTION_JUNK_KEYS.has(key)
+      CRITERIA_ALIASES.includes(key),
+  );
+  if (!hasContractKey) return undefined;
+  const columns = keys.map((key) => input[key]);
+  if (!columns.every(Array.isArray)) return undefined;
+  const width = (columns[0] as unknown[]).length;
+  if (width < 1) return undefined;
+  if (!columns.every((column) => (column as unknown[]).length === width)) {
+    return undefined;
+  }
+  const questions: Record<string, unknown> = {};
+  const used = new Set<string>();
+  for (let i = 0; i < width; i += 1) {
+    const parts: Record<string, unknown> = {};
+    for (const key of keys) {
+      if (key === "item" || key === "name" || key === "id" || key === "key") {
+        continue;
+      }
+      setOwn(parts, key, (input[key] as unknown[])[i]);
+    }
+    const nameKey = ["item", "name", "id", "key"].find((key) =>
+      Array.isArray(input[key]),
+    );
+    const raw = nameKey ? (input[nameKey] as unknown[])[i] : undefined;
+    let name = typeof raw === "string" && raw.trim() !== "" ? raw : `q${i + 1}`;
+    for (let n = 2; used.has(name); n += 1) name = `${raw ?? `q${i + 1}`}_${n}`;
+    used.add(name);
+    setOwn(questions, name, normalizeQuestion(parts));
+  }
+  return questions;
+}
+
+/**
+ * A record holding only questions, i.e. a question map that landed in a name
+ * slot, possibly more than one level deep. A question never holds a question,
+ * so this reading is unambiguous. Bounded so a pathological object graph
+ * cannot spin.
+ */
+const MAX_NESTED_MAP_DEPTH = 4;
+
+/** A question, or a (possibly nested) map whose every leaf is a question. */
+function isQuestionTree(value: unknown, depth = 0): boolean {
+  if (looksLikeQuestion(value)) return true;
+  if (!isRecord(value) || depth >= MAX_NESTED_MAP_DEPTH) return false;
+  const keys = Object.keys(value);
+  return (
+    keys.length > 0 &&
+    keys.every((key) => isQuestionTree(value[key], depth + 1))
+  );
+}
+
+function isNestedQuestionMap(value: unknown): value is Record<string, unknown> {
+  return isRecord(value) && !looksLikeQuestion(value) && isQuestionTree(value);
+}
+
+/** Every leaf question in a (possibly nested) question map, with its name. */
+function flattenQuestionMap(
+  value: Record<string, unknown>,
+  depth = 0,
+): Array<[string, unknown]> {
+  const out: Array<[string, unknown]> = [];
+  for (const name of Object.keys(value)) {
+    const child = value[name];
+    if (
+      isRecord(child) &&
+      !looksLikeQuestion(child) &&
+      depth < MAX_NESTED_MAP_DEPTH
     ) {
-      continue;
+      out.push(...flattenQuestionMap(child, depth + 1));
+    } else {
+      out.push([name, child]);
     }
-    setOwn(out, key, value);
   }
   return out;
 }
 
-function normalizeQuestions(input: unknown): unknown {
+function normalizeQuestions(input: unknown, drops?: string[]): unknown {
+  if (typeof input === "string") input = tryParseJson(input);
+  if (isRecord(input)) {
+    // An array of questions wrapped in one key (`{"item": [...]}`) is the
+    // list the contract already accepts, one level too deep. Unwrap it and
+    // let the array path below name each entry the same way. Only when the
+    // wrapped array actually holds records: `{"q1": ["junk", "junk"]}` is a
+    // question map whose one entry is not a question, and unwrapping it
+    // renamed the junk on every pass.
+    const keys = Object.keys(input);
+    if (
+      keys.length === 1 &&
+      Array.isArray(input[keys[0]]) &&
+      (input[keys[0]] as unknown[]).some((entry) => isRecord(entry))
+    ) {
+      return normalizeQuestions(input[keys[0]], drops);
+    }
+    // One unwrapped question filed under the wrapper's own name, e.g.
+    // `{"questions": {"type": ..., "instructions": ...}}` — possibly beside
+    // other junk keys, as the model leaves them. The value is the question.
+    for (const key of keys) {
+      if (!QUESTION_NAME_ALIASES.has(key.toLowerCase())) continue;
+      const value = input[key];
+      if (isRecord(value) && typeof value.type === "string") {
+        // Every sibling is abandoned by this unwrap, and a sibling is often a
+        // real question: `{"questions": {"questions": {choice}, "risk":
+        // {noul}}}` is a two-question batch. Returning the aliased question
+        // alone answered half the batch and said nothing, so name what was
+        // left behind rather than letting the model believe it was answered.
+        for (const other of keys) {
+          if (other !== key) noteDrop(drops, other, input[other]);
+        }
+        return normalizeQuestions(value, drops);
+      }
+    }
+    // Parallel arrays standing in for a batch of questions.
+    const transposed = transposeParallelQuestions(input);
+    if (transposed !== undefined) return transposed;
+    // An array of questions the model sent as a name-to-array map. Naming is
+    // metadata, so take every question rather than stopping at the first:
+    // `{"fixes": [...], "risks": [...]}` is two questions, not one.
+    if (keys.length > 0 && keys.every((key) => Array.isArray(input[key]))) {
+      const entries = keys.flatMap((key) => input[key] as unknown[]);
+      // Only a map of question lists: `{q1: ["junk"]}` is a question map whose
+      // single entry is not a question, and flattening it renamed the junk.
+      if (!entries.some((entry) => isRecord(entry))) {
+        // fall through to the ordinary record handling
+      } else {
+        const merged: unknown[] = [];
+        for (const key of keys) {
+          for (const entry of input[key] as unknown[]) {
+            merged.push(
+              isRecord(entry) && entry.name === undefined
+                ? { name: key, ...entry }
+                : entry,
+            );
+          }
+        }
+        return normalizeQuestions(merged, drops);
+      }
+    }
+  }
   if (Array.isArray(input)) {
     const record: Record<string, unknown> = {};
     const used = new Set<string>();
@@ -233,19 +780,39 @@ function normalizeQuestions(input: unknown): unknown {
       used.add(candidate);
       return candidate;
     };
-    input.forEach((entry, index) => {
-      if (isRecord(entry)) {
-        const { name, id, key, ...rest } = entry;
-        const rawName = name ?? id ?? key;
-        const base =
-          typeof rawName === "string" && rawName.trim() !== ""
-            ? rawName
-            : `q${index + 1}`;
-        setOwn(record, claimName(base), normalizeQuestion(rest));
-      } else {
-        setOwn(record, claimName(`q${index + 1}`), entry);
-      }
+    // Same rule as the record branch below: a non-question entry is kept only
+    // while no real question exists. Applying it in one branch but not the
+    // other made normalization non-idempotent — `["junk", {a question}]`
+    // produced different maps on the first and second pass, and the second
+    // pass is the one execute() validates and sends.
+    //
+    // Question-ness is judged on the NORMALIZED entry, not the raw one: an
+    // entry like `{"description": "..."}` becomes a question only after
+    // normalization, so judging it raw makes the two passes disagree.
+    const pairs: Array<[string, unknown]> = input.map((entry, index) => {
+      // A question serialized as a JSON string (`["{\"type\":...}"]`) is the
+      // same provider quirk one level down; decode it so it can be normalized,
+      // and let a non-JSON string fall through as the junk it is.
+      const question = decodeJsonInput(entry);
+      if (!isRecord(question)) return [`q${index + 1}`, question];
+      // No intermediate `{...rest}` copy: normalizeQuestion() already drops
+      // name/id/key as junk, so passing the entry through repairs naming
+      // metadata and aliases in a single construction pass.
+      const rawName = question.name ?? question.id ?? question.key;
+      const base =
+        typeof rawName === "string" && rawName.trim() !== ""
+          ? rawName
+          : `q${index + 1}`;
+      return [base, normalizeQuestion(question)];
     });
+    const hasQuestion = pairs.some(([, value]) => looksLikeQuestion(value));
+    for (const [base, value] of pairs) {
+      if (hasQuestion && !looksLikeQuestion(value)) {
+        noteDrop(drops, base, value);
+        continue;
+      }
+      setOwn(record, claimName(base), value);
+    }
     return record;
   }
   if (isRecord(input)) {
@@ -270,9 +837,61 @@ function normalizeQuestions(input: unknown): unknown {
       );
       if (knownKind || allQuestionKeys) return { q: normalizeQuestion(input) };
     }
+    // Copy-on-write: share the map (and each canonical question) when
+    // nothing needs repair; otherwise rebuild with repaired questions and
+    // unaffected siblings shared by reference. The scan probes
+    // canonicality only — it must never build (and discard) repairs.
+    //
+    // A whole question MAP can land in a name slot, one level too deep:
+    // `{"Which library should we adopt?": {"pick": {type, instructions,
+    // criteria}}}`. The outer key is the question text, the value is a map
+    // whose every entry is a real question. Splice those entries up to this
+    // level. Provably safe: a question never holds a question, so a record
+    // whose values are ALL questions is a question map and nothing else.
+    const entries: Array<[string, unknown]> = [];
+    let dirty = false;
+    for (const name in input) {
+      if (!Object.hasOwn(input, name)) continue;
+      const question = input[name];
+      if (isNestedQuestionMap(question)) {
+        dirty = true;
+        entries.push(...flattenQuestionMap(question));
+        continue;
+      }
+      if (!isRecord(question) || !isCanonicalQuestion(question)) dirty = true;
+      entries.push([name, question]);
+    }
+    if (!dirty) return input;
     const record: Record<string, unknown> = {};
-    for (const [name, question] of Object.entries(input)) {
-      setOwn(record, name, normalizeQuestion(question));
+    // A question is always an object carrying a contract key. Anything else in
+    // a name slot is a label or a question field that landed a level too high
+    // (`{"deny": "refund it"}`, `{"criteria": {...}}`), so it is dropped — but
+    // only while a real question remains to answer with. A map with no real
+    // question carries none at all, and is left to report the precise error.
+    // Question-ness is judged on the normalized entry, matching the array
+    // branch: an entry that only becomes a question after normalization must
+    // still count, or the two passes disagree about what to keep.
+    const pairs: Array<[string, unknown]> = [];
+    for (const [name, value] of entries) {
+      const question = decodeJsonInput(value);
+      pairs.push([
+        name,
+        isRecord(question) ? normalizeQuestion(question) : question,
+      ]);
+    }
+    const hasQuestion = pairs.some(([, value]) => looksLikeQuestion(value));
+    for (const [name, question] of pairs) {
+      if (hasQuestion && !looksLikeQuestion(question)) {
+        noteDrop(drops, name, question);
+        continue;
+      }
+      // Two questions can only reach the same name if one was spliced up out
+      // of a nested map; suffix rather than silently drop the second.
+      let unique = name;
+      for (let n = 2; Object.hasOwn(record, unique); n += 1) {
+        unique = `${name}_${n}`;
+      }
+      setOwn(record, unique, question);
     }
     return record;
   }
@@ -285,18 +904,79 @@ function normalizeQuestions(input: unknown): unknown {
  * re-applies it defensively for direct calls that bypass validation.
  */
 export function prepareSystemOneArgs(args: unknown): SystemOneParams {
+  return normalizeArgs(args);
+}
+
+/**
+ * The same normalization, reporting any question-map entry it had to discard.
+ * `prepareSystemOneArgs` stays pure because Pi calls it on every tool call and
+ * the property harness relies on it being idempotent and reentrant; only the
+ * tool's own execute() needs to know what was thrown away, so only it pays for
+ * the second walk.
+ */
+export function collectDiscardedQuestions(args: unknown): string[] {
+  const drops: string[] = [];
+  if (!isRecord(args)) return drops;
+  normalizeArgs(args, drops);
+  return drops;
+}
+
+function normalizeArgs(args: unknown, drops?: string[]): SystemOneParams {
   if (!isRecord(args)) return args as SystemOneParams;
-  const out: Record<string, unknown> = {};
-  if (args.state !== undefined) {
-    out.state = args.state;
-  } else if (args.context !== undefined) {
-    out.state = args.context;
-  } else if (args.evidence !== undefined) {
-    out.state = args.evidence;
-  }
   const questions =
     args.questions ?? args.question ?? args.queries ?? undefined;
-  if (questions !== undefined) out.questions = normalizeQuestions(questions);
+  const normalizedQuestions =
+    questions !== undefined ? normalizeQuestions(questions, drops) : undefined;
+  // A state nested inside a question is request state; lift it unless a real
+  // top-level one was supplied, which always wins.
+  const lifted = liftNestedState(
+    normalizedQuestions,
+    args.state ?? args.context ?? args.evidence,
+  );
+  const topState = lifted.state;
+  const finalQuestions = lifted.questions;
+  // Copy-on-write fast path: canonical state/questions slots, no alias keys
+  // to rename, no unknown keys to drop — return the input by reference, so
+  // the defensive re-normalization in execute() never copies the question
+  // map or any question object, and retains nothing.
+  //
+  // The path is cheap to *copy* but no longer cheap to *decide*: the
+  // canonicality checks below now have to rule out all 13 repair rules
+  // before they can conclude "nothing to do". Measured on the canonical
+  // fixture in bench/normalize.bench.ts, against 8cf6ba1 on the same
+  // machine: 620 -> 1329 ns/op and 290 -> 1939 B/op generated, with
+  // retained memory ~0 on both sides. The cost is transient garbage from
+  // the analysis, not copies, and it is negligible against the network
+  // round trip to the judge. The repair path itself is unchanged
+  // (sloppy fixture: 1571 -> 1563 B/op generated).
+  const questionsCanonical =
+    finalQuestions === questions &&
+    (questions === undefined
+      ? !Object.hasOwn(args, "questions") &&
+        !Object.hasOwn(args, "question") &&
+        !Object.hasOwn(args, "queries")
+      : questions === args.questions &&
+        !Object.hasOwn(args, "question") &&
+        !Object.hasOwn(args, "queries"));
+  if (
+    questionsCanonical &&
+    Object.hasOwn(args, "state") &&
+    args.state !== undefined &&
+    !Object.hasOwn(args, "context") &&
+    !Object.hasOwn(args, "evidence")
+  ) {
+    let knownKeysOnly = true;
+    for (const key in args) {
+      if (Object.hasOwn(args, key) && key !== "state" && key !== "questions") {
+        knownKeysOnly = false;
+        break;
+      }
+    }
+    if (knownKeysOnly) return args as SystemOneParams;
+  }
+  const out: Record<string, unknown> = {};
+  if (topState !== undefined) out.state = topState;
+  if (finalQuestions !== undefined) out.questions = finalQuestions;
   // Drop unknown top-level keys; a missing `state` / `questions` still
   // produces a clear error from semantic validation in execute().
   return out as SystemOneParams;
@@ -325,8 +1005,6 @@ export interface SystemOneDetails {
  * is the final arbiter for anything stricter). Every error states what
  * was wrong, which question it was in, and what valid shape looks like.
  */
-const KNOWN_QUESTION_KEYS = new Set(["type", "instructions", "criteria"]);
-
 function assertAnswerableQuestions(questions: unknown): void {
   if (questions === undefined) {
     throw new Error(
@@ -351,13 +1029,6 @@ function assertAnswerableQuestions(questions: unknown): void {
         `system_one: question "${name}" must be an object with "type", "instructions", and "criteria".`,
       );
     }
-    for (const key of Object.keys(value)) {
-      if (!KNOWN_QUESTION_KEYS.has(key)) {
-        throw new Error(
-          `system_one: question "${name}" has unknown field "${key}"; use only "type", "instructions", and "criteria".`,
-        );
-      }
-    }
     if (value.instructions === undefined || value.instructions === null) {
       throw new Error(
         `system_one: question "${name}" needs "instructions" describing what to evaluate, e.g. {"type": "${typeof value.type === "string" ? value.type : "choice"}", "instructions": "Which option fits best?"}.`,
@@ -406,10 +1077,10 @@ export function buildSystemOneTool(deps: {
     label: "System One",
 
     description:
-      "Judge bounded decisions over explicitly supplied state with a dedicated judge model — calibrated probabilities conditional on that state (confidence for choice/score only; noul has no confidence field, its probability is the uncertainty measure). " +
-      "Call system_one instead of answering directly when the request is a pick from named options, a yes/no likelihood, or a rubric score over state already in context — the judge's state-conditional probabilities beat guesses from priors. " +
+      "Judge bounded decisions over explicitly supplied state with a dedicated judge model - calibrated probabilities conditional on that state (confidence for choice/score only; noul has no confidence field, its probability is the uncertainty measure). " +
+      "Call system_one instead of making a bounded judgment directly when the decision is a pick from named options, a yes/no likelihood, or a rubric score over state already in context. This applies both to final answers and intermediate agent decisions such as classification, routing, or choosing among plausible tools, skills, strategies, implementations, models, or providers. " +
       "The judge only weighs the state you supply: it cannot recall facts or browse, so retrieve evidence first and never ask it to recall facts. " +
-      "Do not use it for open-ended text generation or factual lookup. " +
+      "Do not use it for open-ended generation itself or factual lookup. A generative task may still contain bounded intermediate judgments where system_one is useful. " +
       "Questions that share the same state can be evaluated together in one call. " +
       'Each question is {"type": "choice" | "noul" | "score", "instructions": "...", "criteria": ...}: ' +
       'choice criteria is an object keyed by choice label ({"a": null, "b": null}), ' +
@@ -419,14 +1090,24 @@ export function buildSystemOneTool(deps: {
     parameters: systemOneParams,
 
     promptSnippet:
-      "Use system_one for bounded choice, yes/no, and ordered-scale judgments over supplied evidence",
+      "Use system_one for bounded judgments over supplied evidence, including classification, routing, and selecting among plausible tools, skills, strategies, implementations, models, or providers",
 
     promptGuidelines: [
-      "Before answering a bounded judgment over supplied or retrieved evidence, call system_one instead of making the judgment yourself. A bounded judgment is: choosing among explicit alternatives, making a yes/no judgment, or rating something on an ordered scale.",
+      "Whenever you encounter a bounded judgment over supplied or retrieved evidence, including as an intermediate step in a larger task, call system_one instead of making the judgment yourself. A bounded judgment is choosing among explicit alternatives, making a yes/no judgment, or rating something on an ordered scale.",
+
+      "Common bounded-choice patterns include classification into known labels, selecting among plausible candidate tools or skills, routing among models/providers, and choosing among plausible strategies or implementations. These are examples, not an exhaustive list; recognize other bounded decisions from their structure.",
+
       "Pick the system_one question type mechanically: unordered alternatives (frontend, backend, platform) -> choice; yes/no -> noul; ordered scale, rating, severity, risk, or grade -> score. Never use choice for an ordered scale merely because its levels have names: very low / low / moderate / high / very high is score, not choice.",
+
       "Retrieve missing factual evidence into state first; never ask system_one to recall facts or browse. Use system_one for bounded judgments over available evidence, not as a replacement for factual lookup.",
+
+      "Do not use system_one to perform open-ended generation itself - writing, drafting, composing, generating code, or explaining. However, a generative task may contain bounded intermediate judgments where system_one is appropriate, such as classification, routing, or choosing among plausible tools, skills, strategies, implementations, models, or providers.",
+
+      "Do not use system_one for trivial or mechanically obvious selections where there is no meaningful judgment to make. Use it when multiple candidates are genuinely plausible and the choice depends on supplied or retrieved evidence.",
+
       "Batch independent system_one questions sharing the same state into one call instead of one call per question.",
-      "For system_one choice questions, the keys of criteria are the available choices — preserve user-specified labels and use null values when labels are self-explanatory; never add a separate options field.",
+
+      "For system_one choice questions, the keys of criteria are the available choices - preserve user-specified labels and use null values when labels are self-explanatory; never add a separate options field.",
     ],
 
     prepareArguments: (args) => prepareSystemOneArgs(args),
@@ -440,11 +1121,12 @@ export function buildSystemOneTool(deps: {
        * `prepareArguments` above is an optimization for newer Pi only: it
        * runs before schema validation there, but older Pi versions ignore
        * it and validate the raw model output against the permissive
-       * schema instead. Correctness never depends on it — re-normalize
+       * schema instead. Correctness never depends on it - re-normalize
        * here so every path (new Pi, old Pi, direct calls) converges on
        * the same canonical shape before semantic validation.
        */
       const normalized = prepareSystemOneArgs(params);
+
       // prepareSystemOneArgs passes non-objects through untouched; direct
       // calls bypassing Pi validation must get an actionable error, not a
       // TypeError from property access on null.
@@ -453,12 +1135,15 @@ export function buildSystemOneTool(deps: {
           'system_one: request must be an object with "state" and "questions".',
         );
       }
+
       if (normalized.state === undefined) {
         throw new Error(
           'system_one: state is required. Put the material under judgment in "state" (string or object), e.g. {"state": "<evidence>", "questions": {...}}.',
         );
       }
+
       assertAnswerableQuestions(normalized.questions);
+
       const response = await systemOne.evaluate(
         {
           state: normalized.state as SystemOneState,
@@ -471,7 +1156,10 @@ export function buildSystemOneTool(deps: {
         content: [
           {
             type: "text" as const,
-            text: renderSystemOneResult(response),
+            text: renderSystemOneResult(
+              response,
+              collectDiscardedQuestions(params),
+            ),
           },
         ],