pi-system-one 1.1.4 → 1.2.1

package/tests/extension.test.ts

@@ -0,0 +1,123 @@
+// pi-system-one/tests/extension.test.ts
+
+import assert from "node:assert/strict";
+import { existsSync, readFileSync } from "node:fs";
+import { join } from "node:path";
+import { describe, it } from "node:test";
+import piSystemOneExtension, {
+  systemOnePromptsDir,
+  systemOneSkillsDir,
+} from "../src/extension.ts";
+
+describe("extension resources", () => {
+  it("contributes a valid system-one skill directory", async () => {
+    const prev = process.env.SYSTEM_ONE_BASE_URL;
+    process.env.SYSTEM_ONE_BASE_URL = "http://localhost:8008";
+    try {
+      const handlers: Record<string, (event: never) => unknown> = {};
+      const pi = {
+        registerTool: () => {},
+        registerCommand: () => {},
+        on: (channel: string, handler: (event: never) => unknown) => {
+          handlers[channel] = handler;
+        },
+      };
+      piSystemOneExtension(pi as never);
+      const discover = handlers.resources_discover;
+      assert.ok(discover, "resources_discover handler registered");
+      const result = (await discover({} as never)) as {
+        skillPaths: string[];
+      };
+      assert.equal(result.skillPaths.length, 1);
+      assert.equal(result.skillPaths[0], systemOneSkillsDir());
+      const skillMd = join(result.skillPaths[0], "system-one", "SKILL.md");
+      assert.ok(existsSync(skillMd), `missing ${skillMd}`);
+      const raw = readFileSync(skillMd, "utf-8");
+      const frontmatter = raw.split("---")[1] ?? "";
+      // YAML forbids `: ` inside unquoted plain scalars (it starts a nested
+      // mapping — Pi rejects the skill). Every multi-word value must be
+      // quoted or use a block scalar.
+      for (const line of frontmatter.split("\n")) {
+        const trimmed = line.trim();
+        if (!trimmed || trimmed.startsWith("#")) continue;
+        const value = trimmed.replace(/^\w+:\s*/, "");
+        const quoted =
+          (value.startsWith('"') && value.endsWith('"')) ||
+          (value.startsWith("'") && value.endsWith("'")) ||
+          value.startsWith("|") ||
+          value.startsWith(">");
+        assert.ok(
+          quoted || !value.includes(": "),
+          `unquoted ": " in SKILL.md frontmatter: ${trimmed}`,
+        );
+      }
+      const stripQuotes = (s: string) =>
+        s.startsWith('"') && s.endsWith('"') ? s.slice(1, -1) : s;
+      const name = stripQuotes(
+        frontmatter.match(/name:\s*(.+)/)?.[1]?.trim() ?? "",
+      );
+      const description = stripQuotes(
+        frontmatter.match(/description:\s*(.+)/)?.[1]?.trim() ?? "",
+      );
+      // Pi's skill validation rules (docs/skills.md): name 1-64 chars,
+      // lowercase alphanumerics/hyphens, no leading/trailing or consecutive
+      // hyphens; description required, max 1024 chars.
+      assert.match(name, /^[a-z0-9]([a-z0-9-]{0,62}[a-z0-9])?$/);
+      assert.ok(name.length >= 1 && name.length <= 64);
+      assert.ok(!name.includes("--"));
+      assert.ok(description.length >= 1 && description.length <= 1024);
+      assert.match(description, /system_one|System One/);
+      assert.ok(
+        existsSync(
+          join(
+            result.skillPaths[0],
+            "system-one",
+            "references",
+            "use-cases.md",
+          ),
+        ),
+        "missing use-cases reference",
+      );
+    } finally {
+      if (prev === undefined) delete process.env.SYSTEM_ONE_BASE_URL;
+      else process.env.SYSTEM_ONE_BASE_URL = prev;
+    }
+  });
+
+  it("contributes a valid /judge prompt template", async () => {
+    const prev = process.env.SYSTEM_ONE_BASE_URL;
+    process.env.SYSTEM_ONE_BASE_URL = "http://localhost:8008";
+    try {
+      const handlers: Record<string, (event: never) => unknown> = {};
+      const pi = {
+        registerTool: () => {},
+        registerCommand: () => {},
+        on: (channel: string, handler: (event: never) => unknown) => {
+          handlers[channel] = handler;
+        },
+      };
+      piSystemOneExtension(pi as never);
+      const discover = handlers.resources_discover;
+      assert.ok(discover, "resources_discover handler registered");
+      const result = (await discover({} as never)) as {
+        promptPaths: string[];
+      };
+      assert.equal(result.promptPaths.length, 1);
+      assert.equal(result.promptPaths[0], systemOnePromptsDir());
+      const judgeMd = join(result.promptPaths[0], "judge.md");
+      assert.ok(existsSync(judgeMd), `missing ${judgeMd}`);
+      const content = readFileSync(judgeMd, "utf-8");
+      // Prompt templates take `$@` args and must name the tool explicitly:
+      // that explicit naming is what makes routing deterministic.
+      assert.match(content, /\$@/);
+      assert.match(content, /system_one/);
+      assert.match(content, /do not\s+answer it directly/i);
+      // noul answers carry no confidence field; the template must not ask
+      // the model to report one or it will invent numbers.
+      assert.match(content, /for noul the probability/i);
+    } finally {
+      if (prev === undefined) delete process.env.SYSTEM_ONE_BASE_URL;
+      else process.env.SYSTEM_ONE_BASE_URL = prev;
+    }
+  });
+});

package/tests/packaging.test.ts

@@ -0,0 +1,62 @@
+// pi-system-one/tests/packaging.test.ts
+//
+// The skill and /judge prompt are runtime behavior (served via
+// resources_discover), not just docs. Assert the published tarball
+// actually contains them by inspecting the real `npm pack` file list
+// rather than the source checkout.
+
+import assert from "node:assert/strict";
+import { execFileSync } from "node:child_process";
+import { readFileSync } from "node:fs";
+import { join } from "node:path";
+import { describe, it } from "node:test";
+import { fileURLToPath } from "node:url";
+
+const packageRoot = fileURLToPath(new URL("..", import.meta.url));
+
+function packedFiles(): string[] {
+  const stdout = execFileSync("npm", ["pack", "--dry-run", "--json"], {
+    cwd: packageRoot,
+    encoding: "utf-8",
+    stdio: ["ignore", "pipe", "pipe"],
+  });
+  const parsed: unknown = JSON.parse(stdout);
+  const entry = Array.isArray(parsed) ? parsed[0] : undefined;
+  const files = (entry as { files?: Array<{ path?: string }> } | undefined)
+    ?.files;
+  assert.ok(
+    Array.isArray(files) && files.length > 0,
+    "npm pack --dry-run --json returned no files",
+  );
+  return (files as Array<{ path?: string }>)
+    .map((f) => f.path ?? "")
+    .filter((p) => p.length > 0);
+}
+
+describe("npm package runtime resources", () => {
+  it("declares the extension entry for both Pi and OMP", () => {
+    const packageJson = JSON.parse(
+      readFileSync(join(packageRoot, "package.json"), "utf-8"),
+    ) as {
+      pi?: { extensions?: string[] };
+      omp?: { extensions?: string[] };
+    };
+    assert.deepEqual(packageJson.pi, { extensions: ["./src/extension.ts"] });
+    assert.deepEqual(packageJson.omp, { extensions: ["./src/extension.ts"] });
+  });
+
+  it("packs the skill, its references, and the /judge prompt", () => {
+    const files = packedFiles();
+    for (const required of [
+      "skills/system-one/SKILL.md",
+      "skills/system-one/references/use-cases.md",
+      "prompts/judge.md",
+      "src/extension.ts",
+    ]) {
+      assert.ok(
+        files.includes(required),
+        `published package is missing runtime resource: ${required}`,
+      );
+    }
+  });
+});