pi-subagents 0.9.2 → 0.11.0

package/settings.ts

@@ -213,7 +213,7 @@ export function resolveStepBehavior(
  * Resolve a file path: absolute paths pass through, relative paths get chainDir prepended.
  */
 function resolveChainPath(filePath: string, chainDir: string): string {
-	return path.isAbsolute(filePath) ? filePath : `${chainDir}/${filePath}`;
+	return path.isAbsolute(filePath) ? filePath : path.join(chainDir, filePath);
 }
 
 /**
@@ -243,7 +243,7 @@ export function buildChainInstructions(
 
 	// Progress instructions in suffix (less critical)
 	if (behavior.progress) {
-		const progressPath = `${chainDir}/progress.md`;
+		const progressPath = path.join(chainDir, "progress.md");
 		if (isFirstProgressAgent) {
 			suffixParts.push(`Create and maintain progress at: ${progressPath}`);
 		} else {
@@ -288,7 +288,7 @@ export function resolveParallelBehaviors(
 		}
 
 		// Build subdirectory path for this parallel task
-		const subdir = `parallel-${stepIndex}/${taskIndex}-${task.agent}`;
+		const subdir = path.join(`parallel-${stepIndex}`, `${taskIndex}-${task.agent}`);
 
 		// Output: task override > agent default (namespaced) > false
 		// Absolute paths pass through unchanged; relative paths get namespaced under subdir
@@ -299,11 +299,11 @@ export function resolveParallelBehaviors(
 			} else if (path.isAbsolute(task.output)) {
 				output = task.output; // Absolute path: use as-is
 			} else {
-				output = `${subdir}/${task.output}`; // Relative: namespace under subdir
+				output = path.join(subdir, task.output); // Relative: namespace under subdir
 			}
 		} else if (config.output) {
 			// Agent defaults are always relative, so namespace them
-			output = `${subdir}/${config.output}`;
+			output = path.join(subdir, config.output);
 		}
 
 		// Reads: task override > agent default > false
@@ -372,15 +372,17 @@ export function aggregateParallelOutputs(results: ParallelTaskResult[]): string
 		.map((r, i) => {
 			const header = `=== Parallel Task ${i + 1} (${r.agent}) ===`;
 			const hasTextOutput = Boolean(r.output?.trim());
-			const status = r.exitCode !== 0
-				? `⚠️ FAILED (exit code ${r.exitCode})${r.error ? `: ${r.error}` : ""}`
-				: r.error
-					? `⚠️ WARNING: ${r.error}`
-					: !hasTextOutput && r.outputTargetPath && r.outputTargetExists === false
-						? `⚠️ EMPTY OUTPUT (expected output file missing: ${r.outputTargetPath})`
-						: !hasTextOutput && !r.outputTargetPath
-							? "⚠️ EMPTY OUTPUT (no textual response returned)"
-							: "";
+			const status = r.exitCode === -1
+				? "⏭️ SKIPPED"
+				: r.exitCode !== 0
+					? `⚠️ FAILED (exit code ${r.exitCode})${r.error ? `: ${r.error}` : ""}`
+					: r.error
+						? `⚠️ WARNING: ${r.error}`
+						: !hasTextOutput && r.outputTargetPath && r.outputTargetExists === false
+							? `⚠️ EMPTY OUTPUT (expected output file missing: ${r.outputTargetPath})`
+							: !hasTextOutput && !r.outputTargetPath
+								? "⚠️ EMPTY OUTPUT (no textual response returned)"
+								: "";
 			const body = status
 				? (hasTextOutput ? `${status}\n${r.output}` : status)
 				: r.output;

package/skills.ts

@@ -2,6 +2,7 @@
  * Skill resolution and caching for subagent extension
  */
 
+import { execSync } from "node:child_process";
 import * as fs from "node:fs";
 import * as os from "node:os";
 import * as path from "node:path";
@@ -89,11 +90,31 @@ function getPackageSkillPaths(packageRoot: string): string[] {
 	}
 }
 
+let cachedGlobalNpmRoot: string | null = null;
+
+function getGlobalNpmRoot(): string | null {
+	if (cachedGlobalNpmRoot !== null) return cachedGlobalNpmRoot;
+	try {
+		cachedGlobalNpmRoot = execSync("npm root -g", { encoding: "utf-8", timeout: 5000 }).trim();
+		return cachedGlobalNpmRoot;
+	} catch {
+		cachedGlobalNpmRoot = ""; // Empty string means "tried but failed"
+		return null;
+	}
+}
+
 function collectPackageSkillPaths(cwd: string): string[] {
 	const dirs = [
 		path.join(cwd, CONFIG_DIR, "npm", "node_modules"),
 		path.join(AGENT_DIR, "npm", "node_modules"),
 	];
+	
+	// Add global npm root if available (where pi installs global packages)
+	const globalRoot = getGlobalNpmRoot();
+	if (globalRoot) {
+		dirs.push(globalRoot);
+	}
+	
 	const results: string[] = [];
 
 	for (const dir of dirs) {
@@ -178,6 +199,8 @@ function inferSkillSource(rawSource: unknown, filePath: string, cwd: string): Sk
 	const projectRoot = path.resolve(cwd, CONFIG_DIR);
 	const isProjectScoped = isWithinPath(filePath, projectRoot);
 	const isUserScoped = isWithinPath(filePath, AGENT_DIR);
+	const globalRoot = getGlobalNpmRoot();
+	const isGlobalPackage = globalRoot ? isWithinPath(filePath, globalRoot) : false;
 
 	if (source === "project") return "project";
 	if (source === "user") return "user";
@@ -188,7 +211,7 @@ function inferSkillSource(rawSource: unknown, filePath: string, cwd: string): Sk
 	}
 	if (source === "package") {
 		if (isProjectScoped) return "project-package";
-		if (isUserScoped) return "user-package";
+		if (isUserScoped || isGlobalPackage) return "user-package";
 		return "unknown";
 	}
 	if (source === "extension") return "extension";
@@ -196,6 +219,7 @@ function inferSkillSource(rawSource: unknown, filePath: string, cwd: string): Sk
 
 	if (isProjectScoped) return "project";
 	if (isUserScoped) return "user";
+	if (isGlobalPackage) return "user-package";
 	return "unknown";
 }