pi-subagents 0.9.2 → 0.10.0

package/render.ts

@@ -20,9 +20,68 @@ function getTermWidth(): number {
 	return process.stdout.columns || 120;
 }
 
+// Grapheme segmenter for proper Unicode handling (shared instance)
+const segmenter = new Intl.Segmenter(undefined, { granularity: "grapheme" });
+
+/**
+ * Truncate a line to maxWidth, preserving ANSI styling through the ellipsis.
+ * 
+ * pi-tui's truncateToWidth adds \x1b[0m before ellipsis which resets all styling,
+ * causing background color bleed in the TUI. This implementation tracks active
+ * ANSI styles and re-applies them before the ellipsis.
+ * 
+ * Uses Intl.Segmenter for proper Unicode/emoji handling (not char-by-char).
+ */
 function truncLine(text: string, maxWidth: number): string {
 	if (visibleWidth(text) <= maxWidth) return text;
-	return truncateToWidth(text, maxWidth - 1) + "…";
+
+	const targetWidth = maxWidth - 1; // Room for single ellipsis character
+	let result = "";
+	let currentWidth = 0;
+	let activeStyles: string[] = []; // Track ALL active styles (not just last)
+	let i = 0;
+
+	while (i < text.length) {
+		// Check for ANSI escape code
+		const ansiMatch = text.slice(i).match(/^\x1b\[[0-9;]*m/);
+		if (ansiMatch) {
+			const code = ansiMatch[0];
+			result += code;
+
+			if (code === "\x1b[0m" || code === "\x1b[m") {
+				activeStyles = []; // Reset clears all styles
+			} else {
+				activeStyles.push(code); // Stack styles (bold + color, etc.)
+			}
+			i += code.length;
+			continue;
+		}
+
+		// Find end of non-ANSI text segment
+		let end = i;
+		while (end < text.length && !text.slice(end).match(/^\x1b\[[0-9;]*m/)) {
+			end++;
+		}
+
+		// Segment into graphemes for proper Unicode handling
+		const textPortion = text.slice(i, end);
+		for (const seg of segmenter.segment(textPortion)) {
+			const grapheme = seg.segment;
+			const graphemeWidth = visibleWidth(grapheme);
+
+			if (currentWidth + graphemeWidth > targetWidth) {
+				// Re-apply all active styles before ellipsis to preserve background/colors
+				return result + activeStyles.join("") + "…";
+			}
+
+			result += grapheme;
+			currentWidth += graphemeWidth;
+		}
+		i = end;
+	}
+
+	// Reached end without exceeding width (shouldn't happen given initial check)
+	return result + activeStyles.join("") + "…";
 }
 
 // Track last rendered widget state to avoid no-op re-renders
@@ -319,7 +378,9 @@ export function renderSubagentResult(
 		c.addChild(new Text(truncLine(stepHeader, w), 0, 0));
 
 		const taskMaxLen = Math.max(20, w - 12);
-		const taskPreview = r.task.slice(0, taskMaxLen) + (r.task.length > taskMaxLen ? "..." : "");
+		const taskPreview = r.task.length > taskMaxLen
+			? `${r.task.slice(0, taskMaxLen)}...`
+			: r.task;
 		c.addChild(new Text(truncLine(theme.fg("dim", `    task: ${taskPreview}`), w), 0, 0));
 
 		const outputTarget = extractOutputTarget(r.task);
@@ -340,22 +401,31 @@ export function renderSubagentResult(
 			}
 			// Current tool for running step
 			if (rProg.currentTool) {
-				const toolLine = rProg.currentToolArgs
-					? `${rProg.currentTool}: ${rProg.currentToolArgs.slice(0, 100)}${rProg.currentToolArgs.length > 100 ? "..." : ""}`
+				const maxToolArgsLen = Math.max(50, w - 20);
+				const toolArgsPreview = rProg.currentToolArgs
+					? (rProg.currentToolArgs.length > maxToolArgsLen
+						? `${rProg.currentToolArgs.slice(0, maxToolArgsLen)}...`
+						: rProg.currentToolArgs)
+					: "";
+				const toolLine = toolArgsPreview
+					? `${rProg.currentTool}: ${toolArgsPreview}`
 					: rProg.currentTool;
 				c.addChild(new Text(truncLine(theme.fg("warning", `    > ${toolLine}`), w), 0, 0));
 			}
 			// Recent tools
 			if (rProg.recentTools?.length) {
 				for (const t of rProg.recentTools.slice(0, 3)) {
-					const args = t.args.slice(0, 90) + (t.args.length > 90 ? "..." : "");
-					c.addChild(new Text(truncLine(theme.fg("dim", `      ${t.tool}: ${args}`), w), 0, 0));
+					const maxArgsLen = Math.max(40, w - 30);
+					const argsPreview = t.args.length > maxArgsLen
+						? `${t.args.slice(0, maxArgsLen)}...`
+						: t.args;
+					c.addChild(new Text(truncLine(theme.fg("dim", `      ${t.tool}: ${argsPreview}`), w), 0, 0));
 				}
 			}
-			// Recent output (limited)
+			// Recent output - let truncLine handle truncation entirely
 			const recentLines = (rProg.recentOutput ?? []).slice(-5);
 			for (const line of recentLines) {
-				c.addChild(new Text(truncLine(theme.fg("dim", `      ${line.slice(0, 100)}${line.length > 100 ? "..." : ""}`), w), 0, 0));
+				c.addChild(new Text(truncLine(theme.fg("dim", `      ${line}`), w), 0, 0));
 			}
 		}
 

package/schemas.ts

@@ -83,7 +83,7 @@ export const SubagentParams = Type.Object({
 	maxOutput: MaxOutputSchema,
 	artifacts: Type.Optional(Type.Boolean({ description: "Write debug artifacts (default: true)" })),
 	includeProgress: Type.Optional(Type.Boolean({ description: "Include full progress in result (default: false)" })),
-	share: Type.Optional(Type.Boolean({ description: "Create shareable session log (default: true)", default: true })),
+	share: Type.Optional(Type.Boolean({ description: "Upload session to GitHub Gist for sharing (default: false)" })),
 	sessionDir: Type.Optional(
 		Type.String({ description: "Directory to store session logs (default: temp; enables sessions even if share=false)" }),
 	),

package/settings.ts

@@ -213,7 +213,7 @@ export function resolveStepBehavior(
  * Resolve a file path: absolute paths pass through, relative paths get chainDir prepended.
  */
 function resolveChainPath(filePath: string, chainDir: string): string {
-	return path.isAbsolute(filePath) ? filePath : `${chainDir}/${filePath}`;
+	return path.isAbsolute(filePath) ? filePath : path.join(chainDir, filePath);
 }
 
 /**
@@ -243,7 +243,7 @@ export function buildChainInstructions(
 
 	// Progress instructions in suffix (less critical)
 	if (behavior.progress) {
-		const progressPath = `${chainDir}/progress.md`;
+		const progressPath = path.join(chainDir, "progress.md");
 		if (isFirstProgressAgent) {
 			suffixParts.push(`Create and maintain progress at: ${progressPath}`);
 		} else {
@@ -288,7 +288,7 @@ export function resolveParallelBehaviors(
 		}
 
 		// Build subdirectory path for this parallel task
-		const subdir = `parallel-${stepIndex}/${taskIndex}-${task.agent}`;
+		const subdir = path.join(`parallel-${stepIndex}`, `${taskIndex}-${task.agent}`);
 
 		// Output: task override > agent default (namespaced) > false
 		// Absolute paths pass through unchanged; relative paths get namespaced under subdir
@@ -299,11 +299,11 @@ export function resolveParallelBehaviors(
 			} else if (path.isAbsolute(task.output)) {
 				output = task.output; // Absolute path: use as-is
 			} else {
-				output = `${subdir}/${task.output}`; // Relative: namespace under subdir
+				output = path.join(subdir, task.output); // Relative: namespace under subdir
 			}
 		} else if (config.output) {
 			// Agent defaults are always relative, so namespace them
-			output = `${subdir}/${config.output}`;
+			output = path.join(subdir, config.output);
 		}
 
 		// Reads: task override > agent default > false
@@ -372,15 +372,17 @@ export function aggregateParallelOutputs(results: ParallelTaskResult[]): string
 		.map((r, i) => {
 			const header = `=== Parallel Task ${i + 1} (${r.agent}) ===`;
 			const hasTextOutput = Boolean(r.output?.trim());
-			const status = r.exitCode !== 0
-				? `⚠️ FAILED (exit code ${r.exitCode})${r.error ? `: ${r.error}` : ""}`
-				: r.error
-					? `⚠️ WARNING: ${r.error}`
-					: !hasTextOutput && r.outputTargetPath && r.outputTargetExists === false
-						? `⚠️ EMPTY OUTPUT (expected output file missing: ${r.outputTargetPath})`
-						: !hasTextOutput && !r.outputTargetPath
-							? "⚠️ EMPTY OUTPUT (no textual response returned)"
-							: "";
+			const status = r.exitCode === -1
+				? "⏭️ SKIPPED"
+				: r.exitCode !== 0
+					? `⚠️ FAILED (exit code ${r.exitCode})${r.error ? `: ${r.error}` : ""}`
+					: r.error
+						? `⚠️ WARNING: ${r.error}`
+						: !hasTextOutput && r.outputTargetPath && r.outputTargetExists === false
+							? `⚠️ EMPTY OUTPUT (expected output file missing: ${r.outputTargetPath})`
+							: !hasTextOutput && !r.outputTargetPath
+								? "⚠️ EMPTY OUTPUT (no textual response returned)"
+								: "";
 			const body = status
 				? (hasTextOutput ? `${status}\n${r.output}` : status)
 				: r.output;

package/skills.ts

@@ -2,6 +2,7 @@
  * Skill resolution and caching for subagent extension
  */
 
+import { execSync } from "node:child_process";
 import * as fs from "node:fs";
 import * as os from "node:os";
 import * as path from "node:path";
@@ -89,11 +90,31 @@ function getPackageSkillPaths(packageRoot: string): string[] {
 	}
 }
 
+let cachedGlobalNpmRoot: string | null = null;
+
+function getGlobalNpmRoot(): string | null {
+	if (cachedGlobalNpmRoot !== null) return cachedGlobalNpmRoot;
+	try {
+		cachedGlobalNpmRoot = execSync("npm root -g", { encoding: "utf-8", timeout: 5000 }).trim();
+		return cachedGlobalNpmRoot;
+	} catch {
+		cachedGlobalNpmRoot = ""; // Empty string means "tried but failed"
+		return null;
+	}
+}
+
 function collectPackageSkillPaths(cwd: string): string[] {
 	const dirs = [
 		path.join(cwd, CONFIG_DIR, "npm", "node_modules"),
 		path.join(AGENT_DIR, "npm", "node_modules"),
 	];
+	
+	// Add global npm root if available (where pi installs global packages)
+	const globalRoot = getGlobalNpmRoot();
+	if (globalRoot) {
+		dirs.push(globalRoot);
+	}
+	
 	const results: string[] = [];
 
 	for (const dir of dirs) {
@@ -178,6 +199,8 @@ function inferSkillSource(rawSource: unknown, filePath: string, cwd: string): Sk
 	const projectRoot = path.resolve(cwd, CONFIG_DIR);
 	const isProjectScoped = isWithinPath(filePath, projectRoot);
 	const isUserScoped = isWithinPath(filePath, AGENT_DIR);
+	const globalRoot = getGlobalNpmRoot();
+	const isGlobalPackage = globalRoot ? isWithinPath(filePath, globalRoot) : false;
 
 	if (source === "project") return "project";
 	if (source === "user") return "user";
@@ -188,7 +211,7 @@ function inferSkillSource(rawSource: unknown, filePath: string, cwd: string): Sk
 	}
 	if (source === "package") {
 		if (isProjectScoped) return "project-package";
-		if (isUserScoped) return "user-package";
+		if (isUserScoped || isGlobalPackage) return "user-package";
 		return "unknown";
 	}
 	if (source === "extension") return "extension";
@@ -196,6 +219,7 @@ function inferSkillSource(rawSource: unknown, filePath: string, cwd: string): Sk
 
 	if (isProjectScoped) return "project";
 	if (isUserScoped) return "user";
+	if (isGlobalPackage) return "user-package";
 	return "unknown";
 }