pi-subagents 0.69.0 → 0.70.0

package/src/slash/delegation-json.ts

@@ -1,108 +0,0 @@
-const MAX_JSON_DEPTH = 64;
-const MAX_JSON_ENTRIES = 100_000;
-
-export type BoundedJsonClone =
-	| { ok: true; value: unknown; encodedBytes: number }
-	| { ok: false; reason: "invalid" | "too_large" };
-
-/** Clone plain JSON data without invoking getters or toJSON hooks. */
-export function cloneJsonWithinByteLimit(input: unknown, maxBytes: number): BoundedJsonClone {
-	let minimumBytes = 0;
-	let entries = 0;
-	const active = new WeakSet<object>();
-
-	const addMinimumBytes = (bytes: number): void => {
-		minimumBytes += bytes;
-		if (minimumBytes > maxBytes) throw new RangeError("too_large");
-	};
-
-	const visit = (value: unknown, depth: number): unknown => {
-		if (depth > MAX_JSON_DEPTH) throw new TypeError("invalid");
-		if (value === null) {
-			addMinimumBytes(4);
-			return null;
-		}
-		if (typeof value === "boolean") {
-			addMinimumBytes(value ? 4 : 5);
-			return value;
-		}
-		if (typeof value === "number") {
-			if (!Number.isFinite(value)) throw new TypeError("invalid");
-			const encoded = JSON.stringify(Object.is(value, -0) ? 0 : value);
-			addMinimumBytes(Buffer.byteLength(encoded, "utf8"));
-			return Object.is(value, -0) ? 0 : value;
-		}
-		if (typeof value === "string") {
-			// Quoting and escaping can only increase the encoded size.
-			addMinimumBytes(Buffer.byteLength(value, "utf8") + 2);
-			return value;
-		}
-		if (typeof value !== "object") throw new TypeError("invalid");
-
-		const object = value as object;
-		if (active.has(object)) throw new TypeError("invalid");
-		active.add(object);
-		try {
-			const prototype = Object.getPrototypeOf(object);
-			const keys = Reflect.ownKeys(object);
-			if (Array.isArray(object)) {
-				if (prototype !== Array.prototype) throw new TypeError("invalid");
-				const lengthDescriptor = Object.getOwnPropertyDescriptor(object, "length");
-				if (!lengthDescriptor || !("value" in lengthDescriptor) || !Number.isSafeInteger(lengthDescriptor.value) || lengthDescriptor.value < 0) {
-					throw new TypeError("invalid");
-				}
-				const length = lengthDescriptor.value as number;
-				addMinimumBytes(2 + Math.max(0, length - 1));
-				const output: unknown[] = [];
-				for (const key of keys) {
-					if (typeof key === "symbol") throw new TypeError("invalid");
-					if (key === "length") continue;
-					if (!/^(?:0|[1-9][0-9]*)$/.test(key) || Number(key) >= length) throw new TypeError("invalid");
-				}
-				for (let index = 0; index < length; index++) {
-					const descriptor = Object.getOwnPropertyDescriptor(object, String(index));
-					if (!descriptor || !("value" in descriptor) || !descriptor.enumerable) throw new TypeError("invalid");
-					entries++;
-					if (entries > MAX_JSON_ENTRIES) throw new TypeError("invalid");
-					output.push(visit(descriptor.value, depth + 1));
-				}
-				return output;
-			}
-
-			if (prototype !== Object.prototype && prototype !== null) throw new TypeError("invalid");
-			addMinimumBytes(2 + Math.max(0, keys.length - 1));
-			const output: Record<string, unknown> = {};
-			for (const key of keys) {
-				if (typeof key === "symbol") throw new TypeError("invalid");
-				const descriptor = Object.getOwnPropertyDescriptor(object, key);
-				if (!descriptor || !("value" in descriptor) || !descriptor.enumerable) throw new TypeError("invalid");
-				entries++;
-				if (entries > MAX_JSON_ENTRIES) throw new TypeError("invalid");
-				addMinimumBytes(Buffer.byteLength(JSON.stringify(key), "utf8") + 1);
-				Object.defineProperty(output, key, {
-					value: visit(descriptor.value, depth + 1),
-					enumerable: true,
-					configurable: true,
-					writable: true,
-				});
-			}
-			return output;
-		} finally {
-			active.delete(object);
-		}
-	};
-
-	try {
-		const value = visit(input, 0);
-		const encoded = JSON.stringify(value);
-		if (encoded === undefined) return { ok: false, reason: "invalid" };
-		const encodedBytes = Buffer.byteLength(encoded, "utf8");
-		if (encodedBytes > maxBytes) return { ok: false, reason: "too_large" };
-		return { ok: true, value, encodedBytes };
-	} catch (error) {
-		return {
-			ok: false,
-			reason: error instanceof RangeError && error.message === "too_large" ? "too_large" : "invalid",
-		};
-	}
-}

package/src/slash/delegation-request.ts

@@ -1,176 +0,0 @@
-import {
-	type SubagentDelegationRequest,
-} from "../api/delegation.ts";
-import { validateIntercomBridgeConfig } from "../intercom/intercom-bridge.ts";
-import { validateToolBudgetConfig } from "../runs/shared/tool-budget.ts";
-import type { IntercomBridgeConfig } from "../shared/types.ts";
-import { cloneJsonWithinByteLimit } from "./delegation-json.ts";
-
-export type SubagentDelegationParseResult =
-	| { ok: true; request: SubagentDelegationRequest }
-	| { ok: false; requestId?: string; ownerRunId?: string; nodeId?: string; error: string };
-
-const supportedFields = new Set([
-	"requestId",
-	"ownerRunId",
-	"nodeId",
-	"agent",
-	"task",
-	"context",
-	"cwd",
-	"model",
-	"thinking",
-	"timeoutMs",
-	"toolBudget",
-	"skill",
-	"artifacts",
-	"intercomBridge",
-	"result",
-]);
-
-const thinkingLevels = new Set(["off", "minimal", "low", "medium", "high", "xhigh", "max"]);
-const MAX_SCHEMA_BYTES = 64 * 1024;
-const MAX_TASK_BYTES = 1024 * 1024;
-const MAX_CWD_BYTES = 32 * 1024;
-const MAX_SHORT_TEXT_BYTES = 1024;
-const MAX_SKILL_ENTRIES = 256;
-const MAX_SKILL_AGGREGATE_BYTES = 64 * 1024;
-
-function nonEmptyString(value: unknown): value is string {
-	return typeof value === "string" && value.trim().length > 0;
-}
-
-function validateId(value: unknown): string | undefined {
-	if (!nonEmptyString(value) || value.length > 256 || /[\r\n]/.test(value)) return undefined;
-	return value;
-}
-
-export function parseSubagentDelegationRequest(data: unknown): SubagentDelegationParseResult {
-	if (!data || typeof data !== "object" || Array.isArray(data)) {
-		return { ok: false, error: "Delegation request must be an object." };
-	}
-	const value = data as Record<string, unknown>;
-	const requestId = validateId(value.requestId);
-	if (!requestId) {
-		return { ok: false, error: "Delegation requestId must be a non-empty string of at most 256 characters without newlines." };
-	}
-	const ownerRunId = validateId(value.ownerRunId);
-	if (!ownerRunId) {
-		return { ok: false, requestId, error: "Delegation ownerRunId must be a non-empty string of at most 256 characters without newlines." };
-	}
-	const nodeId = validateId(value.nodeId);
-	if (!nodeId) {
-		return { ok: false, requestId, ownerRunId, error: "Delegation nodeId must be a non-empty string of at most 256 characters without newlines." };
-	}
-	const identity = { requestId, ownerRunId, nodeId };
-	const unsupportedField = Object.keys(value).find((key) => !supportedFields.has(key));
-	if (unsupportedField) return { ok: false, ...identity, error: `Unsupported delegation field: ${unsupportedField}.` };
-	if (!nonEmptyString(value.agent)) return { ok: false, ...identity, error: "Delegation agent must be a non-empty string." };
-	if (!nonEmptyString(value.task)) return { ok: false, ...identity, error: "Delegation task must be a non-empty string." };
-	if (value.context !== "fresh" && value.context !== "fork") {
-		return { ok: false, ...identity, error: "Delegation context must be fresh or fork." };
-	}
-	if (!nonEmptyString(value.cwd)) return { ok: false, ...identity, error: "Delegation cwd must be a non-empty string." };
-	if (value.model !== undefined && !nonEmptyString(value.model)) {
-		return { ok: false, ...identity, error: "model must be a non-empty string when provided." };
-	}
-	if (value.timeoutMs !== undefined && (typeof value.timeoutMs !== "number" || !Number.isInteger(value.timeoutMs) || value.timeoutMs < 1)) {
-		return { ok: false, ...identity, error: "timeoutMs must be an integer >= 1." };
-	}
-	const timeoutMs = typeof value.timeoutMs === "number" ? value.timeoutMs : undefined;
-	if (timeoutMs !== undefined && timeoutMs > 2_147_483_647) {
-		return { ok: false, ...identity, error: "timeoutMs must be <= 2147483647." };
-	}
-	if (value.toolBudget && typeof value.toolBudget === "object" && !Array.isArray(value.toolBudget)) {
-		const unsupportedToolBudgetField = Object.keys(value.toolBudget).find((key) => key !== "soft" && key !== "hard" && key !== "block");
-		if (unsupportedToolBudgetField) {
-			return { ok: false, ...identity, error: `toolBudget.${unsupportedToolBudgetField} is not supported.` };
-		}
-	}
-	const toolBudget = validateToolBudgetConfig(value.toolBudget, "toolBudget", { minimumHard: 0 });
-	if (toolBudget.error) return { ok: false, ...identity, error: toolBudget.error };
-	if (value.skill !== undefined) {
-		const validSkill = typeof value.skill === "boolean"
-			|| nonEmptyString(value.skill)
-			|| (Array.isArray(value.skill) && value.skill.length > 0 && value.skill.every(nonEmptyString));
-		if (!validSkill) {
-			return { ok: false, ...identity, error: "skill must be a boolean, non-empty string, or non-empty string array." };
-		}
-	}
-	if (value.artifacts !== undefined && typeof value.artifacts !== "boolean") {
-		return { ok: false, ...identity, error: "artifacts must be a boolean." };
-	}
-	let intercomBridge: IntercomBridgeConfig | undefined;
-	if (value.intercomBridge !== undefined) {
-		const bridge = validateIntercomBridgeConfig({ value: value.intercomBridge, label: "intercomBridge" });
-		if (!bridge.ok) return { ok: false, ...identity, error: bridge.error };
-		if (typeof bridge.value.instructionFile === "string" && Buffer.byteLength(bridge.value.instructionFile, "utf8") > MAX_SHORT_TEXT_BYTES) {
-			return { ok: false, ...identity, error: "intercomBridge.instructionFile exceeds 1 KiB when UTF-8 encoded." };
-		}
-		intercomBridge = bridge.value;
-	}
-	if (Buffer.byteLength(value.task as string, "utf8") > MAX_TASK_BYTES) {
-		return { ok: false, ...identity, error: "Delegation task exceeds 1 MiB when UTF-8 encoded." };
-	}
-	if (Buffer.byteLength(value.cwd as string, "utf8") > MAX_CWD_BYTES) {
-		return { ok: false, ...identity, error: "Delegation cwd exceeds 32 KiB when UTF-8 encoded." };
-	}
-	if (Buffer.byteLength(value.agent as string, "utf8") > MAX_SHORT_TEXT_BYTES) {
-		return { ok: false, ...identity, error: "Delegation agent exceeds 1 KiB when UTF-8 encoded." };
-	}
-	if (typeof value.model === "string" && Buffer.byteLength(value.model, "utf8") > MAX_SHORT_TEXT_BYTES) {
-		return { ok: false, ...identity, error: "Delegation model exceeds 1 KiB when UTF-8 encoded." };
-	}
-	const skillEntries = typeof value.skill === "string" ? [value.skill] : Array.isArray(value.skill) ? value.skill as string[] : [];
-	if (skillEntries.length > MAX_SKILL_ENTRIES) {
-		return { ok: false, ...identity, error: "Delegation skill supports at most 256 entries." };
-	}
-	if (skillEntries.some((entry) => Buffer.byteLength(entry, "utf8") > MAX_SHORT_TEXT_BYTES)) {
-		return { ok: false, ...identity, error: "Delegation skill entry exceeds 1 KiB when UTF-8 encoded." };
-	}
-	if (skillEntries.reduce((total, entry) => total + Buffer.byteLength(entry, "utf8"), 0) > MAX_SKILL_AGGREGATE_BYTES) {
-		return { ok: false, ...identity, error: "Delegation skill entries exceed 64 KiB in aggregate when UTF-8 encoded." };
-	}
-	if (value.thinking !== undefined && (typeof value.thinking !== "string" || !thinkingLevels.has(value.thinking))) {
-		return { ok: false, ...identity, error: "thinking must be one of off, minimal, low, medium, high, xhigh, or max." };
-	}
-	if (!value.result || typeof value.result !== "object" || Array.isArray(value.result)) {
-		return { ok: false, ...identity, error: "result must be { kind: \"text\" } or { kind: \"structured\", schema: object }." };
-	}
-	const result = value.result as Record<string, unknown>;
-	let structuredSchema: Record<string, unknown> | undefined;
-	if (result.kind === "text") {
-		const unsupportedResultField = Object.keys(result).find((key) => key !== "kind");
-		if (unsupportedResultField) return { ok: false, ...identity, error: `result.${unsupportedResultField} is not supported for text results.` };
-	} else if (result.kind === "structured") {
-		const unsupportedResultField = Object.keys(result).find((key) => key !== "kind" && key !== "schema");
-		if (unsupportedResultField) return { ok: false, ...identity, error: `result.${unsupportedResultField} is not supported for structured results.` };
-		if (!result.schema || typeof result.schema !== "object" || Array.isArray(result.schema)) {
-			return { ok: false, ...identity, error: "result.schema must be a JSON Schema object." };
-		}
-		const inspectedSchema = cloneJsonWithinByteLimit(result.schema, MAX_SCHEMA_BYTES);
-		if (inspectedSchema.ok === false) {
-			return {
-				ok: false,
-				...identity,
-				error: inspectedSchema.reason === "too_large"
-					? "result.schema exceeds 64 KiB when encoded."
-					: "result.schema must be plain JSON data.",
-			};
-		}
-		structuredSchema = inspectedSchema.value as Record<string, unknown>;
-	} else {
-		return { ok: false, ...identity, error: "result.kind must be text or structured." };
-	}
-	return {
-		ok: true,
-		request: {
-			...value,
-			// The validated copy replaces the caller's object so the request never aliases untrusted input.
-			...(intercomBridge ? { intercomBridge } : {}),
-			result: structuredSchema
-				? { kind: "structured", schema: structuredSchema }
-				: { kind: "text" },
-		} as unknown as SubagentDelegationRequest,
-	};
-}