pi-subagents 0.63.0 → 0.64.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +24 -1
- package/docs/watchdog.md +92 -114
- package/package.json +1 -1
- package/skills/pi-subagents/references/execution-controls.md +4 -3
- package/src/runs/background/async-execution.ts +3 -0
- package/src/runs/background/notify.ts +41 -2
- package/src/runs/background/subagent-runner.ts +23 -1
- package/src/runs/foreground/execution.ts +7 -1
- package/src/runs/foreground/subagent-executor.ts +21 -1
- package/src/runs/shared/acceptance.ts +10 -0
- package/src/runs/shared/async-status-projection.ts +11 -43
- package/src/runs/shared/pi-args.ts +1 -4
- package/src/runs/shared/subagent-control.ts +4 -2
- package/src/shared/types.ts +9 -2
- package/src/tui/render.ts +5 -0
- package/src/watchdog/child-status.ts +54 -33
- package/src/watchdog/diff-tool.ts +77 -0
- package/src/watchdog/emission-guard.ts +5 -3
- package/src/watchdog/guidance.ts +20 -0
- package/src/watchdog/register-child.ts +16 -13
- package/src/watchdog/register-main.ts +10 -9
- package/src/watchdog/render.ts +4 -5
- package/src/watchdog/review.ts +15 -4
- package/src/watchdog/rules.ts +70 -0
- package/src/watchdog/runtime.ts +75 -92
- package/src/watchdog/scope.ts +0 -11
- package/src/watchdog/settings.ts +48 -104
- package/src/watchdog/types.ts +18 -32
- package/src/watchdog/warning-format.ts +0 -1
- package/src/workflows/chat-progress.ts +3 -2
- package/src/workflows/workflow-checklist.ts +10 -12
- package/src/workflows/workflow-preflight.ts +28 -1
package/src/watchdog/settings.ts
CHANGED
|
@@ -3,39 +3,31 @@ import * as path from "node:path";
|
|
|
3
3
|
import { THINKING_LEVELS, type ThinkingLevel } from "../shared/model-info.ts";
|
|
4
4
|
import { getAgentDir, getProjectConfigDir } from "../shared/utils.ts";
|
|
5
5
|
import {
|
|
6
|
-
WATCHDOG_DELIVERY_MODES,
|
|
7
|
-
WATCHDOG_LATE_WARNING_POLICIES,
|
|
8
6
|
WATCHDOG_WARNING_SEVERITIES,
|
|
9
7
|
type ResolvedWatchdogConfig,
|
|
10
|
-
type WatchdogAsyncCompletionConfig,
|
|
11
|
-
type WatchdogAutoFollowConfig,
|
|
12
8
|
type WatchdogChildOverrideConfig,
|
|
13
9
|
type WatchdogChildrenConfig,
|
|
14
|
-
type WatchdogDeliveryMode,
|
|
15
10
|
type WatchdogEndpointConfig,
|
|
16
11
|
type WatchdogCadenceConfig,
|
|
17
12
|
type WatchdogGuidanceConfig,
|
|
18
|
-
type WatchdogLateWarningPolicy,
|
|
19
13
|
type WatchdogScopeConfig,
|
|
20
14
|
type WatchdogLspConfig,
|
|
15
|
+
type WatchdogRoleModelRule,
|
|
16
|
+
type WatchdogRulesConfig,
|
|
21
17
|
type WatchdogSettingsError,
|
|
22
18
|
type WatchdogSettingsResult,
|
|
23
19
|
type WatchdogSettingsSource,
|
|
24
20
|
type WatchdogSeverity,
|
|
25
|
-
type WatchdogSyncBacklog,
|
|
26
21
|
} from "./types.ts";
|
|
27
22
|
|
|
28
|
-
type WatchdogAutoFollowPatch = Partial<WatchdogAutoFollowConfig>;
|
|
29
23
|
type WatchdogGuidancePatch = Partial<WatchdogGuidanceConfig>;
|
|
30
24
|
type WatchdogScopePatch = Partial<WatchdogScopeConfig>;
|
|
31
25
|
type WatchdogCadencePatch = Partial<WatchdogCadenceConfig>;
|
|
32
26
|
type WatchdogEndpointPatch = Partial<WatchdogEndpointConfig>;
|
|
33
27
|
type WatchdogChildOverridePatch = Partial<WatchdogChildOverrideConfig>;
|
|
34
|
-
type WatchdogChildrenPatch = Partial<Omit<WatchdogChildrenConfig, "
|
|
35
|
-
autoFollow?: WatchdogAutoFollowPatch;
|
|
28
|
+
type WatchdogChildrenPatch = Partial<Omit<WatchdogChildrenConfig, "overrides">> & {
|
|
36
29
|
overrides?: Record<string, WatchdogChildOverridePatch>;
|
|
37
30
|
};
|
|
38
|
-
type WatchdogAsyncCompletionPatch = Partial<WatchdogAsyncCompletionConfig>;
|
|
39
31
|
type WatchdogLspPatch = Partial<WatchdogLspConfig>;
|
|
40
32
|
|
|
41
33
|
export type WatchdogSettingsWriteScope = "user" | "project";
|
|
@@ -52,14 +44,13 @@ export interface WatchdogModelSettingsWrite {
|
|
|
52
44
|
thinking?: ThinkingLevel | false | null;
|
|
53
45
|
}
|
|
54
46
|
|
|
55
|
-
type WatchdogConfigPatch = Partial<Omit<ResolvedWatchdogConfig, "guidance" | "
|
|
47
|
+
type WatchdogConfigPatch = Partial<Omit<ResolvedWatchdogConfig, "guidance" | "scope" | "cadence" | "main" | "children" | "lsp" | "rules">> & {
|
|
48
|
+
rules?: WatchdogRulesConfig;
|
|
56
49
|
guidance?: WatchdogGuidancePatch;
|
|
57
|
-
autoFollow?: WatchdogAutoFollowPatch;
|
|
58
50
|
scope?: WatchdogScopePatch;
|
|
59
51
|
cadence?: WatchdogCadencePatch;
|
|
60
52
|
main?: WatchdogEndpointPatch;
|
|
61
53
|
children?: WatchdogChildrenPatch;
|
|
62
|
-
asyncCompletion?: WatchdogAsyncCompletionPatch;
|
|
63
54
|
lsp?: WatchdogLspPatch;
|
|
64
55
|
};
|
|
65
56
|
|
|
@@ -70,22 +61,13 @@ interface ParseMeta {
|
|
|
70
61
|
|
|
71
62
|
export const DEFAULT_WATCHDOG_CONFIG: ResolvedWatchdogConfig = {
|
|
72
63
|
enabled: false,
|
|
73
|
-
delivery: "held",
|
|
74
|
-
showDuringRun: false,
|
|
75
|
-
syncBacklog: "off",
|
|
76
64
|
agentEndTimeoutMs: 30_000,
|
|
77
|
-
lateWarningPolicy: "show-stale-no-autofollow",
|
|
78
65
|
severityThreshold: "concern",
|
|
79
66
|
maxWarnings: null,
|
|
80
67
|
guidance: {
|
|
81
68
|
watchdogMd: true,
|
|
82
|
-
systemPromptPath: null,
|
|
83
|
-
},
|
|
84
|
-
autoFollow: {
|
|
85
|
-
blockers: true,
|
|
86
|
-
maxAttempts: 3,
|
|
87
|
-
stalemateRepeats: 3,
|
|
88
69
|
},
|
|
70
|
+
stalemateRepeats: 3,
|
|
89
71
|
scope: {
|
|
90
72
|
enabled: true,
|
|
91
73
|
},
|
|
@@ -98,73 +80,51 @@ export const DEFAULT_WATCHDOG_CONFIG: ResolvedWatchdogConfig = {
|
|
|
98
80
|
children: {
|
|
99
81
|
enabled: false,
|
|
100
82
|
watchdogTailTimeoutMs: 120_000,
|
|
101
|
-
autoFollow: {
|
|
102
|
-
blockers: true,
|
|
103
|
-
maxAttempts: 3,
|
|
104
|
-
stalemateRepeats: 3,
|
|
105
|
-
},
|
|
106
83
|
overrides: {},
|
|
107
84
|
},
|
|
108
|
-
asyncCompletion: {
|
|
109
|
-
enabled: false,
|
|
110
|
-
autoFollowBlockers: false,
|
|
111
|
-
},
|
|
112
85
|
lsp: {
|
|
113
86
|
enabled: true,
|
|
114
87
|
timeoutMs: 3_000,
|
|
115
88
|
maxFiles: 20,
|
|
116
89
|
maxDiagnostics: 50,
|
|
117
90
|
},
|
|
118
|
-
compactAtPercent: 80,
|
|
119
|
-
reviewRetryDelayMs: 1_000,
|
|
120
|
-
maxReviewFailures: 3,
|
|
121
91
|
};
|
|
122
92
|
|
|
123
93
|
const WATCHDOG_FIELDS = new Set([
|
|
124
94
|
"enabled",
|
|
125
|
-
"delivery",
|
|
126
|
-
"showDuringRun",
|
|
127
|
-
"syncBacklog",
|
|
128
95
|
"agentEndTimeoutMs",
|
|
129
|
-
"lateWarningPolicy",
|
|
130
96
|
"severityThreshold",
|
|
131
97
|
"maxWarnings",
|
|
132
98
|
"guidance",
|
|
133
|
-
"
|
|
99
|
+
"stalemateRepeats",
|
|
134
100
|
"scope",
|
|
135
101
|
"cadence",
|
|
136
102
|
"main",
|
|
137
103
|
"children",
|
|
138
|
-
"asyncCompletion",
|
|
139
104
|
"lsp",
|
|
140
|
-
"
|
|
141
|
-
"reviewRetryDelayMs",
|
|
142
|
-
"maxReviewFailures",
|
|
105
|
+
"rules",
|
|
143
106
|
]);
|
|
144
|
-
const
|
|
145
|
-
const
|
|
107
|
+
const RULES_FIELDS = new Set(["action", "roleModels"]);
|
|
108
|
+
const ROLE_MODEL_RULE_FIELDS = new Set(["allow", "deny", "note"]);
|
|
109
|
+
const GUIDANCE_FIELDS = new Set(["watchdogMd"]);
|
|
146
110
|
const SCOPE_FIELDS = new Set(["enabled"]);
|
|
147
111
|
const CADENCE_FIELDS = new Set(["everyNTools"]);
|
|
148
112
|
const ENDPOINT_FIELDS = new Set(["enabled", "model", "thinking"]);
|
|
149
|
-
const CHILDREN_FIELDS = new Set(["enabled", "model", "thinking", "watchdogTailTimeoutMs", "
|
|
150
|
-
const CHILD_OVERRIDE_FIELDS = new Set(["enabled", "model", "thinking"]);
|
|
151
|
-
const ASYNC_COMPLETION_FIELDS = new Set(["enabled", "autoFollowBlockers"]);
|
|
113
|
+
const CHILDREN_FIELDS = new Set(["enabled", "model", "thinking", "watchdogTailTimeoutMs", "cadence", "overrides"]);
|
|
114
|
+
const CHILD_OVERRIDE_FIELDS = new Set(["enabled", "model", "thinking", "cadence"]);
|
|
152
115
|
const LSP_FIELDS = new Set(["enabled", "timeoutMs", "maxFiles", "maxDiagnostics"]);
|
|
153
116
|
|
|
154
117
|
function cloneDefaultConfig(): ResolvedWatchdogConfig {
|
|
155
118
|
return {
|
|
156
119
|
...DEFAULT_WATCHDOG_CONFIG,
|
|
157
120
|
guidance: { ...DEFAULT_WATCHDOG_CONFIG.guidance },
|
|
158
|
-
autoFollow: { ...DEFAULT_WATCHDOG_CONFIG.autoFollow },
|
|
159
121
|
scope: { ...DEFAULT_WATCHDOG_CONFIG.scope },
|
|
160
122
|
cadence: { ...DEFAULT_WATCHDOG_CONFIG.cadence },
|
|
161
123
|
main: { ...DEFAULT_WATCHDOG_CONFIG.main },
|
|
162
124
|
children: {
|
|
163
125
|
...DEFAULT_WATCHDOG_CONFIG.children,
|
|
164
|
-
autoFollow: { ...DEFAULT_WATCHDOG_CONFIG.children.autoFollow },
|
|
165
126
|
overrides: {},
|
|
166
127
|
},
|
|
167
|
-
asyncCompletion: { ...DEFAULT_WATCHDOG_CONFIG.asyncCompletion },
|
|
168
128
|
lsp: { ...DEFAULT_WATCHDOG_CONFIG.lsp },
|
|
169
129
|
};
|
|
170
130
|
}
|
|
@@ -227,35 +187,11 @@ function parseEnum<T extends string>(value: unknown, field: string, meta: ParseM
|
|
|
227
187
|
throw invalid(meta, field, values.map((item) => `'${item}'`).join(" or "));
|
|
228
188
|
}
|
|
229
189
|
|
|
230
|
-
function parseSyncBacklog(value: unknown, field: string, meta: ParseMeta): WatchdogSyncBacklog {
|
|
231
|
-
if (value === "off") return "off";
|
|
232
|
-
return parseInteger(value, field, meta, "'off' or a positive integer", (candidate) => candidate >= 1);
|
|
233
|
-
}
|
|
234
|
-
|
|
235
190
|
function parseGuidancePatch(value: unknown, field: string, meta: ParseMeta): WatchdogGuidancePatch {
|
|
236
191
|
const input = parseObject(value, field, meta);
|
|
237
192
|
assertKnownFields(input, GUIDANCE_FIELDS, field, meta);
|
|
238
193
|
const patch: WatchdogGuidancePatch = {};
|
|
239
194
|
if ("watchdogMd" in input) patch.watchdogMd = parseBoolean(input.watchdogMd, `${field}.watchdogMd`, meta);
|
|
240
|
-
if ("systemPromptPath" in input) {
|
|
241
|
-
patch.systemPromptPath = input.systemPromptPath === null
|
|
242
|
-
? null
|
|
243
|
-
: parseNonEmptyString(input.systemPromptPath, `${field}.systemPromptPath`, meta);
|
|
244
|
-
}
|
|
245
|
-
return patch;
|
|
246
|
-
}
|
|
247
|
-
|
|
248
|
-
function parseAutoFollowPatch(value: unknown, field: string, meta: ParseMeta): WatchdogAutoFollowPatch {
|
|
249
|
-
const input = parseObject(value, field, meta);
|
|
250
|
-
assertKnownFields(input, AUTO_FOLLOW_FIELDS, field, meta);
|
|
251
|
-
const patch: WatchdogAutoFollowPatch = {};
|
|
252
|
-
if ("blockers" in input) patch.blockers = parseBoolean(input.blockers, `${field}.blockers`, meta);
|
|
253
|
-
if ("maxAttempts" in input) {
|
|
254
|
-
patch.maxAttempts = parseNullableInteger(input.maxAttempts, `${field}.maxAttempts`, meta, "null or a positive integer", (candidate) => candidate >= 1);
|
|
255
|
-
}
|
|
256
|
-
if ("stalemateRepeats" in input) {
|
|
257
|
-
patch.stalemateRepeats = parseInteger(input.stalemateRepeats, `${field}.stalemateRepeats`, meta, "a positive integer", (candidate) => candidate >= 1);
|
|
258
|
-
}
|
|
259
195
|
return patch;
|
|
260
196
|
}
|
|
261
197
|
|
|
@@ -296,6 +232,7 @@ function parseChildOverridePatch(value: unknown, field: string, meta: ParseMeta)
|
|
|
296
232
|
if ("enabled" in input) patch.enabled = parseBoolean(input.enabled, `${field}.enabled`, meta);
|
|
297
233
|
if ("model" in input) patch.model = parseNonEmptyString(input.model, `${field}.model`, meta);
|
|
298
234
|
if ("thinking" in input) patch.thinking = parseThinking(input.thinking, `${field}.thinking`, meta);
|
|
235
|
+
if ("cadence" in input) patch.cadence = parseCadencePatch(input.cadence, `${field}.cadence`, meta);
|
|
299
236
|
return patch;
|
|
300
237
|
}
|
|
301
238
|
|
|
@@ -309,7 +246,7 @@ function parseChildrenPatch(value: unknown, field: string, meta: ParseMeta): Wat
|
|
|
309
246
|
if ("watchdogTailTimeoutMs" in input) {
|
|
310
247
|
patch.watchdogTailTimeoutMs = parseInteger(input.watchdogTailTimeoutMs, `${field}.watchdogTailTimeoutMs`, meta, "a positive integer", (candidate) => candidate >= 1);
|
|
311
248
|
}
|
|
312
|
-
if ("
|
|
249
|
+
if ("cadence" in input) patch.cadence = parseCadencePatch(input.cadence, `${field}.cadence`, meta);
|
|
313
250
|
if ("overrides" in input) {
|
|
314
251
|
const overrides = parseObject(input.overrides, `${field}.overrides`, meta);
|
|
315
252
|
patch.overrides = {};
|
|
@@ -321,15 +258,6 @@ function parseChildrenPatch(value: unknown, field: string, meta: ParseMeta): Wat
|
|
|
321
258
|
return patch;
|
|
322
259
|
}
|
|
323
260
|
|
|
324
|
-
function parseAsyncCompletionPatch(value: unknown, field: string, meta: ParseMeta): WatchdogAsyncCompletionPatch {
|
|
325
|
-
const input = parseObject(value, field, meta);
|
|
326
|
-
assertKnownFields(input, ASYNC_COMPLETION_FIELDS, field, meta);
|
|
327
|
-
const patch: WatchdogAsyncCompletionPatch = {};
|
|
328
|
-
if ("enabled" in input) patch.enabled = parseBoolean(input.enabled, `${field}.enabled`, meta);
|
|
329
|
-
if ("autoFollowBlockers" in input) patch.autoFollowBlockers = parseBoolean(input.autoFollowBlockers, `${field}.autoFollowBlockers`, meta);
|
|
330
|
-
return patch;
|
|
331
|
-
}
|
|
332
|
-
|
|
333
261
|
function parseLspPatch(value: unknown, field: string, meta: ParseMeta): WatchdogLspPatch {
|
|
334
262
|
const input = parseObject(value, field, meta);
|
|
335
263
|
assertKnownFields(input, LSP_FIELDS, field, meta);
|
|
@@ -341,20 +269,43 @@ function parseLspPatch(value: unknown, field: string, meta: ParseMeta): Watchdog
|
|
|
341
269
|
return patch;
|
|
342
270
|
}
|
|
343
271
|
|
|
272
|
+
function parseStringList(value: unknown, field: string, meta: ParseMeta): string[] {
|
|
273
|
+
if (!Array.isArray(value) || value.some((entry) => typeof entry !== "string" || !entry.trim())) throw invalid(meta, field, "an array of non-empty strings");
|
|
274
|
+
return value.map((entry: string) => entry.trim());
|
|
275
|
+
}
|
|
276
|
+
|
|
277
|
+
function parseRoleModelRule(value: unknown, field: string, meta: ParseMeta): WatchdogRoleModelRule {
|
|
278
|
+
const input = parseObject(value, field, meta);
|
|
279
|
+
assertKnownFields(input, ROLE_MODEL_RULE_FIELDS, field, meta);
|
|
280
|
+
const rule: WatchdogRoleModelRule = {};
|
|
281
|
+
if ("allow" in input) rule.allow = parseStringList(input.allow, `${field}.allow`, meta);
|
|
282
|
+
if ("deny" in input) rule.deny = parseStringList(input.deny, `${field}.deny`, meta);
|
|
283
|
+
if ("note" in input) rule.note = parseNonEmptyString(input.note, `${field}.note`, meta);
|
|
284
|
+
return rule;
|
|
285
|
+
}
|
|
286
|
+
|
|
287
|
+
function parseRules(value: unknown, field: string, meta: ParseMeta): WatchdogRulesConfig {
|
|
288
|
+
const input = parseObject(value, field, meta);
|
|
289
|
+
assertKnownFields(input, RULES_FIELDS, field, meta);
|
|
290
|
+
const rules: WatchdogRulesConfig = { action: "warn", roleModels: {} };
|
|
291
|
+
if ("action" in input) rules.action = parseEnum(input.action, `${field}.action`, meta, ["warn", "block"] as const);
|
|
292
|
+
if ("roleModels" in input) {
|
|
293
|
+
for (const [agent, rule] of Object.entries(parseObject(input.roleModels, `${field}.roleModels`, meta))) {
|
|
294
|
+
if (!agent.trim()) throw invalid(meta, `${field}.roleModels`, "agent names to be non-empty");
|
|
295
|
+
rules.roleModels[agent] = parseRoleModelRule(rule, `${field}.roleModels.${agent}`, meta);
|
|
296
|
+
}
|
|
297
|
+
}
|
|
298
|
+
return rules;
|
|
299
|
+
}
|
|
300
|
+
|
|
344
301
|
function parseWatchdogPatch(value: unknown, field: string, meta: ParseMeta): WatchdogConfigPatch {
|
|
345
302
|
const input = parseObject(value, field, meta);
|
|
346
303
|
assertKnownFields(input, WATCHDOG_FIELDS, field, meta);
|
|
347
304
|
const patch: WatchdogConfigPatch = {};
|
|
348
305
|
if ("enabled" in input) patch.enabled = parseBoolean(input.enabled, `${field}.enabled`, meta);
|
|
349
|
-
if ("delivery" in input) patch.delivery = parseEnum<WatchdogDeliveryMode>(input.delivery, `${field}.delivery`, meta, WATCHDOG_DELIVERY_MODES);
|
|
350
|
-
if ("showDuringRun" in input) patch.showDuringRun = parseBoolean(input.showDuringRun, `${field}.showDuringRun`, meta);
|
|
351
|
-
if ("syncBacklog" in input) patch.syncBacklog = parseSyncBacklog(input.syncBacklog, `${field}.syncBacklog`, meta);
|
|
352
306
|
if ("agentEndTimeoutMs" in input) {
|
|
353
307
|
patch.agentEndTimeoutMs = parseInteger(input.agentEndTimeoutMs, `${field}.agentEndTimeoutMs`, meta, "a positive integer", (candidate) => candidate >= 1);
|
|
354
308
|
}
|
|
355
|
-
if ("lateWarningPolicy" in input) {
|
|
356
|
-
patch.lateWarningPolicy = parseEnum<WatchdogLateWarningPolicy>(input.lateWarningPolicy, `${field}.lateWarningPolicy`, meta, WATCHDOG_LATE_WARNING_POLICIES);
|
|
357
|
-
}
|
|
358
309
|
if ("severityThreshold" in input) {
|
|
359
310
|
patch.severityThreshold = parseEnum<WatchdogSeverity>(input.severityThreshold, `${field}.severityThreshold`, meta, WATCHDOG_WARNING_SEVERITIES);
|
|
360
311
|
}
|
|
@@ -362,22 +313,15 @@ function parseWatchdogPatch(value: unknown, field: string, meta: ParseMeta): Wat
|
|
|
362
313
|
patch.maxWarnings = parseNullableInteger(input.maxWarnings, `${field}.maxWarnings`, meta, "null or a non-negative integer", (candidate) => candidate >= 0);
|
|
363
314
|
}
|
|
364
315
|
if ("guidance" in input) patch.guidance = parseGuidancePatch(input.guidance, `${field}.guidance`, meta);
|
|
365
|
-
if ("
|
|
316
|
+
if ("stalemateRepeats" in input) {
|
|
317
|
+
patch.stalemateRepeats = parseInteger(input.stalemateRepeats, `${field}.stalemateRepeats`, meta, "a positive integer", (candidate) => candidate >= 1);
|
|
318
|
+
}
|
|
366
319
|
if ("scope" in input) patch.scope = parseScopePatch(input.scope, `${field}.scope`, meta);
|
|
367
320
|
if ("cadence" in input) patch.cadence = parseCadencePatch(input.cadence, `${field}.cadence`, meta);
|
|
368
321
|
if ("main" in input) patch.main = parseEndpointPatch(input.main, `${field}.main`, meta);
|
|
369
322
|
if ("children" in input) patch.children = parseChildrenPatch(input.children, `${field}.children`, meta);
|
|
370
|
-
if ("asyncCompletion" in input) patch.asyncCompletion = parseAsyncCompletionPatch(input.asyncCompletion, `${field}.asyncCompletion`, meta);
|
|
371
323
|
if ("lsp" in input) patch.lsp = parseLspPatch(input.lsp, `${field}.lsp`, meta);
|
|
372
|
-
if ("
|
|
373
|
-
patch.compactAtPercent = parseInteger(input.compactAtPercent, `${field}.compactAtPercent`, meta, "an integer from 50 through 95", (candidate) => candidate >= 50 && candidate <= 95);
|
|
374
|
-
}
|
|
375
|
-
if ("reviewRetryDelayMs" in input) {
|
|
376
|
-
patch.reviewRetryDelayMs = parseInteger(input.reviewRetryDelayMs, `${field}.reviewRetryDelayMs`, meta, "a positive integer", (candidate) => candidate >= 1);
|
|
377
|
-
}
|
|
378
|
-
if ("maxReviewFailures" in input) {
|
|
379
|
-
patch.maxReviewFailures = parseInteger(input.maxReviewFailures, `${field}.maxReviewFailures`, meta, "a positive integer", (candidate) => candidate >= 1);
|
|
380
|
-
}
|
|
324
|
+
if ("rules" in input) patch.rules = parseRules(input.rules, `${field}.rules`, meta);
|
|
381
325
|
return patch;
|
|
382
326
|
}
|
|
383
327
|
|
package/src/watchdog/types.ts
CHANGED
|
@@ -18,7 +18,7 @@ export type WatchdogCategory = typeof WATCHDOG_WARNING_CATEGORIES[number];
|
|
|
18
18
|
export const WATCHDOG_WARNING_CONFIDENCES = ["medium", "high"] as const;
|
|
19
19
|
export type WatchdogConfidence = typeof WATCHDOG_WARNING_CONFIDENCES[number];
|
|
20
20
|
|
|
21
|
-
export const WATCHDOG_WARNING_SOURCES = ["main", "child", "
|
|
21
|
+
export const WATCHDOG_WARNING_SOURCES = ["main", "child", "lsp"] as const;
|
|
22
22
|
export type WatchdogWarningSource = typeof WATCHDOG_WARNING_SOURCES[number];
|
|
23
23
|
|
|
24
24
|
export const WATCHDOG_LSP_DIAGNOSTIC_SEVERITIES = ["error", "warning", "info", "hint"] as const;
|
|
@@ -42,14 +42,6 @@ export const WATCHDOG_WARNING_STATES = [
|
|
|
42
42
|
] as const;
|
|
43
43
|
export type WatchdogWarningState = typeof WATCHDOG_WARNING_STATES[number];
|
|
44
44
|
|
|
45
|
-
export const WATCHDOG_LATE_WARNING_POLICIES = ["show-stale-no-autofollow"] as const;
|
|
46
|
-
export type WatchdogLateWarningPolicy = typeof WATCHDOG_LATE_WARNING_POLICIES[number];
|
|
47
|
-
|
|
48
|
-
export const WATCHDOG_DELIVERY_MODES = ["held"] as const;
|
|
49
|
-
export type WatchdogDeliveryMode = typeof WATCHDOG_DELIVERY_MODES[number];
|
|
50
|
-
|
|
51
|
-
export type WatchdogSyncBacklog = "off" | number;
|
|
52
|
-
|
|
53
45
|
export interface WatchdogWarning {
|
|
54
46
|
severity: WatchdogSeverity;
|
|
55
47
|
summary: string;
|
|
@@ -61,7 +53,6 @@ export interface WatchdogWarning {
|
|
|
61
53
|
agent?: string;
|
|
62
54
|
runId?: string;
|
|
63
55
|
stale?: boolean;
|
|
64
|
-
autoFollowAttempt?: number;
|
|
65
56
|
state?: WatchdogWarningState;
|
|
66
57
|
}
|
|
67
58
|
|
|
@@ -81,15 +72,8 @@ export interface WatchdogWarningMessage {
|
|
|
81
72
|
details: WatchdogWarningDetails;
|
|
82
73
|
}
|
|
83
74
|
|
|
84
|
-
export interface WatchdogAutoFollowConfig {
|
|
85
|
-
blockers: boolean;
|
|
86
|
-
maxAttempts: number | null;
|
|
87
|
-
stalemateRepeats: number;
|
|
88
|
-
}
|
|
89
|
-
|
|
90
75
|
export interface WatchdogGuidanceConfig {
|
|
91
76
|
watchdogMd: boolean;
|
|
92
|
-
systemPromptPath: string | null;
|
|
93
77
|
}
|
|
94
78
|
|
|
95
79
|
export interface WatchdogScopeConfig {
|
|
@@ -110,19 +94,16 @@ export interface WatchdogChildOverrideConfig {
|
|
|
110
94
|
enabled?: boolean;
|
|
111
95
|
model?: string;
|
|
112
96
|
thinking?: string | false;
|
|
97
|
+
cadence?: Partial<WatchdogCadenceConfig>;
|
|
113
98
|
}
|
|
114
99
|
|
|
115
100
|
export interface WatchdogChildrenConfig extends WatchdogEndpointConfig {
|
|
116
101
|
watchdogTailTimeoutMs: number;
|
|
117
|
-
|
|
102
|
+
/** Mid-run cadence for child watchdogs; defaults to the top-level cadence. */
|
|
103
|
+
cadence?: Partial<WatchdogCadenceConfig>;
|
|
118
104
|
overrides: Record<string, WatchdogChildOverrideConfig>;
|
|
119
105
|
}
|
|
120
106
|
|
|
121
|
-
export interface WatchdogAsyncCompletionConfig {
|
|
122
|
-
enabled: boolean;
|
|
123
|
-
autoFollowBlockers: boolean;
|
|
124
|
-
}
|
|
125
|
-
|
|
126
107
|
export interface WatchdogLspConfig {
|
|
127
108
|
enabled: boolean;
|
|
128
109
|
timeoutMs: number;
|
|
@@ -156,26 +137,31 @@ export interface WatchdogLspRuntimeSnapshot extends WatchdogLspResult {
|
|
|
156
137
|
updatedAt?: string;
|
|
157
138
|
}
|
|
158
139
|
|
|
140
|
+
export interface WatchdogRoleModelRule {
|
|
141
|
+
allow?: string[];
|
|
142
|
+
deny?: string[];
|
|
143
|
+
note?: string;
|
|
144
|
+
}
|
|
145
|
+
|
|
146
|
+
export interface WatchdogRulesConfig {
|
|
147
|
+
action: "warn" | "block";
|
|
148
|
+
roleModels: Record<string, WatchdogRoleModelRule>;
|
|
149
|
+
}
|
|
150
|
+
|
|
159
151
|
export interface ResolvedWatchdogConfig {
|
|
160
152
|
enabled: boolean;
|
|
161
|
-
delivery: WatchdogDeliveryMode;
|
|
162
|
-
showDuringRun: boolean;
|
|
163
|
-
syncBacklog: WatchdogSyncBacklog;
|
|
164
153
|
agentEndTimeoutMs: number;
|
|
165
|
-
lateWarningPolicy: WatchdogLateWarningPolicy;
|
|
166
154
|
severityThreshold: WatchdogSeverity;
|
|
167
155
|
maxWarnings: number | null;
|
|
168
156
|
guidance: WatchdogGuidanceConfig;
|
|
169
|
-
|
|
157
|
+
/** Consecutive identical boundary warnings before the watchdog stops continuing the run. */
|
|
158
|
+
stalemateRepeats: number;
|
|
170
159
|
scope: WatchdogScopeConfig;
|
|
171
160
|
cadence: WatchdogCadenceConfig;
|
|
172
161
|
main: WatchdogEndpointConfig;
|
|
173
162
|
children: WatchdogChildrenConfig;
|
|
174
|
-
asyncCompletion: WatchdogAsyncCompletionConfig;
|
|
175
163
|
lsp: WatchdogLspConfig;
|
|
176
|
-
|
|
177
|
-
reviewRetryDelayMs: number;
|
|
178
|
-
maxReviewFailures: number;
|
|
164
|
+
rules?: WatchdogRulesConfig;
|
|
179
165
|
}
|
|
180
166
|
|
|
181
167
|
export interface WatchdogSettingsError {
|
|
@@ -44,7 +44,6 @@ export function formatWatchdogWarningContent(warning: WatchdogWarning): string {
|
|
|
44
44
|
tag("run_id", details.runId),
|
|
45
45
|
tag("state", details.state),
|
|
46
46
|
tag("stale", details.stale),
|
|
47
|
-
tag("auto_follow_attempt", details.autoFollowAttempt),
|
|
48
47
|
];
|
|
49
48
|
return [
|
|
50
49
|
`<subagent_watchdog ${attrs.join(" ")}>`,
|
|
@@ -2,6 +2,7 @@ import { spawnSync } from "node:child_process";
|
|
|
2
2
|
import * as fs from "node:fs";
|
|
3
3
|
import * as path from "node:path";
|
|
4
4
|
import type { Details, WorkflowPreflightLaneV1, WorkflowPreflightV1 } from "../shared/types.ts";
|
|
5
|
+
import { workflowPreflightLaneForRuntimeKey } from "./workflow-preflight.ts";
|
|
5
6
|
|
|
6
7
|
export const WORKFLOW_CHAT_PROGRESS_MODES = ["auto", "off", "live-card"] as const;
|
|
7
8
|
export type WorkflowChatProgressMode = typeof WORKFLOW_CHAT_PROGRESS_MODES[number];
|
|
@@ -111,7 +112,6 @@ function cleanLabel(value: unknown): string | undefined {
|
|
|
111
112
|
|
|
112
113
|
export function buildWorkflowChatProgressRows(trace: NonNullable<Details["workflow"]>["trace"], preflight?: WorkflowPreflightV1): WorkflowChatProgressRow[] {
|
|
113
114
|
const rows = new Map<string, WorkflowChatProgressRow>();
|
|
114
|
-
for (const lane of preflight?.lanes ?? []) rows.set(lane.key, { key: lane.key, state: "planned", preflight: lane });
|
|
115
115
|
for (const entry of trace) {
|
|
116
116
|
if (entry.operation !== "run") continue;
|
|
117
117
|
const existing = rows.get(entry.key);
|
|
@@ -124,8 +124,9 @@ export function buildWorkflowChatProgressRows(trace: NonNullable<Details["workfl
|
|
|
124
124
|
}
|
|
125
125
|
continue;
|
|
126
126
|
}
|
|
127
|
+
const lane = workflowPreflightLaneForRuntimeKey(preflight, entry.key, [entry.generatedLaneKey]);
|
|
127
128
|
const next: WorkflowChatProgressRow = existing ?? { key: entry.key, state: "running" };
|
|
128
|
-
if (
|
|
129
|
+
if (lane && !next.preflight) next.preflight = lane;
|
|
129
130
|
next.state = entry.state === "completed"
|
|
130
131
|
? "complete"
|
|
131
132
|
: entry.state === "failed"
|
|
@@ -1,5 +1,6 @@
|
|
|
1
1
|
import type { AsyncJobStep, HostStepNodeV1, WorkflowGraphNode, WorkflowGraphSnapshot, WorkflowPreflightLaneV1, WorkflowPreflightV1 } from "../shared/types.ts";
|
|
2
2
|
import { sanitizeDisplayText } from "../shared/display-text.ts";
|
|
3
|
+
import { workflowPreflightLaneForRuntimeKey } from "./workflow-preflight.ts";
|
|
3
4
|
|
|
4
5
|
export type WorkflowChecklistState = "complete" | "running" | "queued" | "blocked" | "failed" | "paused" | "stopped";
|
|
5
6
|
|
|
@@ -189,8 +190,8 @@ function duration(step: Pick<WorkflowChecklistStep, "durationMs" | "startedAt" |
|
|
|
189
190
|
return end === undefined ? undefined : Math.max(0, end - startedAt);
|
|
190
191
|
}
|
|
191
192
|
|
|
192
|
-
function laneFor(
|
|
193
|
-
return
|
|
193
|
+
function laneFor(preflight: WorkflowPreflightV1 | undefined, key: string, preferredKeys: readonly (string | undefined)[] = []): WorkflowPreflightLaneV1 | undefined {
|
|
194
|
+
return workflowPreflightLaneForRuntimeKey(preflight, key, preferredKeys);
|
|
194
195
|
}
|
|
195
196
|
|
|
196
197
|
function stepKey(step: WorkflowChecklistStep): string | undefined {
|
|
@@ -264,7 +265,7 @@ function traceSources(trace: readonly WorkflowChecklistTraceEntry[] | undefined)
|
|
|
264
265
|
}
|
|
265
266
|
|
|
266
267
|
function traceItem(entry: WorkflowChecklistTraceEntry, index: number, preflight: WorkflowPreflightLaneV1 | undefined): WorkflowChecklistItem {
|
|
267
|
-
const phase = keyText(entry.generatedLaneKey ?? entry.phase
|
|
268
|
+
const phase = keyText(preflight?.key ?? entry.generatedLaneKey ?? entry.phase, "Workflow");
|
|
268
269
|
const item = stepItem({ key: entry.key, label: entry.label, phase, agent: entry.agent, status: entry.state === "started" ? "running" : entry.state, durationMs: entry.durationMs, error: entry.error }, index, phase, entry.key, entry.label ?? entry.key, preflight);
|
|
269
270
|
if (entry.operation === "host") item.kind = "host";
|
|
270
271
|
return item;
|
|
@@ -317,16 +318,13 @@ function finalize(phase: WorkflowChecklistPhase): void {
|
|
|
317
318
|
|
|
318
319
|
export function projectWorkflowChecklist(input: WorkflowChecklistInput): WorkflowChecklistProjection {
|
|
319
320
|
const phases = new Map<string, WorkflowChecklistPhase>();
|
|
320
|
-
const lanes = new Map((input.preflight?.lanes ?? []).map((lane) => [lane.key, lane]));
|
|
321
321
|
const steps = (input.steps ?? []) as readonly WorkflowChecklistStep[];
|
|
322
322
|
const nodes = graphNodes(input.graph);
|
|
323
323
|
const trace = traceSources(input.trace);
|
|
324
324
|
const traceByKey = new Map(trace.map((entry) => [entry.key, entry]));
|
|
325
325
|
const phaseByNode = new Map<string, string>();
|
|
326
|
-
const graphPhaseLabels = new Set<string>();
|
|
327
326
|
for (const phase of input.graph?.phases ?? []) {
|
|
328
327
|
const title = keyText(phase.title, "Workflow");
|
|
329
|
-
graphPhaseLabels.add(title);
|
|
330
328
|
phaseFor(phases, title);
|
|
331
329
|
for (const nodeId of phase.nodeIds) if (!phaseByNode.has(nodeId)) phaseByNode.set(nodeId, title);
|
|
332
330
|
}
|
|
@@ -356,28 +354,28 @@ export function projectWorkflowChecklist(input: WorkflowChecklistInput): Workflo
|
|
|
356
354
|
if (matches.length) {
|
|
357
355
|
for (const match of matches) {
|
|
358
356
|
usedSteps.add(match.index);
|
|
359
|
-
add(phases, phase, applyNow(mergeNodeStep(node, match.step, phase, traceByKey.get(stepKey(match.step) ?? node.id), laneFor(node.id, phase
|
|
357
|
+
add(phases, phase, applyNow(mergeNodeStep(node, match.step, phase, traceByKey.get(stepKey(match.step) ?? node.id), laneFor(input.preflight, node.id, [phase])), input.now));
|
|
360
358
|
}
|
|
361
359
|
continue;
|
|
362
360
|
}
|
|
363
|
-
add(phases, phase, applyNow(mergeNodeStep(node, { key: node.id, label: node.label, phase, agent: node.agent, status: node.status, outputName: node.outputName, error: node.error, acceptance: node.acceptanceStatus ? { status: node.acceptanceStatus } : undefined }, phase, traceByKey.get(node.id), laneFor(node.id, phase
|
|
361
|
+
add(phases, phase, applyNow(mergeNodeStep(node, { key: node.id, label: node.label, phase, agent: node.agent, status: node.status, outputName: node.outputName, error: node.error, acceptance: node.acceptanceStatus ? { status: node.acceptanceStatus } : undefined }, phase, traceByKey.get(node.id), laneFor(input.preflight, node.id, [phase])), input.now));
|
|
364
362
|
}
|
|
365
363
|
|
|
366
364
|
for (const [index, step] of steps.entries()) {
|
|
367
365
|
if (usedSteps.has(index)) continue;
|
|
368
366
|
const key = keyText(stepKey(step), `step-${index + 1}`);
|
|
369
367
|
const traceEntry = traceByKey.get(key);
|
|
370
|
-
const
|
|
371
|
-
|
|
368
|
+
const lane = laneFor(input.preflight, key, [step.phase, traceEntry?.generatedLaneKey, traceEntry?.phase]);
|
|
369
|
+
const phase = keyText(lane?.key ?? step.phase ?? traceEntry?.generatedLaneKey ?? traceEntry?.phase, "Workflow");
|
|
370
|
+
add(phases, phase, applyNow(stepItem(step, index, phase, key, step.label ?? step.key ?? step.agent, lane), input.now));
|
|
372
371
|
}
|
|
373
372
|
|
|
374
373
|
for (const host of hostById.values()) add(phases, keyText(host.label, "Host"), hostItem(host, keyText(host.label, "Host")));
|
|
375
374
|
for (const entry of trace) {
|
|
376
375
|
if (graphKeys.has(entry.key) || stepKeys.has(entry.key) || hostKeys.has(entry.key)) continue;
|
|
377
|
-
const item = traceItem(entry, phases.size, laneFor(entry.key, entry.generatedLaneKey
|
|
376
|
+
const item = traceItem(entry, phases.size, laneFor(input.preflight, entry.key, [entry.generatedLaneKey, entry.phase]));
|
|
378
377
|
add(phases, item.phase, item);
|
|
379
378
|
}
|
|
380
|
-
for (const lane of input.preflight?.lanes ?? []) if (!graphKeys.has(lane.key) && !graphPhaseLabels.has(lane.key) && !phases.get(lane.key)?.items.length) add(phases, lane.key, { key: lane.key, label: lane.key, phase: lane.key, state: "queued", preflight: lane });
|
|
381
379
|
|
|
382
380
|
const finalized = [...phases.values()].filter((phase) => phase.items.length > 0);
|
|
383
381
|
for (const phase of finalized) {
|
|
@@ -146,8 +146,35 @@ function declaredKeys(preflight: WorkflowPreflightV1): Set<string> {
|
|
|
146
146
|
* Treat declared lane keys as plan roots: `lane` is the lane itself and
|
|
147
147
|
* `lane.stage` is a stage by convention, even without generated provenance.
|
|
148
148
|
*/
|
|
149
|
+
export function workflowKeyMatchesPreflightLane(key: string, laneKey: string, generatedLaneKey?: string): boolean {
|
|
150
|
+
return generatedLaneKey === laneKey || key === laneKey || key.startsWith(`${laneKey}.`);
|
|
151
|
+
}
|
|
152
|
+
|
|
153
|
+
/** Select the most specific advisory lane without allowing declaration order to override an exact runtime key. */
|
|
154
|
+
export function workflowPreflightLaneForRuntimeKey(
|
|
155
|
+
preflight: WorkflowPreflightV1 | undefined,
|
|
156
|
+
key: string,
|
|
157
|
+
preferredKeys: readonly (string | undefined)[] = [],
|
|
158
|
+
): WorkflowPreflightLaneV1 | undefined {
|
|
159
|
+
const lanes = preflight?.lanes;
|
|
160
|
+
if (!lanes) return undefined;
|
|
161
|
+
const exact = lanes.find((lane) => lane.key === key);
|
|
162
|
+
if (exact) return exact;
|
|
163
|
+
let closestRoot: WorkflowPreflightLaneV1 | undefined;
|
|
164
|
+
for (const lane of lanes) {
|
|
165
|
+
if (key.startsWith(`${lane.key}.`) && (!closestRoot || lane.key.length > closestRoot.key.length)) closestRoot = lane;
|
|
166
|
+
}
|
|
167
|
+
if (closestRoot) return closestRoot;
|
|
168
|
+
for (const preferredKey of preferredKeys) {
|
|
169
|
+
if (!preferredKey) continue;
|
|
170
|
+
const preferred = lanes.find((lane) => lane.key === preferredKey);
|
|
171
|
+
if (preferred) return preferred;
|
|
172
|
+
}
|
|
173
|
+
return undefined;
|
|
174
|
+
}
|
|
175
|
+
|
|
149
176
|
function declaredLaneCoversWorkflowKey(entry: WorkflowTraceLike, laneKey: string): boolean {
|
|
150
|
-
return entry.key
|
|
177
|
+
return workflowKeyMatchesPreflightLane(entry.key, laneKey, entry.generatedLaneKey);
|
|
151
178
|
}
|
|
152
179
|
|
|
153
180
|
function keyCoveredByDeclaredLane(entry: WorkflowTraceLike, declared: ReadonlySet<string>): boolean {
|