pi-subagents 0.49.0 → 0.51.0

package/src/runs/background/control-channel.ts

@@ -18,6 +18,7 @@ import * as fs from "node:fs";
 import * as path from "node:path";
 import { writeAtomicJson } from "../../shared/atomic-json.ts";
 import { POLL_INTERVAL_MS } from "../../shared/types.ts";
+import { shouldUseNativeFsWatch } from "../../shared/watch-strategy.ts";
 import { resolveWatchPath } from "../../shared/utils.ts";
 
 export type ControlChannelFs = Pick<typeof fs, "mkdirSync" | "existsSync" | "rmSync" | "watch" | "readdirSync" | "readFileSync" | "realpathSync">;
@@ -56,13 +57,6 @@ export interface StopRequest {
 	reason?: string;
 }
 
-export interface CheckpointDecisionRequest {
-	type: "approve-checkpoint" | "reject-checkpoint";
-	ts?: number;
-	source?: string;
-	reason?: string;
-}
-
 export type SteerDeliveryMode = "steer" | "follow_up" | "auto";
 export type SteerDeliveryStatus = "delivered" | "queued";
 
@@ -127,14 +121,6 @@ export function stopRequestPath(asyncDir: string): string {
 	return path.join(controlInboxDir(asyncDir), "stop.json");
 }
 
-export function approveCheckpointRequestPath(asyncDir: string): string {
-	return path.join(controlInboxDir(asyncDir), "approve-checkpoint.json");
-}
-
-export function rejectCheckpointRequestPath(asyncDir: string): string {
-	return path.join(controlInboxDir(asyncDir), "reject-checkpoint.json");
-}
-
 /** Directory of parent-to-runner steering requests. */
 export function steerRequestsDir(asyncDir: string): string {
 	return path.join(controlInboxDir(asyncDir), STEER_REQUESTS_DIR);
@@ -144,8 +130,8 @@ export function steerInboxClosedPath(asyncDir: string): string {
 	return path.join(controlInboxDir(asyncDir), STEER_INBOX_CLOSED_FILE);
 }
 
-export function closeSteerInbox(asyncDir: string, state: string): void {
-	writeAtomicJson(steerInboxClosedPath(asyncDir), { version: 1, closedAt: Date.now(), state });
+export function closeSteerInbox(asyncDir: string, state: string, write: (filePath: string, payload: object) => void = writeAtomicJson): void {
+	write(steerInboxClosedPath(asyncDir), { version: 1, closedAt: Date.now(), state });
 }
 
 /** Per-child inbox consumed by the child prompt runtime inside the Pi process. */
@@ -299,18 +285,6 @@ export function requestAsyncStop(
 	return requestPath;
 }
 
-export function requestAsyncCheckpointDecision(
-	asyncDir: string,
-	type: CheckpointDecisionRequest["type"],
-	payload: Omit<CheckpointDecisionRequest, "type"> = {},
-	deps: { now?: () => number } = {},
-): string {
-	const requestPath = type === "approve-checkpoint" ? approveCheckpointRequestPath(asyncDir) : rejectCheckpointRequestPath(asyncDir);
-	const request: CheckpointDecisionRequest = { ...payload, ts: payload.ts ?? deps.now?.() ?? Date.now(), type };
-	writeAtomicJson(requestPath, request);
-	return requestPath;
-}
-
 export function requestAsyncSteer(
 	asyncDir: string,
 	payload: { message: string; mode?: SteerDeliveryMode; targetIndex?: number; targetIndexes?: number[]; source?: string; id?: string; ts?: number },
@@ -559,21 +533,6 @@ export function consumeStopRequest(
 	return true;
 }
 
-export function consumeCheckpointDecisionRequest(
-	asyncDir: string,
-	fsImpl: Pick<typeof fs, "existsSync" | "rmSync"> = fs,
-): "approved" | "rejected" | undefined {
-	if (fsImpl.existsSync(rejectCheckpointRequestPath(asyncDir))) {
-		try { fsImpl.rmSync(rejectCheckpointRequestPath(asyncDir), { force: true, recursive: true }); } catch {}
-		return "rejected";
-	}
-	if (fsImpl.existsSync(approveCheckpointRequestPath(asyncDir))) {
-		try { fsImpl.rmSync(approveCheckpointRequestPath(asyncDir), { force: true, recursive: true }); } catch {}
-		return "approved";
-	}
-	return undefined;
-}
-
 /** Parent side: write the authoritative portable interrupt request. */
 export function deliverInterruptRequest(input: {
 	asyncDir: string;
@@ -605,21 +564,6 @@ export function deliverStopRequest(input: {
 	requestAsyncStop(input.asyncDir, input.source ? { source: input.source } : {}, { now: input.now });
 }
 
-export function deliverCheckpointDecisionRequest(input: {
-	asyncDir: string;
-	decision: "approved" | "rejected";
-	now?: () => number;
-	source?: string;
-	reason?: string;
-}): void {
-	requestAsyncCheckpointDecision(
-		input.asyncDir,
-		input.decision === "approved" ? "approve-checkpoint" : "reject-checkpoint",
-		{ ...(input.source ? { source: input.source } : {}), ...(input.reason ? { reason: input.reason } : {}) },
-		{ now: input.now },
-	);
-}
-
 /**
  * Runner side: watch the control inbox and route interrupt requests into
  * `onInterrupt`. Uses `fs.watch` when available and starts interval polling
@@ -633,11 +577,11 @@ export function watchAsyncControlInbox(
 		onTimeout?: () => void;
 		onStop?: () => void;
 		onSteer?: (request: SteerRequest) => void;
-		onCheckpointDecision?: (decision: "approved" | "rejected") => void;
 		onSteerCapability?: (capability: SteerCapability) => void;
 		onSteerAck?: (ack: SteerAck) => void;
 		pollIntervalMs?: number;
 		safetyPollIntervalMs?: number;
+		platform?: NodeJS.Platform;
 		fs?: ControlChannelFs;
 		timers?: ControlChannelTimers;
 	},
@@ -658,8 +602,6 @@ export function watchAsyncControlInbox(
 			if (consumeStopRequest(asyncDir, fsImpl)) opts.onStop?.();
 			if (consumeTimeoutRequest(asyncDir, fsImpl)) opts.onTimeout?.();
 			if (consumeInterruptRequest(asyncDir, fsImpl)) opts.onInterrupt();
-			const checkpointDecision = consumeCheckpointDecisionRequest(asyncDir, fsImpl);
-			if (checkpointDecision) opts.onCheckpointDecision?.(checkpointDecision);
 			for (const request of consumeSteerRequests(asyncDir, fsImpl)) opts.onSteer?.(request);
 			for (const capability of consumeSteerCapabilities(asyncDir, fsImpl)) opts.onSteerCapability?.(capability);
 			for (const ack of consumeSteerAcks(asyncDir, fsImpl)) opts.onSteerAck?.(ack);
@@ -707,12 +649,16 @@ export function watchAsyncControlInbox(
 		for (const entry of entries) watchDir(path.join(ackRoot, entry));
 	};
 	try {
-		watchDir(dir);
-		watchDir(steerRequestsDir(asyncDir), true);
-		watchDir(steerCapabilitiesDir(asyncDir), true);
-		watchDir(path.join(dir, STEER_ACKS_DIR), true);
-		watchExistingSteerAckDirs();
-		startSafetyPolling();
+		if (shouldUseNativeFsWatch("runner-control-inbox", opts.platform)) {
+			watchDir(dir);
+			watchDir(steerRequestsDir(asyncDir), true);
+			watchDir(steerCapabilitiesDir(asyncDir), true);
+			watchDir(path.join(dir, STEER_ACKS_DIR), true);
+			watchExistingSteerAckDirs();
+			startSafetyPolling();
+		} else {
+			startPolling();
+		}
 	} catch {
 		startPolling();
 	}

package/src/runs/background/fleet-view.ts

@@ -443,6 +443,8 @@ export function formatAsyncRunTranscript(status: AsyncStatus, asyncDir: string,
 		: uniqueStrings([runOutputPath]);
 	const sessionFile = selected.index !== undefined ? selected.step?.sessionFile : status.sessionFile;
 	const eventsPath = path.join(asyncDir, "events.jsonl");
+	// Synthesized output paths can name files that were never written. Keep the unfiltered paths
+	// below so a present-but-unreadable file still reports its read error.
 
 	const context = contextModeLabel(status.context ?? summarizeContextModes((status.steps ?? []).map((step) => step.context)));
 	const lines = [
@@ -452,7 +454,7 @@ export function formatAsyncRunTranscript(status: AsyncStatus, asyncDir: string,
 		stepStateLine(status.mode, selected.index, selected.step),
 		selected.hint,
 	].filter((line): line is string => Boolean(line));
-	appendKnownArtifacts(lines, { outputPaths, sessionFile, eventsPath: fs.existsSync(eventsPath) ? eventsPath : undefined, logPath: fs.existsSync(logPath) ? logPath : undefined });
+	appendKnownArtifacts(lines, { outputPaths: outputPaths.filter((outputPath) => fs.existsSync(outputPath)), sessionFile, eventsPath: fs.existsSync(eventsPath) ? eventsPath : undefined, logPath: fs.existsSync(logPath) ? logPath : undefined });
 
 	const warnings: string[] = [];
 	let transcriptLines: string[] = [];

package/src/runs/background/index-segment.ts

@@ -0,0 +1,59 @@
+import { createHash } from "node:crypto";
+
+/**
+ * Keep opaque index keys below common filesystem component limits.
+ *
+ * Portable short values retain the historical URI-encoded representation.
+ * Oversized or non-portable values use a deterministic digest so callers can
+ * resolve the same index without persisting a separate lookup table.
+ *
+ * Encoded backslashes and trailing file extensions are not portable. Pi session
+ * ids are often the full session `.jsonl` path. On Windows, `readdir` of a
+ * directory whose name ends in `.jsonl` or contains `%5C` can fail with EPERM.
+ */
+export const MAX_INDEX_SEGMENT_BYTES = 255;
+const HASHED_INDEX_SEGMENT_PREFIX = "~sha256-";
+const WINDOWS_RESERVED_NAME = /^(?:con|prn|aux|nul|com[1-9]|lpt[1-9])(?:\.|$)/i;
+
+function hashedSegment(value: string): string {
+	return `${HASHED_INDEX_SEGMENT_PREFIX}${createHash("sha256").update(value).digest("hex")}`;
+}
+
+function isPortableSegment(value: string): boolean {
+	return value.length > 0
+		&& value !== "."
+		&& value !== ".."
+		&& !value.endsWith(".")
+		&& !WINDOWS_RESERVED_NAME.test(value)
+		&& !/%5C/i.test(value)
+		&& !/\.[A-Za-z][A-Za-z0-9]{0,7}$/.test(value);
+}
+
+export function encodeIndexSegment(value: string, maxBytes = MAX_INDEX_SEGMENT_BYTES): string {
+	let encoded: string;
+	try {
+		encoded = encodeURIComponent(value);
+	} catch {
+		return hashedSegment(value);
+	}
+	if (Buffer.byteLength(encoded, "utf-8") <= maxBytes && isPortableSegment(encoded)) return encoded;
+	return hashedSegment(value);
+}
+
+function historicallyReadableSegment(value: string, maxBytes: number): string | undefined {
+	try {
+		const encoded = encodeURIComponent(value);
+		if (encoded.length === 0 || encoded === "." || encoded === ".." || encoded.endsWith(".") || WINDOWS_RESERVED_NAME.test(encoded)) return undefined;
+		if (Buffer.byteLength(encoded, "utf-8") > maxBytes) return undefined;
+		return encoded;
+	} catch {
+		return undefined;
+	}
+}
+
+/** Current write key first, then the pre-hash URI-encoded key when it still fits. */
+export function indexSegmentAliases(value: string, maxBytes = MAX_INDEX_SEGMENT_BYTES): string[] {
+	const current = encodeIndexSegment(value, maxBytes);
+	const historical = historicallyReadableSegment(value, maxBytes);
+	return historical && historical !== current ? [current, historical] : [current];
+}

package/src/runs/background/notify.ts

@@ -63,6 +63,7 @@ export interface CompletionNotification {
 	taskIndex?: number;
 	totalTasks?: number;
 	sessionId?: string | null;
+	completionOwnerId?: string | null;
 	triggerTurn?: boolean;
 	/** True when an acknowledged grouped intercom relay already delivered this run. */
 	intercomDelivered?: boolean;
@@ -239,7 +240,7 @@ export function buildCompletionDetails(result: CompletionNotification): Subagent
 
 export default function registerSubagentNotify(
 	pi: ExtensionAPI,
-	state: Pick<SubagentState, "currentSessionId">,
+	state: Pick<SubagentState, "currentSessionId" | "completionOwnerId">,
 	options: RegisterSubagentNotifyOptions = {},
 ): CompletionNotifier {
 	const seen = new Map<string, number>();
@@ -275,6 +276,7 @@ export default function registerSubagentNotify(
 
 	const deliver = (result: CompletionNotification): Promise<boolean> => {
 		if (disposed || typeof result.sessionId !== "string" || result.sessionId !== state.currentSessionId) return Promise.resolve(false);
+		if (result.source !== "foreground" && (!state.completionOwnerId || result.completionOwnerId !== state.completionOwnerId)) return Promise.resolve(false);
 		if (result.intercomDelivered === true) return Promise.resolve(true);
 		const key = buildCompletionKey(result, "notify");
 		const seenAt = seen.get(key);