pi-subagents 0.3.0 → 0.3.2

package/CHANGELOG.md

@@ -1,5 +1,40 @@
 # Changelog
 
+## [0.3.2] - 2026-01-25
+
+### Performance
+- **4x faster polling** - Reduced poll interval from 1000ms to 250ms (efficient with mtime caching)
+- **Mtime-based caching** - status.json and output tail reads cached to avoid redundant I/O
+- **Unified throttled updates** - All onUpdate calls consolidated under 50ms throttle
+- **Widget change detection** - Hash-based change detection skips no-op re-renders
+- **Array optimizations** - Use concat instead of spread for chain progress updates
+
+### Fixed
+- **Timer leaks** - Track and clear pendingTimer and cleanupTimers properly
+- **Updates after close** - processClosed flag prevents updates after process terminates  
+- **Session cleanup** - Clear cleanup timers on session_start/switch/branch/shutdown
+
+## [0.3.1] - 2026-01-24
+
+### Changed
+- **Major code refactor** - Split monolithic index.ts into focused modules:
+  - `execution.ts` - Core runSync function for single agent execution
+  - `chain-execution.ts` - Chain orchestration (sequential + parallel steps)
+  - `async-execution.ts` - Async/background execution support
+  - `render.ts` - TUI rendering (widget, tool result display)
+  - `schemas.ts` - TypeBox parameter schemas
+  - `formatters.ts` - Output formatting utilities
+  - `utils.ts` - Shared utility functions
+  - `types.ts` - Shared type definitions and constants
+
+### Fixed
+- **Expanded view visibility** - Running chains now properly show:
+  - Task preview (truncated to 80 chars) for each step
+  - Recent tools fallback when between tool calls
+  - Increased recent output from 2 to 3 lines
+- **Progress matching** - Added agent name fallback when index doesn't match
+- **Type safety** - Added defensive `?? []` for `recentOutput` access on union types
+
 ## [0.3.0] - 2026-01-24
 
 ### Added

package/agents.ts

@@ -160,13 +160,3 @@ export function discoverAgents(cwd: string, scope: AgentScope): AgentDiscoveryRe
 
 	return { agents: Array.from(agentMap.values()), projectAgentsDir };
 }
-
-export function formatAgentList(agents: AgentConfig[], maxItems: number): { text: string; remaining: number } {
-	if (agents.length === 0) return { text: "none", remaining: 0 };
-	const listed = agents.slice(0, maxItems);
-	const remaining = agents.length - listed.length;
-	return {
-		text: listed.map((a) => `${a.name} (${a.source}): ${a.description}`).join("; "),
-		remaining,
-	};
-}

package/async-execution.ts

@@ -0,0 +1,261 @@
+/**
+ * Async execution logic for subagent tool
+ */
+
+import { spawn } from "node:child_process";
+import * as fs from "node:fs";
+import * as os from "node:os";
+import * as path from "node:path";
+import { fileURLToPath } from "node:url";
+import { createRequire } from "node:module";
+import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
+import type { AgentConfig } from "./agents.js";
+import { isParallelStep, type ChainStep, type SequentialStep } from "./settings.js";
+import {
+	type ArtifactConfig,
+	type Details,
+	type MaxOutputConfig,
+	ASYNC_DIR,
+	RESULTS_DIR,
+} from "./types.js";
+
+const require = createRequire(import.meta.url);
+const jitiCliPath: string | undefined = (() => {
+	try {
+		return path.join(path.dirname(require.resolve("jiti/package.json")), "lib/jiti-cli.mjs");
+	} catch {
+		return undefined;
+	}
+})();
+
+export interface AsyncExecutionContext {
+	pi: ExtensionAPI;
+	cwd: string;
+	currentSessionId: string;
+}
+
+export interface AsyncChainParams {
+	chain: ChainStep[];
+	agents: AgentConfig[];
+	ctx: AsyncExecutionContext;
+	cwd?: string;
+	maxOutput?: MaxOutputConfig;
+	artifactsDir?: string;
+	artifactConfig: ArtifactConfig;
+	shareEnabled: boolean;
+	sessionRoot?: string;
+}
+
+export interface AsyncSingleParams {
+	agent: string;
+	task: string;
+	agentConfig: AgentConfig;
+	ctx: AsyncExecutionContext;
+	cwd?: string;
+	maxOutput?: MaxOutputConfig;
+	artifactsDir?: string;
+	artifactConfig: ArtifactConfig;
+	shareEnabled: boolean;
+	sessionRoot?: string;
+}
+
+export interface AsyncExecutionResult {
+	content: Array<{ type: "text"; text: string }>;
+	details: Details;
+	isError?: boolean;
+}
+
+/**
+ * Check if jiti is available for async execution
+ */
+export function isAsyncAvailable(): boolean {
+	return jitiCliPath !== undefined;
+}
+
+/**
+ * Spawn the async runner process
+ */
+function spawnRunner(cfg: object, suffix: string, cwd: string): number | undefined {
+	if (!jitiCliPath) return undefined;
+	
+	const cfgPath = path.join(os.tmpdir(), `pi-async-cfg-${suffix}.json`);
+	fs.writeFileSync(cfgPath, JSON.stringify(cfg));
+	const runner = path.join(path.dirname(fileURLToPath(import.meta.url)), "subagent-runner.ts");
+	
+	const proc = spawn("node", [jitiCliPath, runner, cfgPath], {
+		cwd,
+		detached: true,
+		stdio: "ignore",
+	});
+	proc.unref();
+	return proc.pid;
+}
+
+/**
+ * Execute a chain asynchronously
+ */
+export function executeAsyncChain(
+	id: string,
+	params: AsyncChainParams,
+): AsyncExecutionResult {
+	const { chain, agents, ctx, cwd, maxOutput, artifactsDir, artifactConfig, shareEnabled, sessionRoot } = params;
+	
+	// Async mode doesn't support parallel steps (v1 limitation)
+	const hasParallelInChain = chain.some(isParallelStep);
+	if (hasParallelInChain) {
+		return {
+			content: [{ type: "text", text: "Async mode doesn't support chains with parallel steps. Use clarify: true (sync mode) for parallel-in-chain." }],
+			isError: true,
+			details: { mode: "chain" as const, results: [] },
+		};
+	}
+
+	// At this point, all steps are sequential
+	const seqSteps = chain as SequentialStep[];
+
+	// Validate all agents exist before building steps
+	for (const s of seqSteps) {
+		if (!agents.find((x) => x.name === s.agent)) {
+			return {
+				content: [{ type: "text", text: `Unknown agent: ${s.agent}` }],
+				isError: true,
+				details: { mode: "chain" as const, results: [] },
+			};
+		}
+	}
+
+	const asyncDir = path.join(ASYNC_DIR, id);
+	try {
+		fs.mkdirSync(asyncDir, { recursive: true });
+	} catch {}
+
+	const steps = seqSteps.map((s, i) => {
+		const a = agents.find((x) => x.name === s.agent)!;
+		return {
+			agent: s.agent,
+			// First step validated to have task; others default to {previous} (replaced by runner)
+			task: s.task ?? "{previous}",
+			cwd: s.cwd,
+			model: a.model,
+			tools: a.tools,
+			systemPrompt: a.systemPrompt?.trim() || null,
+		};
+	});
+
+	const runnerCwd = cwd ?? ctx.cwd;
+	const pid = spawnRunner(
+		{
+			id,
+			steps,
+			resultPath: path.join(RESULTS_DIR, `${id}.json`),
+			cwd: runnerCwd,
+			placeholder: "{previous}",
+			maxOutput,
+			artifactsDir: artifactConfig.enabled ? artifactsDir : undefined,
+			artifactConfig,
+			share: shareEnabled,
+			sessionDir: sessionRoot ? path.join(sessionRoot, `async-${id}`) : undefined,
+			asyncDir,
+			sessionId: ctx.currentSessionId,
+		},
+		id,
+		runnerCwd,
+	);
+
+	if (pid) {
+		const firstAgent = chain[0] as SequentialStep;
+		ctx.pi.events.emit("subagent_enhanced:started", {
+			id,
+			pid,
+			agent: firstAgent.agent,
+			task: firstAgent.task?.slice(0, 50),
+			chain: chain.map((s) => (s as SequentialStep).agent),
+			cwd: runnerCwd,
+			asyncDir,
+		});
+		ctx.pi.events.emit("subagent:started", {
+			id,
+			pid,
+			agent: firstAgent.agent,
+			task: firstAgent.task?.slice(0, 50),
+			chain: chain.map((s) => (s as SequentialStep).agent),
+			cwd: runnerCwd,
+			asyncDir,
+		});
+	}
+
+	return {
+		content: [
+			{ type: "text", text: `Async chain: ${chain.map((s) => (s as SequentialStep).agent).join(" -> ")} [${id}]` },
+		],
+		details: { mode: "chain", results: [], asyncId: id, asyncDir },
+	};
+}
+
+/**
+ * Execute a single agent asynchronously
+ */
+export function executeAsyncSingle(
+	id: string,
+	params: AsyncSingleParams,
+): AsyncExecutionResult {
+	const { agent, task, agentConfig, ctx, cwd, maxOutput, artifactsDir, artifactConfig, shareEnabled, sessionRoot } = params;
+
+	const asyncDir = path.join(ASYNC_DIR, id);
+	try {
+		fs.mkdirSync(asyncDir, { recursive: true });
+	} catch {}
+
+	const runnerCwd = cwd ?? ctx.cwd;
+	const pid = spawnRunner(
+		{
+			id,
+			steps: [
+				{
+					agent,
+					task,
+					cwd,
+					model: agentConfig.model,
+					tools: agentConfig.tools,
+					systemPrompt: agentConfig.systemPrompt?.trim() || null,
+				},
+			],
+			resultPath: path.join(RESULTS_DIR, `${id}.json`),
+			cwd: runnerCwd,
+			placeholder: "{previous}",
+			maxOutput,
+			artifactsDir: artifactConfig.enabled ? artifactsDir : undefined,
+			artifactConfig,
+			share: shareEnabled,
+			sessionDir: sessionRoot ? path.join(sessionRoot, `async-${id}`) : undefined,
+			asyncDir,
+			sessionId: ctx.currentSessionId,
+		},
+		id,
+		runnerCwd,
+	);
+
+	if (pid) {
+		ctx.pi.events.emit("subagent_enhanced:started", {
+			id,
+			pid,
+			agent,
+			task: task?.slice(0, 50),
+			cwd: runnerCwd,
+			asyncDir,
+		});
+		ctx.pi.events.emit("subagent:started", {
+			id,
+			pid,
+			agent,
+			task: task?.slice(0, 50),
+			cwd: runnerCwd,
+			asyncDir,
+		});
+	}
+
+	return {
+		content: [{ type: "text", text: `Async: ${agent} [${id}]` }],
+		details: { mode: "single", results: [], asyncId: id, asyncDir },
+	};
+}