pi-studio 0.9.52 → 0.9.53

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-studio",
-  "version": "0.9.52",
+  "version": "0.9.53",
   "description": "Two-pane browser workspace for pi with prompt/response editing, annotations, critiques, active quiz, prompt/response history, live previews, and tmux-backed REPL/literate REPL workflows",
   "type": "module",
   "license": "MIT",

package/shared/studio-resource-grants.js

@@ -0,0 +1,157 @@
+import { realpathSync, statSync } from "node:fs";
+import { homedir } from "node:os";
+import { dirname, isAbsolute, relative, resolve, sep } from "node:path";
+
+export const STUDIO_RESOURCE_GRANT_MAX_ENTRIES = 128;
+
+function expandHome(pathInput) {
+	const value = String(pathInput || "").trim();
+	if (value === "~") return homedir();
+	if (value.startsWith("~/") || value.startsWith("~\\")) return resolve(homedir(), value.slice(2));
+	return value;
+}
+
+function resolveGrantInput(pathInput, fallbackCwd) {
+	const raw = expandHome(pathInput);
+	if (!raw) throw new Error("Missing Studio resource grant path.");
+	if (/\0/.test(raw)) throw new Error("Invalid Studio resource grant path.");
+	if (/^[a-z][a-z0-9+.-]*:/i.test(raw) && !/^[a-z]:[\\/]/i.test(raw)) {
+		throw new Error("Studio resource grants require a local path.");
+	}
+	return isAbsolute(raw) ? raw : resolve(fallbackCwd, raw);
+}
+
+function canonicalExistingPath(pathInput, fallbackCwd, expectedKind) {
+	const resolvedPath = resolveGrantInput(pathInput, fallbackCwd);
+	const canonicalPath = realpathSync(resolvedPath);
+	const stats = statSync(canonicalPath);
+	if (expectedKind === "directory" && !stats.isDirectory()) {
+		throw new Error("Studio resource directory grant does not refer to a directory.");
+	}
+	if (expectedKind === "file" && !stats.isFile()) {
+		throw new Error("Studio resource file grant does not refer to a file.");
+	}
+	if (!stats.isDirectory() && !stats.isFile()) {
+		throw new Error("Studio resource grant path must refer to a file or directory.");
+	}
+	return { canonicalPath, resolvedPath, kind: stats.isDirectory() ? "directory" : "file" };
+}
+
+function isPathInsideOrEqualDirectory(candidatePath, directoryPath) {
+	const rel = relative(directoryPath, candidatePath);
+	return rel === "" || (!isAbsolute(rel) && rel !== ".." && !rel.startsWith(`..${sep}`));
+}
+
+function normalizeGrantSource(source, fallback) {
+	const value = String(source || "").trim();
+	return (value || fallback).slice(0, 100);
+}
+
+function copyGrant(entry) {
+	return Object.freeze({
+		kind: entry.kind,
+		path: entry.path,
+		sources: Object.freeze(Array.from(entry.sources)),
+		grantedAt: entry.grantedAt,
+	});
+}
+
+export function createStudioResourceGrantRegistry(options = {}) {
+	const requestedMaxEntries = Number(options.maxEntries);
+	const maxEntries = Math.max(1, Math.min(
+		STUDIO_RESOURCE_GRANT_MAX_ENTRIES,
+		Number.isFinite(requestedMaxEntries) && requestedMaxEntries > 0
+			? Math.floor(requestedMaxEntries)
+			: STUDIO_RESOURCE_GRANT_MAX_ENTRIES,
+	));
+	const now = typeof options.now === "function" ? options.now : Date.now;
+	const defaultCwd = typeof options.cwd === "string" && options.cwd.trim() ? options.cwd : process.cwd();
+	const entries = new Map();
+
+	function fallbackCwd(details) {
+		return typeof details?.cwd === "string" && details.cwd.trim() ? details.cwd : defaultCwd;
+	}
+
+	function addGrant(kind, canonicalPath, source) {
+		const key = `${kind}:${canonicalPath}`;
+		const existing = entries.get(key);
+		if (existing) {
+			existing.sources.add(source);
+			return copyGrant(existing);
+		}
+		if (entries.size >= maxEntries) {
+			throw new Error(`Studio resource grant limit reached (${maxEntries}).`);
+		}
+		const entry = {
+			kind,
+			path: canonicalPath,
+			sources: new Set([source]),
+			grantedAt: Math.max(0, Number(now()) || 0),
+		};
+		entries.set(key, entry);
+		return copyGrant(entry);
+	}
+
+	function grantDirectory(pathInput, details = {}) {
+		const resolved = canonicalExistingPath(pathInput, fallbackCwd(details), "directory");
+		return addGrant("directory", resolved.canonicalPath, normalizeGrantSource(details.source, "explicit-directory"));
+	}
+
+	function grantFile(pathInput, details = {}) {
+		const resolved = canonicalExistingPath(pathInput, fallbackCwd(details), "file");
+		return addGrant("file", resolved.canonicalPath, normalizeGrantSource(details.source, "explicit-file"));
+	}
+
+	function grantDocument(pathInput, details = {}) {
+		const cwd = fallbackCwd(details);
+		const document = canonicalExistingPath(pathInput, cwd, "file");
+		const documentDirectory = dirname(resolveGrantInput(pathInput, cwd));
+		const directoryGrant = grantDirectory(documentDirectory, {
+			cwd,
+			source: normalizeGrantSource(details.source, "document"),
+		});
+		if (!isPathInsideOrEqualDirectory(document.canonicalPath, directoryGrant.path)) {
+			grantFile(document.canonicalPath, { cwd, source: "document-file" });
+		}
+		return directoryGrant;
+	}
+
+	function findGrant(pathInput, details = {}) {
+		let candidate;
+		try {
+			candidate = canonicalExistingPath(pathInput, fallbackCwd(details));
+		} catch {
+			return null;
+		}
+		const exactFile = entries.get(`file:${candidate.canonicalPath}`);
+		if (exactFile) return copyGrant(exactFile);
+
+		let bestDirectory = null;
+		for (const entry of entries.values()) {
+			if (entry.kind !== "directory" || !isPathInsideOrEqualDirectory(candidate.canonicalPath, entry.path)) continue;
+			if (!bestDirectory || entry.path.length > bestDirectory.path.length) bestDirectory = entry;
+		}
+		return bestDirectory ? copyGrant(bestDirectory) : null;
+	}
+
+	return Object.freeze({
+		grantDirectory,
+		grantFile,
+		grantDocument,
+		findGrant,
+		allows(pathInput, details = {}) {
+			return findGrant(pathInput, details) !== null;
+		},
+		snapshot() {
+			return Array.from(entries.values())
+				.sort((a, b) => a.path.localeCompare(b.path) || a.kind.localeCompare(b.kind))
+				.map(copyGrant);
+		},
+		clear() {
+			entries.clear();
+		},
+		get size() {
+			return entries.size;
+		},
+	});
+}

package/shared/studio-side-question-context.js

@@ -1,4 +1,4 @@
-import { readFileSync, readdirSync, realpathSync, statSync } from "node:fs";
+import { lstatSync, readFileSync, readdirSync, realpathSync, statSync } from "node:fs";
 import { basename, dirname, extname, isAbsolute, join, relative, resolve } from "node:path";
 
 export const STUDIO_SIDE_CONTEXT_MAX_FILE_BYTES = 5_000_000;
@@ -53,8 +53,21 @@ export function resolveStudioSideQuestionRoot(pathInput, fallbackCwd) {
 	return stats.isDirectory() ? real : dirname(real);
 }
 
+export function assertStudioSideQuestionRootStable(rootPath) {
+	const requested = resolve(String(rootPath || ""));
+	if (lstatSync(requested).isSymbolicLink()) {
+		throw new Error("The selected side-question context root changed or now resolves to another folder.");
+	}
+	const currentReal = realpathSync(requested);
+	if (currentReal !== requested) {
+		throw new Error("The selected side-question context root changed or now resolves to another folder.");
+	}
+	if (!statSync(currentReal).isDirectory()) throw new Error("The selected side-question context root is no longer a folder.");
+	return currentReal;
+}
+
 export function resolveStudioSideQuestionPath(rootPath, pathInput, options = {}) {
-	const rootReal = realpathSync(rootPath);
+	const rootReal = assertStudioSideQuestionRootStable(rootPath);
 	const raw = String(pathInput || "").trim().replace(/^@/, "");
 	if (!raw || /^[a-z][a-z0-9+.-]*:\/\//i.test(raw)) throw new Error("Use a local path inside the selected context root.");
 	const candidate = isAbsolute(raw) ? raw : resolve(rootReal, raw);
@@ -76,7 +89,7 @@ function classifyContextPath(filePath) {
 }
 
 export function listStudioSideQuestionContext(rootPath, options = {}) {
-	const root = realpathSync(rootPath);
+	const root = assertStudioSideQuestionRootStable(rootPath);
 	const maxFiles = Math.max(1, Math.min(1_000, Math.floor(Number(options.maxFiles) || 400)));
 	const maxDirs = Math.max(1, Math.min(1_000, Math.floor(Number(options.maxDirs) || 500)));
 	const maxDepth = Math.max(0, Math.min(12, Math.floor(Number(options.maxDepth) || 8)));
@@ -177,7 +190,7 @@ export function sliceStudioSideQuestionExtractedText(text, options = {}) {
 
 export function searchStudioSideQuestionContext(rootPath, queryInput, options = {}) {
 	if (options.signal?.aborted) throw new Error("Local context search was cancelled.");
-	const root = realpathSync(rootPath);
+	const root = assertStudioSideQuestionRootStable(rootPath);
 	const query = String(queryInput || "").trim();
 	if (!query) throw new Error("Search query is empty.");
 	if (query.length > 500) throw new Error("Search query is too long.");