pi-squire 0.18.3 → 0.18.4

package/CHANGELOG.md

@@ -6,6 +6,18 @@ follows [Semantic Versioning](https://semver.org/).
 
 ## [Unreleased]
 
+## [0.18.4] - 2026-11-02
+
+### Fixed
+
+- Fresh-session owner discovery no longer warns that tmux could not be asked
+  when tmux answered but a busy startup held its answer past the 200 ms notice
+  budget. Discovery now runs after `session_start` returns instead of holding
+  it, the tmux listing is bounded by the tmux client's own timeout, and the
+  200 ms budget covers only the registry scan after it. The warning now carries
+  tmux's error message, and the newest-tree sort reads each registry's
+  modification time once. Tests that read discovery notices now wait for them.
+
 ## [0.18.3] - 2026-11-01
 
 ### Changed
@@ -1060,7 +1072,8 @@ author's dotfiles; the changes below are against that copy.
 
 - The published file list includes `child.ts`, which `index.ts` imports.
 
-[Unreleased]: https://github.com/gvanderclay/pi-squire/compare/v0.18.3...HEAD
+[Unreleased]: https://github.com/gvanderclay/pi-squire/compare/v0.18.4...HEAD
+[0.18.4]: https://github.com/gvanderclay/pi-squire/compare/v0.18.3...v0.18.4
 [0.18.3]: https://github.com/gvanderclay/pi-squire/compare/v0.18.2...v0.18.3
 [0.18.2]: https://github.com/gvanderclay/pi-squire/compare/v0.18.1...v0.18.2
 [0.18.1]: https://github.com/gvanderclay/pi-squire/compare/v0.18.0...v0.18.1

package/README.md

@@ -329,10 +329,13 @@ this agent directory's newest **64** registry files, and only entries using its
 current session-storage directory. It reports at most **10** direct owners with
 positively matched live windows and explains reopening the owning session (or
 returning to its existing owner). Registry-content reads are limited to 1 MiB
-per tree and one **200 ms total cooperative notice budget**, including the tmux
-wait, with registry lock waits capped at the remaining budget or 20 ms. The scan
-yields between trees and reports unavailable tmux, unreadable owner records or
-truncated scope once. Individual filesystem operations cannot be preempted.
+per tree and one **200 ms total cooperative notice budget**, which starts once
+tmux has listed its windows, with registry lock waits capped at the remaining
+budget or 20 ms. Discovery runs after `session_start` returns, so it never
+delays startup or a session switch; the tmux listing is bounded by the tmux
+client's own timeout, and a session that ends first reports nothing. The scan
+yields between trees and reports, once, a tmux failure with its message,
+unreadable owner records or truncated scope. Individual filesystem operations cannot be preempted.
 Directory names/mtimes are enumerated, but no recursive
 session search, mailbox search or other agent-directory search occurs. Exact-id
 restoration is not restricted by this notice budget.

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-squire",
-	"version": "0.18.3",
+	"version": "0.18.4",
 	"description": "Starts a delegate Pi session in a background tmux window, sends it the task over message:*, and shows the parent its result",
 	"keywords": [
 		"pi-package",

package/src/index.ts

@@ -741,13 +741,13 @@ export default function delegate(
 	pi.on("session_start", (_event, ctx) => {
 		viewContext = ctx;
 	});
-	pi.on("session_start", async (_event, ctx) => {
+	// Discovery is advisory: it runs after session_start returns, so tmux never delays startup or a session switch.
+	pi.on("session_start", (_event, ctx) => {
 		if (!identity.current() && results.list().length === 0) {
-			try {
-				await treeNotice(ctx, tmux, () => owner.active());
-			} catch (error) {
-				ctx.ui.notify(`delegate: owner discovery unavailable: ${String(error)}`, "warning");
-			}
+			const active = () => owner.active();
+			treeNotice(ctx, tmux, active).catch((error: unknown) => {
+				if (active()) ctx.ui.notify(`delegate: owner discovery unavailable: ${String(error)}`, "warning");
+			});
 		}
 	});
 	const viewResults = {

package/src/tree-notice.ts

@@ -1,4 +1,6 @@
 // Bounded discovery is a notice only. Exact-session restore never uses this budget.
+// Callers start it without awaiting, so a slow tmux never holds session_start; the
+// tmux client's own timeout bounds the listing, and the budget bounds only the scan.
 import { statSync } from "node:fs";
 import { performance } from "node:perf_hooks";
 import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
@@ -6,7 +8,6 @@ import { findSession } from "./result-sessions.ts";
 import { ownerDetails, sessionIsOwned } from "./session-owner.ts";
 import type { TmuxClient, TmuxWindow } from "./tmux.ts";
 import { listTreeRoots, readTree, type TreeEntry, treePath } from "./tree-registry.ts";
-import { listWindows } from "./windows.ts";
 
 export const NOTICE_TREES = 64;
 export const NOTICE_OWNERS = 10;
@@ -16,21 +17,15 @@ export async function treeNotice(
 	tmux: TmuxClient,
 	active: () => boolean = () => true,
 ): Promise<void> {
-	const deadline: number = performance.now() + NOTICE_MS;
 	const session: string = ctx.sessionManager.getSessionId();
 	const dir: string = ctx.sessionManager.getSessionDir();
 	const roots: string[] = listTreeRoots().filter((root) => root !== session);
-	const newest: string[] = roots.sort((a, b) => modified(b) - modified(a)).slice(0, NOTICE_TREES);
+	const newest: string[] = newestRoots(roots);
 	if (!newest.length) return;
-	const windows: TmuxWindow[] | undefined = await noticeWindows(tmux, deadline);
-	if (!active()) return;
-	if (!windows) {
-		ctx.ui.notify(
-			"delegate: owner discovery unavailable: tmux could not be asked within the total notice budget; no absence or ownership was inferred.",
-			"warning",
-		);
-		return;
-	}
+	const windows: TmuxWindow[] | undefined = await noticeWindows(ctx, tmux, active);
+	if (!windows || !active()) return;
+	// The scan budget starts once tmux has answered.
+	const deadline: number = performance.now() + NOTICE_MS;
 	const owners: Map<string, TreeEntry> = new Map();
 	let unavailable = 0,
 		scanned = 0,
@@ -73,17 +68,30 @@ function reportOwners(ctx: ExtensionContext, dir: string, owners: Map<string, Tr
 	}
 	return ownerErrors;
 }
-async function noticeWindows(tmux: TmuxClient, deadline: number): Promise<TmuxWindow[] | undefined> {
-	let timer: ReturnType<typeof setTimeout> | undefined;
+/** The newest roots first; each tree is stat'ed once, not on every sort comparison. */
+function newestRoots(roots: string[]): string[] {
+	return roots
+		.map((root) => ({ root, mtime: modified(root) }))
+		.sort((a, b) => b.mtime - a.mtime)
+		.slice(0, NOTICE_TREES)
+		.map(({ root }) => root);
+}
+/** tmux's windows, or undefined after warning (while still active) that tmux failed. */
+async function noticeWindows(
+	ctx: ExtensionContext,
+	tmux: TmuxClient,
+	active: () => boolean,
+): Promise<TmuxWindow[] | undefined> {
 	try {
-		return await Promise.race([
-			listWindows(tmux),
-			new Promise<undefined>((resolve) => {
-				timer = setTimeout(() => resolve(undefined), remaining(deadline));
-			}),
-		]);
-	} finally {
-		if (timer) clearTimeout(timer);
+		return await tmux.listWindows();
+	} catch (error) {
+		if (!active()) return undefined;
+		const reason: string = error instanceof Error ? error.message : String(error);
+		ctx.ui.notify(
+			`delegate: owner discovery unavailable: tmux could not be asked: ${reason}; no absence or ownership was inferred.`,
+			"warning",
+		);
+		return undefined;
 	}
 }
 function remaining(deadline: number): number {