pi-squire 0.18.2 → 0.18.4

package/CHANGELOG.md

@@ -6,6 +6,29 @@ follows [Semantic Versioning](https://semver.org/).
 
 ## [Unreleased]
 
+## [0.18.4] - 2026-11-02
+
+### Fixed
+
+- Fresh-session owner discovery no longer warns that tmux could not be asked
+  when tmux answered but a busy startup held its answer past the 200 ms notice
+  budget. Discovery now runs after `session_start` returns instead of holding
+  it, the tmux listing is bounded by the tmux client's own timeout, and the
+  200 ms budget covers only the registry scan after it. The warning now carries
+  tmux's error message, and the newest-tree sort reads each registry's
+  modification time once. Tests that read discovery notices now wait for them.
+
+## [0.18.3] - 2026-11-01
+
+### Changed
+
+- Model-facing delegate completion messages link the task copy instead of
+  quoting it, omit the workspace launch summary, and keep only the checkout
+  summary without path categories. Result bodies, errors, identity and file
+  pointers are unchanged. Task previews, workspace facts, and full snapshots
+  remain in saved message details and the expanded view. Tests that pinned the
+  previous model-facing wording now assert this shorter projection.
+
 ## [0.18.2] - 2026-11-01
 
 ### Fixed
@@ -1049,7 +1072,9 @@ author's dotfiles; the changes below are against that copy.
 
 - The published file list includes `child.ts`, which `index.ts` imports.
 
-[Unreleased]: https://github.com/gvanderclay/pi-squire/compare/v0.18.2...HEAD
+[Unreleased]: https://github.com/gvanderclay/pi-squire/compare/v0.18.4...HEAD
+[0.18.4]: https://github.com/gvanderclay/pi-squire/compare/v0.18.3...v0.18.4
+[0.18.3]: https://github.com/gvanderclay/pi-squire/compare/v0.18.2...v0.18.3
 [0.18.2]: https://github.com/gvanderclay/pi-squire/compare/v0.18.1...v0.18.2
 [0.18.1]: https://github.com/gvanderclay/pi-squire/compare/v0.18.0...v0.18.1
 [0.18.0]: https://github.com/gvanderclay/pi-squire/compare/v0.17.0...v0.18.0

package/README.md

@@ -76,7 +76,7 @@ Then, from a Pi session running in tmux, hand it a task:
 
 A detached tmux window named `scout-first` opens in your working directory.
 When the delegate finishes, its answer reaches the parent as one `[delegate]`
-message that quotes the task (see [Results](#results)), and the delegate then
+message that links the task copy (see [Results](#results)), and the delegate then
 closes its own window ([auto-exit](#auto-exit)).
 
 `/delegate` with no arguments opens a form instead: pick an agent, write the
@@ -329,10 +329,13 @@ this agent directory's newest **64** registry files, and only entries using its
 current session-storage directory. It reports at most **10** direct owners with
 positively matched live windows and explains reopening the owning session (or
 returning to its existing owner). Registry-content reads are limited to 1 MiB
-per tree and one **200 ms total cooperative notice budget**, including the tmux
-wait, with registry lock waits capped at the remaining budget or 20 ms. The scan
-yields between trees and reports unavailable tmux, unreadable owner records or
-truncated scope once. Individual filesystem operations cannot be preempted.
+per tree and one **200 ms total cooperative notice budget**, which starts once
+tmux has listed its windows, with registry lock waits capped at the remaining
+budget or 20 ms. Discovery runs after `session_start` returns, so it never
+delays startup or a session switch; the tmux listing is bounded by the tmux
+client's own timeout, and a session that ends first reports nothing. The scan
+yields between trees and reports, once, a tmux failure with its message,
+unreadable owner records or truncated scope. Individual filesystem operations cannot be preempted.
 Directory names/mtimes are enumerated, but no recursive
 session search, mailbox search or other agent-directory search occurs. Exact-id
 restoration is not restricted by this notice budget.
@@ -1450,16 +1453,9 @@ the parent one message labelled delegate output:
 ```
 [delegate] Result from scout (provider/model), delegation <id>, request <request id>.
 Status: done
-Task, quoted from <sent/ copy>:
-> the task
+Task: <sent/ copy>
 Working directory: <the directory its window opened in>
-Workspace: <how the directory was chosen and its Git checkout at launch>
 Checkout when the result arrived: <branch, head, launch commit, commits since launch, clean or dirty>
-  committed since launch: <paths>
-  staged: <paths>
-  unstaged: <paths>
-  untracked: <paths>
-  conflicted: <paths>
 Envelope: <cur/ path>
 Delegate session: <session file or id>
 
@@ -1501,19 +1497,22 @@ Delegate session: <session file or id>
   delegations skip it.` (a model scope reads `on model provider/id`; a mark
   that has since cleared reads `it was marked until …`). A failed reply with
   no such mark is unchanged.
-- The task is quoted from the request copy the provider puts on the payload,
-  capped at 2 KiB with the copy's `sent/` path. A request with no copy is
-  named by id alone.
+- `Task:` points to the full request copy in `sent/`. The message details
+  and expanded view retain a task preview capped at 2 KiB. A request with no
+  copy gets a diagnostic with its request id.
 - The working directory is the one recorded at launch, or
-  `unknown (not recorded)` for a delegation recorded before it was kept. The
-  `Workspace:` line repeats the recorded [workspace](#working-directory), and
-  is left out for records from before it was kept; the closed-without-a-result
-  message carries the same two lines.
-- `Checkout when the result arrived:` is the [snapshot](#checkout-snapshots)
-  taken as the reply was claimed, also recorded with the result and in the
-  message details and expanded view. The reply is claimed first, so a slow or
-  failing Git cannot lose or duplicate it; the snapshot is then unknown. A
-  non-Git directory reads `not a Git checkout`.
+  `unknown (not recorded)` for a delegation recorded before it was kept.
+  The recorded [workspace](#working-directory) remains in message details
+  and the expanded view, but the model-facing result omits its launch summary.
+  Closed-without-a-result messages still include that summary when recorded.
+- `Checkout when the result arrived:` summarizes the
+  [snapshot](#checkout-snapshots) taken as the reply was claimed. Git summaries
+  keep the branch or detached HEAD, full head and launch commit, commits since
+  launch, and working-tree state. Path categories remain in the saved snapshot,
+  message details, and expanded view, not the model-facing result.
+  The reply is claimed first, so a slow or failing Git cannot lose or duplicate
+  it. An unknown snapshot includes the reason. A non-Git directory reads
+  `not a Git checkout`.
 - The envelope path is the claimed reply in the parent's `cur/`; the
   delegate's session path is found by the delegation id in the session
   directory recorded at launch (the parent's current one for older records),

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-squire",
-	"version": "0.18.2",
+	"version": "0.18.4",
 	"description": "Starts a delegate Pi session in a background tmux window, sends it the task over message:*, and shows the parent its result",
 	"keywords": [
 		"pi-package",

package/src/index.ts

@@ -741,13 +741,13 @@ export default function delegate(
 	pi.on("session_start", (_event, ctx) => {
 		viewContext = ctx;
 	});
-	pi.on("session_start", async (_event, ctx) => {
+	// Discovery is advisory: it runs after session_start returns, so tmux never delays startup or a session switch.
+	pi.on("session_start", (_event, ctx) => {
 		if (!identity.current() && results.list().length === 0) {
-			try {
-				await treeNotice(ctx, tmux, () => owner.active());
-			} catch (error) {
-				ctx.ui.notify(`delegate: owner discovery unavailable: ${String(error)}`, "warning");
-			}
+			const active = () => owner.active();
+			treeNotice(ctx, tmux, active).catch((error: unknown) => {
+				if (active()) ctx.ui.notify(`delegate: owner discovery unavailable: ${String(error)}`, "warning");
+			});
 		}
 	});
 	const viewResults = {

package/src/result-message.ts

@@ -1,6 +1,6 @@
 // The text and details of the one message the parent receives for a settled delegation.
 import { readMarks } from "./limits.ts";
-import { cwdLine, modelLabel, snapshotLines, workspaceLine } from "./render.ts";
+import { cwdLine, modelLabel, snapshotLines } from "./render.ts";
 import { sessionIdOf } from "./result-sessions.ts";
 import type { StartedRecorded } from "./result-types.ts";
 import type { Inbound, MessageDetails, TaskQuote } from "./results.ts";
@@ -88,29 +88,21 @@ export function resultDetails(
 	};
 }
 
-/** The snapshot lines of the result text: a heading line, then its path lists indented. */
 function checkoutText(snapshot: WorkspaceSnapshot): string[] {
-	const [first, ...rest] = snapshotLines(snapshot);
-	return [`Checkout when the result arrived: ${first}`, ...rest.map((line) => `  ${line}`)];
+	const [first] = snapshotLines(snapshot);
+	return [`Checkout when the result arrived: ${first}`];
 }
 
 /** The one message the parent model reads for a settled delegation. */
 export function resultText(details: ResultDetails): string {
 	const { task } = details;
-	const quote =
-		"note" in task
-			? task.note
-			: `Task, quoted from ${task.path}:\n${task.text
-					.split("\n")
-					.map((line) => `> ${line}`)
-					.join("\n")}`;
+	const taskLine = "note" in task ? task.note : `Task: ${task.path}`;
 	return [
 		`[delegate] Result from ${details.agent} (${modelLabel(details.model, details.finishedModel)}), delegation ${details.id}${details.resumedFrom === undefined ? "" : ` (resumed from ${details.resumedFrom})`}, request ${details.requestId}.`,
 		`Status: ${details.status}`,
 		...(details.limit === undefined ? [] : [details.limit]),
-		quote,
+		taskLine,
 		`Working directory: ${cwdLine(details.cwd)}`,
-		...(details.workspace === undefined ? [] : [`Workspace: ${workspaceLine(details.workspace)}`]),
 		...(details.workspaceSnapshot === undefined ? [] : checkoutText(details.workspaceSnapshot)),
 		`Envelope: ${details.envelopePath}`,
 		`Delegate session: ${details.sessionPath ?? details.sessionId ?? details.id}`,

package/src/tree-notice.ts

@@ -1,4 +1,6 @@
 // Bounded discovery is a notice only. Exact-session restore never uses this budget.
+// Callers start it without awaiting, so a slow tmux never holds session_start; the
+// tmux client's own timeout bounds the listing, and the budget bounds only the scan.
 import { statSync } from "node:fs";
 import { performance } from "node:perf_hooks";
 import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
@@ -6,7 +8,6 @@ import { findSession } from "./result-sessions.ts";
 import { ownerDetails, sessionIsOwned } from "./session-owner.ts";
 import type { TmuxClient, TmuxWindow } from "./tmux.ts";
 import { listTreeRoots, readTree, type TreeEntry, treePath } from "./tree-registry.ts";
-import { listWindows } from "./windows.ts";
 
 export const NOTICE_TREES = 64;
 export const NOTICE_OWNERS = 10;
@@ -16,21 +17,15 @@ export async function treeNotice(
 	tmux: TmuxClient,
 	active: () => boolean = () => true,
 ): Promise<void> {
-	const deadline: number = performance.now() + NOTICE_MS;
 	const session: string = ctx.sessionManager.getSessionId();
 	const dir: string = ctx.sessionManager.getSessionDir();
 	const roots: string[] = listTreeRoots().filter((root) => root !== session);
-	const newest: string[] = roots.sort((a, b) => modified(b) - modified(a)).slice(0, NOTICE_TREES);
+	const newest: string[] = newestRoots(roots);
 	if (!newest.length) return;
-	const windows: TmuxWindow[] | undefined = await noticeWindows(tmux, deadline);
-	if (!active()) return;
-	if (!windows) {
-		ctx.ui.notify(
-			"delegate: owner discovery unavailable: tmux could not be asked within the total notice budget; no absence or ownership was inferred.",
-			"warning",
-		);
-		return;
-	}
+	const windows: TmuxWindow[] | undefined = await noticeWindows(ctx, tmux, active);
+	if (!windows || !active()) return;
+	// The scan budget starts once tmux has answered.
+	const deadline: number = performance.now() + NOTICE_MS;
 	const owners: Map<string, TreeEntry> = new Map();
 	let unavailable = 0,
 		scanned = 0,
@@ -73,17 +68,30 @@ function reportOwners(ctx: ExtensionContext, dir: string, owners: Map<string, Tr
 	}
 	return ownerErrors;
 }
-async function noticeWindows(tmux: TmuxClient, deadline: number): Promise<TmuxWindow[] | undefined> {
-	let timer: ReturnType<typeof setTimeout> | undefined;
+/** The newest roots first; each tree is stat'ed once, not on every sort comparison. */
+function newestRoots(roots: string[]): string[] {
+	return roots
+		.map((root) => ({ root, mtime: modified(root) }))
+		.sort((a, b) => b.mtime - a.mtime)
+		.slice(0, NOTICE_TREES)
+		.map(({ root }) => root);
+}
+/** tmux's windows, or undefined after warning (while still active) that tmux failed. */
+async function noticeWindows(
+	ctx: ExtensionContext,
+	tmux: TmuxClient,
+	active: () => boolean,
+): Promise<TmuxWindow[] | undefined> {
 	try {
-		return await Promise.race([
-			listWindows(tmux),
-			new Promise<undefined>((resolve) => {
-				timer = setTimeout(() => resolve(undefined), remaining(deadline));
-			}),
-		]);
-	} finally {
-		if (timer) clearTimeout(timer);
+		return await tmux.listWindows();
+	} catch (error) {
+		if (!active()) return undefined;
+		const reason: string = error instanceof Error ? error.message : String(error);
+		ctx.ui.notify(
+			`delegate: owner discovery unavailable: tmux could not be asked: ${reason}; no absence or ownership was inferred.`,
+			"warning",
+		);
+		return undefined;
 	}
 }
 function remaining(deadline: number): number {