pi-squad 0.1.0 → 0.4.14

package/src/panel/message-view.ts

@@ -1,21 +1,26 @@
 /**
  * message-view.ts — Scrollable message log for a task.
- * Shows tool calls, agent text, @mentions, human messages.
+ * All lines truncated to width. Caps rendered messages to prevent
+ * TUI corruption from large message histories.
  */
 
 import type { Theme } from "@mariozechner/pi-coding-agent";
+import { truncateToWidth } from "@mariozechner/pi-tui";
 import type { TaskMessage } from "../types.js";
 import * as store from "../store.js";
 
-// ============================================================================
-// Message View
-// ============================================================================
+/** Max messages to render (most recent). Older messages are skipped. */
+const MAX_MESSAGES = 30;
+/** Max lines per text message before truncation */
+const MAX_TEXT_LINES = 5;
 
 export class MessageView {
 	private theme: Theme;
 	private squadId: string;
 	private taskId: string | null = null;
 	private scrollOffset = 0;
+	/** Track if user has manually scrolled up */
+	private userScrolled = false;
 
 	constructor(theme: Theme, squadId: string) {
 		this.theme = theme;
@@ -25,6 +30,7 @@ export class MessageView {
 	setTaskId(taskId: string): void {
 		this.taskId = taskId;
 		this.scrollOffset = 0;
+		this.userScrolled = false;
 	}
 
 	getTaskId(): string | null {
@@ -33,200 +39,169 @@ export class MessageView {
 
 	scrollUp(): void {
 		this.scrollOffset = Math.max(0, this.scrollOffset - 1);
+		this.userScrolled = true;
 	}
 
 	scrollDown(): void {
 		this.scrollOffset++;
+		// Will be clamped in render
 	}
 
-	invalidate(): void {
-		/* stateless */
-	}
+	invalidate(): void {}
 
 	render(width: number, maxLines: number): string[] {
 		const th = this.theme;
+		const w = Math.max(10, width);
 
 		if (!this.taskId) {
-			return this.padToHeight(["", th.fg("muted", "  No task selected")], maxLines);
+			return pad(["", th.fg("muted", "  No task selected")], maxLines);
 		}
 
 		const task = store.loadTask(this.squadId, this.taskId);
 		if (!task) {
-			return this.padToHeight(["", th.fg("error", "  Task not found")], maxLines);
+			return pad(["", th.fg("error", "  Task not found")], maxLines);
 		}
 
-		const messages = store.loadMessages(this.squadId, this.taskId);
-		const lines: string[] = [];
+		const allMessages = store.loadMessages(this.squadId, this.taskId);
 
-		// Header: task info
+		// Header (fixed, always visible)
+		const header: string[] = [];
 		const statusColor = task.status === "done" ? "success"
 			: task.status === "failed" ? "error"
 			: task.status === "in_progress" ? "warning"
 			: "muted";
-		lines.push(` ${th.fg("accent", th.bold(task.id))} · ${th.fg("dim", task.agent)} ${th.fg(statusColor as any, task.status)}`);
-		lines.push(` ${th.fg("dim", task.title.slice(0, width - 2))}`);
-		lines.push("");
+		header.push(fit(` ${th.fg("accent", th.bold(task.id))} · ${th.fg("dim", task.agent)} ${th.fg(statusColor as any, task.status)}`, w));
+		header.push(fit(` ${th.fg("dim", task.title)}`, w));
+		header.push("");
 
-		if (messages.length === 0) {
-			lines.push(th.fg("muted", "  No messages yet"));
-			return this.padToHeight(lines, maxLines);
+		if (allMessages.length === 0) {
+			header.push(th.fg("muted", "  No messages yet"));
+			return pad(header, maxLines);
 		}
 
-		// Render messages
-		const msgLines = this.renderMessages(messages, width);
+		// Only render recent messages to prevent TUI overload
+		const messages = allMessages.slice(-MAX_MESSAGES);
+		const skipped = allMessages.length - messages.length;
 
-		// Apply scroll
-		const contentHeight = maxLines - lines.length - 1;
+		const msgLines: string[] = [];
+		if (skipped > 0) {
+			msgLines.push(fit(th.fg("dim", ` ··· ${skipped} older messages ···`), w));
+			msgLines.push("");
+		}
+		msgLines.push(...this.renderMessages(messages, w));
+
+		// Fixed layout: header + scrollable content + status line = maxLines exactly
+		const statusLines = 1; // always show status/scroll bar
+		const contentHeight = Math.max(1, maxLines - header.length - statusLines);
 		const maxScroll = Math.max(0, msgLines.length - contentHeight);
-		this.scrollOffset = Math.min(this.scrollOffset, maxScroll);
-		// Auto-scroll to bottom if near the end
-		if (this.scrollOffset >= maxScroll - 2) {
+
+		// Auto-scroll to bottom unless user scrolled up
+		if (!this.userScrolled) {
 			this.scrollOffset = maxScroll;
+		} else {
+			this.scrollOffset = Math.min(this.scrollOffset, maxScroll);
+			if (this.scrollOffset >= maxScroll) {
+				this.userScrolled = false;
+			}
 		}
 
+		// Build output — exact height every time
+		const lines = [...header];
+
+		// Content area: pad to exact contentHeight
 		const visible = msgLines.slice(this.scrollOffset, this.scrollOffset + contentHeight);
-		lines.push(...visible);
+		while (visible.length < contentHeight) visible.push("");
+		lines.push(...visible.slice(0, contentHeight));
 
-		// Scroll indicator
-		if (msgLines.length > contentHeight) {
-			const pos = maxScroll > 0 ? Math.round((this.scrollOffset / maxScroll) * 100) : 100;
-			lines.push(th.fg("dim", ` ─── ${pos}% ───`));
-		}
+		// Status bar (always present, keeps layout stable)
+		const pct = maxScroll > 0 ? Math.round((this.scrollOffset / maxScroll) * 100) : 100;
+		const scrollInfo = maxScroll > 0
+			? th.fg("dim", ` ─ ${pct}% ─ ${allMessages.length} msgs ─ ↑↓ scroll`)
+			: th.fg("dim", ` ─ ${allMessages.length} msgs`);
+		lines.push(fit(scrollInfo, w));
 
-		return this.padToHeight(lines, maxLines);
+		// Strict: return exactly maxLines
+		return lines.slice(0, maxLines);
 	}
 
-	// =========================================================================
-	// Message Rendering
-	// =========================================================================
-
 	private renderMessages(messages: TaskMessage[], width: number): string[] {
 		const th = this.theme;
 		const lines: string[] = [];
 		let lastFrom: string | null = null;
 
 		for (const msg of messages) {
-			// Skip system status messages that are noise
-			if (msg.type === "status" && msg.from === "system" && msg.text === "Agent starting work") {
-				continue;
-			}
+			if (msg.type === "status" && msg.from === "system" && msg.text === "Agent starting work") continue;
 
-			// Group consecutive messages from the same sender
 			const showHeader = msg.from !== lastFrom;
 			lastFrom = msg.from;
 
 			if (showHeader) {
-				// Blank line between different senders
 				if (lines.length > 0) lines.push("");
-
-				// Sender header with timestamp
-				const time = this.formatTime(msg.ts);
-				const senderColor = this.getSenderColor(msg.from);
-				const senderName = msg.from === "human" ? "YOU" : msg.from;
-				lines.push(` ${th.fg("dim", time)} ${th.fg(senderColor as any, senderName)}`);
+				const time = fmtTime(msg.ts);
+				const color = msg.from === "human" ? "accent" : msg.from === "system" ? "dim" : "success";
+				const name = msg.from === "human" ? "YOU" : msg.from;
+				lines.push(fit(` ${th.fg("dim", time)} ${th.fg(color as any, name)}`, width));
 			}
 
-			// Message content
 			switch (msg.type) {
 				case "tool": {
-					const toolName = msg.name || msg.text;
-					const argsStr = msg.args?.path || msg.args?.command || "";
-					const preview = argsStr
-						? `→ ${toolName} ${argsStr}`
-						: `→ ${toolName}`;
-					lines.push(`   ${th.fg("muted", preview.slice(0, width - 4))}`);
+					const name = msg.name || msg.text;
+					// Tool args can contain multi-line bash commands — take first line only
+					const rawArg = (msg.args?.path || msg.args?.command || "").toString();
+					const arg = rawArg.split("\n")[0];
+					lines.push(fit(`   ${th.fg("muted", `→ ${name}${arg ? " " + arg : ""}`)}`, width));
 					break;
 				}
-
 				case "mention": {
-					const target = msg.to ? `→ ${msg.to}` : "";
-					lines.push(`   ${th.fg("accent", `@${msg.to || "?"}`)} ${th.fg("dim", msg.text.slice(0, width - 10))}`);
+					lines.push(fit(`   ${th.fg("accent", `@${msg.to || "?"}`)} ${th.fg("dim", msg.text)}`, width));
 					break;
 				}
-
 				case "text":
 				case "message":
 				case "reply": {
-					// Wrap long text
-					const textLines = this.wrapText(msg.text, width - 4);
-					for (const textLine of textLines.slice(0, 10)) {
-						lines.push(`   ${textLine}`);
+					// Split text, strip any \r, ensure no embedded newlines survive
+					const textLines = msg.text.replace(/\r/g, "").split("\n");
+					const show = textLines.slice(0, MAX_TEXT_LINES);
+					for (const tl of show) {
+						lines.push(fit(`   ${tl}`, width));
 					}
-					if (textLines.length > 10) {
-						lines.push(`   ${th.fg("dim", `... +${textLines.length - 10} lines`)}`);
+					if (textLines.length > MAX_TEXT_LINES) {
+						lines.push(fit(`   ${th.fg("dim", `... +${textLines.length - MAX_TEXT_LINES} lines`)}`, width));
 					}
 					break;
 				}
-
-				case "done": {
-					lines.push(`   ${th.fg("success", "✓ " + msg.text.slice(0, width - 6))}`);
+				case "done":
+					lines.push(fit(`   ${th.fg("success", "✓ " + msg.text)}`, width));
 					break;
-				}
-
-				case "error": {
-					lines.push(`   ${th.fg("error", "✗ " + msg.text.slice(0, width - 6))}`);
+				case "error":
+					lines.push(fit(`   ${th.fg("error", "✗ " + msg.text)}`, width));
 					break;
-				}
-
-				case "status": {
-					lines.push(`   ${th.fg("dim", msg.text.slice(0, width - 4))}`);
+				case "status":
+					lines.push(fit(`   ${th.fg("dim", msg.text)}`, width));
 					break;
-				}
 			}
 		}
 
 		return lines;
 	}
+}
 
-	// =========================================================================
-	// Helpers
-	// =========================================================================
-
-	private getSenderColor(from: string): string {
-		if (from === "human") return "accent";
-		if (from === "system") return "dim";
-		// Rotate through available colors for different agents
-		const colors = ["success", "warning", "accent", "muted"];
-		let hash = 0;
-		for (const c of from) hash = (hash * 31 + c.charCodeAt(0)) & 0x7fffffff;
-		return colors[hash % colors.length];
-	}
-
-	private formatTime(ts: string): string {
-		try {
-			const d = new Date(ts);
-			const h = d.getHours().toString().padStart(2, "0");
-			const m = d.getMinutes().toString().padStart(2, "0");
-			return `${h}:${m}`;
-		} catch {
-			return "??:??";
-		}
-	}
+function fit(line: string, width: number): string {
+	// Strip any newlines that would create extra terminal lines and break layout math
+	const clean = line.replace(/[\n\r]/g, " ");
+	return truncateToWidth(clean, width, "…");
+}
 
-	private wrapText(text: string, maxWidth: number): string[] {
-		const lines: string[] = [];
-		for (const rawLine of text.split("\n")) {
-			if (rawLine.length <= maxWidth) {
-				lines.push(rawLine);
-			} else {
-				// Simple word wrap
-				let remaining = rawLine;
-				while (remaining.length > maxWidth) {
-					const breakAt = remaining.lastIndexOf(" ", maxWidth);
-					const splitAt = breakAt > maxWidth * 0.3 ? breakAt : maxWidth;
-					lines.push(remaining.slice(0, splitAt));
-					remaining = remaining.slice(splitAt).trimStart();
-				}
-				if (remaining) lines.push(remaining);
-			}
-		}
-		return lines;
-	}
+function pad(lines: string[], max: number): string[] {
+	while (lines.length < max) lines.push("");
+	return lines.slice(0, max);
+}
 
-	private padToHeight(lines: string[], maxLines: number): string[] {
-		while (lines.length < maxLines) {
-			lines.push("");
-		}
-		return lines.slice(0, maxLines);
+function fmtTime(ts: string): string {
+	try {
+		const d = new Date(ts);
+		return `${d.getHours().toString().padStart(2, "0")}:${d.getMinutes().toString().padStart(2, "0")}`;
+	} catch {
+		return "??:??";
 	}
 }