pi-soly 1.11.2 → 1.12.1

package/commands.ts

@@ -9,6 +9,7 @@
 //                    subcommands: position, state, plan, context, research, roadmap,
 //                                 progress, phases, tasks, task <id>, features,
 //                                 milestone, reload, help
+//   - /artifacts     browse this session's html_artifact gallery (list/open/clear)
 //   - /rulewizard    interactive guide for rule vs .editorconfig vs linter
 //   - /why           show rules + project state that grounded the last turn
 //
@@ -18,7 +19,8 @@
 
 import * as path from "node:path";
 import * as fs from "node:fs";
-import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
+import { platform } from "node:os";
+import type { ExtensionAPI, ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
 import {
 	analyzeRules,
 	buildProgressBar,
@@ -43,8 +45,8 @@ import {
 import type { SolyConfig } from "./config.ts";
 import { migrateSolyDir } from "./migrate.js";
 import { initSolyProject } from "./init.js";
-import { readNotifications, formatNotifications } from "./notifications-log.js";
-import { formatStatus } from "./status.js";
+import { ListPanel, type ListItem, type ListAction } from "./visual/list-panel.ts";
+import { getArtifactServer, ensureArtifactServer, artifactDir } from "./artifact/session.ts";
 
 /** Minimum ui surface the command handlers actually need. */
 export interface CommandUI {
@@ -65,6 +67,68 @@ export interface CommandsDeps {
 	getIntentDocs: () => IntentDoc[];
 }
 
+/** Open a focused list modal (overlay) for the given items + actions. */
+async function openListPanel(
+	ctx: ExtensionCommandContext,
+	spec: {
+		title: string;
+		headerRight?: string;
+		build: () => ListItem[];
+		actions?: ListAction[];
+		onSelect?: (item: ListItem) => void;
+	},
+): Promise<void> {
+	await ctx.ui.custom<void>(
+		(tui, theme, keybindings, done) =>
+			new ListPanel({
+				tui,
+				theme,
+				keybindings,
+				done: () => done(),
+				title: spec.title,
+				headerRight: spec.headerRight,
+				items: spec.build(),
+				actions: spec.actions,
+				refresh: spec.build,
+				onSelect: spec.onSelect,
+			}),
+		{ overlay: true },
+	);
+}
+
+/** Open a URL/file with the OS default handler (browser for http/.html). */
+async function openExternally(pi: ExtensionAPI, target: string): Promise<void> {
+	const o = platform();
+	const r =
+		o === "darwin"
+			? await pi.exec("open", [target])
+			: o === "win32"
+				? await pi.exec("cmd", ["/c", "start", "", target])
+				: await pi.exec("xdg-open", [target]);
+	if (r.code !== 0) throw new Error(r.stderr || `open failed (exit ${r.code})`);
+}
+
+/** Status marker for a rule: ● always-on · ◐ glob-matched · ○ disabled. */
+function ruleMarker(r: RuleFile): string {
+	if (!r.enabled) return "○";
+	return r.meta.always || !(r.meta.globs && r.meta.globs.length) ? "●" : "◐";
+}
+
+/** Map a rule to a panel row (token estimate + globs + description preview). */
+function ruleItem(r: RuleFile): ListItem {
+	const tokens = Math.ceil(r.body.length / 4);
+	const bits = [`${formatTok(tokens)} tok`];
+	if (r.meta.globs && r.meta.globs.length) bits.push(r.meta.globs.join(","));
+	if (!r.enabled) bits.push("off");
+	return {
+		id: r.relPath,
+		marker: ruleMarker(r),
+		label: r.relPath,
+		meta: bits.join(" · "),
+		body: r.meta.description ? `${r.meta.description}\n\n${r.body}` : r.body,
+	};
+}
+
 export function registerCommands(pi: ExtensionAPI, deps: CommandsDeps): void {
 	const {
 		getRules,
@@ -94,7 +158,8 @@ export function registerCommands(pi: ExtensionAPI, deps: CommandsDeps): void {
 				confirm: (title, message) => ctx.ui.confirm(title, message),
 			};
 			const parts = args.trim().split(/\s+/);
-			const sub = parts[0] ?? "list";
+			// Bare `/rules` (empty args) opens the modal; an explicit subcommand does not.
+			const sub = parts[0] || "list";
 			const target = parts[1];
 
 			if (sub === "list") {
@@ -104,6 +169,22 @@ export function registerCommands(pi: ExtensionAPI, deps: CommandsDeps): void {
 					ui.notify("no rules loaded from any source", "info");
 					return;
 				}
+				// Rich modal in the TUI; plain select elsewhere (RPC/print).
+				if (ctx.mode === "tui") {
+					const analytics = analyzeRules(getRules(), CONTEXT_WINDOW_TOKENS);
+					await openListPanel(ctx, {
+						title: "soly · rules",
+						headerRight: `${getRules().length} rules · ${formatTok(analytics.totalTokens)} · ${analytics.contextBudgetPct.toFixed(1)}%`,
+						build: () => getRules().map(ruleItem),
+						actions: [
+							{ key: "e", hint: "enable", run: (it) => { const r = getRules().find((x) => x.relPath === it.id); if (r) r.enabled = true; } },
+							{ key: "d", hint: "disable", run: (it) => { const r = getRules().find((x) => x.relPath === it.id); if (r) r.enabled = false; } },
+							{ key: "r", hint: "reload", run: () => refreshRules() },
+						],
+					});
+					updateStatus(ui);
+					return;
+				}
 				const lines: string[] = [];
 				for (const r of rules) {
 					const status = r.enabled ? "●" : "○";
@@ -374,7 +455,34 @@ What must the LLM do?
 				confirm: (title, message) => ctx.ui.confirm(title, message),
 			};
 			const parts = args.trim().split(/\s+/);
-			const sub = parts[0] ?? "stats";
+			// Bare `/docs` opens the modal; an explicit subcommand (e.g. stats) does not.
+			const sub = parts[0] || "list";
+
+			if (sub === "list") {
+				const docs = getIntentDocs();
+				if (docs.length === 0) {
+					ui.notify("no intent docs found in .soly/docs/ — drop your vision/domain docs there", "info");
+					return;
+				}
+				if (ctx.mode === "tui") {
+					const total = docs.reduce((s, d) => s + d.tokens, 0);
+					await openListPanel(ctx, {
+						title: "soly · docs",
+						headerRight: `${docs.length} docs · ${formatTok(total)}`,
+						build: () =>
+							getIntentDocs().map((d) => ({
+								id: d.relPath,
+								marker: "○",
+								label: d.title || d.relPath,
+								meta: `${d.kind} · ${formatTok(d.tokens)} tok${d.oversized ? " · oversized" : ""}`,
+								body: d.preview,
+							})),
+					});
+					return;
+				}
+				ui.notify(docs.map((d) => `○ ${d.title || d.relPath} (${formatTok(d.tokens)} tok)`).join("\n"), "info");
+				return;
+			}
 
 			if (sub === "stats") {
 				const docs = getIntentDocs();
@@ -385,7 +493,7 @@ What must the LLM do?
 			}
 
 			ui.notify(
-				`Usage: /docs stats — show context breakdown for intent docs\n` +
+				`Usage: /docs [list|stats] — open the docs panel, or show the context breakdown\n` +
 				`Found ${getIntentDocs().length} doc(s) loaded.`,
 				"info",
 			);
@@ -720,50 +828,158 @@ What must the LLM do?
 				},
 			};
 
+			const ICONS: Record<string, string> = {
+				position: "📍", state: "📄", plan: "📋", context: "💡",
+				research: "🔬", roadmap: "🗺️", progress: "📊",
+				phases: "📁", tasks: "✅", task: "🔎",
+				features: "⭐", milestone: "🎯", reload: "🔄", config: "⚙️",
+			};
+
+			// Short live preview shown in the modal's preview pane per subcommand.
+			const previewFor = (name: string): string => {
+				const s = getState();
+				const teaser = (p: string | null): string => (p ?? "").replace(/\s+/g, " ").slice(0, 240);
+				const phaseFile = (suffix: string) =>
+					s.currentPhase ? readIfExists(path.join(s.currentPhase.dir, `${s.currentPhase.slug}-${suffix}.md`)) : null;
+				switch (name) {
+					case "position": return s.position ? `${s.position.phase} · ${s.position.plan} · ${s.position.status} · ${s.progress.percent}%` : `${s.milestone} — no position set`;
+					case "progress": return `${s.progress.percent}% · ${s.progress.completedPhases}/${s.progress.totalPhases} phases · ${s.progress.completedPlans}/${s.progress.totalPlans} plans`;
+					case "phases": return s.phases.length ? s.phases.map((p) => `${p.number}.${p.name}`).join(" · ") : "no phases";
+					case "tasks": return s.tasks.length ? `${s.tasks.length} task(s) across ${s.features.length} feature(s)` : "no tasks";
+					case "features": return s.features.length ? s.features.map((f) => f.name).join(" · ") : "no features";
+					case "milestone": return s.milestone && s.milestone !== "—" ? String(s.milestoneName ?? s.milestone) : "no milestone set";
+					case "state": return teaser(s.stateBody) || "STATE.md not found";
+					case "roadmap": return teaser(s.roadmapBody) || "ROADMAP.md not found";
+					case "plan": return s.currentPlanPath ? teaser(readIfExists(s.currentPlanPath)) : "no current plan";
+					case "context": return s.currentPhase ? teaser(phaseFile("CONTEXT")) || "CONTEXT.md not found" : "no current phase";
+					case "research": return s.currentPhase ? teaser(phaseFile("RESEARCH")) || "RESEARCH.md not found" : "no current phase";
+					case "config": return "merged config — press ⏎ to view the JSON";
+					case "reload": return "re-read project state from disk";
+					default: return subcommands[name]?.description ?? "";
+				}
+			};
+
+			const solyItems = (): ListItem[] =>
+				Object.keys(subcommands).map((name) => ({
+					id: name,
+					marker: ICONS[name] ?? "▸",
+					label: name,
+					meta: subcommands[name]!.description,
+					body: previewFor(name),
+				}));
+
+			// Plain-select fallback for non-TUI (RPC/print) modes.
 			const picker = async (label: string) => {
 				const entries = Object.entries(subcommands);
-				const lines = entries.map(
-					([name, spec], i) => {
-						const icons: Record<string, string> = {
-							position: "📍", state: "📄", plan: "📋", context: "💡",
-							research: "🔬", roadmap: "🗺️", progress: "📊",
-							phases: "📁", tasks: "✅", task: "🔎",
-							features: "⭐", milestone: "🎯", reload: "🔄",
-							config: "⚙️",
-						};
-						const icon = icons[name] ?? "▸";
-						return `${icon} ${name} — ${spec.description}`;
-					},
-				);
+				const lines = entries.map(([name, spec]) => `${ICONS[name] ?? "▸"} ${name} — ${spec.description}`);
 				const choice = await ui.select(label, lines);
 				if (choice != null && typeof choice === "number") {
 					const name = entries[choice]?.[0];
-					if (name) {
-						await subcommands[name].run([name]);
-					}
+					if (name) await subcommands[name]!.run([name]);
 				}
 			};
 
+			const openMenu = async () => {
+				if (ctx.mode !== "tui") return picker("soly (esc to cancel):");
+				const s = getState();
+				await openListPanel(ctx, {
+					title: "soly · state",
+					headerRight: `${s.phases.length} phases · ${s.progress.percent}%`,
+					build: solyItems,
+					onSelect: (it) => {
+						void subcommands[it.id]?.run([it.id]);
+					},
+				});
+			};
+
 			const parts = args.trim().split(/\s+/).filter(Boolean);
 			const sub = parts[0] ?? "";
 
-			// /soly with no args → interactive picker with emoji + next hint
-			if (!sub) {
-				return picker("soly (esc to cancel):");
-			}
-
-			if (sub === "help" || sub === "?" || sub === "--help" || sub === "-h") {
-				return picker("soly subcommand (esc to cancel):");
+			// /soly (or help) with no specific subcommand → the modal (TUI) / picker.
+			if (!sub || sub === "help" || sub === "?" || sub === "--help" || sub === "-h") {
+				return openMenu();
 			}
 
 			if (!subcommands[sub]) {
 				ui.notify(`soly: unknown subcommand '${sub}'`, "error");
-				return picker("did you mean:");
+				return openMenu();
 			}
 
 			await subcommands[sub].run(parts);
 		},
 	});
+	// ============================================================================
+	// /artifacts — browse this session's html_artifact gallery
+	// ============================================================================
+
+	pi.registerCommand("artifacts", {
+		description: "browse this project's html_artifact gallery (list, open, clear)",
+		handler: async (args, ctx) => {
+			if (!getConfig().artifacts.server) {
+				ctx.ui.notify("soly: artifact server is disabled (artifacts.server=false)", "info");
+				return;
+			}
+			// Always re-resolve: reuse another window's server or start ours, and
+			// re-probe a stale client whose owner may have died in the meantime.
+			let server = getArtifactServer();
+			try {
+				server = await ensureArtifactServer(artifactDir(getConfig().artifacts.dir, ctx.cwd), ctx.cwd);
+			} catch {
+				// ignore — handled by the count check below
+			}
+			if (!server || server.count === 0) {
+				ctx.ui.notify("soly: no artifacts for this project yet (use the html_artifact tool)", "info");
+				return;
+			}
+			const gallery = server.galleryUrl();
+			const sub = args.trim().split(/\s+/).filter(Boolean)[0] ?? "";
+
+			if (sub === "clear") {
+				const n = server.clear();
+				ctx.ui.notify(`soly: cleared ${n} artifact(s)`, "info");
+				return;
+			}
+			if (sub === "open" || sub === "gallery") {
+				try {
+					await openExternally(pi, gallery);
+					ctx.ui.notify(`soly: opened ${gallery}`, "info");
+				} catch {
+					ctx.ui.notify(`soly artifacts gallery: ${gallery}`, "info");
+				}
+				return;
+			}
+
+			if (ctx.mode === "tui") {
+				await openListPanel(ctx, {
+					title: "soly · artifacts",
+					// BMP-only header (no long URL — it overflowed the bar). Count only.
+					headerRight: `${server.count} artifact${server.count === 1 ? "" : "s"}`,
+					build: () =>
+						(getArtifactServer()?.list() ?? []).map((a) => ({
+							id: a.id,
+							marker: "▦", // BMP glyph — an astral emoji (🖼) breaks ListPanel width
+							label: a.title,
+							meta: new Date(a.createdAt).toLocaleTimeString(),
+							body: a.url,
+						})),
+					onSelect: (it) => {
+						const a = getArtifactServer()?.list().find((x) => x.id === it.id);
+						if (a) void openExternally(pi, a.url);
+					},
+					actions: [
+						{ key: "g", hint: "gallery", run: () => void openExternally(pi, gallery) },
+						{ key: "x", hint: "delete", run: (it) => { getArtifactServer()?.remove(it.id); } },
+					],
+				});
+				return;
+			}
+
+			// Non-TUI: print the list + gallery URL.
+			const lines = server.list().map((a) => `🖼 ${a.title} — ${a.url}`);
+			ctx.ui.notify([`soly artifacts gallery: ${gallery}`, "", ...lines].join("\n"), "info");
+		},
+	});
+
 	// ============================================================================
 	// /rulewizard
 	// ============================================================================

package/config.ts

@@ -35,11 +35,16 @@ export interface SolyConfig {
 		preferAskPro: boolean;
 		/** When soly pause is invoked, also auto-save HANDOFF.json (currently always true; knob for future). */
 		autoCheckpointOnPause: boolean;
-		/** DEPRECATED in 1.3.0. Soly no longer ships a subagent. The LLM
-		 *  executes plans directly using the slash commands + the
-		 *  soly-framework skill. This option is kept as a no-op for
-		 *  backward compat with old config files. */
-		useSolyWorkerSubagents: boolean;
+		/** Show the soft "non-trivial / research" nudge as a chat box. Default off
+		 *  (it was noisy). The system-prompt nudge guides the LLM regardless. */
+		nudgeNotify: boolean;
+		/** Inject per-turn affordance hints (examples → html_artifact, options →
+		 *  decision_deck, …) when the prompt mentions those. Default on. */
+		toolHints: boolean;
+		/** For non-trivial tasks, tell the LLM to confirm the approach with the
+		 *  user (ask "ready to implement, or discuss first?") before writing code.
+		 *  Default on. */
+		confirmBeforeCode: boolean;
 	};
 	display: {
 		/** Always show the recommended (⭐) option as the first row. */
@@ -63,6 +68,48 @@ export interface SolyConfig {
 		/** $EDITOR command for opening files (e.g. "code", "vim", "cursor"). */
 		command: string;
 	};
+	chrome: {
+		/** Install soly's status chrome (top bar + custom footer + spinner). */
+		enabled: boolean;
+		/** Use ASCII fallbacks instead of Nerd-Font glyphs. */
+		ascii: boolean;
+		/** Working-spinner animation frames (rendered verbatim by pi). */
+		spinnerFrames: string[];
+		/** Working-spinner frame interval in ms. */
+		spinnerIntervalMs: number;
+		/** Show live telemetry (elapsed · ↑↓ tokens · tok/s) in the working line. */
+		telemetry: boolean;
+		/** Hex gradient stops for the welcome banner (empty → accent color). */
+		bannerColors: string[];
+	};
+	verify: {
+		/** Max self-review passes before the loop stops on its own. */
+		maxIterations: number;
+		/** Strip prior review iterations from context each pass ("fresh eyes"). */
+		freshContext: boolean;
+		/** Review prompt re-injected each pass. */
+		prompt: string;
+		/** Regex (case-insensitive) signaling "nothing left to fix" → exit. */
+		exitPatterns: string[];
+		/** Regex signaling issues were fixed → keep looping despite an exit phrase. */
+		issuesFixedPatterns: string[];
+	};
+	artifacts: {
+		/** Open generated HTML artifacts in the browser automatically. */
+		open: boolean;
+		/** Output directory. Empty → OS temp dir (pi-soly-artifacts/). Accepts an
+		 *  absolute path, ~, or a path relative to the project cwd. */
+		dir: string;
+		/** Serve artifacts from a per-session HTTP server with a live gallery
+		 *  (one stable localhost URL). When false, just open the .html file. */
+		server: boolean;
+		/** Path to a CSS file overriding the artifact theme. Empty → built-in.
+		 *  Resolved like `dir`; also auto-detected at `.soly/artifact-theme.css`. */
+		theme: string;
+		/** Prune session artifact dirs older than N days on session start.
+		 *  0 = keep forever. */
+		retentionDays: number;
+	};
 }
 
 export const DEFAULT_CONFIG: SolyConfig = {
@@ -75,7 +122,9 @@ export const DEFAULT_CONFIG: SolyConfig = {
 	agent: {
 		preferAskPro: true,
 		autoCheckpointOnPause: true,
-		useSolyWorkerSubagents: false,
+		nudgeNotify: false,
+		toolHints: true,
+		confirmBeforeCode: true,
 	},
 	display: {
 		defaultRecommendedFirst: true,
@@ -92,6 +141,37 @@ export const DEFAULT_CONFIG: SolyConfig = {
 	editor: {
 		command: "code",
 	},
+	chrome: {
+		enabled: true,
+		ascii: false,
+		spinnerFrames: [
+			"⠁", "⠉", "⠙", "⠹", "⠽", "⠿", "⠾", "⠼", "⠶", "⠦", "⠆", "⠂",
+			"◴", "◷", "◶", "◵",
+			"⠁", "⠉", "⠙", "⠹", "⠽", "⠿", "⠾", "⠼", "⠶", "⠦", "⠆", "⠂",
+		],
+		spinnerIntervalMs: 150,
+		telemetry: true,
+		bannerColors: [], // empty → gradient derived from the theme accent
+	},
+	verify: {
+		maxIterations: 7,
+		freshContext: false,
+		prompt:
+			"Review the work from this session with fresh eyes. Re-read any relevant plan, " +
+			"spec, or PRD first. Look for bugs, missed edge cases, missing error handling, and " +
+			"inconsistencies with the project rules. If you find problems, fix them, then end your " +
+			'reply with: "Fixed N issue(s). Ready for another review." If you find nothing, end with ' +
+			'exactly: "No issues found."',
+		exitPatterns: ["no issues found", "no further issues", "nothing to fix"],
+		issuesFixedPatterns: ["fixed \\d+ issue", "ready for another review", "issues? fixed"],
+	},
+	artifacts: {
+		open: true,
+		dir: "",
+		server: true,
+		theme: "",
+		retentionDays: 7,
+	},
 };
 
 /** Raw parsed shape from a config.json — could be partial, could have wrong types. */
@@ -130,8 +210,12 @@ function deepMerge(base: SolyConfig, over: RawConfig): SolyConfig {
 			merged.agent.preferAskPro = over.agent.preferAskPro;
 		if (typeof over.agent.autoCheckpointOnPause === "boolean")
 			merged.agent.autoCheckpointOnPause = over.agent.autoCheckpointOnPause;
-		if (typeof over.agent.useSolyWorkerSubagents === "boolean")
-			merged.agent.useSolyWorkerSubagents = over.agent.useSolyWorkerSubagents;
+		if (typeof over.agent.nudgeNotify === "boolean")
+			merged.agent.nudgeNotify = over.agent.nudgeNotify;
+		if (typeof over.agent.toolHints === "boolean")
+			merged.agent.toolHints = over.agent.toolHints;
+		if (typeof over.agent.confirmBeforeCode === "boolean")
+			merged.agent.confirmBeforeCode = over.agent.confirmBeforeCode;
 	}
 	if (over.display) {
 		if (typeof over.display.defaultRecommendedFirst === "boolean")
@@ -153,6 +237,38 @@ function deepMerge(base: SolyConfig, over: RawConfig): SolyConfig {
 	if (over.editor && typeof over.editor.command === "string") {
 		merged.editor.command = over.editor.command;
 	}
+	if (over.chrome) {
+		if (typeof over.chrome.enabled === "boolean") merged.chrome.enabled = over.chrome.enabled;
+		if (typeof over.chrome.ascii === "boolean") merged.chrome.ascii = over.chrome.ascii;
+		if (Array.isArray(over.chrome.spinnerFrames)) {
+			const frames = over.chrome.spinnerFrames.filter((f) => typeof f === "string");
+			if (frames.length > 0) merged.chrome.spinnerFrames = frames;
+		}
+		if (typeof over.chrome.spinnerIntervalMs === "number" && over.chrome.spinnerIntervalMs > 0)
+			merged.chrome.spinnerIntervalMs = over.chrome.spinnerIntervalMs;
+		if (typeof over.chrome.telemetry === "boolean") merged.chrome.telemetry = over.chrome.telemetry;
+		if (Array.isArray(over.chrome.bannerColors)) {
+			merged.chrome.bannerColors = over.chrome.bannerColors.filter((c) => typeof c === "string");
+		}
+	}
+	if (over.verify) {
+		if (typeof over.verify.maxIterations === "number" && over.verify.maxIterations > 0)
+			merged.verify.maxIterations = over.verify.maxIterations;
+		if (typeof over.verify.freshContext === "boolean") merged.verify.freshContext = over.verify.freshContext;
+		if (typeof over.verify.prompt === "string" && over.verify.prompt.trim()) merged.verify.prompt = over.verify.prompt;
+		if (Array.isArray(over.verify.exitPatterns))
+			merged.verify.exitPatterns = over.verify.exitPatterns.filter((p) => typeof p === "string");
+		if (Array.isArray(over.verify.issuesFixedPatterns))
+			merged.verify.issuesFixedPatterns = over.verify.issuesFixedPatterns.filter((p) => typeof p === "string");
+	}
+	if (over.artifacts) {
+		if (typeof over.artifacts.open === "boolean") merged.artifacts.open = over.artifacts.open;
+		if (typeof over.artifacts.dir === "string") merged.artifacts.dir = over.artifacts.dir;
+		if (typeof over.artifacts.server === "boolean") merged.artifacts.server = over.artifacts.server;
+		if (typeof over.artifacts.theme === "string") merged.artifacts.theme = over.artifacts.theme;
+		if (typeof over.artifacts.retentionDays === "number" && over.artifacts.retentionDays >= 0)
+			merged.artifacts.retentionDays = over.artifacts.retentionDays;
+	}
 	return merged;
 }