pi-soly 1.11.2 → 1.12.0

package/workflows/inspect.ts

@@ -199,33 +199,30 @@ export function showDoctor(_cmd: unknown, state: SolyState, ui: InspectUI, confi
 		});
 	}
 
-	// 11. soly-aware subagents (opt-in via `agent.useSolyWorkerSubagents`).
-	// Reports current state — not a failure if disabled.
+	// 11. subagent tool (execute/plan delegate to it; without it they run inline)
 	if (state.exists) {
-		const userAgentsDir = path.join(os.homedir(), ".pi", "agent", "agents");
-		const hasWorker = fs.existsSync(path.join(userAgentsDir, "soly-worker.md"));
-		const hasOracle = fs.existsSync(path.join(userAgentsDir, "soly-oracle.md"));
-		const both = hasWorker && hasOracle;
-		const flag = config.agent.useSolyWorkerSubagents;
-		if (flag) {
-			// User opted in: both files MUST be present
-			checks.push({
-				name: "soly-aware subagents (opt-in enabled)",
-				status: both ? "pass" : "warn",
-				detail: both
-					? "installed in ~/.pi/agent/agents/ — soly execute uses soly-worker"
-					: `useSolyWorkerSubagents=true but ${hasWorker ? "soly-oracle.md" : "soly-worker.md"} missing — check session_start install errors`,
-			});
-		} else {
-			// Opt-in disabled: informational only
-			checks.push({
-				name: "soly-aware subagents (opt-in available, not enabled)",
-				status: "info",
-				detail: both
-					? "soly-worker.md and soly-oracle.md present in ~/.pi/agent/agents/ — set `agent.useSolyWorkerSubagents: true` in .soly/config.json to use them in soly execute"
-					: "set `agent.useSolyWorkerSubagents: true` in .soly/config.json to auto-install soly-worker + soly-oracle (specialized for soly paths/plans/todo)",
-			});
-		}
+		const hasSubagent = activeTools.includes("subagent");
+		checks.push({
+			name: "subagent tool (delegated execution)",
+			status: hasSubagent ? "pass" : "info",
+			detail: hasSubagent
+				? "subagent tool loaded — soly execute/plan delegate to a worker"
+				: "not installed — soly execute/plan run inline in this session (install pi-subagents for delegated/parallel execution)",
+		});
+	}
+
+	// 12. project layout (suggest migration to the unified phase=tasks model)
+	if (state.exists) {
+		const legacy =
+			state.phases.some((p) => p.plans.length > 0 && (!p.tasks || p.tasks.length === 0)) ||
+			state.features.length > 0;
+		checks.push({
+			name: "project layout",
+			status: legacy ? "info" : "pass",
+			detail: legacy
+				? "legacy plans/features detected — run `soly migrate` to move to phases/<N>/tasks/"
+				: "unified model (phase = group of tasks)",
+		});
 	}
 
 	// Render

package/workflows/migrate.ts

@@ -0,0 +1,85 @@
+// =============================================================================
+// workflows/migrate.ts — `soly migrate`: legacy layout → unified (LLM-runnable)
+// =============================================================================
+//
+// The unified model is `phases/<N>/tasks/<id>/PLAN.md`. Two legacy shapes need
+// converting:
+//   - standalone plan files `phases/<N>/<NN-MM>-PLAN.md` (+ *-SUMMARY.md)
+//   - the separate features model `features/<f>/tasks/<id>/`
+//
+// Conversion is semantic (derive a task id/kind/deps from a plan), so we hand
+// the model a careful, verify-before-delete protocol rather than doing blind
+// file moves in the extension. Returns a transform the LLM executes inline.
+// =============================================================================
+
+import type { SolyState } from "../core.ts";
+
+export type MigrateResult = { handled: boolean; transformedText?: string };
+
+/** Phases that still use legacy standalone plan files and have no tasks/ yet. */
+function legacyPhases(state: SolyState): string[] {
+	return state.phases
+		.filter((p) => p.plans.length > 0 && (!p.tasks || p.tasks.length === 0))
+		.map((p) => `${p.slug} (${p.plans.length} plan${p.plans.length === 1 ? "" : "s"})`);
+}
+
+export function buildMigrateTransform(state: SolyState): MigrateResult {
+	if (!state.exists) {
+		return {
+			handled: true,
+			transformedText:
+				`soly migrate: no .soly/ project in this directory — nothing to migrate.`,
+		};
+	}
+
+	const phases = legacyPhases(state);
+	const features = state.features.map((f) => `${f.slug} (${f.taskCount} task${f.taskCount === 1 ? "" : "s"})`);
+
+	if (phases.length === 0 && features.length === 0) {
+		return {
+			handled: true,
+			transformedText:
+				`soly migrate: already on the unified model (phase = group of tasks). Nothing to migrate.`,
+		};
+	}
+
+	const detected: string[] = [];
+	if (phases.length > 0) detected.push(`- Legacy plan files in: ${phases.join(", ")}`);
+	if (features.length > 0) detected.push(`- Legacy \`features/\` dirs: ${features.join(", ")}`);
+
+	return {
+		handled: true,
+		transformedText: `soly migrate — convert the legacy layout to the unified model (phase = group of tasks).
+
+Target layout:
+  .soly/phases/<N>/tasks/<task-id>/PLAN.md   (frontmatter: id, kind, status, depends-on, feature?)
+  .soly/phases/<N>/tasks/<task-id>/SUMMARY.md
+
+Detected legacy artifacts:
+${detected.join("\n")}
+
+Do the conversion YOURSELF, carefully, one item at a time. NEVER delete an old file until the new one is written and you've confirmed its contents. Use \`soly_read\` / \`soly_snippet\` to read, your file tools to write/move.
+
+**A. For each legacy plan \`phases/<N>/<NN-MM>-PLAN.md\`:**
+1. Read it. Derive a stable task id \`<short-slug>-<4hex>\` from the plan's title/intent (lowercase, hyphenated, e.g. \`auth-login-a3f9\`).
+2. Write \`phases/<N>/tasks/<id>/PLAN.md\` with frontmatter, then the original body unchanged:
+   \`\`\`
+   ---
+   id: <id>
+   kind: <be|fe|infra|docs|test>   # infer from the plan
+   status: <ready|done>            # done if a matching *-SUMMARY.md exists
+   depends-on: []                  # fill if the plan depends on earlier plans/tasks
+   ---
+   <original plan body>
+   \`\`\`
+3. If a matching \`<NN-MM>-SUMMARY.md\` exists, move it to \`phases/<N>/tasks/<id>/SUMMARY.md\`.
+4. Verify the new files exist and read correctly, THEN delete the old \`<NN-MM>-PLAN.md\` and its \`*-SUMMARY.md\`.
+
+**B. For each \`features/<f>/tasks/<id>/\`:**
+1. Decide which phase it belongs to (ask the user with \`ask_pro\` if it's not obvious from the task/feature).
+2. Move the whole task dir to \`phases/<N>/tasks/<id>/\` and add \`feature: <f>\` to its PLAN.md frontmatter.
+3. When a feature's tasks are all moved, remove the now-empty \`features/<f>/\`.
+
+**Close out:** update any path references in STATE.md / ROADMAP.md, run \`soly status\` and \`soly doctor\` to confirm the new layout loads, then commit. Report a short summary of what moved (counts + any tasks you couldn't place).`,
+	};
+}

package/workflows/parser.ts

@@ -18,7 +18,7 @@
 /** Verbs currently supported by the workflow handlers. */
 export type WorkflowVerb =
 	| "execute" | "pause" | "compact" | "resume" | "status" | "log" | "diff"
-	| "plan" | "discuss" | "help" | "doctor" | "iterations" | "phase" | "todos";
+	| "plan" | "discuss" | "help" | "doctor" | "iterations" | "phase" | "todos" | "verify" | "migrate";
 
 export interface SolyCommand {
 	verb: WorkflowVerb;
@@ -66,7 +66,9 @@ export function parseSolyCommand(text: string): SolyCommand | null {
 		verb !== "doctor" &&
 		verb !== "iterations" &&
 		verb !== "phase" &&
-		verb !== "todos"
+		verb !== "todos" &&
+		verb !== "verify" &&
+		verb !== "migrate"
 	) {
 		return null;
 	}

package/workflows/planning.ts

@@ -129,13 +129,13 @@ These documents hold the project's INTENT — business context, design vision, w
 Phase directory: ${phase.dir}
 Current state:   planCount=${phase.planCount}, context=${phase.contextExists}, research=${phase.researchExists}
 
-Launch a subagent to produce the plan. Do NOT plan inline.
+Launch a subagent to produce the phase's tasks. Do NOT plan inline.
 
 subagent({
   agent: "worker",
   context: "fresh",
   async: true,
-  task: \`You are a planner. Produce PLAN.md (and ${phase.contextExists ? "" : "optionally CONTEXT.md / "}RESEARCH.md if missing) for phase ${target.phase}.
+  task: \`You are a planner. Break phase ${target.phase} into discrete tasks (unified model): write one PLAN.md per task at phases/<NN>-slug/tasks/<task-id>/PLAN.md with frontmatter, plus ${phase.contextExists ? "" : "CONTEXT.md / "}RESEARCH.md if missing.
 
 **FIRST ACTION — read the iteration context file:**
 \`\`\`
@@ -155,15 +155,16 @@ ${workflow}
 
 Hard rules:
   - Do not write production code. Planning only.
-  - Wave numbers must be pre-computed; dependency graph must be acyclic.
-  - Each plan needs requirements, must_haves.truths, must_haves.artifacts, must_haves.key_links.
-  - PATH DISCIPLINE: all PLAN.md / CONTEXT.md / RESEARCH.md files go under \`.soly/phases/<NN>-<slug>/\`. Never write plan files to the project root.
+  - One task = one PLAN.md under .soly/phases/<NN>-<slug>/tasks/<task-id>/ (task id = <short-slug>-<4hex>).
+  - Each task PLAN.md starts with frontmatter: id, kind, status: ready, depends-on: [task ids], optional feature. The cross-task dependency graph must be acyclic.
+  - Each task PLAN needs requirements, must_haves.truths, must_haves.artifacts, must_haves.key_links.
+  - PATH DISCIPLINE: all task PLAN.md / phase CONTEXT.md / RESEARCH.md go under \`.soly/phases/<NN>-<slug>/\`. Never write to the project root.
   - Update .soly/STATE.md Current Position at the end.
-  - Return: created files, plan count, wave breakdown, open questions.
+  - Return: created task ids, the dependency order (which tasks are ready first), open questions.
 \`
 })
 
-When the subagent returns, summarize the plan structure and ask the user to confirm before any execution.`;
+When the subagent returns, summarize the tasks + their dependency order, then suggest \`soly execute ${target.phase}\` (or ask the user to confirm before execution).`;
 		return { handled: true, transformedText: instruction };
 	}
 
@@ -607,7 +608,7 @@ soly_ask_user({
 - ${hasAskPro ? "`ask_pro` — multi-question tabbed picker (PREFERRED)" : "`soly_ask_user` — single-question picker (fallback)"}
 - \`soly_save_discuss_checkpoint\` — save partial progress (use after each answer)
 - \`soly_finish_discuss\` — finalize: writes CONTEXT.md, deletes checkpoint
-- \`soly_read\`, \`soly_snippet\`, \`soly_doc_search\`, \`soly_intent\` — read .soly/ artifacts as needed
+- \`soly_read\`, \`soly_snippet\`, \`soly_doc_search\` — read .soly/ artifacts as needed (intent docs are already in your system prompt)
 - \`soly_log_decision\` — log to STATE.md Decisions table (use sparingly)
 - Standard pi tools: \`read\`, \`bash\`, \`grep\`, \`find\` for codebase context
 

package/workflows/verify.ts

@@ -0,0 +1,194 @@
+// =============================================================================
+// workflows/verify.ts — self-review loop ("fresh eyes") for `soly verify`
+// =============================================================================
+//
+// Repeatedly asks the model to review its own work until it reports nothing
+// left to fix, or a max-iteration cap is hit. Driven by the `agent_end` event:
+// after each turn we read the assistant's last message, decide exit vs. loop,
+// and (if looping) re-inject the review prompt via sendUserMessage.
+//
+// Optional fresh-context mode strips prior review iterations from the model's
+// view through the shared context-manager — the agent re-reviews with genuinely
+// fresh eyes instead of through the lens of its earlier passes. We only ever
+// drop real messages (slice), never fabricate; the "re-read the plan" nudge
+// lives in the review prompt text, so no synthetic messages are needed.
+//
+// Pure helpers (exit detection, message slicing) are exported for unit tests.
+// =============================================================================
+
+import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
+import type { AgentMessageLike, ContextManager, ContextRewriter } from "../context-manager.ts";
+
+/** Resolved verify settings (from soly config `verify`). */
+export type VerifyConfig = {
+	maxIterations: number;
+	freshContext: boolean;
+	prompt: string;
+	exitPatterns: string[];
+	issuesFixedPatterns: string[];
+};
+
+export type VerifyState = { active: boolean; iteration: number; max: number; fresh: boolean };
+
+export type VerifyDeps = {
+	contextManager: ContextManager;
+	getConfig: () => VerifyConfig;
+	/** Notified whenever the loop state changes (drives the chrome top bar). */
+	onState: (state: VerifyState) => void;
+};
+
+export type VerifyStartOpts = { max?: number; fresh?: boolean };
+
+export type VerifyLoop = {
+	isActive: () => boolean;
+	start: (ctx: ExtensionContext, opts?: VerifyStartOpts) => void;
+	stop: (ctx: ExtensionContext | undefined, reason: string) => void;
+};
+
+// ---------------------------------------------------------------------------
+// Pure helpers
+// ---------------------------------------------------------------------------
+
+/** Extract plain text from a message's content (string or text-block array). */
+export function extractText(content: unknown): string {
+	if (typeof content === "string") return content;
+	if (!Array.isArray(content)) return "";
+	const parts: string[] = [];
+	for (const block of content) {
+		if (block && typeof block === "object" && (block as { type?: string }).type === "text") {
+			const t = (block as { text?: unknown }).text;
+			if (typeof t === "string") parts.push(t);
+		}
+	}
+	return parts.join("\n");
+}
+
+/** Compile pattern strings into case-insensitive RegExps, skipping invalid ones. */
+export function compilePatterns(patterns: string[]): RegExp[] {
+	const out: RegExp[] = [];
+	for (const p of patterns) {
+		try {
+			out.push(new RegExp(p, "i"));
+		} catch {
+			/* skip malformed pattern */
+		}
+	}
+	return out;
+}
+
+/**
+ * Exit only when the text signals "done" AND does NOT also signal that issues
+ * were fixed — so "Fixed 3 issues. No issues found." keeps looping (the fix
+ * may have introduced new problems), but a clean "No issues found." exits.
+ */
+export function shouldExit(text: string, exit: RegExp[], fixed: RegExp[]): boolean {
+	const matched = (res: RegExp[]) => res.some((r) => r.test(text));
+	return matched(exit) && !matched(fixed);
+}
+
+/** Index of the last user message, or -1. */
+export function lastUserIndex(messages: AgentMessageLike[]): number {
+	for (let i = messages.length - 1; i >= 0; i--) {
+		if (messages[i]?.role === "user") return i;
+	}
+	return -1;
+}
+
+/**
+ * Fresh-eyes view: keep the conversation before the loop began (`boundary` =
+ * index of the first review prompt) plus the current review prompt onward,
+ * dropping the in-between prior iterations. Returns the input unchanged on the
+ * first pass (boundary === last user message).
+ */
+export function freshContextMessages<T extends AgentMessageLike>(messages: T[], boundary: number): T[] {
+	if (boundary < 0 || boundary >= messages.length) return messages;
+	const current = lastUserIndex(messages);
+	if (current <= boundary) return messages;
+	return [...messages.slice(0, boundary), ...messages.slice(current)];
+}
+
+// ---------------------------------------------------------------------------
+// Loop
+// ---------------------------------------------------------------------------
+
+/** Create the verify loop and register its `agent_end` + `input` handlers. */
+export function createVerifyLoop(pi: ExtensionAPI, deps: VerifyDeps): VerifyLoop {
+	let active = false;
+	let iteration = 0;
+	let max = 0;
+	let fresh = false;
+	let boundary = -1;
+	let exitRes: RegExp[] = [];
+	let fixedRes: RegExp[] = [];
+
+	const emit = () => deps.onState({ active, iteration, max, fresh });
+
+	// Captures the boundary on the first call, then strips prior iterations.
+	const rewriter: ContextRewriter = (messages) => {
+		if (boundary < 0) {
+			boundary = lastUserIndex(messages);
+			return messages;
+		}
+		return freshContextMessages(messages, boundary);
+	};
+
+	const stop = (ctx: ExtensionContext | undefined, reason: string): void => {
+		if (!active) return;
+		active = false;
+		boundary = -1;
+		deps.contextManager.setRewriter(null);
+		emit();
+		ctx?.ui.notify(`soly verify: ${reason}`, "info");
+	};
+
+	pi.on("agent_end", async (event, ctx) => {
+		if (!active) return;
+		const last = [...event.messages].reverse().find((m) => m.role === "assistant");
+		const text = extractText((last as { content?: unknown } | undefined)?.content);
+		iteration++;
+		if (!text.trim()) {
+			stop(ctx, iteration === 1 ? "nothing to review" : "done");
+			return;
+		}
+		if (shouldExit(text, exitRes, fixedRes)) {
+			stop(ctx, "no issues found");
+			return;
+		}
+		if (iteration >= max) {
+			stop(ctx, `stopped after ${max} iterations`);
+			return;
+		}
+		emit();
+		pi.sendUserMessage(deps.getConfig().prompt, { deliverAs: "followUp" });
+	});
+
+	// Any interactive input (other than re-invoking verify) breaks the loop.
+	pi.on("input", async (event, ctx) => {
+		if (!active || event.source !== "interactive") return;
+		if (event.text.trim().toLowerCase().startsWith("soly verify")) return;
+		stop(ctx, "interrupted");
+	});
+
+	return {
+		isActive: () => active,
+		start(ctx, opts = {}): void {
+			if (active) {
+				ctx.ui.notify("soly verify: already running", "info");
+				return;
+			}
+			const cfg = deps.getConfig();
+			active = true;
+			iteration = 0;
+			boundary = -1;
+			max = Math.max(1, opts.max ?? cfg.maxIterations);
+			fresh = opts.fresh ?? cfg.freshContext;
+			exitRes = compilePatterns(cfg.exitPatterns);
+			fixedRes = compilePatterns(cfg.issuesFixedPatterns);
+			if (fresh) deps.contextManager.setRewriter(rewriter);
+			emit();
+			ctx.ui.notify(`soly verify: review mode on (max ${max}${fresh ? ", fresh context" : ""})`, "info");
+			pi.sendUserMessage(cfg.prompt);
+		},
+		stop,
+	};
+}

package/workflows-data/discuss-phase.md

@@ -2,8 +2,11 @@
 
 <purpose>Reference document for the **interactive** `soly discuss <N>` flow. The
 discussion is now driven by the interactive LLM (you) directly — no subagent.
-You use the `soly_ask_user` tool to ask questions one at a time via a real
-UI picker, and `soly_finish_discuss` to write the canonical CONTEXT.md. This
+You ask questions via a real UI picker — **`ask_pro` (preferred, one batched
+call)**, falling back to `soly_ask_user` (deprecated, one question at a time)
+when `ask_pro` isn't available — and `soly_finish_discuss` to write the
+canonical CONTEXT.md. For design/architecture forks you may reach for
+`decision_deck`, and for a rich visual comparison `html_artifact`. This
 markdown is background context, not a strict protocol.</purpose>
 
 <path_discipline>
@@ -20,8 +23,9 @@ The iteration context file (path given by the parent in the task prompt) is your
 2. **Generate 3-5 phase-specific gray areas** grounded in the intent + ROADMAP row. For each, prepare a question with 2-3 CONCRETE options, ⭐ first = recommended answer, with 1-sentence rationale.
 
 3. **Pick a picker** (the parent's prompt tells you which one is preferred):
-   - **`ask_pro`** (from the separate `pi-ask` extension, if installed) — multi-question tabbed picker. **PREFERRED**: call ONCE with all questions, returns all answers in one shot. Supports `allowOther: true` for free-text input per question.
-   - **`soly_ask_user`** (always available as fallback) — single-question picker. Call N times, one per question. No `allowOther` support.
+   - **`ask_pro`** — multi-question tabbed picker. **PREFERRED**: call ONCE with all questions, returns all answers in one shot. Per question: `multiSelect` (+ `minSelect`/`maxSelect`), `allowOther` (free-text choice), `freeText` (typed answer, no options), per-option `preview` (side panel, code highlighted); the user can press `s` to skip.
+   - **`soly_ask_user`** (deprecated — fallback only when `ask_pro` is unavailable) — single-question picker. Call N times, one per question. No `allowOther` support.
+   - **`decision_deck`** (optional) — for an architecture/design fork where the choice hinges on the concrete code shape, present the options as full-screen cards (code snippet + pros/cons) instead of a flat list.
 
 4. **Save a checkpoint after each answer** with `soly_save_discuss_checkpoint` so the user can quit and resume. The final `soly_finish_discuss` will delete the checkpoint and write CONTEXT.md.
 
@@ -165,9 +169,9 @@ Build a small `<codebase_context>` block (≤ 10 lines) of reusable assets/patte
 
 **10. Discuss (interactive, one question at a time).**
 
-**PREFERRED** (if `ask_pro` tool is available from the `pi-ask` extension): call `ask_pro` ONCE with all questions as tabs. Returns all answers in one shot. Per question: `header`, `question`, `options[2-4]`, optional `multiSelect`, optional `allowOther` (text input for custom answer).
+**PREFERRED**: call `ask_pro` ONCE with all questions as tabs. Returns all answers in one shot. Per question: `header`, `question`, `options[2-4]`, optional `multiSelect` (+ `minSelect`/`maxSelect`), `allowOther` (text input for custom answer), or `freeText: true` for an open typed answer (no options). For a design/architecture fork where the choice turns on the concrete code shape, `decision_deck` (cards with code + pros/cons) reads better than a flat option list.
 
-**FALLBACK** (if `ask_pro` is not available): call `soly_ask_user` once per question, one at a time. Pattern:
+**FALLBACK** (only if `ask_pro` is unavailable — it is deprecated): call `soly_ask_user` once per question, one at a time. Pattern:
 
 ```
 soly_ask_user({

package/agents-install.ts

@@ -1,106 +0,0 @@
-// =============================================================================
-// assets-install.ts — Idempotent install of soly-managed user assets
-// =============================================================================
-//
-// Soly ships one kind of user-scope asset:
-//
-//   Skills → `~/.pi/agent/skills/<name>/`
-//      The `soly-framework` skill — framework documentation the LLM
-//      loads on demand via the read tool. This is the LLM's only
-//      "helper" for soly — pi doesn't need a separate subagent layer
-//      for plan execution (the LLM in the main session does it).
-//
-// pi discovers the skill from `~/.pi/agent/`, so on first session_start
-// we copy our shipped file there.
-//
-// IDEMPOTENT: if the target file already exists (user may have customized
-// it), we do NOT overwrite. This is one-way "first install wins".
-// =============================================================================
-
-import * as fs from "node:fs";
-import * as os from "node:os";
-import * as path from "node:path";
-
-/** soly skills bundled with the extension. Each entry is a directory
- *  under `skills/` containing a SKILL.md. */
-const SHIPPED_SKILLS = [
-	"soly-framework",
-] as const;
-
-/** Where pi looks for user skills. Respects HOME/USERPROFILE for
- *  testability (otherwise we'd always write to the real user home). */
-function userSkillsDir(): string {
-	const home = process.env.HOME || process.env.USERPROFILE || os.homedir();
-	return path.join(home, ".pi", "agent", "skills");
-}
-
-/** Where this soly extension's `skills/` directory lives. */
-function shippedSkillsDir(extensionRoot: string): string {
-	return path.join(extensionRoot, "skills");
-}
-
-export interface InstallResult {
-	installed: string[];
-	skipped: string[];
-	errors: string[];
-}
-
-/** Copy a directory tree if destination doesn't exist. Idempotent. */
-function copyDirIfMissing(from: string, to: string): "installed" | "skipped" | "error" {
-	if (!fs.existsSync(from)) return "error";
-	if (fs.existsSync(to)) return "skipped";
-	try {
-		fs.mkdirSync(path.dirname(to), { recursive: true });
-		fs.cpSync(from, to, { recursive: true });
-		return "installed";
-	} catch {
-		return "error";
-	}
-}
-
-/** Install shipped soly skills to `~/.pi/agent/skills/`. Idempotent. */
-export function installSolySkills(extensionRoot: string): InstallResult {
-	const result: InstallResult = { installed: [], skipped: [], errors: [] };
-	const src = shippedSkillsDir(extensionRoot);
-	const dst = userSkillsDir();
-
-	if (!fs.existsSync(src)) return result; // dev mode no-op
-
-	for (const name of SHIPPED_SKILLS) {
-		const from = path.join(src, name);
-		const to = path.join(dst, name);
-		const r = copyDirIfMissing(from, to);
-		if (r === "installed") result.installed.push(name);
-		else if (r === "skipped") result.skipped.push(name);
-		else result.errors.push(`missing source: ${from}`);
-	}
-
-	return result;
-}
-
-/** Install all soly assets (skills only — agents are not shipped). */
-export function installSolyAssets(extensionRoot: string): {
-	skills: InstallResult;
-} {
-	return {
-		skills: installSolySkills(extensionRoot),
-	};
-}
-
-/** Check which shipped soly skills are present in the user dir. */
-export function checkSolySkillsInstalled(extensionRoot: string): {
-	installed: string[];
-	missing: string[];
-} {
-	const dst = userSkillsDir();
-	const installed: string[] = [];
-	const missing: string[] = [];
-	for (const name of SHIPPED_SKILLS) {
-		if (fs.existsSync(path.join(dst, name, "SKILL.md"))) {
-			installed.push(name);
-		} else {
-			missing.push(name);
-		}
-	}
-	return { installed, missing };
-}

package/ask/prompt.ts

@@ -1,41 +0,0 @@
-// =============================================================================
-// prompt.ts — System-prompt section for the pi-ask extension
-// =============================================================================
-//
-// Injected into the agent's system prompt via `before_agent_start` so the
-// LLM knows `ask_pro` is available, when to use it, and when NOT to
-// (anti-patterns matter more than use-cases here — the tool is easy to
-// overuse for trivial questions).
-//
-// Kept short (~600 chars) so it doesn't bloat every turn's prompt. The
-// tool's own `description` and parameter schema still carry the detailed
-// contract; this section is the "when to reach for it" trigger.
-// =============================================================================
-
-/** Build the "when to use ask_pro" section. Pure function, easily testable. */
-export function buildAskProSection(): string {
-	return `
-
-## pi-ask — when to use \`ask_pro\`
-
-\`ask_pro\` is a multi-question picker (tabbed, numbered, ⭐ recommended). Use it when:
-- You need a focused choice between 2–4 options and a free-text question would be slower
-- You have 2–6 related questions to ask in one batch (e.g. \`soly discuss\` scoping flow)
-- The user must pick a single concrete answer to move forward
-
-DON'T use it for:
-- Simple yes/no — just ask in text
-- Open-ended questions ("what do you want?") — free text is better
-- More than 6 questions — tab-switching fatigue
-- When the user already gave a clear answer — don't second-guess
-- Trivial clarifications — use plain text first, escalate to \`ask_pro\` only if the answer matters
-
-Keyboard in the picker: \`↑↓\` navigate, \`1-N\` instant-pick, \`Tab\` next question, \`Space\` toggle (multi-select only), \`Enter\` confirm/advance/submit, \`n\` add a free-text note to the current question, \`Esc\` cancel.
-
-Schema reminder: \`questions: [{ header, question, options: [{label, description?, recommended?, preview?}], multiSelect? }]\`. Mark exactly one option \`recommended: true\` per question when you have a default.
-
-**Option previews:** \`option.preview\` (markdown/plain string) shows in a side panel next to the option list while that option is focused. Use it when the question is about a code structure, API shape, or concrete example — show a small snippet of what each option entails so the user can decide without asking follow-ups. Example: when asking "how should we model auth?", each option's preview can show the relevant type signature.
-
-**Notes:** the user can press \`n\` after picking an answer to attach a free-text note (edge cases, constraints, reasoning). The note is returned to you as \`// note: \"...\"\` next to the chosen answer. Treat it as a hard constraint.
-`;
-}

package/ask/tests/prompt.test.ts

@@ -1,54 +0,0 @@
-// =============================================================================
-// tests/prompt.test.ts — Tests for the system-prompt section
-// =============================================================================
-
-/// <reference types="bun-types" />
-import { describe, test, expect } from "bun:test";
-import { buildAskProSection } from "../prompt.js";
-
-describe("buildAskProSection", () => {
-	const s = buildAskProSection();
-
-	test("starts with a header", () => {
-		expect(s.trim().startsWith("## pi-ask")).toBe(true);
-	});
-
-	test("explains when to use ask_pro", () => {
-		expect(s).toContain("ask_pro");
-		expect(s).toContain("when to use");
-		// Use-case coverage
-		expect(s).toMatch(/focused choice/i);
-		expect(s).toMatch(/2.6 related questions/i);
-	});
-
-	test("explains when NOT to use it (anti-patterns)", () => {
-		expect(s).toContain("DON");
-		expect(s).toMatch(/yes\/no/i);
-		expect(s).toMatch(/open-ended/i);
-		expect(s).toMatch(/more than 6 questions/i);
-	});
-
-	test("documents keyboard shortcuts", () => {
-		expect(s).toContain("Space");
-		expect(s).toContain("Enter");
-		expect(s).toContain("Esc");
-		expect(s).toContain("Tab");
-	});
-
-	test("reminds about the schema", () => {
-		expect(s).toContain("header");
-		expect(s).toContain("question");
-		expect(s).toContain("options");
-		expect(s).toContain("recommended");
-	});
-
-	test("is reasonably short (< 2.5 KB) to not bloat every turn", () => {
-		// Sanity check — if this grows, consider trimming. The cost is
-		// paid on every turn (before_agent_start runs every prompt).
-		expect(s.length).toBeLessThan(2500);
-	});
-
-	test("is a pure function (same output across calls)", () => {
-		expect(buildAskProSection()).toBe(s);
-	});
-});