pi-smart-voice-notify 0.5.2 → 0.5.3

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## [Unreleased]
+
+## [0.5.3] - 2026-06-16
+
+### Fixed
+- Filtered blank template entries so whitespace-only overrides no longer produce empty notification messages.
+- Added a final fallback (`"Notification: Please check the terminal."`) when all template expansions and defaults yield empty output.
+
 ## [0.5.2] - 2026-06-01
 
 ### Changed

package/package.json

@@ -1,74 +1,74 @@
-{
-  "name": "pi-smart-voice-notify",
-  "version": "0.5.2",
-  "description": "Windows-optimized smart voice, sound, and desktop notifications for Pi coding agent.",
-  "type": "module",
-  "main": "./index.ts",
-  "exports": {
-    ".": "./index.ts"
-  },
-  "files": [
-    "index.ts",
-    "src",
-    "config/config.example.json",
-    "assets",
-    "README.md",
-    "CHANGELOG.md",
-    "LICENSE"
-  ],
-  "scripts": {
-    "build": "npx --yes -p typescript@5.7.3 -p @types/node@20.17.57 tsc -p tsconfig.json --noEmit",
-    "lint": "npm run build",
-    "test": "node --experimental-strip-types --test test/abortable-command.test.ts test/reminder-playback.test.ts test/permission-forwarding-watcher.test.ts test/sound-theme.test.ts test/webhook.test.ts test/linux.test.ts test/index.test.ts test/tts.test.ts",
-    "check": "npm run build && npm run test"
-  },
-  "keywords": [
-    "pi-package",
-    "pi",
-    "pi-extension",
-    "pi-coding-agent",
-    "coding-agent",
-    "voice-notify",
-    "desktop-notification",
-    "notifications",
-    "voice",
-    "audio",
-    "text-to-speech",
-    "tts",
-    "windows",
-    "linux",
-    "macos"
-  ],
-  "author": "MasuRii",
-  "license": "MIT",
-  "repository": {
-    "type": "git",
-    "url": "git+https://github.com/MasuRii/pi-smart-voice-notify.git"
-  },
-  "homepage": "https://github.com/MasuRii/pi-smart-voice-notify#readme",
-  "bugs": {
-    "url": "https://github.com/MasuRii/pi-smart-voice-notify/issues"
-  },
-  "engines": {
-    "node": ">=24"
-  },
-  "publishConfig": {
-    "access": "public"
-  },
-  "pi": {
-    "extensions": [
-      "./index.ts"
-    ]
-  },
-  "peerDependencies": {
-    "@earendil-works/pi-coding-agent": "^0.74.0 || ^0.75.0 || ^0.77.0 || ^0.78.0",
-    "@earendil-works/pi-tui": "^0.74.0 || ^0.75.0 || ^0.77.0 || ^0.78.0"
-  },
-  "dependencies": {
-    "node-notifier": "^10.0.1",
-    "undici": "^8.3.0"
-  },
-  "devDependencies": {
-    "@types/node": "25.9.1"
-  }
-}
+{
+  "name": "pi-smart-voice-notify",
+  "version": "0.5.3",
+  "description": "Windows-optimized smart voice, sound, and desktop notifications for Pi coding agent.",
+  "type": "module",
+  "main": "./index.ts",
+  "exports": {
+    ".": "./index.ts"
+  },
+  "files": [
+    "index.ts",
+    "src",
+    "config/config.example.json",
+    "assets",
+    "README.md",
+    "CHANGELOG.md",
+    "LICENSE"
+  ],
+  "scripts": {
+    "build": "npx --yes -p typescript@5.7.3 -p @types/node@20.17.57 tsc -p tsconfig.json --noEmit",
+    "lint": "npm run build",
+    "test": "node --experimental-strip-types --test test/abortable-command.test.ts test/reminder-playback.test.ts test/permission-forwarding-watcher.test.ts test/sound-theme.test.ts test/webhook.test.ts test/linux.test.ts test/index.test.ts test/tts.test.ts",
+    "check": "npm run build && npm run test"
+  },
+  "keywords": [
+    "pi-package",
+    "pi",
+    "pi-extension",
+    "pi-coding-agent",
+    "coding-agent",
+    "voice-notify",
+    "desktop-notification",
+    "notifications",
+    "voice",
+    "audio",
+    "text-to-speech",
+    "tts",
+    "windows",
+    "linux",
+    "macos"
+  ],
+  "author": "MasuRii",
+  "license": "MIT",
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/MasuRii/pi-smart-voice-notify.git"
+  },
+  "homepage": "https://github.com/MasuRii/pi-smart-voice-notify#readme",
+  "bugs": {
+    "url": "https://github.com/MasuRii/pi-smart-voice-notify/issues"
+  },
+  "engines": {
+    "node": ">=24"
+  },
+  "publishConfig": {
+    "access": "public"
+  },
+  "pi": {
+    "extensions": [
+      "./index.ts"
+    ]
+  },
+  "peerDependencies": {
+    "@earendil-works/pi-coding-agent": "^0.74.0 || ^0.75.0 || ^0.77.0 || ^0.78.0 || ^0.79.0",
+    "@earendil-works/pi-tui": "^0.74.0 || ^0.75.0 || ^0.77.0 || ^0.78.0 || ^0.79.0"
+  },
+  "dependencies": {
+    "node-notifier": "^10.0.1",
+    "undici": "^8.5.0"
+  },
+  "devDependencies": {
+    "@types/node": "25.9.3"
+  }
+}

package/src/agent-dir.ts

@@ -1,32 +1,32 @@
-import { homedir } from "node:os";
-import { join } from "node:path";
-
-const PI_AGENT_DIR_ENV_VAR = "PI_CODING_AGENT_DIR";
-
-interface AgentDirEnvironment {
-	[name: string]: string | undefined;
-}
-
-function expandHomeDirectory(configuredDir: string, homeDirectory: string): string {
-	if (configuredDir === "~") {
-		return homeDirectory;
-	}
-
-	if (configuredDir.startsWith("~/") || configuredDir.startsWith("~\\")) {
-		return join(homeDirectory, configuredDir.slice(2));
-	}
-
-	return configuredDir;
-}
-
-export function resolvePiAgentDir(
-	env: AgentDirEnvironment = process.env,
-	homeDirectory = homedir(),
-): string {
-	const configuredDir = env[PI_AGENT_DIR_ENV_VAR];
-	if (!configuredDir) {
-		return join(homeDirectory, ".pi", "agent");
-	}
-
-	return expandHomeDirectory(configuredDir, homeDirectory);
-}
+import { homedir } from "node:os";
+import { join } from "node:path";
+
+const PI_AGENT_DIR_ENV_VAR = "PI_CODING_AGENT_DIR";
+
+interface AgentDirEnvironment {
+	[name: string]: string | undefined;
+}
+
+function expandHomeDirectory(configuredDir: string, homeDirectory: string): string {
+	if (configuredDir === "~") {
+		return homeDirectory;
+	}
+
+	if (configuredDir.startsWith("~/") || configuredDir.startsWith("~\\")) {
+		return join(homeDirectory, configuredDir.slice(2));
+	}
+
+	return configuredDir;
+}
+
+export function resolvePiAgentDir(
+	env: AgentDirEnvironment = process.env,
+	homeDirectory = homedir(),
+): string {
+	const configuredDir = env[PI_AGENT_DIR_ENV_VAR];
+	if (!configuredDir) {
+		return join(homeDirectory, ".pi", "agent");
+	}
+
+	return expandHomeDirectory(configuredDir, homeDirectory);
+}

package/src/ai-messages.ts

@@ -237,6 +237,10 @@ function sanitizeMessage(message: string, maxLength = DEFAULT_MAX_MESSAGE_LENGTH
 	return `${clipped.slice(0, safeBoundary).trimEnd()}...`;
 }
 
+function getUsableTemplates(templates: string[]): string[] {
+	return templates.filter((template) => template.trim().length > 0);
+}
+
 function pickTemplate(templates: string[]): string {
 	const index = Math.floor(Math.random() * templates.length);
 	return templates[index] ?? templates[0] ?? "Notification";
@@ -252,8 +256,11 @@ function getTemplatesForEvent(eventType: string, config: AIMessageConfig): strin
 	}
 
 	const overrideTemplates = config.templates[eventType];
-	if (Array.isArray(overrideTemplates) && overrideTemplates.length > 0) {
-		return overrideTemplates;
+	if (Array.isArray(overrideTemplates)) {
+		const usableTemplates = getUsableTemplates(overrideTemplates);
+		if (usableTemplates.length > 0) {
+			return usableTemplates;
+		}
 	}
 	return DEFAULT_TEMPLATES[eventType];
 }
@@ -317,8 +324,20 @@ export class AIMessageService {
 		const templates = getTemplatesForEvent(eventType, this.config);
 		const template = pickTemplate(templates);
 		const variables = buildTemplateVariables(eventType, context);
-		const message = applyTemplateVariables(template, variables);
-		return sanitizeMessage(message);
+		const message = sanitizeMessage(applyTemplateVariables(template, variables));
+		if (message.length > 0) {
+			return message;
+		}
+
+		if (isCoreEventType(eventType)) {
+			const fallbackTemplate = pickTemplate(DEFAULT_TEMPLATES[eventType]);
+			const fallbackMessage = sanitizeMessage(applyTemplateVariables(fallbackTemplate, variables));
+			if (fallbackMessage.length > 0) {
+				return fallbackMessage;
+			}
+		}
+
+		return "Notification: Please check the terminal.";
 	}
 
 	public async generateAIMessage(eventType: string, context: AIMessageContext = {}): Promise<string | null> {