pi-smart-voice-notify 0.3.5 → 0.4.0

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## [0.4.0] - 2026-04-30
+
+### Added
+- Detect agent turn failures reported at `agent_end` and send error notifications instead of completion alerts.
+
+### Changed
+- Renamed bundled notification sound assets to stable lowercase filenames and migrate legacy bundled sound paths automatically.
+- Updated `@mariozechner/pi-*` peer dependency ranges to `^0.70.6` and synchronized package lock metadata.
+
 ## [0.3.5] - 2026-04-27
 
 ### Fixed

package/README.md

@@ -166,10 +166,10 @@ Forwarded permission watcher notifications use privacy-safe text, require the re
 
 | Option | Type | Default |
 |--------|------|---------|
-| `idleSoundFile` | string | `"assets/Soft-high-tech-notification-sound-effect.mp3"` |
-| `permissionSoundFile` | string | `"assets/Machine-alert-beep-sound-effect.mp3"` |
-| `questionSoundFile` | string | `"assets/Machine-alert-beep-sound-effect.mp3"` |
-| `errorSoundFile` | string | `"assets/Machine-alert-beep-sound-effect.mp3"` |
+| `idleSoundFile` | string | `"assets/soft-notification.mp3"` |
+| `permissionSoundFile` | string | `"assets/attention-alert.mp3"` |
+| `questionSoundFile` | string | `"assets/attention-alert.mp3"` |
+| `errorSoundFile` | string | `"assets/attention-alert.mp3"` |
 
 Paths can be absolute or relative to the extension directory.
 

package/config/config.example.json

@@ -94,10 +94,10 @@
   "openaiTtsSpeed": 1,
 
   "_comment_sounds": "Direct sound file fallbacks.",
-  "idleSoundFile": "assets/Soft-high-tech-notification-sound-effect.mp3",
-  "permissionSoundFile": "assets/Machine-alert-beep-sound-effect.mp3",
-  "questionSoundFile": "assets/Machine-alert-beep-sound-effect.mp3",
-  "errorSoundFile": "assets/Machine-alert-beep-sound-effect.mp3",
+  "idleSoundFile": "assets/soft-notification.mp3",
+  "permissionSoundFile": "assets/attention-alert.mp3",
+  "questionSoundFile": "assets/attention-alert.mp3",
+  "errorSoundFile": "assets/attention-alert.mp3",
 
   "_comment_sound_theme": "Sound theme settings.",
   "themePath": "",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-smart-voice-notify",
-  "version": "0.3.5",
+  "version": "0.4.0",
   "description": "Windows-optimized smart voice, sound, and desktop notifications for Pi coding agent.",
   "type": "module",
   "main": "./index.ts",
@@ -61,8 +61,8 @@
     ]
   },
   "peerDependencies": {
-    "@mariozechner/pi-coding-agent": "^0.70.2",
-    "@mariozechner/pi-tui": "^0.70.2"
+    "@mariozechner/pi-coding-agent": "^0.70.6",
+    "@mariozechner/pi-tui": "^0.70.6"
   },
   "dependencies": {
     "node-notifier": "^10.0.1"

package/src/config-store.ts

@@ -174,10 +174,10 @@ export const DEFAULT_CONFIG: VoiceNotifyConfig = {
 	openaiTtsFormat: "mp3",
 	openaiTtsSpeed: 1,
 
-	idleSoundFile: "assets/Soft-high-tech-notification-sound-effect.mp3",
-	permissionSoundFile: "assets/Machine-alert-beep-sound-effect.mp3",
-	questionSoundFile: "assets/Machine-alert-beep-sound-effect.mp3",
-	errorSoundFile: "assets/Machine-alert-beep-sound-effect.mp3",
+	idleSoundFile: "assets/soft-notification.mp3",
+	permissionSoundFile: "assets/attention-alert.mp3",
+	questionSoundFile: "assets/attention-alert.mp3",
+	errorSoundFile: "assets/attention-alert.mp3",
 	themePath: "",
 	themeName: "default",
 	themesRootPath: "",
@@ -344,6 +344,34 @@ function stringOrDefault(value: unknown, fallback: string): string {
 	return fallback;
 }
 
+const LEGACY_BUNDLED_SOUND_FILES: Record<string, string> = {
+	"assets/machine-alert-beep-sound-effect.mp3": "assets/attention-alert.mp3",
+	"assets/soft-high-tech-notification-sound-effect.mp3": "assets/soft-notification.mp3",
+};
+
+function normalizeSoundFileLookup(value: string): string {
+	return value.replaceAll("\\", "/").replace(/^\.\//, "").toLowerCase();
+}
+
+function soundFileExists(value: string): boolean {
+	return existsSync(isAbsolute(value) ? value : join(CONFIG_DIR, value));
+}
+
+function normalizeSoundFile(value: unknown, fallback: string): string {
+	const selected = stringOrDefault(value, fallback);
+	const lookup = normalizeSoundFileLookup(selected);
+	const migrated = LEGACY_BUNDLED_SOUND_FILES[lookup];
+	if (migrated) {
+		return migrated;
+	}
+
+	if (lookup.startsWith("assets/") && !soundFileExists(selected) && soundFileExists(fallback)) {
+		return fallback;
+	}
+
+	return selected;
+}
+
 function stringOrEmpty(value: unknown): string {
 	if (typeof value === "string") {
 		return value.trim();
@@ -746,13 +774,13 @@ export function normalizeConfig(raw: unknown): VoiceNotifyConfig {
 		openaiTtsFormat: stringOrDefault(record.openaiTtsFormat, DEFAULT_CONFIG.openaiTtsFormat),
 		openaiTtsSpeed: clampNumber(record.openaiTtsSpeed, DEFAULT_CONFIG.openaiTtsSpeed, 0.25, 4),
 
-		idleSoundFile: stringOrDefault(record.idleSoundFile ?? record.idleSound, DEFAULT_CONFIG.idleSoundFile),
-		permissionSoundFile: stringOrDefault(
+		idleSoundFile: normalizeSoundFile(record.idleSoundFile ?? record.idleSound, DEFAULT_CONFIG.idleSoundFile),
+		permissionSoundFile: normalizeSoundFile(
 			record.permissionSoundFile ?? record.permissionSound,
 			DEFAULT_CONFIG.permissionSoundFile,
 		),
-		questionSoundFile: stringOrDefault(record.questionSoundFile ?? record.questionSound, DEFAULT_CONFIG.questionSoundFile),
-		errorSoundFile: stringOrDefault(record.errorSoundFile ?? record.errorSound, DEFAULT_CONFIG.errorSoundFile),
+		questionSoundFile: normalizeSoundFile(record.questionSoundFile ?? record.questionSound, DEFAULT_CONFIG.questionSoundFile),
+		errorSoundFile: normalizeSoundFile(record.errorSoundFile ?? record.errorSound, DEFAULT_CONFIG.errorSoundFile),
 		themePath: stringOrEmpty(record.themePath ?? record.soundThemeDir ?? record.themeDirectory),
 		themeName: stringOrDefault(record.themeName, DEFAULT_CONFIG.themeName),
 		themesRootPath: stringOrEmpty(record.themesRootPath ?? record.themesRootDirectory),
@@ -989,7 +1017,7 @@ export function isWindows(): boolean {
 
 export function resolveSoundFile(config: VoiceNotifyConfig, type: NotificationType): string | null {
 	const field = SOUND_FILE_FIELD[type];
-	const value = config[field];
+	const value = normalizeSoundFile(config[field], DEFAULT_CONFIG[field]);
 	if (!value.trim()) {
 		return null;
 	}

package/src/index.ts

@@ -127,6 +127,52 @@ function classifyToolResult(
 	return "error";
 }
 
+type AgentEndStatus = "completed" | "error" | "aborted";
+
+interface AgentEndOutcome {
+	status: AgentEndStatus;
+	reason?: string;
+}
+
+function readAgentEndOutcome(event: unknown): AgentEndOutcome {
+	const messages = toRecord(event).messages;
+	if (!Array.isArray(messages)) {
+		return { status: "completed" };
+	}
+
+	for (let index = messages.length - 1; index >= 0; index -= 1) {
+		const message = toRecord(messages[index]);
+		if (message.role !== "assistant") {
+			continue;
+		}
+
+		const stopReason = normalizeOptionalString(message.stopReason);
+		const errorMessage = normalizeOptionalString(message.errorMessage);
+		if (stopReason === "error") {
+			return { status: "error", reason: errorMessage ?? extractTextContent(message.content) };
+		}
+		if (stopReason === "aborted") {
+			return { status: "aborted", reason: errorMessage };
+		}
+		if (errorMessage) {
+			return { status: "error", reason: errorMessage };
+		}
+
+		return { status: "completed" };
+	}
+
+	return { status: "completed" };
+}
+
+function formatAgentErrorNotification(reason: string | undefined): string {
+	const normalizedReason = reason?.replace(/\s+/g, " ").trim();
+	if (!normalizedReason) {
+		return "❌ Agent ended with an error. Check the latest output before continuing.";
+	}
+
+	return `❌ Agent ended with an error: ${normalizedReason.slice(0, 160)}`;
+}
+
 function statusLine(config: VoiceNotifyConfig): string | undefined {
 	if (!config.enabled) {
 		return "voice:off";
@@ -1750,6 +1796,7 @@ export default function smartVoiceNotifyExtension(
 		pendingPermissionToolCallIds.clear();
 		processedToolResultToolCallIds.clear();
 		resetPermissionBatch("agent_start");
+		cancelReminderActivity("agent_start");
 		logger.debug("agent.start", {});
 	});
 
@@ -1803,8 +1850,30 @@ export default function smartVoiceNotifyExtension(
 		});
 	});
 
-	pi.on("agent_end", async (_event, ctx) => {
+	pi.on("agent_end", async (event, ctx) => {
 		activeSessionContext = ctx;
+		const outcome = readAgentEndOutcome(event);
+		if (outcome.status === "error") {
+			hadErrorInTurn = true;
+			logger.debug("agent.end.error_detected", {
+				reason: outcome.reason,
+			});
+			if (config.enabled && config.enableErrorNotification) {
+				triggerNotification("error", ctx, {
+					customMessage: formatAgentErrorNotification(outcome.reason),
+					reason: outcome.reason,
+				});
+			}
+			return;
+		}
+		if (outcome.status === "aborted") {
+			hadErrorInTurn = true;
+			logger.debug("agent.end.idle_skipped", {
+				reason: "agent_aborted",
+				errorMessage: outcome.reason,
+			});
+			return;
+		}
 		if (!config.enabled || !config.enableIdleNotification) {
 			logger.debug("agent.end.idle_skipped", {
 				reason: "idle_notification_disabled",