pi-smart-compact 9.2.1 → 9.3.0

package/dist/provider-eval.js

@@ -156,7 +156,7 @@ function formatProviderEvaluation(report) {
 import fs2 from "fs";
 
 // src/constants.ts
-var VERSION = "9.2.1";
+var VERSION = "9.3.0";
 var SETTLED_TRIGGER_COOLDOWN_MS = 10 * 60000;
 var COMPACT_SYSTEM_PREFIX = "You are an expert conversation summarizer for a coding agent. " + "Produce structured markdown summaries. " + "Follow output format exactly. " + "Use EXACT names \u2014 never paraphrase code identifiers. " + "Trust deterministic extraction data over intuition.";
 var PROFILES = {
@@ -400,6 +400,188 @@ function lruSet(m, key, value, max) {
 }
 
 // src/utils/tokens.ts
+var PROVIDER_MAP = {
+  "zai-anthropic": {
+    maxOutputTokens: 8192,
+    supportsTools: "probe",
+    jsonReliability: "high",
+    instructionFollowing: "high",
+    tokenRatioEstimate: 3.5,
+    concurrencyLimit: 3,
+    cacheStrategy: "anthropic",
+    timeoutMultiplier: 1.2,
+    singlePassTokenMultiplier: 1,
+    multimodal: "metadata-only"
+  },
+  "kimi-coding": {
+    maxOutputTokens: 8192,
+    supportsTools: "probe",
+    jsonReliability: "high",
+    instructionFollowing: "high",
+    tokenRatioEstimate: 3.5,
+    concurrencyLimit: 2,
+    cacheStrategy: "anthropic",
+    timeoutMultiplier: 1.5,
+    singlePassTokenMultiplier: 0.95,
+    multimodal: "metadata-only"
+  },
+  anthropic: {
+    maxOutputTokens: 8192,
+    supportsTools: true,
+    jsonReliability: "high",
+    instructionFollowing: "high",
+    tokenRatioEstimate: 3.5,
+    concurrencyLimit: 3,
+    cacheStrategy: "anthropic",
+    timeoutMultiplier: 1.2,
+    singlePassTokenMultiplier: 1,
+    multimodal: "native"
+  },
+  openai: {
+    maxOutputTokens: 16384,
+    supportsTools: true,
+    jsonReliability: "high",
+    instructionFollowing: "high",
+    tokenRatioEstimate: 4,
+    concurrencyLimit: 5,
+    cacheStrategy: "openai",
+    timeoutMultiplier: 1,
+    singlePassTokenMultiplier: 1.15,
+    multimodal: "native"
+  },
+  google: {
+    maxOutputTokens: 8192,
+    supportsTools: true,
+    jsonReliability: "high",
+    instructionFollowing: "high",
+    tokenRatioEstimate: 3.8,
+    concurrencyLimit: 3,
+    cacheStrategy: "openai",
+    timeoutMultiplier: 1.15,
+    singlePassTokenMultiplier: 1.1,
+    multimodal: "native"
+  },
+  deepseek: {
+    maxOutputTokens: 8192,
+    supportsTools: true,
+    jsonReliability: "medium",
+    instructionFollowing: "medium",
+    tokenRatioEstimate: 3.6,
+    concurrencyLimit: 2,
+    cacheStrategy: "none",
+    timeoutMultiplier: 1.5,
+    singlePassTokenMultiplier: 0.85,
+    multimodal: "metadata-only"
+  },
+  minimax: {
+    maxOutputTokens: 4096,
+    supportsTools: "probe",
+    jsonReliability: "medium",
+    instructionFollowing: "medium",
+    tokenRatioEstimate: 3.8,
+    concurrencyLimit: 2,
+    cacheStrategy: "anthropic",
+    timeoutMultiplier: 1.6,
+    singlePassTokenMultiplier: 0.8,
+    multimodal: "metadata-only"
+  },
+  "xiaomi-token-plan": {
+    maxOutputTokens: 8192,
+    supportsTools: "probe",
+    jsonReliability: "medium",
+    instructionFollowing: "medium",
+    tokenRatioEstimate: 3.3,
+    concurrencyLimit: 2,
+    cacheStrategy: "openai",
+    timeoutMultiplier: 1.35,
+    singlePassTokenMultiplier: 0.9,
+    multimodal: "metadata-only"
+  },
+  "xiaomi-mimo": {
+    maxOutputTokens: 8192,
+    supportsTools: "probe",
+    jsonReliability: "medium",
+    instructionFollowing: "medium",
+    tokenRatioEstimate: 3.3,
+    concurrencyLimit: 2,
+    cacheStrategy: "anthropic",
+    timeoutMultiplier: 1.35,
+    singlePassTokenMultiplier: 0.9,
+    multimodal: "metadata-only"
+  },
+  crofai: {
+    maxOutputTokens: 8192,
+    supportsTools: "probe",
+    jsonReliability: "medium",
+    instructionFollowing: "medium",
+    tokenRatioEstimate: 3.8,
+    concurrencyLimit: 3,
+    cacheStrategy: "none",
+    timeoutMultiplier: 1.2,
+    singlePassTokenMultiplier: 0.95,
+    multimodal: "metadata-only"
+  },
+  mistral: {
+    maxOutputTokens: 8192,
+    supportsTools: true,
+    jsonReliability: "high",
+    instructionFollowing: "high",
+    tokenRatioEstimate: 3.5,
+    concurrencyLimit: 3,
+    cacheStrategy: "openai",
+    timeoutMultiplier: 1.2,
+    singlePassTokenMultiplier: 1,
+    multimodal: "metadata-only"
+  },
+  xai: {
+    maxOutputTokens: 8192,
+    supportsTools: true,
+    jsonReliability: "medium",
+    instructionFollowing: "high",
+    tokenRatioEstimate: 3.8,
+    concurrencyLimit: 3,
+    cacheStrategy: "openai",
+    timeoutMultiplier: 1.2,
+    singlePassTokenMultiplier: 1,
+    multimodal: "native"
+  }
+};
+var PROVIDER_ALIASES = [
+  { pattern: /anthropic/i, provider: "anthropic" },
+  { pattern: /kimi/i, provider: "kimi-coding" },
+  { pattern: /zai/i, provider: "zai-anthropic" },
+  { pattern: /openai/i, provider: "openai" },
+  { pattern: /gpt/i, provider: "openai" },
+  { pattern: /google|gemini/i, provider: "google" },
+  { pattern: /deepseek/i, provider: "deepseek" },
+  { pattern: /minimax/i, provider: "minimax" },
+  { pattern: /xiaomi-mimo/i, provider: "xiaomi-mimo" },
+  { pattern: /xiaomi/i, provider: "xiaomi-token-plan" },
+  { pattern: /crofai/i, provider: "crofai" },
+  { pattern: /mistral/i, provider: "mistral" },
+  { pattern: /xai|grok/i, provider: "xai" }
+];
+var DEFAULT_CAPS = {
+  maxOutputTokens: 8192,
+  supportsTools: "probe",
+  jsonReliability: "medium",
+  instructionFollowing: "medium",
+  tokenRatioEstimate: 3.8,
+  concurrencyLimit: 2,
+  cacheStrategy: "none",
+  timeoutMultiplier: 1.35,
+  singlePassTokenMultiplier: 0.9,
+  multimodal: "metadata-only"
+};
+function getProviderCaps(provider) {
+  if (PROVIDER_MAP[provider])
+    return PROVIDER_MAP[provider];
+  for (const { pattern, provider: key } of PROVIDER_ALIASES) {
+    if (pattern.test(provider))
+      return PROVIDER_MAP[key] ?? DEFAULT_CAPS;
+  }
+  return DEFAULT_CAPS;
+}
 class TokenCalibrationStore {
   maxEntries;
   factors = new Map;
@@ -497,13 +679,53 @@ function buildUniquePathNeedles(filePath, allPaths) {
   });
 }
 function isKnownPathReference(ref, knownPaths) {
-  const normalizedRef = normalizePath(ref);
+  const normalizedRef = normalizePath(ref).replace(/^\/+/, "");
+  if (!normalizedRef)
+    return false;
+  const pathShaped = normalizedRef.includes("/");
   return knownPaths.some((path) => {
-    const normalizedPath = normalizePath(path);
-    return normalizedPath === normalizedRef || normalizedPath.endsWith("/" + normalizedRef);
+    const normalizedPath = normalizePath(path).replace(/^\/+/, "");
+    if (normalizedPath === normalizedRef || normalizedPath.endsWith("/" + normalizedRef))
+      return true;
+    if (normalizedPath.endsWith(normalizedRef)) {
+      const boundary = normalizedPath[normalizedPath.length - normalizedRef.length - 1];
+      if (boundary && !/[\w./-]/.test(boundary))
+        return true;
+    }
+    if (!pathShaped)
+      return false;
+    return normalizedPath.split("/").some((_, index, parts) => parts.slice(index).join("/").startsWith(normalizedRef + "/"));
   });
 }
 
+// src/utils/logger.ts
+var DEBUG = process.env.DEBUG?.includes("smart-compact") ?? false;
+function warn(msg, err) {
+  const detail = err instanceof Error ? err.message : err ?? "";
+  console.error(LOG_PREFIX + " " + msg + (detail ? ": " + detail : ""));
+}
+
+// src/infra/paths.ts
+import path from "path";
+function home() {
+  return process.env.HOME ?? "/tmp";
+}
+function piAgentDir() {
+  return path.join(home(), ".pi", "agent");
+}
+function cacheDir() {
+  return path.join(piAgentDir(), ".cache");
+}
+function smartCompactCacheDir() {
+  return path.join(cacheDir(), "smart-compact");
+}
+function metricsLogFile() {
+  return path.join(cacheDir(), "compact-metrics.jsonl");
+}
+function damageReportsFile() {
+  return path.join(smartCompactCacheDir(), "damage-reports.jsonl");
+}
+
 // src/domain/tool-semantics.ts
 var PATH_KEYS = [
   "path",
@@ -586,10 +808,20 @@ function isLikelyFileRef(candidate) {
   return CODE_EXT_RE.test(candidate);
 }
 function extractFileRefs(summary) {
-  const candidates = summary.match(FILE_REF_CANDIDATE_RE) ?? [];
-  return candidates.filter(isLikelyFileRef);
+  const matcher = new RegExp(FILE_REF_CANDIDATE_RE.source, FILE_REF_CANDIDATE_RE.flags);
+  const refs = [];
+  for (const match of summary.matchAll(matcher)) {
+    if (/[\\/]/.test(summary[(match.index ?? 0) + match[0].length] ?? ""))
+      continue;
+    if (isLikelyFileRef(match[0]))
+      refs.push(match[0]);
+  }
+  return refs;
 }
 
+// src/domain/summary-parse.ts
+import { createHash } from "crypto";
+
 // src/domain/summary-schema.ts
 function classifyHeading(raw) {
   const text = raw.replace(/^#+\s*/, "").replace(/[:\s]+$/, "").trim().toLowerCase();
@@ -629,6 +861,58 @@ var HEADING_RE = /^(#{1,3})\s+(.+?)\s*$/;
 function summaryEvidenceLine(value, maxLength) {
   return value.replace(/[\u0000-\u0008\u000B\u000C\u000E-\u001F\u007F]/g, " ").replace(/\s+/g, " ").trim().replace(/^(?:(?:#{1,6}|[-*+]|>)\s+)+/, "").slice(0, maxLength).trim();
 }
+function summaryPathLine(value) {
+  return JSON.stringify(value);
+}
+function compactPathLine(value, maxLength, digest) {
+  const minimal = JSON.stringify("#" + digest);
+  if (minimal.length >= maxLength)
+    return minimal;
+  const chars = Array.from(value.replace(/\\/g, "/"));
+  let low = 0;
+  let high = chars.length;
+  let best = minimal;
+  while (low <= high) {
+    const length = Math.floor((low + high) / 2);
+    const candidate = JSON.stringify("\u2026/" + chars.slice(-length).join("") + "#" + digest);
+    if (candidate.length <= maxLength) {
+      best = candidate;
+      low = length + 1;
+    } else {
+      high = length - 1;
+    }
+  }
+  return best;
+}
+function buildSummaryPathEvidence(paths, budgetTokens = PROFILES.balanced.summaryBudgetTokens) {
+  const unique = Array.from(new Set(paths.filter(Boolean)));
+  if (!unique.length)
+    return new Map;
+  const full = unique.map((path2) => [path2, summaryPathLine(path2)]);
+  const minimumPerLine = JSON.stringify("#" + "x".repeat(12)).length + 3;
+  const budgetChars = Math.max(unique.length * minimumPerLine, Math.min(20000, Math.max(4000, Math.floor(budgetTokens * 2))));
+  if (full.reduce((total, [, line]) => total + line.length + 3, 0) <= budgetChars) {
+    return new Map(full);
+  }
+  const digests = new Map;
+  const owners = new Map;
+  for (const path2 of unique) {
+    const fullDigest = createHash("sha256").update(path2).digest("base64url");
+    let digest = fullDigest.slice(0, 12);
+    const owner = owners.get(digest);
+    if (owner && owner !== path2) {
+      digest = fullDigest;
+      digests.set(owner, createHash("sha256").update(owner).digest("base64url"));
+    }
+    owners.set(digest, path2);
+    digests.set(path2, digest);
+  }
+  const perPath = Math.max(JSON.stringify("#" + "x".repeat(12)).length, Math.floor((budgetChars - unique.length * 3) / unique.length));
+  return new Map(unique.map((path2) => [
+    path2,
+    compactPathLine(path2, perPath, digests.get(path2) ?? "")
+  ]));
+}
 function mergeBodies(first, second) {
   const seen = new Set;
   return [first, second].filter(Boolean).flatMap((body) => body.split(`
@@ -653,7 +937,11 @@ function parseSummary(markdown) {
     if (existing)
       existing.body = mergeBodies(existing.body, body);
     else
-      sections.push({ kind: currentKind, heading: currentHeading.trim(), body });
+      sections.push({
+        kind: currentKind,
+        heading: currentHeading.trim(),
+        body
+      });
   };
   for (const line of lines) {
     const fenceMatch = line.match(/^\s{0,3}(`{3,}|~{3,})(.*)$/);
@@ -744,7 +1032,11 @@ function buildToolCallIndex(msgs) {
         for (let t = 0;t < nested.length; t++) {
           const tool = nested[t];
           const id = nestedToolCallId(b.id, i, t, tool.id);
-          idx.set(id, { name: tool.name, arguments: tool.arguments, msgIndex: i });
+          idx.set(id, {
+            name: tool.name,
+            arguments: tool.arguments,
+            msgIndex: i
+          });
         }
       }
     }
@@ -752,46 +1044,42 @@ function buildToolCallIndex(msgs) {
   return idx;
 }
 var CONSTRAINT_PATTERNS = [
-  { re: /\b(?:must|need|require|has to|important)\b.*\b(?:be|use|have|include|support)\b/i, cat: "requirement", conf: TUNING.CONFIDENCE_HIGH },
-  { re: /\b(?:don't|never|avoid|shouldn't|must not|do not|no\s+(?:need|want))\b/i, cat: "prohibition", conf: TUNING.CONFIDENCE_MEDIUM },
-  { re: /\b(?:prefer|like|want|would rather|should)\b.*\b(?:use|be|have|with)\b/i, cat: "preference", conf: TUNING.CONFIDENCE_LOW },
-  { re: /(?<![A-Za-z0-9_])(?:yapma|kullanma|sak\u0131n|sak\u0131nha|asla(?:\s+(?:kullanma|yapma|getirme))?|bunu yapma)(?![A-Za-z0-9_])/iu, cat: "prohibition", conf: TUNING.CONFIDENCE_MEDIUM },
-  { re: /(?<![A-Za-z0-9_])(?:kritik|kritikal|\u00F6nemli|onemli|\u015Fart|sart|zorunlu|\u015Fart ko\u015Ful|\u00F6nemli \u015Fart|kesinlikle|kesinlikle \u015Fart|b\u00F6yle olsun|b\u00F6yle yap\u0131n|\u015F\u00F6yle olsun|\u015F\u00F6yle yap\u0131n)(?![A-Za-z0-9_])/iu, cat: "requirement", conf: TUNING.CONFIDENCE_MEDIUM },
-  { re: /(?<![A-Za-z0-9_])(?:tercih|isterim|olsun|kullanal\u0131m|yapal\u0131m|istiyorum)(?![A-Za-z0-9_])/iu, cat: "preference", conf: TUNING.CONFIDENCE_LOW }
+  {
+    re: /\b(?:must|need|require|has to|important)\b.*\b(?:be|use|have|include|support)\b/i,
+    cat: "requirement",
+    conf: TUNING.CONFIDENCE_HIGH
+  },
+  {
+    re: /\b(?:don't|never|avoid|shouldn't|must not|do not|no\s+(?:need|want))\b/i,
+    cat: "prohibition",
+    conf: TUNING.CONFIDENCE_MEDIUM
+  },
+  {
+    re: /\b(?:prefer|like|want|would rather|should)\b.*\b(?:use|be|have|with)\b/i,
+    cat: "preference",
+    conf: TUNING.CONFIDENCE_LOW
+  },
+  {
+    re: /(?<![A-Za-z0-9_])(?:yapma|kullanma|sak\u0131n|sak\u0131nha|asla(?:\s+(?:kullanma|yapma|getirme))?|bunu yapma)(?![A-Za-z0-9_])/iu,
+    cat: "prohibition",
+    conf: TUNING.CONFIDENCE_MEDIUM
+  },
+  {
+    re: /(?<![A-Za-z0-9_])(?:kritik|kritikal|\u00F6nemli|onemli|\u015Fart|sart|zorunlu|\u015Fart ko\u015Ful|\u00F6nemli \u015Fart|kesinlikle|kesinlikle \u015Fart|b\u00F6yle olsun|b\u00F6yle yap\u0131n|\u015F\u00F6yle olsun|\u015F\u00F6yle yap\u0131n)(?![A-Za-z0-9_])/iu,
+    cat: "requirement",
+    conf: TUNING.CONFIDENCE_MEDIUM
+  },
+  {
+    re: /(?<![A-Za-z0-9_])(?:tercih|isterim|olsun|kullanal\u0131m|yapal\u0131m|istiyorum)(?![A-Za-z0-9_])/iu,
+    cat: "preference",
+    conf: TUNING.CONFIDENCE_LOW
+  }
 ];
 function isDiagnosticConstraintText(text) {
   const candidate = text.replace(/^\s*[-*]\s+/, "").trim();
   return /^(?:\[[^\]]+\]\s*)?(?:npm\s+(?:error|warn|notice|audit|verbose|info)\b|(?:rg|grep):|command exited\b)/i.test(candidate);
 }
 
-// src/utils/logger.ts
-var DEBUG = process.env.DEBUG?.includes("smart-compact") ?? false;
-function warn(msg, err) {
-  const detail = err instanceof Error ? err.message : err ?? "";
-  console.error(LOG_PREFIX + " " + msg + (detail ? ": " + detail : ""));
-}
-
-// src/infra/paths.ts
-import path from "path";
-function home() {
-  return process.env.HOME ?? "/tmp";
-}
-function piAgentDir() {
-  return path.join(home(), ".pi", "agent");
-}
-function cacheDir() {
-  return path.join(piAgentDir(), ".cache");
-}
-function smartCompactCacheDir() {
-  return path.join(cacheDir(), "smart-compact");
-}
-function metricsLogFile() {
-  return path.join(cacheDir(), "compact-metrics.jsonl");
-}
-function damageReportsFile() {
-  return path.join(smartCompactCacheDir(), "damage-reports.jsonl");
-}
-
 // src/infra/fs.ts
 import fs from "fs";
 function readJsonlTail(target, limit, maxBytes = 512 * 1024) {
@@ -886,7 +1174,10 @@ function withCodexWireLimit(model, opts) {
     onPayload: async (payload, requestModel) => {
       const transformed = await previous?.(payload, requestModel);
       const body = transformed ?? payload;
-      return body && typeof body === "object" ? { ...body, max_output_tokens: opts.maxTokens } : body;
+      return body && typeof body === "object" ? {
+        ...body,
+        max_output_tokens: opts.maxTokens
+      } : body;
     }
   };
 }
@@ -907,11 +1198,12 @@ function assertSuccessful(message) {
   }
   return message;
 }
-async function withProviderDeadline(opts, invoke) {
+async function withProviderDeadline(opts, invoke, modelId) {
   if (opts.signal?.aborted)
     throw new Error("LLM request aborted before dispatch");
   const controller = new AbortController;
-  const watchdogMs = resolveCodexWatchdogMs(opts.maxTokens, opts.codexWatchdogMs);
+  const multiplier = modelId && !((opts.codexWatchdogMs ?? 0) > 0) ? getProviderCaps(modelId).timeoutMultiplier : 1;
+  const watchdogMs = Math.round(resolveCodexWatchdogMs(opts.maxTokens, opts.codexWatchdogMs) * multiplier);
   const abort = Promise.withResolvers();
   const abortFromCaller = () => {
     controller.abort(opts.signal?.reason);
@@ -984,7 +1276,7 @@ var rawLlmClient = {
         return completeChatGptCodex(model, body, bounded);
       const response = bounded.reasoning === undefined ? await (await resolveComplete())(model, body, bounded) : await (await resolveCompleteSimple())(model, body, bounded);
       return assertSuccessful(response);
-    });
+    }, model.id);
   }
 };
 var defaultLlmClient = rawLlmClient;
@@ -998,7 +1290,10 @@ import crypto from "crypto";
 
 // src/domain/scrub.ts
 var SECRET_PATTERNS = [
-  { kind: "private-key", regex: /-----BEGIN [A-Z ]*PRIVATE KEY-----[\s\S]*?-----END [A-Z ]*PRIVATE KEY-----/g },
+  {
+    kind: "private-key",
+    regex: /-----BEGIN [A-Z ]*PRIVATE KEY-----[\s\S]*?-----END [A-Z ]*PRIVATE KEY-----/g
+  },
   { kind: "aws-access-key", regex: /\bAKIA[0-9A-Z]{16}\b/g },
   { kind: "google-api-key", regex: /\bAIza[0-9A-Za-z_-]{30,}\b/g },
   { kind: "stripe-key", regex: /\b[rs]k_(?:live|test)_[0-9A-Za-z]{16,}\b/g },
@@ -1007,8 +1302,15 @@ var SECRET_PATTERNS = [
   { kind: "github-token", regex: /\bgh[pousr]_[A-Za-z0-9]{20,}\b/g },
   { kind: "api-key", regex: /\bsk-(?:ant-)?[A-Za-z0-9_-]{20,}\b/g },
   { kind: "slack-token", regex: /\bxox[baprs]-[A-Za-z0-9-]{10,}\b/g },
-  { kind: "jwt", regex: /\beyJ[A-Za-z0-9_-]{10,}\.[A-Za-z0-9_-]{10,}\.[A-Za-z0-9_-]{10,}\b/g },
-  { kind: "bearer-token", regex: /\bBearer\s+[A-Za-z0-9._~+\/-]{12,}=*/gi, replacement: () => "Bearer [REDACTED:bearer-token]" },
+  {
+    kind: "jwt",
+    regex: /\beyJ[A-Za-z0-9_-]{10,}\.[A-Za-z0-9_-]{10,}\.[A-Za-z0-9_-]{10,}\b/g
+  },
+  {
+    kind: "bearer-token",
+    regex: /\bBearer\s+[A-Za-z0-9._~+/-]{12,}=*/gi,
+    replacement: () => "Bearer [REDACTED:bearer-token]"
+  },
   {
     kind: "connection-password",
     regex: /\b([a-z][a-z0-9+.-]*:\/\/[^:\s/@]+:)[^@\s/]+(@)/gi,
@@ -1017,12 +1319,35 @@ var SECRET_PATTERNS = [
   {
     kind: "credential",
     regex: /\b((?:[A-Za-z0-9]+[_-])*(?:api[_-]?key|access[_-]?token|auth[_-]?token|token|password|passwd|secret(?:[_-]?(?:access)?[_-]?key)?|client[_-]?secret)(?:[_-][A-Za-z0-9]+)*)\s*([:=])\s*["']?([^\s"']{16,})["']?/gi,
-    replacement: (name, separator) => name + separator + "[REDACTED:credential]"
+    replacement: (name, separator, value, match) => /^[A-Za-z_$][\w$]*(?:\.[A-Za-z_$][\w$]*)+$/.test(value) ? match : name + separator + "[REDACTED:credential]"
   }
 ];
+function passesLuhn(candidate) {
+  const digits = candidate.replace(/\D/g, "");
+  if (digits.length < 13 || digits.length > 19)
+    return false;
+  if (/^(\d)\1+$/.test(digits))
+    return false;
+  let sum = 0, double = false;
+  for (let i = digits.length - 1;i >= 0; i--) {
+    let d = digits.charCodeAt(i) - 48;
+    if (double) {
+      d *= 2;
+      if (d > 9)
+        d -= 9;
+    }
+    sum += d;
+    double = !double;
+  }
+  return sum % 10 === 0;
+}
 var PII_PATTERNS = [
   { kind: "email", regex: /\b[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,}\b/gi },
-  { kind: "payment-card", regex: /\b(?:\d[ -]*?){13,19}\b/g },
+  {
+    kind: "payment-card",
+    regex: /\b(?:\d[ -]*?){13,19}\b/g,
+    replacement: (candidate) => passesLuhn(candidate) ? "[REDACTED:payment-card]" : candidate
+  },
   { kind: "phone", regex: /(?<![\w.])(?:\+?\d[\d ()-]{8,}\d)(?![\w.])/g }
 ];
 function redact(text, patterns) {
@@ -1030,15 +1355,22 @@ function redact(text, patterns) {
   let value = text;
   for (const pattern of patterns) {
     value = value.replace(pattern.regex, (...args) => {
-      counts.set(pattern.kind, (counts.get(pattern.kind) ?? 0) + 1);
+      const match = String(args[0]);
+      let replacement = "[REDACTED:" + pattern.kind + "]";
       if (pattern.replacement) {
         const groups = args.slice(1, -2).map(String);
-        return pattern.replacement(...groups);
+        replacement = pattern.replacement(...groups, match);
       }
-      return "[REDACTED:" + pattern.kind + "]";
+      if (replacement === match)
+        return match;
+      counts.set(pattern.kind, (counts.get(pattern.kind) ?? 0) + 1);
+      return replacement;
     });
   }
-  return { value, findings: [...counts].map(([kind, count]) => ({ kind, count })) };
+  return {
+    value,
+    findings: [...counts].map(([kind, count]) => ({ kind, count }))
+  };
 }
 function mergeFindings(target, findings) {
   for (const finding of findings)
@@ -1068,7 +1400,6 @@ var SECRET_KEY_NAMES = {
   set_cookie: true,
   otp: true,
   one_time_password: true,
-  pin: true,
   passcode: true
 };
 function normalizeObjectKey(key) {
@@ -1134,7 +1465,7 @@ class SecretScrubber {
       const output = {};
       seen.set(value2, output);
       for (const [key, item] of Object.entries(value2)) {
-        const carriesSecret = typeof item === "string" ? item.length > 0 : item != null;
+        const carriesSecret = typeof item === "string" && item.length >= 8;
         if (this.secretsEnabled && isSecretBearingKey(key) && carriesSecret) {
           output[key] = "[REDACTED:credential]";
           recordCredential();
@@ -1145,7 +1476,10 @@ class SecretScrubber {
       return output;
     };
     const value = visit(input);
-    return { value, findings: [...findings].map(([kind, count]) => ({ kind, count })) };
+    return {
+      value,
+      findings: [...findings].map(([kind, count]) => ({ kind, count }))
+    };
   }
   count() {
     return this.total;