pi-skillful 0.3.8 → 0.3.9

package/CHANGELOG.md

@@ -1,11 +1,17 @@
 # Changelog
 
+## 0.3.9 - 2026-06-14
+
 All notable changes to this project will be documented in this file.
 
 This project follows the spirit of [Keep a Changelog](https://keepachangelog.com/en/1.1.0/) and uses semantic versioning for releases.
 
 ## [Unreleased]
 
+### Fixed
+
+- Skipped Pi package-bundled skills when applying hidden-skill and toggle-slot configuration so `skillful` only affects global and project skills.
+
 ## [0.3.8] - 2026-06-06
 
 ### Changed

package/README.md

@@ -37,6 +37,8 @@ Hidden skills:
 - remain loaded by Pi;
 - remain available for explicit invocation with `/skill:name`, including inline invocation.
 
+Skills bundled in Pi packages are never affected by `skillful`; only global and project skills can be hidden or toggled.
+
 Configuration is stored under the `skillful` key in Pi settings:
 
 ```json
@@ -60,7 +62,7 @@ Open the menu with:
 /skillful
 ```
 
-The menu lists all loaded skills alphabetically. Toggle a skill off or on in the active scope. Use the Global/Project tabs to choose which settings file to edit. In the Project tab, inherited on/off values are shown normally; project overrides are highlighted. Press `1` through `9` on a selected skill to assign or clear that scope's session toggle slot. Visibility and toggle slots are independent.
+The menu lists configurable skills alphabetically. Toggle a skill off or on in the active scope. Use the Global/Project tabs to choose which settings file to edit. In the Project tab, inherited on/off values are shown normally; project overrides are highlighted. Press `1` through `9` on a selected skill to assign or clear that scope's session toggle slot. Visibility and toggle slots are independent.
 
 Pi's startup `[Skills]` list also highlights hidden skills in the error color (red in the default dark theme).
 
@@ -88,7 +90,7 @@ Configured slots appear on the prompt editor's top border as `N skill-name`. Pro
 
 `toggleModifier` defaults to `"alt"`. Supported values are `"alt"`, `"ctrl"`, `"ctrl+shift"`, `"alt+shift"`, `"ctrl+alt"`, and `"ctrl+alt+shift"`. Change it if your terminal reserves `alt+number` shortcuts.
 
-On app startup, non-hidden skills are active and hidden skills are inactive. Within a running Pi process, `/new` preserves the current toggle state for the new session. Resuming, forking, cloning, reloading, or restarting Pi resets toggle state from settings. Inline `/skill:name` invocation remains explicit and works even when that skill is inactive.
+On app startup, non-hidden skills are active and hidden skills are inactive. Within a running Pi process, `/new` preserves the current toggle state for the new session. Resuming, forking, cloning, reloading, or restarting Pi resets toggle state from settings. Inline `/skill:name` invocation remains explicit and works even when that skill is inactive. Skills bundled in Pi packages are never modified by these toggles.
 
 ## Installation
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-skillful",
-  "version": "0.3.8",
+  "version": "0.3.9",
   "description": "Pi package with skill invocation and visibility improvements.",
   "type": "module",
   "exports": {
@@ -45,8 +45,8 @@
     "@earendil-works/pi-tui": "*"
   },
   "devDependencies": {
-    "@earendil-works/pi-coding-agent": "^0.75.4",
-    "@earendil-works/pi-tui": "^0.75.4",
+    "@earendil-works/pi-coding-agent": "^0.78.0",
+    "@earendil-works/pi-tui": "^0.78.0",
     "@types/node": "^25.6.2",
     "typescript": "^6.0.3"
   },

package/src/extensions/session-skill-toggles.ts

@@ -11,7 +11,7 @@ import {
   type SkillToggleSlot,
 } from "../config.js";
 import { replaceSkillsSection } from "../skill-prompt.js";
-import { listLoadedSkills } from "../skills.js";
+import { isTopLevelSkill, listLoadedSkills } from "../skills.js";
 
 const WIDGET_KEY = "pi-skillful-session-toggles";
 const STORE_KEY = Symbol.for("pi-skillful.sessionSkillTogglesStore");
@@ -97,10 +97,9 @@ export default function sessionSkillToggles(pi: ExtensionAPI) {
   pi.on("before_agent_start", (event) => {
     if (state.slots.length === 0 || !event.systemPromptOptions.skills?.length) return;
 
-    const updatedSkills: Skill[] = event.systemPromptOptions.skills.map((skill) => ({
-      ...skill,
-      disableModelInvocation: !isSkillActive(normalizeSkillName(skill.name)),
-    }));
+    const updatedSkills: Skill[] = event.systemPromptOptions.skills.map((skill) =>
+      isTopLevelSkill(skill) ? { ...skill, disableModelInvocation: !isSkillActive(normalizeSkillName(skill.name)) } : skill,
+    );
 
     const systemPrompt = replaceSkillsSection(event.systemPrompt, updatedSkills);
     if (!systemPrompt) return;
@@ -164,7 +163,11 @@ function configuredToggleSlots(
   pi: ExtensionAPI,
   toggleSlots: Partial<Record<SkillToggleSlot, string>>,
 ): ToggleSlotState[] {
-  const loadedSkillNames = new Set(listLoadedSkills(pi.getCommands()).map((skill) => skill.name));
+  const loadedSkillNames = new Set(
+    listLoadedSkills(pi.getCommands())
+      .filter(isTopLevelSkill)
+      .map((skill) => skill.name),
+  );
   return SKILL_TOGGLE_SLOTS.flatMap((slot): ToggleSlotState[] => {
     const skillName = toggleSlots[slot];
     if (!skillName || !loadedSkillNames.has(skillName)) return [];

package/src/extensions/skill-visibility.ts

@@ -20,7 +20,7 @@ import {
   writeToggleSlots,
 } from "../config.js";
 import { replaceSkillsSection } from "../skill-prompt.js";
-import { listLoadedSkills, type LoadedSkillInfo } from "../skills.js";
+import { isTopLevelSkill, listLoadedSkills, type LoadedSkillInfo } from "../skills.js";
 import { hasActiveSessionSkillToggles, refreshSessionSkillToggles } from "./session-skill-toggles.js";
 const SCOPES: SkillfulScope[] = ["global", "project"];
 const STORE_KEY = Symbol.for("pi-skillful.skillVisibilityStore");
@@ -95,7 +95,7 @@ export default function skillVisibility(pi: ExtensionAPI) {
     if (hidden.size === 0 || !event.systemPromptOptions.skills?.length) return;
 
     const filteredSkills: Skill[] = event.systemPromptOptions.skills.map((skill) =>
-      hidden.has(skill.name) ? { ...skill, disableModelInvocation: true } : skill,
+      isTopLevelSkill(skill) && hidden.has(skill.name) ? { ...skill, disableModelInvocation: true } : skill,
     );
     const systemPrompt = replaceSkillsSection(event.systemPrompt, filteredSkills);
     if (!systemPrompt) return;
@@ -239,7 +239,7 @@ function buildColorizedSkillList(names: string[], hidden: Set<string>, theme: Th
 }
 
 function getSkillItems(pi: ExtensionAPI): SkillListItem[] {
-  return listLoadedSkills(pi.getCommands());
+  return listLoadedSkills(pi.getCommands()).filter(isTopLevelSkill);
 }
 
 class SkillfulVisibilityMenu implements Component {

package/src/skills.ts

@@ -1,5 +1,6 @@
 import { readFile } from "node:fs/promises";
 import { dirname } from "node:path";
+import type { SourceInfo } from "@earendil-works/pi-coding-agent";
 import { normalizeSkillName } from "./config.js";
 
 export interface SkillCommandInfo {
@@ -11,12 +12,14 @@ export interface SkillCommandInfo {
 export interface LoadedSkillInfo {
   name: string;
   description: string;
+  sourceInfo: SourceInfo;
 }
 
 interface CommandLike {
   name: string;
   source: string;
   description?: string;
+  sourceInfo: SourceInfo;
 }
 
 export function listLoadedSkills(commands: Iterable<CommandLike>): LoadedSkillInfo[] {
@@ -25,11 +28,15 @@ export function listLoadedSkills(commands: Iterable<CommandLike>): LoadedSkillIn
     if (command.source !== "skill") continue;
     const name = normalizeSkillName(command.name);
     if (!name) continue;
-    byName.set(name, { name, description: command.description ?? "" });
+    byName.set(name, { name, description: command.description ?? "", sourceInfo: command.sourceInfo });
   }
   return Array.from(byName.values()).sort((a, b) => a.name.localeCompare(b.name));
 }
 
+export function isTopLevelSkill(skill: { sourceInfo: { origin: SourceInfo["origin"] } }): boolean {
+  return skill.sourceInfo.origin === "top-level";
+}
+
 export function stripFrontmatter(markdown: string): string {
   const normalized = markdown.replace(/^\uFEFF/, "");
   const match = normalized.match(/^---\r?\n[\s\S]*?\r?\n---\r?\n?/);