pi-skillful 0.1.0 → 0.2.1

package/CHANGELOG.md

@@ -6,9 +6,11 @@ This project follows the spirit of [Keep a Changelog](https://keepachangelog.com
 
 ## [Unreleased]
 
+## [0.2.0] - 2026-05-07
+
 ### Added
 
 - Inline `/skill:name` expansion anywhere in a prompt.
 - `/skillful` menu for global/project skill prompt visibility.
 - `skillful.hiddenSkills` settings support.
-- Startup skill-list annotations for visible vs hidden skills.
+- Startup `[Skills]` list highlights hidden skills in the error color.

package/README.md

@@ -57,7 +57,7 @@ Open the menu with:
 
 The menu lists all loaded skills alphabetically. Toggle a skill off to save it in the active scope's `hiddenSkills` list. Use the Global/Project tabs to choose which settings file to edit.
 
-Pi's startup `[Skills]` list is also annotated: visible skills are marked with a green dot, and hidden skills are marked with a dim red dot.
+Pi's startup `[Skills]` list also highlights hidden skills in the error color (red in the default dark theme).
 
 When the project settings file contains only `skillful` settings and the project `hiddenSkills` list becomes empty, `.pi/settings.json` is deleted instead of leaving an empty settings file behind.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-skillful",
-  "version": "0.1.0",
+  "version": "0.2.1",
   "description": "Pi package with skill invocation and visibility improvements.",
   "type": "module",
   "license": "MIT",

package/src/extensions/skill-visibility.ts

@@ -20,16 +20,34 @@ import {
 const SKILLS_SECTION_PATTERN = /\n\nThe following skills provide specialized instructions for specific tasks\.[\s\S]*?<\/available_skills>/;
 const SCOPES: SkillfulScope[] = ["global", "project"];
 const STORE_KEY = Symbol.for("pi-skillful.skillVisibilityStore");
-const STARTUP_SKILL_LIST_PATCH_KEY = Symbol.for("pi-skillful.startupSkillListPatchInstalled");
+const STARTUP_PATCH_KEY = Symbol.for("pi-skillful.startupPatchV2");
 
 interface SkillVisibilityStore {
   hiddenSkillsByCwd: Map<string, Set<string>>;
   lastHiddenSkills: Set<string>;
+  theme: Theme | null;
 }
 
-const skillVisibilityStore = (((globalThis as Record<PropertyKey, unknown>)[STORE_KEY] as SkillVisibilityStore | undefined) ??= {
+interface ExpandableTextLike {
+  getCollapsedText: () => string;
+  setText: (text: string) => void;
+}
+
+interface BoxLike {
+  children: unknown[];
+}
+
+interface InteractiveModeLike {
+  chatContainer?: BoxLike;
+  showLoadedResources?: (options?: unknown) => void;
+  session?: { resourceLoader?: { getSkills: () => { skills: Skill[]; diagnostics: unknown[] } } };
+  sessionManager?: { getCwd?: () => string };
+}
+
+const store = (((globalThis as Record<PropertyKey, unknown>)[STORE_KEY] as SkillVisibilityStore | undefined) ??= {
   hiddenSkillsByCwd: new Map<string, Set<string>>(),
   lastHiddenSkills: new Set<string>(),
+  theme: null,
 }) as SkillVisibilityStore;
 
 interface SkillListItem {
@@ -41,7 +59,8 @@ export default function skillVisibility(pi: ExtensionAPI) {
   installStartupSkillListPatch();
 
   pi.on("session_start", async (_event, ctx) => {
-    await refreshHiddenSkillCache(ctx.cwd);
+    store.theme = ctx.ui.theme;
+    await pruneStaleHiddenSkills(pi, ctx.cwd);
   });
 
   pi.on("before_agent_start", async (event, ctx) => {
@@ -90,34 +109,45 @@ export default function skillVisibility(pi: ExtensionAPI) {
   });
 }
 
+async function pruneStaleHiddenSkills(pi: ExtensionAPI, cwd: string): Promise<void> {
+  const installedNames = new Set(getSkillItems(pi).map((s) => s.name));
+  const scoped = await readScopedSkillfulSettings(cwd);
+
+  await Promise.all(
+    SCOPES.map(async (scope) => {
+      const current = scoped[scope].hiddenSkills;
+      const pruned = current.filter((name) => installedNames.has(name));
+      if (pruned.length < current.length) {
+        await writeHiddenSkills(scope, cwd, pruned);
+        scoped[scope] = { hiddenSkills: pruned };
+      }
+    }),
+  );
+
+  const hidden = new Set([...scoped.global.hiddenSkills, ...scoped.project.hiddenSkills]);
+  store.hiddenSkillsByCwd.set(cwd, hidden);
+  store.lastHiddenSkills = hidden;
+}
+
 async function refreshHiddenSkillCache(cwd: string): Promise<Set<string>> {
   const hidden = await readEffectiveHiddenSkills(cwd);
-  skillVisibilityStore.hiddenSkillsByCwd.set(cwd, hidden);
-  skillVisibilityStore.lastHiddenSkills = hidden;
+  store.hiddenSkillsByCwd.set(cwd, hidden);
+  store.lastHiddenSkills = hidden;
   return hidden;
 }
 
+// Must patch the real prototype from pi's module — separate module resolutions have distinct class identities.
 function installStartupSkillListPatch(): void {
-  type StartupResourceLoader = {
-    getSkills: () => { skills: Skill[]; diagnostics: unknown[] };
-  };
-  type InteractiveModeWithStartupResources = {
-    showLoadedResources?: (options?: unknown) => void;
-    session?: { resourceLoader?: StartupResourceLoader };
-    sessionManager?: { getCwd?: () => string };
-  };
+  const realPrototype = (InteractiveMode as unknown as { prototype: InteractiveModeLike }).prototype;
+  if (!realPrototype) return;
 
-  const prototype = (InteractiveMode as unknown as { prototype: InteractiveModeWithStartupResources }).prototype;
-  const patchState = prototype as InteractiveModeWithStartupResources & Record<PropertyKey, unknown>;
-  if (patchState[STARTUP_SKILL_LIST_PATCH_KEY]) return;
+  const patchState = realPrototype as Record<PropertyKey, unknown>;
+  if (patchState[STARTUP_PATCH_KEY]) return;
 
-  const original = prototype.showLoadedResources;
+  const original = realPrototype.showLoadedResources;
   if (typeof original !== "function") return;
 
-  prototype.showLoadedResources = function showLoadedResourcesWithSkillfulVisibility(
-    this: InteractiveModeWithStartupResources,
-    options?: unknown,
-  ): void {
+  realPrototype.showLoadedResources = function (this: InteractiveModeLike, options?: unknown): void {
     const loader = this.session?.resourceLoader;
     const originalGetSkills = loader?.getSkills;
     if (!loader || typeof originalGetSkills !== "function") {
@@ -126,31 +156,48 @@ function installStartupSkillListPatch(): void {
     }
 
     const cwd = this.sessionManager?.getCwd?.();
-    const hidden = (cwd ? skillVisibilityStore.hiddenSkillsByCwd.get(cwd) : undefined) ?? skillVisibilityStore.lastHiddenSkills;
 
+    let rawSkillNames: string[] = [];
     loader.getSkills = () => {
       const result = originalGetSkills.call(loader);
-      return {
-        ...result,
-        skills: result.skills.map((skill) => ({
-          ...skill,
-          name: formatStartupSkillName(skill.name, hidden.has(skill.name)),
-        })),
-      };
+      rawSkillNames = result.skills.map((s) => normalizeSkillName(s.name));
+      return result;
     };
 
+    const childrenBefore = this.chatContainer?.children.length ?? 0;
+
     try {
       original.call(this, options);
     } finally {
       loader.getSkills = originalGetSkills;
     }
+
+    if (rawSkillNames.length === 0 || !cwd || !this.chatContainer) return;
+
+    const children = this.chatContainer.children;
+    for (let i = childrenBefore; i < children.length; i++) {
+      const child = children[i] as ExpandableTextLike | undefined;
+      if (!child || typeof child.getCollapsedText !== "function") continue;
+      const collapsed = child.getCollapsedText();
+      if (!collapsed.includes("[Skills]")) continue;
+
+      child.getCollapsedText = () => buildColorizedSkillList(rawSkillNames, store.lastHiddenSkills, store.theme);
+      child.setText(child.getCollapsedText());
+      break;
+    }
   };
 
-  patchState[STARTUP_SKILL_LIST_PATCH_KEY] = true;
+  patchState[STARTUP_PATCH_KEY] = true;
 }
 
-function formatStartupSkillName(name: string, hidden: boolean): string {
-  return hidden ? `${name} \x1b[31;2m●\x1b[22;39m` : `${name} \x1b[32m●\x1b[39m`;
+function buildColorizedSkillList(names: string[], hidden: Set<string>, theme: Theme | null): string {
+  const sorted = [...names].sort((a, b) => a.localeCompare(b));
+  if (!theme) {
+    return `[Skills]\n  ${sorted.join(", ")}`;
+  }
+  const header = theme.fg("mdHeading", "[Skills]");
+  const parts = sorted.map((n) => (hidden.has(n) ? theme.fg("error", n) : theme.fg("dim", n)));
+  return `${header}\n  ${parts.join(", ")}`;
 }
 
 function getSkillItems(pi: ExtensionAPI): SkillListItem[] {