pi-skill-evolve 0.1.2 → 0.1.4

package/extensions/skill-evolve/test/review-spawn.test.ts

@@ -17,6 +17,7 @@ test("督导用 node + --experimental-strip-types 起，参数里带 runDir", ()
     runDir: "/repo/.pi/evolution/runs/run-1",
     cwd: "/repo",
     env: {},
+    autoReview: true,
     spawnFn: (command, args, options) => {
       seen.calls.push({ command, args, options });
       return {
@@ -44,8 +45,8 @@ test("inherit 不追加 --model，显式模型追加在 runDir 之后", () => {
     explicitArgs.push(args);
     return { pid: 1 };
   };
-  spawnReviewSupervisor({ runDir: "/r", cwd: "/repo", env: {}, reviewModel: "inherit", spawnFn });
-  spawnReviewSupervisor({ runDir: "/r", cwd: "/repo", env: {}, reviewModel: "deepseek/deepseek-v3.2", spawnFn });
+  spawnReviewSupervisor({ runDir: "/r", cwd: "/repo", env: {}, autoReview: true, reviewModel: "inherit", spawnFn });
+  spawnReviewSupervisor({ runDir: "/r", cwd: "/repo", env: {}, autoReview: true, reviewModel: "deepseek/deepseek-v3.2", spawnFn });
   assert.deepEqual(inheritArgs[0], ["--experimental-strip-types", SUPERVISOR_SCRIPT, "/r"]);
   assert.deepEqual(explicitArgs[1], ["--experimental-strip-types", SUPERVISOR_SCRIPT, "/r", "deepseek/deepseek-v3.2"]);
 });
@@ -56,6 +57,7 @@ test("env 里去掉 SKILL_EVOLVE_CHILD，其他变量照旧带走", () => {
     runDir: "/r",
     cwd: "/repo",
     env: { SKILL_EVOLVE_CHILD: "1", PATH: "/usr/bin" },
+    autoReview: true,
     spawnFn: (_command, _args, options) => {
       env = options.env as NodeJS.ProcessEnv;
       return { pid: 1 };
@@ -65,12 +67,33 @@ test("env 里去掉 SKILL_EVOLVE_CHILD，其他变量照旧带走", () => {
   assert.equal(env.PATH, "/usr/bin");
 });
 
+test("自动评审关着：一个进程都不起，只留一句「停在 proposed」日志", () => {
+  const logs: string[] = [];
+  let spawned = 0;
+  const pid = spawnReviewSupervisor({
+    runDir: "/repo/.pi/evolution/runs/run-7",
+    cwd: "/repo",
+    env: {},
+    autoReview: false,
+    log: (msg) => logs.push(msg),
+    spawnFn: () => {
+      spawned += 1;
+      return { pid: 1 };
+    },
+  });
+  assert.equal(pid, null);
+  assert.equal(spawned, 0, "评审关着就不许起子进程（每份子进程都是 token）");
+  assert.equal(logs.length, 1);
+  assert.match(logs[0]!, /自动评审已关，run run-7 停在 proposed 待人工 \/skill-evolve approve/);
+});
+
 test("起不来只记日志返回 null，不抛", () => {
   const logs: string[] = [];
   const pid = spawnReviewSupervisor({
     runDir: "/r",
     cwd: "/repo",
     env: {},
+    autoReview: true,
     log: (msg) => logs.push(msg),
     spawnFn: () => {
       throw new Error("EMFILE");

package/extensions/skill-evolve/test/stale.test.ts

@@ -125,6 +125,7 @@ test("督导进程同样落盘：supervisor.log 就在 run 目录里", () => {
     runDir,
     cwd: dir,
     env: {},
+    autoReview: true,
     spawnFn: (_command, _args, options) => {
       stdio = options.stdio;
       return { pid: 7777, unref: () => {} };

package/extensions/skill-evolve/test/web-actions.test.ts

@@ -13,13 +13,26 @@ import { moveRunToTrash } from "../lib/web/trash.ts";
 
 const FORM = "application/x-www-form-urlencoded";
 
-function workspace(options: { enabled?: boolean; telemetry?: boolean; runs?: { runId: string; status: string }[] } = {}): string {
+function workspace(
+  options: {
+    enabled?: boolean;
+    telemetry?: boolean;
+    autoReview?: boolean;
+    autoApply?: boolean;
+    runs?: { runId: string; status: string }[];
+  } = {},
+): string {
   const cwd = fs.mkdtempSync(path.join(os.tmpdir(), "skill-evolve-webaction-"));
   const evolutionDir = path.join(cwd, ".pi", "evolution");
   fs.mkdirSync(path.join(evolutionDir, "runs"), { recursive: true });
   fs.writeFileSync(
     path.join(evolutionDir, "config.json"),
-    JSON.stringify({ enabled: options.enabled === true, telemetry: options.telemetry === true }),
+    JSON.stringify({
+      enabled: options.enabled === true,
+      telemetry: options.telemetry === true,
+      autoReview: options.autoReview === true,
+      autoApply: options.autoApply === true,
+    }),
     "utf8",
   );
   for (const run of options.runs ?? []) {
@@ -103,6 +116,32 @@ test("POST /toggle?field=telemetry：只动采集，不动复盘", async () => {
   }
 });
 
+test("POST /toggle?field=autoReview：只动评审，复盘 / 采集 / 采纳一个都不动", async () => {
+  const evolutionDir = workspace({ enabled: true, telemetry: true, autoReview: true });
+  const toggle = spyToggle("自动评审已关闭");
+  const panel = await open(evolutionDir, { onToggle: toggle.fn });
+  try {
+    assert.equal((await post(panel, "/toggle?field=autoReview", { csrf: panel.csrf })).status, 303);
+    assert.deepEqual(toggle.calls, [["autoReview", false]], "当前评审是开的 → 传 false，且 field 只能是 autoReview");
+    assert.equal(readAudit(evolutionDir).at(-1)?.field, "autoReview");
+  } finally {
+    await panel.close();
+  }
+});
+
+test("POST /toggle?field=autoApply：关着的采纳能被单独打开，且不动其它三个", async () => {
+  const evolutionDir = workspace({ enabled: true, telemetry: true, autoReview: true, autoApply: false });
+  const toggle = spyToggle("自动采纳已开启");
+  const panel = await open(evolutionDir, { onToggle: toggle.fn });
+  try {
+    assert.equal((await post(panel, "/toggle?field=autoApply", { csrf: panel.csrf })).status, 303);
+    assert.deepEqual(toggle.calls, [["autoApply", true]]);
+    assert.equal(readAudit(evolutionDir).at(-1)?.field, "autoApply");
+  } finally {
+    await panel.close();
+  }
+});
+
 test("POST /toggle 的 field 越界 / 缺失：400，不调回调，写一条带原值的 error 审计", async () => {
   const evolutionDir = workspace({ enabled: true, telemetry: true });
   const toggle = spyToggle("不该被调用");
@@ -110,7 +149,7 @@ test("POST /toggle 的 field 越界 / 缺失：400，不调回调，写一条带
   try {
     const wrong = await post(panel, "/toggle?field=propose", { csrf: panel.csrf });
     assert.equal(wrong.status, 400);
-    assert.match(await wrong.text(), /field 只认 telemetry \/ enabled/);
+    assert.match(await wrong.text(), /field 只认 telemetry \/ enabled \/ autoReview \/ autoApply/);
     const missing = await post(panel, "/toggle", { csrf: panel.csrf });
     assert.equal(missing.status, 400, "缺 field 不能猜一个默认值");
     assert.deepEqual(toggle.calls, [], "越界不放行到回调");

package/extensions/skill-evolve/test/web-data.test.ts

@@ -411,10 +411,15 @@ test("approvals：缺 proposal / review 文件时给 null，不抛也不编造
   assert.equal(row.createdAt, NOW);
 });
 
-test("collectControls：两个开关各读各的字段（采集关、复盘开这个中间态要能显示出来）", () => {
+test("collectControls：四个开关各读各的字段（采集关、复盘开这个中间态要能显示出来）", () => {
   const evolutionDir = workspace();
-  fs.writeFileSync(path.join(evolutionDir, "config.json"), JSON.stringify({ enabled: true, telemetry: false }), "utf8");
+  fs.writeFileSync(
+    path.join(evolutionDir, "config.json"),
+    JSON.stringify({ enabled: true, telemetry: false, autoReview: false, autoApply: true }),
+    "utf8",
+  );
   const controls = collectControls(evolutionDir);
-  assert.deepEqual([controls.telemetry, controls.enabled], [false, true]);
+  assert.deepEqual([controls.telemetry, controls.enabled, controls.autoReview, controls.autoApply], [false, true, false, true]);
+  assert.equal(controls.pendingAuto, 0, "队列空时没有待人工的 auto 条");
   assert.equal(controls.lastActivityAt, null, "没有任何遥测 / run 时最后活动为 null，不编造时间");
 });

package/extensions/skill-evolve/test/web-render.test.ts

@@ -262,37 +262,60 @@ test("待审批页不做 5 秒自刷新：刷新会打断正在点的按钮", ()
   assert.equal(renderPage(emptyState(), "approvals").includes('http-equiv="refresh"'), false);
 });
 
-test("控制条：采集与复盘是两个独立开关，各自 post 到 /toggle?field=", () => {
+test("控制条：四个独立开关，各自 post 到 /toggle?field=", () => {
   const html = renderPage(emptyState(), "pending", {
-    controls: { telemetry: true, enabled: false, lastActivityAt: null },
+    controls: { telemetry: true, enabled: false, autoReview: false, autoApply: false, pendingAuto: 0, lastActivityAt: null },
     csrf: "tok",
     canWrite: true,
   });
   assert.match(html, /采集遥测：开/);
   assert.match(html, /自动复盘：关/);
-  // 两个按钮各自打自己的字段：一个按钮同时翻两个，就回到了「捆在一起」的老问题
-  assert.equal(html.includes('action="/toggle?field=telemetry"'), true);
-  assert.equal(html.includes('action="/toggle?field=enabled"'), true);
+  assert.match(html, /自动评审：关/);
+  assert.match(html, /自动采纳：关/);
+  // 四个按钮各自打自己的字段：一个按钮同时翻两个，就回到了「捆在一起」的老问题
+  for (const field of ["telemetry", "enabled", "autoReview", "autoApply"]) {
+    assert.equal(html.includes(`action="/toggle?field=${field}"`), true, field);
+  }
   assert.match(html, /只写本地日志，不花 token/);
   assert.match(html, /会派生子进程，花 token/);
   assert.match(html, /关闭采集遥测/, "按钮文案是动作（当前开 → 关闭），不是状态的复读");
   assert.match(html, /开启自动复盘/);
+  assert.match(html, /再起一个督导子进程，再花一份 token/);
+  assert.match(html, /改 \.pi\/skills\/ 与 \.cursor\/ 文件，可回滚/);
   assert.equal(html.includes("复盘在跑但采集关着"), false, "两个状态正常时不带警告");
   // 只读（没 csrf）时两个开关只显示状态，不渲染表单
-  const readonly = renderPage(emptyState(), "pending", { controls: { telemetry: false, enabled: false, lastActivityAt: null } });
+  const readonly = renderPage(emptyState(), "pending", {
+    controls: { telemetry: false, enabled: false, autoReview: true, autoApply: true, pendingAuto: 2, lastActivityAt: null },
+  });
   assert.match(readonly, /采集遥测：关/);
   assert.equal(readonly.includes("/toggle?field="), false);
 });
 
+test("控制条：自动采纳关着且队列有 auto 条时写「N 条待人工」，关了预警就消失", () => {
+  const backlog = renderPage(emptyState(), "pending", {
+    controls: { telemetry: true, enabled: true, autoReview: true, autoApply: false, pendingAuto: 3, lastActivityAt: null },
+    csrf: "tok",
+    canWrite: true,
+  });
+  assert.match(backlog, /⏸ 3 条 auto 提案待人工（自动采纳关着）/);
+  // 采纳打开后那些条会被自动消化，提醒必须跟着消失（否则永远挂着一条假待办）
+  const cleared = renderPage(emptyState(), "pending", {
+    controls: { telemetry: true, enabled: true, autoReview: true, autoApply: true, pendingAuto: 3, lastActivityAt: null },
+    csrf: "tok",
+    canWrite: true,
+  });
+  assert.equal(cleared.includes("条 auto 提案待人工"), false);
+});
+
 test("控制条：只开复盘不采集时给一行警告，两个都开后警告消失", () => {
   const warn = renderPage(emptyState(), "pending", {
-    controls: { telemetry: false, enabled: true, lastActivityAt: null },
+    controls: { telemetry: false, enabled: true, autoReview: true, autoApply: false, pendingAuto: 0, lastActivityAt: null },
     csrf: "tok",
     canWrite: true,
   });
   assert.match(warn, /<p class="warn">⚠ 复盘在跑但采集关着：归因只能靠原始会话，加载率不可得<\/p>/);
   const ok = renderPage(emptyState(), "pending", {
-    controls: { telemetry: true, enabled: true, lastActivityAt: null },
+    controls: { telemetry: true, enabled: true, autoReview: true, autoApply: false, pendingAuto: 0, lastActivityAt: null },
     csrf: "tok",
     canWrite: true,
   });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-skill-evolve",
-  "version": "0.1.2",
+  "version": "0.1.4",
   "description": "技能进化：采集会话中的技能曝光/加载，异步复盘、生成改进提案并独立评审，附本机 Web 管理面板",
   "keywords": [
     "pi-package",