pi-rtk-optimizer 0.3.3 → 0.5.0

package/src/config-store.ts

@@ -1,217 +1,224 @@
-import { existsSync, mkdirSync, readFileSync, renameSync, unlinkSync, writeFileSync } from "node:fs";
-import { dirname } from "node:path";
-import { CONFIG_PATH } from "./constants.js";
-import {
-	DEFAULT_RTK_INTEGRATION_CONFIG,
-	RTK_MODES,
-	RTK_SOURCE_FILTER_LEVELS,
-	type ConfigLoadResult,
-	type ConfigSaveResult,
-	type EnsureConfigResult,
-	type RtkIntegrationConfig,
-	type RtkSourceFilterLevel,
-} from "./types.js";
-
-function toBoolean(value: unknown, fallback: boolean): boolean {
-	return typeof value === "boolean" ? value : fallback;
-}
-
-function toInteger(value: unknown, fallback: number, min: number, max: number): number {
-	if (typeof value !== "number" || !Number.isFinite(value)) {
-		return fallback;
-	}
-	const rounded = Math.round(value);
-	return Math.max(min, Math.min(max, rounded));
-}
-
-function toMode(value: unknown): RtkIntegrationConfig["mode"] {
-	return RTK_MODES.includes(value as RtkIntegrationConfig["mode"])
-		? (value as RtkIntegrationConfig["mode"])
-		: DEFAULT_RTK_INTEGRATION_CONFIG.mode;
-}
-
-function toSourceFilterLevel(value: unknown): RtkSourceFilterLevel {
-	return RTK_SOURCE_FILTER_LEVELS.includes(value as RtkSourceFilterLevel)
-		? (value as RtkSourceFilterLevel)
-		: DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.sourceCodeFiltering;
-}
-
-function toObject(value: unknown): Record<string, unknown> {
-	if (!value || typeof value !== "object" || Array.isArray(value)) {
-		return {};
-	}
-	return value as Record<string, unknown>;
-}
-
-export function normalizeRtkIntegrationConfig(raw: unknown): RtkIntegrationConfig {
-	const source = toObject(raw);
-	const outputCompactionSource = toObject(source.outputCompaction);
-	const truncateSource = toObject(outputCompactionSource.truncate);
-	const smartTruncateSource = toObject(outputCompactionSource.smartTruncate);
-
-	return {
-		enabled: toBoolean(source.enabled, DEFAULT_RTK_INTEGRATION_CONFIG.enabled),
-		mode: toMode(source.mode),
-		guardWhenRtkMissing: toBoolean(
-			source.guardWhenRtkMissing,
-			DEFAULT_RTK_INTEGRATION_CONFIG.guardWhenRtkMissing,
-		),
-		showRewriteNotifications: toBoolean(
-			source.showRewriteNotifications,
-			DEFAULT_RTK_INTEGRATION_CONFIG.showRewriteNotifications,
-		),
-		rewriteGitGithub: toBoolean(
-			source.rewriteGitGithub,
-			DEFAULT_RTK_INTEGRATION_CONFIG.rewriteGitGithub,
-		),
-		rewriteFilesystem: toBoolean(
-			source.rewriteFilesystem,
-			DEFAULT_RTK_INTEGRATION_CONFIG.rewriteFilesystem,
-		),
-		rewriteRust: toBoolean(source.rewriteRust, DEFAULT_RTK_INTEGRATION_CONFIG.rewriteRust),
-		rewriteJavaScript: toBoolean(
-			source.rewriteJavaScript,
-			DEFAULT_RTK_INTEGRATION_CONFIG.rewriteJavaScript,
-		),
-		rewritePython: toBoolean(source.rewritePython, DEFAULT_RTK_INTEGRATION_CONFIG.rewritePython),
-		rewriteGo: toBoolean(source.rewriteGo, DEFAULT_RTK_INTEGRATION_CONFIG.rewriteGo),
-		rewriteContainers: toBoolean(
-			source.rewriteContainers,
-			DEFAULT_RTK_INTEGRATION_CONFIG.rewriteContainers,
-		),
-		rewriteNetwork: toBoolean(source.rewriteNetwork, DEFAULT_RTK_INTEGRATION_CONFIG.rewriteNetwork),
-		rewritePackageManagers: toBoolean(
-			source.rewritePackageManagers,
-			DEFAULT_RTK_INTEGRATION_CONFIG.rewritePackageManagers,
-		),
-		outputCompaction: {
-			enabled: toBoolean(
-				outputCompactionSource.enabled,
-				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.enabled,
-			),
-			stripAnsi: toBoolean(
-				outputCompactionSource.stripAnsi,
-				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.stripAnsi,
-			),
-			sourceCodeFilteringEnabled: toBoolean(
-				outputCompactionSource.sourceCodeFilteringEnabled,
-				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.sourceCodeFilteringEnabled,
-			),
-			truncate: {
-				enabled: toBoolean(
-					truncateSource.enabled,
-					DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.truncate.enabled,
-				),
-				maxChars: toInteger(
-					truncateSource.maxChars,
-					DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.truncate.maxChars,
-					1_000,
-					200_000,
-				),
-			},
-			sourceCodeFiltering: toSourceFilterLevel(outputCompactionSource.sourceCodeFiltering),
-			smartTruncate: {
-				enabled: toBoolean(
-					smartTruncateSource.enabled,
-					DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.smartTruncate.enabled,
-				),
-				maxLines: toInteger(
-					smartTruncateSource.maxLines,
-					DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.smartTruncate.maxLines,
-					40,
-					4_000,
-				),
-			},
-			aggregateTestOutput: toBoolean(
-				outputCompactionSource.aggregateTestOutput,
-				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.aggregateTestOutput,
-			),
-			filterBuildOutput: toBoolean(
-				outputCompactionSource.filterBuildOutput,
-				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.filterBuildOutput,
-			),
-			compactGitOutput: toBoolean(
-				outputCompactionSource.compactGitOutput,
-				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.compactGitOutput,
-			),
-			aggregateLinterOutput: toBoolean(
-				outputCompactionSource.aggregateLinterOutput,
-				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.aggregateLinterOutput,
-			),
-			groupSearchOutput: toBoolean(
-				outputCompactionSource.groupSearchOutput,
-				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.groupSearchOutput,
-			),
-			trackSavings: toBoolean(
-				outputCompactionSource.trackSavings,
-				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.trackSavings,
-			),
-		},
-	};
-}
-
-export function ensureConfigExists(): EnsureConfigResult {
-	if (existsSync(CONFIG_PATH)) {
-		return { created: false };
-	}
-
-	try {
-		mkdirSync(dirname(CONFIG_PATH), { recursive: true });
-		writeFileSync(CONFIG_PATH, `${JSON.stringify(DEFAULT_RTK_INTEGRATION_CONFIG, null, 2)}\n`, "utf-8");
-		return { created: true };
-	} catch (error) {
-		const message = error instanceof Error ? error.message : String(error);
-		return {
-			created: false,
-			error: `Failed to create ${CONFIG_PATH}: ${message}`,
-		};
-	}
-}
-
-export function loadRtkIntegrationConfig(): ConfigLoadResult {
-	if (!existsSync(CONFIG_PATH)) {
-		return { config: { ...DEFAULT_RTK_INTEGRATION_CONFIG } };
-	}
-
-	try {
-		const rawText = readFileSync(CONFIG_PATH, "utf-8");
-		const parsed = JSON.parse(rawText) as unknown;
-		return { config: normalizeRtkIntegrationConfig(parsed) };
-	} catch (error) {
-		const message = error instanceof Error ? error.message : String(error);
-		return {
-			config: { ...DEFAULT_RTK_INTEGRATION_CONFIG },
-			warning: `Failed to parse ${CONFIG_PATH}: ${message}`,
-		};
-	}
-}
-
-export function saveRtkIntegrationConfig(config: RtkIntegrationConfig): ConfigSaveResult {
-	const normalized = normalizeRtkIntegrationConfig(config);
-	const tmpPath = `${CONFIG_PATH}.tmp`;
-
-	try {
-		mkdirSync(dirname(CONFIG_PATH), { recursive: true });
-		writeFileSync(tmpPath, `${JSON.stringify(normalized, null, 2)}\n`, "utf-8");
-		renameSync(tmpPath, CONFIG_PATH);
-		return { success: true };
-	} catch (error) {
-		try {
-			if (existsSync(tmpPath)) {
-				unlinkSync(tmpPath);
-			}
-		} catch {
-			// Ignore cleanup failures.
-		}
-
-		const message = error instanceof Error ? error.message : String(error);
-		return {
-			success: false,
-			error: `Failed to save ${CONFIG_PATH}: ${message}`,
-		};
-	}
-}
-
-export function getRtkIntegrationConfigPath(): string {
-	return CONFIG_PATH;
-}
+import { existsSync, mkdirSync, readFileSync, renameSync, unlinkSync, writeFileSync } from "node:fs";
+import { dirname } from "node:path";
+import { CONFIG_PATH } from "./constants.js";
+import {
+	DEFAULT_RTK_INTEGRATION_CONFIG,
+	RTK_MODES,
+	RTK_SOURCE_FILTER_LEVELS,
+	type ConfigLoadResult,
+	type ConfigSaveResult,
+	type EnsureConfigResult,
+	type RtkIntegrationConfig,
+	type RtkSourceFilterLevel,
+} from "./types.js";
+
+function toBoolean(value: unknown, fallback: boolean): boolean {
+	return typeof value === "boolean" ? value : fallback;
+}
+
+function toInteger(value: unknown, fallback: number, min: number, max: number): number {
+	if (typeof value !== "number" || !Number.isFinite(value)) {
+		return fallback;
+	}
+	const rounded = Math.round(value);
+	return Math.max(min, Math.min(max, rounded));
+}
+
+function toMode(value: unknown): RtkIntegrationConfig["mode"] {
+	return RTK_MODES.includes(value as RtkIntegrationConfig["mode"])
+		? (value as RtkIntegrationConfig["mode"])
+		: DEFAULT_RTK_INTEGRATION_CONFIG.mode;
+}
+
+function toSourceFilterLevel(value: unknown): RtkSourceFilterLevel {
+	return RTK_SOURCE_FILTER_LEVELS.includes(value as RtkSourceFilterLevel)
+		? (value as RtkSourceFilterLevel)
+		: DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.sourceCodeFiltering;
+}
+
+function toObject(value: unknown): Record<string, unknown> {
+	if (!value || typeof value !== "object" || Array.isArray(value)) {
+		return {};
+	}
+	return value as Record<string, unknown>;
+}
+
+export function normalizeRtkIntegrationConfig(raw: unknown): RtkIntegrationConfig {
+	const source = toObject(raw);
+	const outputCompactionSource = toObject(source.outputCompaction);
+	const truncateSource = toObject(outputCompactionSource.truncate);
+	const smartTruncateSource = toObject(outputCompactionSource.smartTruncate);
+
+	return {
+		enabled: toBoolean(source.enabled, DEFAULT_RTK_INTEGRATION_CONFIG.enabled),
+		mode: toMode(source.mode),
+		guardWhenRtkMissing: toBoolean(
+			source.guardWhenRtkMissing,
+			DEFAULT_RTK_INTEGRATION_CONFIG.guardWhenRtkMissing,
+		),
+		showRewriteNotifications: toBoolean(
+			source.showRewriteNotifications,
+			DEFAULT_RTK_INTEGRATION_CONFIG.showRewriteNotifications,
+		),
+		rewriteGitGithub: toBoolean(
+			source.rewriteGitGithub,
+			DEFAULT_RTK_INTEGRATION_CONFIG.rewriteGitGithub,
+		),
+		rewriteFilesystem: toBoolean(
+			source.rewriteFilesystem,
+			DEFAULT_RTK_INTEGRATION_CONFIG.rewriteFilesystem,
+		),
+		rewriteRust: toBoolean(source.rewriteRust, DEFAULT_RTK_INTEGRATION_CONFIG.rewriteRust),
+		rewriteJavaScript: toBoolean(
+			source.rewriteJavaScript,
+			DEFAULT_RTK_INTEGRATION_CONFIG.rewriteJavaScript,
+		),
+		rewritePython: toBoolean(source.rewritePython, DEFAULT_RTK_INTEGRATION_CONFIG.rewritePython),
+		rewriteGo: toBoolean(source.rewriteGo, DEFAULT_RTK_INTEGRATION_CONFIG.rewriteGo),
+		rewriteContainers: toBoolean(
+			source.rewriteContainers,
+			DEFAULT_RTK_INTEGRATION_CONFIG.rewriteContainers,
+		),
+		rewriteNetwork: toBoolean(source.rewriteNetwork, DEFAULT_RTK_INTEGRATION_CONFIG.rewriteNetwork),
+		rewritePackageManagers: toBoolean(
+			source.rewritePackageManagers,
+			DEFAULT_RTK_INTEGRATION_CONFIG.rewritePackageManagers,
+		),
+		outputCompaction: {
+			enabled: toBoolean(
+				outputCompactionSource.enabled,
+				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.enabled,
+			),
+			stripAnsi: toBoolean(
+				outputCompactionSource.stripAnsi,
+				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.stripAnsi,
+			),
+			sourceCodeFilteringEnabled: toBoolean(
+				outputCompactionSource.sourceCodeFilteringEnabled,
+				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.sourceCodeFilteringEnabled,
+			),
+			preserveExactSkillReads: toBoolean(
+				outputCompactionSource.preserveExactSkillReads,
+				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.preserveExactSkillReads,
+			),
+			truncate: {
+				enabled: toBoolean(
+					truncateSource.enabled,
+					DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.truncate.enabled,
+				),
+				maxChars: toInteger(
+					truncateSource.maxChars,
+					DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.truncate.maxChars,
+					1_000,
+					200_000,
+				),
+			},
+			sourceCodeFiltering: toSourceFilterLevel(outputCompactionSource.sourceCodeFiltering),
+			smartTruncate: {
+				enabled: toBoolean(
+					smartTruncateSource.enabled,
+					DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.smartTruncate.enabled,
+				),
+				maxLines: toInteger(
+					smartTruncateSource.maxLines,
+					DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.smartTruncate.maxLines,
+					40,
+					4_000,
+				),
+			},
+			aggregateTestOutput: toBoolean(
+				outputCompactionSource.aggregateTestOutput,
+				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.aggregateTestOutput,
+			),
+			filterBuildOutput: toBoolean(
+				outputCompactionSource.filterBuildOutput,
+				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.filterBuildOutput,
+			),
+			compactGitOutput: toBoolean(
+				outputCompactionSource.compactGitOutput,
+				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.compactGitOutput,
+			),
+			aggregateLinterOutput: toBoolean(
+				outputCompactionSource.aggregateLinterOutput,
+				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.aggregateLinterOutput,
+			),
+			groupSearchOutput: toBoolean(
+				outputCompactionSource.groupSearchOutput,
+				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.groupSearchOutput,
+			),
+			trackSavings: toBoolean(
+				outputCompactionSource.trackSavings,
+				DEFAULT_RTK_INTEGRATION_CONFIG.outputCompaction.trackSavings,
+			),
+		},
+	};
+}
+
+export function ensureConfigExists(configPath = CONFIG_PATH): EnsureConfigResult {
+	if (existsSync(configPath)) {
+		return { created: false };
+	}
+
+	try {
+		mkdirSync(dirname(configPath), { recursive: true });
+		writeFileSync(configPath, `${JSON.stringify(DEFAULT_RTK_INTEGRATION_CONFIG, null, 2)}\n`, "utf-8");
+		return { created: true };
+	} catch (error) {
+		const message = error instanceof Error ? error.message : String(error);
+		return {
+			created: false,
+			error: `Failed to create ${configPath}: ${message}`,
+		};
+	}
+}
+
+export function loadRtkIntegrationConfig(configPath = CONFIG_PATH): ConfigLoadResult {
+	if (!existsSync(configPath)) {
+		return { config: { ...DEFAULT_RTK_INTEGRATION_CONFIG } };
+	}
+
+	try {
+		const rawText = readFileSync(configPath, "utf-8");
+		const parsed = JSON.parse(rawText) as unknown;
+		return { config: normalizeRtkIntegrationConfig(parsed) };
+	} catch (error) {
+		const message = error instanceof Error ? error.message : String(error);
+		return {
+			config: { ...DEFAULT_RTK_INTEGRATION_CONFIG },
+			warning: `Failed to parse ${configPath}: ${message}`,
+		};
+	}
+}
+
+export function saveRtkIntegrationConfig(
+	config: RtkIntegrationConfig,
+	configPath = CONFIG_PATH,
+): ConfigSaveResult {
+	const normalized = normalizeRtkIntegrationConfig(config);
+	const tmpPath = `${configPath}.tmp`;
+
+	try {
+		mkdirSync(dirname(configPath), { recursive: true });
+		writeFileSync(tmpPath, `${JSON.stringify(normalized, null, 2)}\n`, "utf-8");
+		renameSync(tmpPath, configPath);
+		return { success: true };
+	} catch (error) {
+		try {
+			if (existsSync(tmpPath)) {
+				unlinkSync(tmpPath);
+			}
+		} catch {
+			// Ignore cleanup failures.
+		}
+
+		const message = error instanceof Error ? error.message : String(error);
+		return {
+			success: false,
+			error: `Failed to save ${configPath}: ${message}`,
+		};
+	}
+}
+
+export function getRtkIntegrationConfigPath(configPath = CONFIG_PATH): string {
+	return configPath;
+}

package/src/index-test.ts

@@ -0,0 +1,54 @@
+import assert from "node:assert/strict";
+import { mock } from "bun:test";
+
+import { runTest } from "./test-helpers.ts";
+
+mock.module("@mariozechner/pi-coding-agent", () => ({
+	getSettingsListTheme: () => ({}),
+	isToolCallEventType: (toolName: string, event: Record<string, unknown>) => event.toolName === toolName,
+}));
+
+mock.module("@mariozechner/pi-tui", () => ({
+	Box: class {},
+	Container: class {
+		addChild(): void {}
+		render(): string[] {
+			return [];
+		}
+		invalidate(): void {}
+	},
+	SettingsList: class {
+		handleInput(): void {}
+		updateValue(): void {}
+	},
+	Spacer: class {},
+	Text: class {},
+	truncateToWidth: (text: string) => text,
+	visibleWidth: (text: string) => text.length,
+}));
+
+const { createBoundedNoticeTracker } = await import("./index.ts");
+
+runTest("bounded notice tracker evicts old entries and supports reset", () => {
+	const tracker = createBoundedNoticeTracker(2);
+
+	assert.equal(tracker.remember("first"), true);
+	assert.equal(tracker.remember("second"), true);
+	assert.equal(tracker.remember("first"), false);
+
+	assert.equal(tracker.remember("third"), true);
+	assert.equal(tracker.remember("second"), false);
+	assert.equal(tracker.remember("first"), true);
+
+	tracker.reset();
+	assert.equal(tracker.remember("third"), true);
+});
+
+runTest("bounded notice tracker coerces invalid limits to a safe minimum", () => {
+	const tracker = createBoundedNoticeTracker(0);
+	assert.equal(tracker.remember("alpha"), true);
+	assert.equal(tracker.remember("beta"), true);
+	assert.equal(tracker.remember("alpha"), true);
+});
+
+console.log("All index tests passed.");