pi-roundtable 0.23.2 → 0.24.1

package/src/core/services.ts

@@ -91,8 +91,13 @@ export const MODES: ServiceKey<ConversationModes> =
 export const THREADS: ServiceKey<DispatchThreads> =
 	serviceKey<DispatchThreads>("roundtable.threads");
 /** The agent server: its team, its directory, the runtime that runs every agent turn. Provided by the agent-server plugin. */
-export const AGENTS: ServiceKey<AgentServer> =
-	serviceKey<AgentServer>("roundtable.agents");
+export const AGENTS: ServiceKey<AgentServer> = serviceKey<AgentServer>(
+	"roundtable.agents",
+	{
+		absent:
+			"This host has no agent server: its configuration says agentServer: false, or it has neither discord nor agents. Remove agentServer: false and configure discord or agents, or drop the plugin that needs the agent server.",
+	},
+);
 /** Scheduled turns, stored. Provided by the `schedule-store` plugin. */
 export const SCHEDULES: ServiceKey<ScheduleStore> = serviceKey<ScheduleStore>(
 	"roundtable.schedules",
@@ -153,6 +158,20 @@ export interface AgentServer {
 	};
 	/** Agents' pictures. */
 	avatars: AvatarStudio;
+	/** Where the agents' files are: the directories their shell and file tools run in. */
+	workspace: AgentWorkspace;
+}
+
+/**
+ * The directories the agents work in, as configured. Every agent shares them: the core has no
+ * workspace per agent. Read-only data, so a plugin that shows or serves the files can find them;
+ * the directories may not exist yet.
+ */
+export interface AgentWorkspace {
+	/** The shell's shared working directory (`config.workDir`), where agents write without a hold. */
+	readonly workDir: string;
+	/** The agents' scratch dir (TMPDIR), when the host sets one; writes there are unheld too. */
+	readonly scratchDir?: string;
 }
 
 /** Agent pictures: rendered from the agent's character, kept and served by content hash. */

package/src/core/shared/workspace-files.ts

@@ -1,5 +1,5 @@
 import { readFile, realpath, stat } from "node:fs/promises";
-import { basename, isAbsolute, relative, resolve } from "node:path";
+import { basename, isAbsolute, relative, resolve, sep } from "node:path";
 
 /** Where a session may read files by path: its shared workspace and its scratch dir. */
 export interface WorkspaceRoots {
@@ -23,10 +23,13 @@ export interface WorkspaceFile {
 	size: number;
 }
 
-/** Whether `child` is `parent` or inside it. */
-function within(parent: string, child: string): boolean {
+/** Whether `child` is `parent` or inside it, judged by the paths alone (resolve symlinks first). */
+export function within(parent: string, child: string): boolean {
 	const rel = relative(parent, child);
-	return rel === "" || (!rel.startsWith("..") && !isAbsolute(rel));
+	return (
+		rel === "" ||
+		(rel !== ".." && !rel.startsWith(`..${sep}`) && !isAbsolute(rel))
+	);
 }
 
 async function realRoot(root: string): Promise<string | undefined> {

package/src/index.ts

@@ -333,6 +333,7 @@ export type {
 	AgentDirectory,
 	AgentServer,
 	AgentTeam,
+	AgentWorkspace,
 	AvatarStudio,
 	BackgroundTurns,
 	DelegationRequest,

package/src/kit/index.ts

@@ -206,3 +206,4 @@ export {
 	runWorkerTask,
 	workTimeout,
 } from "./worker.ts";
+export { within } from "./workspace.ts";

package/src/kit/workspace.ts

@@ -0,0 +1,3 @@
+// Path helper for plugins that serve files from the agents' workspace; see the plugin guide.
+
+export { within } from "../core/shared/workspace-files.ts";

package/src/testing.ts

@@ -2,6 +2,7 @@ import { mkdtempSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import type { SQL } from "bun";
+import { CATALOG } from "./characters/index.ts";
 import { agentClaim } from "./core/agents/agent-claim.ts";
 import { ownerAttachmentDir } from "./core/attachments/attachment-dir.ts";
 import { attachmentPort } from "./core/attachments/attachment-port.ts";
@@ -453,6 +454,7 @@ export async function testPlugin(
 		locale: "en",
 		timeZone: "UTC",
 		now: () => new Date(),
+		characterSkins: CATALOG.skins,
 		...options.env,
 	};
 	// What the agent server does with the slot: the provider's runtime serves `context.turns`.