pi-robot-hand 0.5.1 → 0.5.2

package/README.md

@@ -44,6 +44,7 @@ Not sure what the command does? Press `e` in the selector and another model read
 ```
 
 The first `e` asks which signed-in model to use and remembers it in `~/.pi/agent/robot-hand.json`; after a failed check, `e` asks again, and `E` always does.
+The list shows every model of each provider pi holds a credential for, even an expired one; the provider you are using comes first, and a provider whose check failed is marked and moved to the end.
 Known `secret_drop` values are replaced with `[REDACTED]` before anything is sent; when its registry cannot be read, the check fails and sends nothing. The check informs your choice and never blocks one. When you checked, the agent's result says which model checked and its verdict.
 It needs the terminal UI.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-robot-hand",
-  "version": "0.5.1",
+  "version": "0.5.2",
   "description": "The lazy kit for pi: no IDE, no copy-paste, safety net still on. The agent hands you commands (prompt, clipboard, or a Herdr pane that reports back), answers your ! commands, and takes secrets through a masked dialog it never sees",
   "type": "module",
   "license": "MIT",

package/src/check.ts

@@ -63,6 +63,22 @@ export function modelRef(model: Pick<Model<Api>, "provider" | "id">): string {
 	return `${model.provider}/${model.id}`;
 }
 
+/**
+ * The model list for the picker. pi counts a provider as available when it has a stored credential,
+ * even an expired one, so the provider pi is using now goes first and a provider whose check failed
+ * this session goes last; the rest keep pi's order.
+ */
+export function orderModels(refs: readonly string[], current: string | undefined, failed: ReadonlyMap<string, string>): string[] {
+	const provider = (ref: string) => ref.slice(0, ref.indexOf("/"));
+	const rank = (ref: string) => (failed.has(provider(ref)) ? 2 : provider(ref) === current ? 0 : 1);
+	return refs.map((ref, i) => ({ ref, i })).sort((a, b) => rank(a.ref) - rank(b.ref) || a.i - b.i).map(({ ref }) => ref);
+}
+
+/** How the picker marks a provider whose check failed: sign-in trouble, or any other failure. */
+export function failureNote(error: string): string {
+	return /oauth|auth|unauthori[sz]ed|forbidden|\b40[13]\b|api key|token|credential|login/i.test(error) ? "sign-in failed" : "check failed";
+}
+
 /**
  * The saved check model, or undefined when none was picked yet or the file is unreadable. Read
  * synchronously so the selector opens in the same tick as before the check existed.

package/src/hand-select.ts

@@ -12,8 +12,10 @@ export interface HandSelectProps {
 	/** The same title the plain selector shows: the reason, a blank line, then the command. */
 	title: string;
 	labels: readonly string[];
-	/** `provider/id` of every signed-in model. */
+	/** `provider/id` of every signed-in model, in the order to list them. */
 	models: () => string[];
+	/** A dim note after a model in the list, such as a failed sign-in. */
+	note?: (model: string) => string | undefined;
 	/** The saved check model. */
 	saved: () => string | undefined;
 	/** Remembers the model the user picked. */
@@ -198,8 +200,9 @@ export class HandSelect implements Component, Focusable {
 		const first = Math.max(0, Math.min(picker.cursor - Math.floor(MAX_LISTED / 2), list.length - MAX_LISTED));
 		list.slice(first, first + MAX_LISTED).forEach((model, i) => {
 			const at = first + i === picker.cursor;
-			const saved = model === this.props.saved() ? t.fg("dim", " (saved)") : "";
-			lines.push(`${at ? t.fg("accent", "› ") : "  "}${t.fg(at ? "accent" : "text", model)}${saved}`);
+			const notes = [model === this.props.saved() ? "saved" : undefined, this.props.note?.(model)].filter(Boolean);
+			const suffix = notes.length > 0 ? t.fg("dim", ` (${notes.join(", ")})`) : "";
+			lines.push(`${at ? t.fg("accent", "› ") : "  "}${t.fg(at ? "accent" : "text", model)}${suffix}`);
 		});
 		if (list.length > MAX_LISTED) lines.push(t.fg("dim", `  ${list.length} models; type to narrow`));
 		return lines;

package/src/index.ts

@@ -11,7 +11,7 @@ import { StringEnum } from "@earendil-works/pi-ai";
 import { copyToClipboard, type ExtensionAPI, type ExtensionContext, getAgentDir } from "@earendil-works/pi-coding-agent";
 import { Text } from "@earendil-works/pi-tui";
 import { Type } from "typebox";
-import { type CheckInput, type CheckResult, afterUserMessage, checkSummary, findScripts, lastUserText, loadCheckModel, loadSecrets, modelRef, redactInput, runCheck, saveCheckModel, settingsPath, type Verdict } from "./check.ts";
+import { type CheckInput, type CheckResult, afterUserMessage, checkSummary, failureNote, findScripts, lastUserText, loadCheckModel, loadSecrets, modelRef, orderModels, redactInput, runCheck, saveCheckModel, settingsPath, type Verdict } from "./check.ts";
 import { openDialog } from "./dialog.ts";
 import { busChoices, type Choice, dialogTitle, type Offer, options, promptText, resultText, toOffer } from "./hand.ts";
 import { HandSelect } from "./hand-select.ts";
@@ -108,7 +108,11 @@ export function createRobotHand(
 			}
 		};
 
+		// Providers whose check failed in this session, with the note the picker shows.
+		const failedProviders = new Map<string, string>();
+
 		pi.on("session_shutdown", () => {
+			failedProviders.clear();
 			if (timer) clearInterval(timer);
 			timer = undefined;
 			runs.clear();
@@ -134,7 +138,8 @@ export function createRobotHand(
 						{
 							title,
 							labels,
-							models: () => ctx.modelRegistry.getAvailable().map(modelRef),
+							models: () => orderModels(ctx.modelRegistry.getAvailable().map(modelRef), ctx.model?.provider, failedProviders),
+							note: (ref) => failedProviders.get(ref.slice(0, ref.indexOf("/"))),
 							saved: () => saved,
 							pick: (model) => {
 								saved = model;
@@ -148,7 +153,14 @@ export function createRobotHand(
 									input = undefined;
 									throw error;
 								});
-								return runCheck((m, context, options) => ctx.modelRegistry.complete(m, context, options), model, gathered, signal);
+								try {
+									const result = await runCheck((m, context, options) => ctx.modelRegistry.complete(m, context, options), model, gathered, signal);
+									failedProviders.delete(model.provider);
+									return result;
+								} catch (error) {
+									if (!signal.aborted) failedProviders.set(model.provider, failureNote((error as Error).message));
+									throw error;
+								}
 							},
 						},
 						theme,