pi-revit 0.4.0 → 0.5.0

package/src/Revit/Tools/ManageSchedules.cs

@@ -1,164 +1,174 @@
-using System.Text.Json;
-using Autodesk.Revit.DB;
-
-namespace RevitBridge.Tools;
-
-internal sealed class ManageSchedules : ITool
-{
-    public string Name => "manage_schedules";
-    public string Label => "Manage Schedules";
-    public string Tier => "advanced";
-    public bool Write => true;
-    public string Description => "Create or configure a regular schedule in one atomic step. Create requires category and name; optional area_scheme_id supports area schedules. Configure requires schedule_id. Discover add_fields using get_schedule_fields and pass the returned parameter_id + field_type pair, including Count when listed. Count also supports field_type Count without a parameter_id. update_fields, sort_fields and filters use schedule-local field_id from get_schedules. Supplied sort_fields/filters replace their entire lists; empty arrays clear them. Numeric measured filter values require a compatible unit; returned numeric filter values use internal units. Column widths require explicit length units and apply to both grid and sheet. preview=true commit-validates then rolls back; created schedule/field IDs in previews are temporary. Revision schedules, templates, embedded schedules and calculated/combined-field authoring are outside this tool.";
-    public object ParametersSchema => new
-    {
-        type = "object", properties = new
-        {
-            action = new { type = "string", @enum = new[] { "create", "configure" } },
-            schedule_id = new { type = "integer", minimum = 1 }, category = new { type = "string" }, name = new { type = "string", minLength = 1 }, area_scheme_id = new { type = "integer", minimum = 1 },
-            is_itemized = new { type = "boolean" }, preview = ModelEditInputs.PreviewSchema,
-            add_fields = new { type = "array", maxItems = 50, items = new { type = "object", properties = new
-            {
-                parameter_id = new { type = "integer", description = "Use the ID returned by get_schedule_fields, including negative built-in IDs. Optional for Count; when supplied, the pair must be eligible for the schedule." }, field_type = new { type = "string" },
-                heading = new { type = "string" }, hidden = new { type = "boolean" }, width = new { type = "number", exclusiveMinimum = 0 }, unit = ModelEditInputs.LengthUnitSchema,
-            }, required = new[] { "field_type" } } },
-            update_fields = new { type = "array", maxItems = 50, items = new { type = "object", properties = new
-            {
-                field_id = new { type = "integer", minimum = 0 }, heading = new { type = "string" }, hidden = new { type = "boolean" }, width = new { type = "number", exclusiveMinimum = 0 }, unit = ModelEditInputs.LengthUnitSchema,
-            }, required = new[] { "field_id" } } },
-            sort_fields = new { type = "array", maxItems = 4, items = new { type = "object", properties = new { field_id = new { type = "integer", minimum = 0 }, descending = new { type = "boolean" }, show_header = new { type = "boolean" } }, required = new[] { "field_id" } } },
-            filters = new { type = "array", maxItems = 8, items = new { type = "object", properties = new
-            {
-                field_id = new { type = "integer", minimum = 0 }, comparison = new { type = "string", @enum = new[] { "equals", "not_equals", "contains", "greater_than", "less_than" } },
-                value_type = new { type = "string", @enum = new[] { "string", "number", "integer", "element_id" } }, value = new { description = "Filter value matching value_type." }, unit = new { type = "string", description = "Required for measured numbers; compatible forge unit name, e.g. meters, squareMeters, degrees." },
-            }, required = new[] { "field_id", "comparison", "value_type", "value" } } },
-        }, required = new[] { "action" },
-    };
-
-    public object Execute(JsonElement args, ToolContext context)
-    {
-        var doc = context.Document ?? throw new NoActiveDocumentException();
-        string action = JsonArgs.GetString(args, "action") ?? "";
-        if (action is not ("create" or "configure")) throw new ArgumentException("action must be create or configure.");
-        var additions = Array(args, "add_fields", 50); var updates = Array(args, "update_fields", 50);
-        var sorts = Array(args, "sort_fields", 4); var filters = Array(args, "filters", 8);
-        return ModelEditBatch.Run(doc, Name, args, new[] { new ModelEditBatch.Step(new() { ["action"] = action }, () =>
-        {
-            ViewSchedule schedule;
-            if (action == "create")
-            {
-                string category = JsonArgs.GetString(args, "category") ?? throw new ArgumentException("category is required for creation.");
-                var categoryId = CategoryResolver.Resolve(doc, category);
-                schedule = JsonArgs.GetLong(args, "area_scheme_id") is long area ? ViewSchedule.CreateSchedule(doc, categoryId, new ElementId(area)) : ViewSchedule.CreateSchedule(doc, categoryId);
-                if (!args.TryGetProperty("name", out _)) throw new ArgumentException("name is required for creation.");
-            }
-            else
-            {
-                if (args.TryGetProperty("category", out _) || args.TryGetProperty("area_scheme_id", out _)) throw new ArgumentException("category and area_scheme_id are creation-only.");
-                schedule = doc.GetElement(new ElementId(JsonArgs.GetLong(args, "schedule_id") ?? 0)) as ViewSchedule ?? throw new ArgumentException("schedule_id is not a schedule.");
-            }
-            if (schedule.IsTemplate || schedule.IsTitleblockRevisionSchedule || schedule.Definition.IsEmbedded) throw new ArgumentException("Use a regular, non-template schedule.");
-            if (args.TryGetProperty("name", out var name))
-            {
-                if (name.ValueKind != JsonValueKind.String || string.IsNullOrWhiteSpace(name.GetString())) throw new ArgumentException("name must be nonempty.");
-                schedule.Name = name.GetString()!;
-            }
-            var definition = schedule.Definition;
-            var added = new List<int>();
-            foreach (var input in additions)
-            {
-                string typeName = JsonArgs.GetString(input, "field_type") ?? "";
-                if (typeName.Length == 0 || !char.IsLetter(typeName[0]) || !Enum.TryParse<ScheduleFieldType>(typeName, false, out var type) || !Enum.IsDefined(type)) throw new ArgumentException("Use a field_type from get_schedule_fields, or Count.");
-                ScheduleField field;
-                if (type == ScheduleFieldType.Count && !input.TryGetProperty("parameter_id", out _))
-                {
-                    field = definition.AddField(type);
-                }
-                else
-                {
-                    long parameterId = JsonArgs.GetLong(input, "parameter_id") ?? throw new ArgumentException("parameter_id is required for this field.");
-                    var eligible = definition.GetSchedulableFields().FirstOrDefault(f => f.ParameterId.Value == parameterId && f.FieldType == type) ?? throw new ArgumentException("That parameter_id/field_type pair is not eligible for this schedule.");
-                    field = definition.AddField(eligible);
-                }
-                ConfigureField(field, input); added.Add(field.FieldId.IntegerValue);
-            }
-            var seen = new HashSet<int>();
-            foreach (var input in updates)
-            {
-                var id = FieldId(input);
-                if (!seen.Add(id.IntegerValue)) throw new ArgumentException("update_fields contains a duplicate field_id.");
-                ConfigureField(definition.GetField(id), input);
-            }
-            if (args.TryGetProperty("is_itemized", out _)) definition.IsItemized = Bool(args, "is_itemized");
-            if (args.TryGetProperty("sort_fields", out _))
-                definition.SetSortGroupFields(sorts.Select(input => new ScheduleSortGroupField(FieldId(input), Bool(input, "descending") ? ScheduleSortOrder.Descending : ScheduleSortOrder.Ascending) { ShowHeader = Bool(input, "show_header") }).ToList());
-            if (args.TryGetProperty("filters", out _)) definition.SetFilters(filters.Select(input => Filter(definition, input)).ToList());
-            doc.Regenerate();
-            return new() { ["schedule_id"] = schedule.Id.Value, ["unique_id"] = schedule.UniqueId, ["name"] = schedule.Name,
-                ["created"] = action == "create", ["id_is_temporary"] = action == "create" && JsonArgs.GetBool(args, "preview", false),
-                ["added_field_ids"] = added, ["added_field_ids_are_temporary"] = JsonArgs.GetBool(args, "preview", false),
-                ["is_itemized"] = definition.IsItemized, ["field_count"] = definition.GetFieldCount(), ["filter_count"] = definition.GetFilterCount(), ["sort_count"] = definition.GetSortGroupFieldCount() };
-        }) }).Payload;
-    }
-
-    private static List<JsonElement> Array(JsonElement args, string name, int max)
-    {
-        if (!args.TryGetProperty(name, out var value)) return new();
-        if (value.ValueKind != JsonValueKind.Array || value.GetArrayLength() > max) throw new ArgumentException($"{name} must be an array of at most {max} entries.");
-        var items = value.EnumerateArray().ToList();
-        if (items.Any(item => item.ValueKind != JsonValueKind.Object)) throw new ArgumentException($"{name} entries must be objects.");
-        return items;
-    }
-    private static bool Bool(JsonElement args, string name)
-    {
-        if (!args.TryGetProperty(name, out var value)) return false;
-        if (value.ValueKind is not (JsonValueKind.True or JsonValueKind.False)) throw new ArgumentException($"{name} must be boolean.");
-        return value.GetBoolean();
-    }
-    private static ScheduleFieldId FieldId(JsonElement input)
-    {
-        long id = JsonArgs.GetLong(input, "field_id") ?? -1;
-        return id is >= 0 and <= int.MaxValue ? new ScheduleFieldId((int)id) : throw new ArgumentException("field_id must be a nonnegative schedule-local ID.");
-    }
-    private static void ConfigureField(ScheduleField field, JsonElement input)
-    {
-        if (input.TryGetProperty("heading", out var heading)) field.ColumnHeading = heading.ValueKind == JsonValueKind.String ? heading.GetString()! : throw new ArgumentException("heading must be a string.");
-        if (input.TryGetProperty("hidden", out _)) field.IsHidden = Bool(input, "hidden");
-        if (input.TryGetProperty("width", out _))
-        {
-            double width = ModelEditInputs.Number(input, "width") * ModelEditInputs.LengthScale(input);
-            if (width <= 0) throw new ArgumentException("Column width must be positive.");
-            field.GridColumnWidth = width; field.SheetColumnWidth = width;
-        }
-    }
-    private static ScheduleFilter Filter(ScheduleDefinition definition, JsonElement input)
-    {
-        var id = FieldId(input); var field = definition.GetField(id);
-        var comparison = JsonArgs.GetString(input, "comparison") switch
-        {
-            "equals" => ScheduleFilterType.Equal, "not_equals" => ScheduleFilterType.NotEqual, "contains" => ScheduleFilterType.Contains,
-            "greater_than" => ScheduleFilterType.GreaterThan, "less_than" => ScheduleFilterType.LessThan, _ => throw new ArgumentException("Unknown comparison."),
-        };
-        if (comparison == ScheduleFilterType.Contains ? !definition.CanFilterBySubstring(id) : !definition.CanFilterByValue(id)) throw new ArgumentException("This field does not support that filter operation.");
-        if (!input.TryGetProperty("value", out var value)) throw new ArgumentException("Filter value is required.");
-        string? type = JsonArgs.GetString(input, "value_type");
-        if (type == "string" && value.ValueKind == JsonValueKind.String) return new ScheduleFilter(id, comparison, value.GetString()!);
-        if (type == "integer" && value.ValueKind == JsonValueKind.Number && value.TryGetInt32(out int integer)) return new ScheduleFilter(id, comparison, integer);
-        if (type == "element_id" && value.ValueKind == JsonValueKind.Number && value.TryGetInt64(out long elementId)) return new ScheduleFilter(id, comparison, new ElementId(elementId));
-        if (type == "number")
-        {
-            double number = ModelEditInputs.Number(input, "value");
-            var spec = field.GetSpecTypeId(); string? unit = JsonArgs.GetString(input, "unit");
-            if (UnitUtils.IsMeasurableSpec(spec))
-            {
-                if (string.IsNullOrWhiteSpace(unit)) throw new ArgumentException("Measured numeric filters require an explicit unit.");
-                var unitId = UnitResolver.Resolve(unit);
-                if (!UnitUtils.IsValidUnit(spec, unitId)) throw new ArgumentException("Filter unit does not match the field's specification.");
-                number = UnitUtils.ConvertToInternalUnits(number, unitId);
-            }
-            else if (unit != null) throw new ArgumentException("This numeric field has no measurable unit.");
-            return new ScheduleFilter(id, comparison, number);
-        }
-        throw new ArgumentException("Filter value does not match value_type.");
-    }
-}
+using System.Text.Json;
+using Autodesk.Revit.DB;
+
+namespace RevitBridge.Tools;
+
+internal sealed class ManageSchedules : ITool
+{
+    public string Name => "manage_schedules";
+    public IReadOnlyList<string> DocumentKinds => DocumentKind.ProjectOnly;
+    public IReadOnlyList<string> Keywords => new[] { "create schedule", "schedule", "add field", "sort", "filter schedule", "quantities", "takeoff" };
+    public IReadOnlyList<ToolLimit> Limits => new[]
+    {
+        new ToolLimit("Calculated (formula) fields", "revit_unsupported", "Revit 2025 API exposes ScheduleFieldType.Formula but no member to author a formula"),
+        new ToolLimit("Combined-parameter fields", "api", "ScheduleDefinition.InsertCombinedParameterField"),
+        new ToolLimit("Schedule templates, titleblock revision schedules and embedded schedules", "api", "ViewSchedule and ScheduleDefinition members; verify with search_api_docs"),
+        new ToolLimit("Placing a schedule on a sheet", "tool", "manage_sheet_placements"),
+    };
+    public string? Verification => "reread";
+    public string Label => "Manage Schedules";
+    public string Tier => "advanced";
+    public bool Write => true;
+    public string Description => "Create or configure a regular schedule in one atomic step. Create requires category and name; optional area_scheme_id supports area schedules. Configure requires schedule_id. Discover add_fields using get_schedule_fields and pass the returned parameter_id + field_type pair, including Count when listed. Count also supports field_type Count without a parameter_id. update_fields, sort_fields and filters use schedule-local field_id from get_schedules. Supplied sort_fields/filters replace their entire lists; empty arrays clear them. Numeric measured filter values require a compatible unit; returned numeric filter values use internal units. Column widths require explicit length units and apply to both grid and sheet. preview=true commit-validates then rolls back; created schedule/field IDs in previews are temporary. Revision schedules, templates, embedded schedules and calculated/combined-field authoring are outside this tool.";
+    public object ParametersSchema => new
+    {
+        type = "object", properties = new
+        {
+            action = new { type = "string", @enum = new[] { "create", "configure" } },
+            schedule_id = new { type = "integer", minimum = 1 }, category = new { type = "string" }, name = new { type = "string", minLength = 1 }, area_scheme_id = new { type = "integer", minimum = 1 },
+            is_itemized = new { type = "boolean" }, preview = ModelEditInputs.PreviewSchema,
+            add_fields = new { type = "array", maxItems = 50, items = new { type = "object", properties = new
+            {
+                parameter_id = new { type = "integer", description = "Use the ID returned by get_schedule_fields, including negative built-in IDs. Optional for Count; when supplied, the pair must be eligible for the schedule." }, field_type = new { type = "string" },
+                heading = new { type = "string" }, hidden = new { type = "boolean" }, width = new { type = "number", exclusiveMinimum = 0 }, unit = ModelEditInputs.LengthUnitSchema,
+            }, required = new[] { "field_type" } } },
+            update_fields = new { type = "array", maxItems = 50, items = new { type = "object", properties = new
+            {
+                field_id = new { type = "integer", minimum = 0 }, heading = new { type = "string" }, hidden = new { type = "boolean" }, width = new { type = "number", exclusiveMinimum = 0 }, unit = ModelEditInputs.LengthUnitSchema,
+            }, required = new[] { "field_id" } } },
+            sort_fields = new { type = "array", maxItems = 4, items = new { type = "object", properties = new { field_id = new { type = "integer", minimum = 0 }, descending = new { type = "boolean" }, show_header = new { type = "boolean" } }, required = new[] { "field_id" } } },
+            filters = new { type = "array", maxItems = 8, items = new { type = "object", properties = new
+            {
+                field_id = new { type = "integer", minimum = 0 }, comparison = new { type = "string", @enum = new[] { "equals", "not_equals", "contains", "greater_than", "less_than" } },
+                value_type = new { type = "string", @enum = new[] { "string", "number", "integer", "element_id" } }, value = new { description = "Filter value matching value_type." }, unit = new { type = "string", description = "Required for measured numbers; compatible forge unit name, e.g. meters, squareMeters, degrees." },
+            }, required = new[] { "field_id", "comparison", "value_type", "value" } } },
+        }, required = new[] { "action" },
+    };
+
+    public object Execute(JsonElement args, ToolContext context)
+    {
+        var doc = context.Document ?? throw new NoActiveDocumentException();
+        string action = JsonArgs.GetString(args, "action") ?? "";
+        if (action is not ("create" or "configure")) throw new ArgumentException("action must be create or configure.");
+        var additions = Array(args, "add_fields", 50); var updates = Array(args, "update_fields", 50);
+        var sorts = Array(args, "sort_fields", 4); var filters = Array(args, "filters", 8);
+        return ModelEditBatch.Run(doc, Name, args, new[] { new ModelEditBatch.Step(new() { ["action"] = action }, () =>
+        {
+            ViewSchedule schedule;
+            if (action == "create")
+            {
+                string category = JsonArgs.GetString(args, "category") ?? throw new ArgumentException("category is required for creation.");
+                var categoryId = CategoryResolver.Resolve(doc, category);
+                schedule = JsonArgs.GetLong(args, "area_scheme_id") is long area ? ViewSchedule.CreateSchedule(doc, categoryId, new ElementId(area)) : ViewSchedule.CreateSchedule(doc, categoryId);
+                if (!args.TryGetProperty("name", out _)) throw new ArgumentException("name is required for creation.");
+            }
+            else
+            {
+                if (args.TryGetProperty("category", out _) || args.TryGetProperty("area_scheme_id", out _)) throw new ArgumentException("category and area_scheme_id are creation-only.");
+                schedule = doc.GetElement(new ElementId(JsonArgs.GetLong(args, "schedule_id") ?? 0)) as ViewSchedule ?? throw new ArgumentException("schedule_id is not a schedule.");
+            }
+            if (schedule.IsTemplate || schedule.IsTitleblockRevisionSchedule || schedule.Definition.IsEmbedded) throw new ArgumentException("Use a regular, non-template schedule.");
+            if (args.TryGetProperty("name", out var name))
+            {
+                if (name.ValueKind != JsonValueKind.String || string.IsNullOrWhiteSpace(name.GetString())) throw new ArgumentException("name must be nonempty.");
+                ElementNames.Assign(schedule, name.GetString()!);
+            }
+            var definition = schedule.Definition;
+            var added = new List<int>();
+            foreach (var input in additions)
+            {
+                string typeName = JsonArgs.GetString(input, "field_type") ?? "";
+                if (typeName.Length == 0 || !char.IsLetter(typeName[0]) || !Enum.TryParse<ScheduleFieldType>(typeName, false, out var type) || !Enum.IsDefined(type)) throw new ArgumentException("Use a field_type from get_schedule_fields, or Count.");
+                ScheduleField field;
+                if (type == ScheduleFieldType.Count && !input.TryGetProperty("parameter_id", out _))
+                {
+                    field = definition.AddField(type);
+                }
+                else
+                {
+                    long parameterId = JsonArgs.GetLong(input, "parameter_id") ?? throw new ArgumentException("parameter_id is required for this field.");
+                    var eligible = definition.GetSchedulableFields().FirstOrDefault(f => f.ParameterId.Value == parameterId && f.FieldType == type) ?? throw new ArgumentException("That parameter_id/field_type pair is not eligible for this schedule.");
+                    field = definition.AddField(eligible);
+                }
+                ConfigureField(field, input); added.Add(field.FieldId.IntegerValue);
+            }
+            var seen = new HashSet<int>();
+            foreach (var input in updates)
+            {
+                var id = FieldId(input);
+                if (!seen.Add(id.IntegerValue)) throw new ArgumentException("update_fields contains a duplicate field_id.");
+                ConfigureField(definition.GetField(id), input);
+            }
+            if (args.TryGetProperty("is_itemized", out _)) definition.IsItemized = Bool(args, "is_itemized");
+            if (args.TryGetProperty("sort_fields", out _))
+                definition.SetSortGroupFields(sorts.Select(input => new ScheduleSortGroupField(FieldId(input), Bool(input, "descending") ? ScheduleSortOrder.Descending : ScheduleSortOrder.Ascending) { ShowHeader = Bool(input, "show_header") }).ToList());
+            if (args.TryGetProperty("filters", out _)) definition.SetFilters(filters.Select(input => Filter(definition, input)).ToList());
+            doc.Regenerate();
+            return new() { ["schedule_id"] = schedule.Id.Value, ["unique_id"] = schedule.UniqueId, ["name"] = schedule.Name,
+                ["created"] = action == "create", ["id_is_temporary"] = action == "create" && JsonArgs.GetBool(args, "preview", false),
+                ["added_field_ids"] = added, ["added_field_ids_are_temporary"] = JsonArgs.GetBool(args, "preview", false),
+                ["is_itemized"] = definition.IsItemized, ["field_count"] = definition.GetFieldCount(), ["filter_count"] = definition.GetFilterCount(), ["sort_count"] = definition.GetSortGroupFieldCount() };
+        }) }).Payload;
+    }
+
+    private static List<JsonElement> Array(JsonElement args, string name, int max)
+    {
+        if (!args.TryGetProperty(name, out var value)) return new();
+        if (value.ValueKind != JsonValueKind.Array || value.GetArrayLength() > max) throw new ArgumentException($"{name} must be an array of at most {max} entries.");
+        var items = value.EnumerateArray().ToList();
+        if (items.Any(item => item.ValueKind != JsonValueKind.Object)) throw new ArgumentException($"{name} entries must be objects.");
+        return items;
+    }
+    private static bool Bool(JsonElement args, string name)
+    {
+        if (!args.TryGetProperty(name, out var value)) return false;
+        if (value.ValueKind is not (JsonValueKind.True or JsonValueKind.False)) throw new ArgumentException($"{name} must be boolean.");
+        return value.GetBoolean();
+    }
+    private static ScheduleFieldId FieldId(JsonElement input)
+    {
+        long id = JsonArgs.GetLong(input, "field_id") ?? -1;
+        return id is >= 0 and <= int.MaxValue ? new ScheduleFieldId((int)id) : throw new ArgumentException("field_id must be a nonnegative schedule-local ID.");
+    }
+    private static void ConfigureField(ScheduleField field, JsonElement input)
+    {
+        if (input.TryGetProperty("heading", out var heading)) field.ColumnHeading = heading.ValueKind == JsonValueKind.String ? heading.GetString()! : throw new ArgumentException("heading must be a string.");
+        if (input.TryGetProperty("hidden", out _)) field.IsHidden = Bool(input, "hidden");
+        if (input.TryGetProperty("width", out _))
+        {
+            double width = ModelEditInputs.Number(input, "width") * ModelEditInputs.LengthScale(input);
+            if (width <= 0) throw new ArgumentException("Column width must be positive.");
+            field.GridColumnWidth = width; field.SheetColumnWidth = width;
+        }
+    }
+    private static ScheduleFilter Filter(ScheduleDefinition definition, JsonElement input)
+    {
+        var id = FieldId(input); var field = definition.GetField(id);
+        var comparison = JsonArgs.GetString(input, "comparison") switch
+        {
+            "equals" => ScheduleFilterType.Equal, "not_equals" => ScheduleFilterType.NotEqual, "contains" => ScheduleFilterType.Contains,
+            "greater_than" => ScheduleFilterType.GreaterThan, "less_than" => ScheduleFilterType.LessThan, _ => throw new ArgumentException("Unknown comparison."),
+        };
+        if (comparison == ScheduleFilterType.Contains ? !definition.CanFilterBySubstring(id) : !definition.CanFilterByValue(id)) throw new ArgumentException("This field does not support that filter operation.");
+        if (!input.TryGetProperty("value", out var value)) throw new ArgumentException("Filter value is required.");
+        string? type = JsonArgs.GetString(input, "value_type");
+        if (type == "string" && value.ValueKind == JsonValueKind.String) return new ScheduleFilter(id, comparison, value.GetString()!);
+        if (type == "integer" && value.ValueKind == JsonValueKind.Number && value.TryGetInt32(out int integer)) return new ScheduleFilter(id, comparison, integer);
+        if (type == "element_id" && value.ValueKind == JsonValueKind.Number && value.TryGetInt64(out long elementId)) return new ScheduleFilter(id, comparison, new ElementId(elementId));
+        if (type == "number")
+        {
+            double number = ModelEditInputs.Number(input, "value");
+            var spec = field.GetSpecTypeId(); string? unit = JsonArgs.GetString(input, "unit");
+            if (UnitUtils.IsMeasurableSpec(spec))
+            {
+                if (string.IsNullOrWhiteSpace(unit)) throw new ArgumentException("Measured numeric filters require an explicit unit.");
+                var unitId = UnitResolver.Resolve(unit);
+                if (!UnitUtils.IsValidUnit(spec, unitId)) throw new ArgumentException("Filter unit does not match the field's specification.");
+                number = UnitUtils.ConvertToInternalUnits(number, unitId);
+            }
+            else if (unit != null) throw new ArgumentException("This numeric field has no measurable unit.");
+            return new ScheduleFilter(id, comparison, number);
+        }
+        throw new ArgumentException("Filter value does not match value_type.");
+    }
+}

package/src/Revit/Tools/ManageSelection.cs

@@ -11,8 +11,16 @@ namespace RevitBridge.Tools
     /// </summary>
     internal sealed class ManageSelection : ITool
     {
-        public string Name => "manage_selection";
-        public IReadOnlyList<string> Effects => new[] { "ui", "model" };
+        public string Name => "manage_selection";
+        public IReadOnlyList<string> DocumentKinds => DocumentKind.Both;
+        public IReadOnlyList<string> Keywords => new[] { "select", "highlight", "zoom", "isolate", "show in revit", "selected elements", "current selection" };
+        public IReadOnlyList<ToolLimit> Limits => new[]
+        {
+            new ToolLimit("Permanent hiding or view visibility changes", "api", "View.HideElements; View.SetCategoryHidden"),
+            new ToolLimit("Saved selection sets", "api", "SelectionFilterElement.Create"),
+        };
+        public string? Verification => "reread";
+        public IReadOnlyList<string> Effects => new[] { "ui", "model" };
         public string Label => "Manage Selection";
         public string Description => "Manage the Revit selection and view focus. action 'get' returns the currently selected elements (id, name, category, typeName, levelId); 'set'/'add'/'remove' change the selection with element_ids; 'clear' empties it; 'zoom' zooms open views to element_ids (default: the current selection). isolate_in_view=true additionally applies Revit's Temporary Hide/Isolate to the affected elements in the active view — temporary view state, not a model change (Revit needs a brief internal transaction to toggle it); with an empty target set (action 'clear', or 'get' with nothing selected) it resets the temporary isolate instead. Selection and zoom never modify model data.";
 
@@ -137,25 +145,25 @@ namespace RevitBridge.Tools
                 compactParts.Add($"ids not found: {string.Join(", ", notFound)}");
             }
 
-            if (isolateInView)
-            {
-                var view = uiDocument.ActiveGraphicalView;
-                IReadOnlyList<string> warnings;
-                try
-                {
-                    if (view is null)
-                        throw new ArgumentException("isolate_in_view requires an active graphical view in Revit.");
-                    warnings = ApplyTemporaryIsolate(doc, view, isolateTargets);
-                }
-                catch (Exception ex)
-                {
-                    throw new InvalidOperationException($"Selection action '{action}' completed before temporary isolate failed: {ex.Message}. Selection/zoom changes were not rolled back.", ex);
-                }
-                if (warnings.Count > 0)
-                {
-                    payload["commitWarnings"] = warnings;
-                    compactParts.Add($"{warnings.Count} Revit warning(s) auto-dismissed (see commitWarnings)");
-                }
+            if (isolateInView)
+            {
+                var view = uiDocument.ActiveGraphicalView;
+                IReadOnlyList<string> warnings;
+                try
+                {
+                    if (view is null)
+                        throw new ArgumentException("isolate_in_view requires an active graphical view in Revit.");
+                    warnings = ApplyTemporaryIsolate(doc, view, isolateTargets);
+                }
+                catch (Exception ex)
+                {
+                    throw new InvalidOperationException($"Selection action '{action}' completed before temporary isolate failed: {ex.Message}. Selection/zoom changes were not rolled back.", ex);
+                }
+                if (warnings.Count > 0)
+                {
+                    payload["commitWarnings"] = warnings;
+                    compactParts.Add($"{warnings.Count} Revit warning(s) auto-dismissed (see commitWarnings)");
+                }
                 payload["viewId"] = view.Id.Value;
                 payload["viewName"] = view.Name;
                 if (isolateTargets.Count == 0)
@@ -204,28 +212,28 @@ namespace RevitBridge.Tools
         /// only changes it inside an open transaction — so exactly this branch wraps
         /// a small one while the tool stays Write = false.
         /// </summary>
-        private static IReadOnlyList<string> ApplyTemporaryIsolate(Document doc, View view, ICollection<ElementId> elementIds)
-        {
-            using var transaction = new Transaction(doc, "manage_selection: temporary isolate");
-            if (transaction.Start() != TransactionStatus.Started)
-                throw new InvalidOperationException("Unable to start the temporary-isolate transaction.");
-            var failureGuard = FailureGuard.Attach(transaction);
+        private static IReadOnlyList<string> ApplyTemporaryIsolate(Document doc, View view, ICollection<ElementId> elementIds)
+        {
+            using var transaction = new Transaction(doc, "manage_selection: temporary isolate");
+            if (transaction.Start() != TransactionStatus.Started)
+                throw new InvalidOperationException("Unable to start the temporary-isolate transaction.");
+            var failureGuard = FailureGuard.Attach(transaction);
             try
             {
                 if (elementIds.Count == 0)
                     view.DisableTemporaryViewMode(TemporaryViewMode.TemporaryHideIsolate);
                 else
                     view.IsolateElementsTemporary(elementIds);
-                var status = transaction.Commit();
-                var finalStatus = transaction.GetStatus();
-                if (status != TransactionStatus.Committed || finalStatus != TransactionStatus.Committed)
-                    throw new InvalidOperationException($"The temporary-isolate commit returned {status}; current transaction status is {finalStatus}." + failureGuard.DescribeErrors());
-                return failureGuard.Warnings;
-            }
-            catch (Exception ex)
-            {
-                throw new InvalidOperationException($"Temporary isolate in view '{view.Name}' failed: {ex.Message} {FailureGuard.RollBackAndDescribe(transaction)}", ex);
-            }
+                var status = transaction.Commit();
+                var finalStatus = transaction.GetStatus();
+                if (status != TransactionStatus.Committed || finalStatus != TransactionStatus.Committed)
+                    throw new InvalidOperationException($"The temporary-isolate commit returned {status}; current transaction status is {finalStatus}." + failureGuard.DescribeErrors());
+                return failureGuard.Warnings;
+            }
+            catch (Exception ex)
+            {
+                throw new InvalidOperationException($"Temporary isolate in view '{view.Name}' failed: {ex.Message} {FailureGuard.RollBackAndDescribe(transaction)}", ex);
+            }
         }
     }
 }