pi-revit 0.3.0 → 0.3.1

package/src/Revit/Tools/GetElementDetails.cs

@@ -36,7 +36,7 @@ namespace RevitBridge.Tools
                     properties = new
                     {
                         parameters = new { type = "boolean", description = "Instance parameter values. Default true." },
-                        type_parameters = new { type = "boolean", description = "Include the element type's parameters, marked isType=true, independently of the instance parameters flag. Default false." },
+                        type_parameters = new { type = "boolean", description = "Include the element type's parameters, marked isType=true, independently of the instance parameters flag. Default false." },
                         location = new { type = "boolean", description = "Location point or curve (coordinates in internal feet). Default false." },
                         bounding_box = new { type = "boolean", description = "Model bounding box min/max (internal feet). Default false." },
                         materials = new { type = "boolean", description = "Material ids/names with area/volume (internal units). Default false." },
@@ -70,9 +70,9 @@ namespace RevitBridge.Tools
             JsonElement include = args.TryGetProperty("include", out var includeElement) && includeElement.ValueKind == JsonValueKind.Object
                 ? includeElement
                 : default;
-            bool withParameters = JsonArgs.GetBool(include, "parameters", true);
-            bool withTypeParameters = JsonArgs.GetBool(include, "type_parameters", false);
-            bool withAnyParameters = withParameters || withTypeParameters;
+            bool withParameters = JsonArgs.GetBool(include, "parameters", true);
+            bool withTypeParameters = JsonArgs.GetBool(include, "type_parameters", false);
+            bool withAnyParameters = withParameters || withTypeParameters;
             bool withLocation = JsonArgs.GetBool(include, "location", false);
             bool withBoundingBox = JsonArgs.GetBool(include, "bounding_box", false);
             bool withMaterials = JsonArgs.GetBool(include, "materials", false);
@@ -103,11 +103,11 @@ namespace RevitBridge.Tools
 
                 int parameterCount = 0;
                 int parameterTotal = 0;
-                if (withAnyParameters)
-                {
-                    var parameters = new List<Dictionary<string, object?>>();
-                    if (withParameters)
-                        parameterTotal += AppendParameters(doc, element, nameFilter, isType: false, parameters);
+                if (withAnyParameters)
+                {
+                    var parameters = new List<Dictionary<string, object?>>();
+                    if (withParameters)
+                        parameterTotal += AppendParameters(doc, element, nameFilter, isType: false, parameters);
                     if (withTypeParameters && elementType != null)
                         parameterTotal += AppendParameters(doc, elementType, nameFilter, isType: true, parameters);
                     dto["parameters"] = parameters;
@@ -124,7 +124,7 @@ namespace RevitBridge.Tools
                 elements.Add(dto);
                 // With a name filter active, "0 params" is ambiguous (none matched vs none
                 // exist): report matched-of-total so a localization miss is visible.
-                string paramSummary = !withAnyParameters ? string.Empty
+                string paramSummary = !withAnyParameters ? string.Empty
                     : nameFilter != null ? $", {parameterCount} of {parameterTotal} params matched parameter_names"
                     : $", {parameterCount} params";
                 compactParts.Add($"'{element.Name}' (id {id}, {element.Category?.Name ?? "no category"}{paramSummary})");

package/src/Revit/Tools/GetElements.cs

@@ -21,7 +21,7 @@ namespace RevitBridge.Tools
 
         public string Name => "get_elements";
         public string Label => "Get Elements";
-        public string Description => "Query Revit elements: scope by category (display name like 'Walls' or enum name like 'OST_Walls'), element class, level, type id, or active view; filter by parameter rules; paginate with offset/limit or just count with count_only. Returns identity fields only (id, name, category, typeName, levelId) — read parameter values with get_element_details. Rules with an explicit BuiltInParameter or shared GUID can evaluate inside Revit's collector; display-name rules, regex rules, and unsupported quick filters run as a per-element scan. A display name can identify different parameters even within one category or class. Scope queries to reduce the scan, or use an explicit parameter identity when appropriate. Numeric rule values are interpreted in the document's display units for that parameter unless 'unit' is given.";
+        public string Description => "Query Revit elements: scope by category (display name like 'Walls' or enum name like 'OST_Walls'), element class, level, type id, or active view; filter by parameter rules; paginate with offset/limit or just count with count_only. Returns identity fields only (id, name, category, typeName, levelId) — read parameter values with get_element_details. Rules with an explicit BuiltInParameter or shared GUID can evaluate inside Revit's collector; display-name rules, regex rules, and unsupported quick filters run as a per-element scan. A display name can identify different parameters even within one category or class. Scope queries to reduce the scan, or use an explicit parameter identity when appropriate. Numeric rule values are interpreted in the document's display units for that parameter unless 'unit' is given.";
 
         public object ParametersSchema => new
         {
@@ -292,9 +292,9 @@ namespace RevitBridge.Tools
             if (rules.Count == 0)
                 return (null, null, Array.Empty<string>());
 
-            // Probe a few in-scope elements for missing-name diagnostics and to find
-            // storage/spec exemplars for explicit parameter identities. A sample must
-            // never turn a display name into an assumed globally uniform identity.
+            // Probe a few in-scope elements for missing-name diagnostics and to find
+            // storage/spec exemplars for explicit parameter identities. A sample must
+            // never turn a display name into an assumed globally uniform identity.
             var probes = new List<Element>(ProbeSize);
             foreach (Element element in createBaseCollector())
             {
@@ -326,19 +326,19 @@ namespace RevitBridge.Tools
                 }
             }
 
-            foreach (var rule in rules)
-            {
-                if (rule.Op is RuleOp.Regex or RuleOp.IsEmpty or RuleOp.IsNotEmpty)
-                    continue; // always post-scan (missing-parameter semantics)
-                // Category/class scope and unanimous samples do not establish a
-                // uniform parameter identity across later families. Resolve display
-                // names per element; only explicit identities may use a quick rule.
-                if (rule.BuiltIn is null && rule.SharedGuid is null)
-                    continue;
-                var found = probes.Select(probe => FindParameter(probe, rule)).Where(parameter => parameter != null).ToList();
-                if (found.Count == 0)
-                    continue;
-                rule.QuickRule = TryBuildQuickRule(doc, rule, found[0]!);
+            foreach (var rule in rules)
+            {
+                if (rule.Op is RuleOp.Regex or RuleOp.IsEmpty or RuleOp.IsNotEmpty)
+                    continue; // always post-scan (missing-parameter semantics)
+                // Category/class scope and unanimous samples do not establish a
+                // uniform parameter identity across later families. Resolve display
+                // names per element; only explicit identities may use a quick rule.
+                if (rule.BuiltIn is null && rule.SharedGuid is null)
+                    continue;
+                var found = probes.Select(probe => FindParameter(probe, rule)).Where(parameter => parameter != null).ToList();
+                if (found.Count == 0)
+                    continue;
+                rule.QuickRule = TryBuildQuickRule(doc, rule, found[0]!);
             }
 
             var quickRules = rules.Where(rule => rule.QuickRule != null).ToList();

package/src/Revit/Tools/GetModelOverview.cs

@@ -45,8 +45,8 @@ namespace RevitBridge.Tools
             string? lengthUnit = DisplayUnitName(units, SpecTypeId.Length);
             var project = new Dictionary<string, object?>
             {
-                ["title"] = doc.Title,
-                ["documentId"] = DocumentGuard.GetIdentity(doc),
+                ["title"] = doc.Title,
+                ["documentId"] = DocumentGuard.GetIdentity(doc),
                 ["name"] = info?.Name,
                 ["number"] = info?.Number,
                 ["clientName"] = info?.ClientName,

package/src/Revit/Tools/ManageSelection.cs

@@ -136,25 +136,25 @@ namespace RevitBridge.Tools
                 compactParts.Add($"ids not found: {string.Join(", ", notFound)}");
             }
 
-            if (isolateInView)
-            {
-                var view = uiDocument.ActiveGraphicalView;
-                IReadOnlyList<string> warnings;
-                try
-                {
-                    if (view is null)
-                        throw new ArgumentException("isolate_in_view requires an active graphical view in Revit.");
-                    warnings = ApplyTemporaryIsolate(doc, view, isolateTargets);
-                }
-                catch (Exception ex)
-                {
-                    throw new InvalidOperationException($"Selection action '{action}' completed before temporary isolate failed: {ex.Message}. Selection/zoom changes were not rolled back.", ex);
-                }
-                if (warnings.Count > 0)
-                {
-                    payload["commitWarnings"] = warnings;
-                    compactParts.Add($"{warnings.Count} Revit warning(s) auto-dismissed (see commitWarnings)");
-                }
+            if (isolateInView)
+            {
+                var view = uiDocument.ActiveGraphicalView;
+                IReadOnlyList<string> warnings;
+                try
+                {
+                    if (view is null)
+                        throw new ArgumentException("isolate_in_view requires an active graphical view in Revit.");
+                    warnings = ApplyTemporaryIsolate(doc, view, isolateTargets);
+                }
+                catch (Exception ex)
+                {
+                    throw new InvalidOperationException($"Selection action '{action}' completed before temporary isolate failed: {ex.Message}. Selection/zoom changes were not rolled back.", ex);
+                }
+                if (warnings.Count > 0)
+                {
+                    payload["commitWarnings"] = warnings;
+                    compactParts.Add($"{warnings.Count} Revit warning(s) auto-dismissed (see commitWarnings)");
+                }
                 payload["viewId"] = view.Id.Value;
                 payload["viewName"] = view.Name;
                 if (isolateTargets.Count == 0)
@@ -203,28 +203,28 @@ namespace RevitBridge.Tools
         /// only changes it inside an open transaction — so exactly this branch wraps
         /// a small one while the tool stays Write = false.
         /// </summary>
-        private static IReadOnlyList<string> ApplyTemporaryIsolate(Document doc, View view, ICollection<ElementId> elementIds)
-        {
-            using var transaction = new Transaction(doc, "manage_selection: temporary isolate");
-            if (transaction.Start() != TransactionStatus.Started)
-                throw new InvalidOperationException("Unable to start the temporary-isolate transaction.");
-            var failureGuard = FailureGuard.Attach(transaction);
+        private static IReadOnlyList<string> ApplyTemporaryIsolate(Document doc, View view, ICollection<ElementId> elementIds)
+        {
+            using var transaction = new Transaction(doc, "manage_selection: temporary isolate");
+            if (transaction.Start() != TransactionStatus.Started)
+                throw new InvalidOperationException("Unable to start the temporary-isolate transaction.");
+            var failureGuard = FailureGuard.Attach(transaction);
             try
             {
                 if (elementIds.Count == 0)
                     view.DisableTemporaryViewMode(TemporaryViewMode.TemporaryHideIsolate);
                 else
                     view.IsolateElementsTemporary(elementIds);
-                var status = transaction.Commit();
-                var finalStatus = transaction.GetStatus();
-                if (status != TransactionStatus.Committed || finalStatus != TransactionStatus.Committed)
-                    throw new InvalidOperationException($"The temporary-isolate commit returned {status}; current transaction status is {finalStatus}." + failureGuard.DescribeErrors());
-                return failureGuard.Warnings;
-            }
-            catch (Exception ex)
-            {
-                throw new InvalidOperationException($"Temporary isolate in view '{view.Name}' failed: {ex.Message} {FailureGuard.RollBackAndDescribe(transaction)}", ex);
-            }
+                var status = transaction.Commit();
+                var finalStatus = transaction.GetStatus();
+                if (status != TransactionStatus.Committed || finalStatus != TransactionStatus.Committed)
+                    throw new InvalidOperationException($"The temporary-isolate commit returned {status}; current transaction status is {finalStatus}." + failureGuard.DescribeErrors());
+                return failureGuard.Warnings;
+            }
+            catch (Exception ex)
+            {
+                throw new InvalidOperationException($"Temporary isolate in view '{view.Name}' failed: {ex.Message} {FailureGuard.RollBackAndDescribe(transaction)}", ex);
+            }
         }
     }
 }

package/src/Revit/Tools/SetParameters.cs

@@ -70,9 +70,9 @@ namespace RevitBridge.Tools
             var failed = new List<Dictionary<string, object?>>();
 
             using var transaction = new Transaction(doc, "set_parameters");
-            if (transaction.Start() != TransactionStatus.Started)
-                throw new InvalidOperationException("Unable to start the set_parameters transaction.");
-            var failureGuard = FailureGuard.Attach(transaction);
+            if (transaction.Start() != TransactionStatus.Started)
+                throw new InvalidOperationException("Unable to start the set_parameters transaction.");
+            var failureGuard = FailureGuard.Attach(transaction);
 
             try
             {
@@ -101,23 +101,23 @@ namespace RevitBridge.Tools
 
                 if (succeeded.Count > 0)
                 {
-                    var status = transaction.Commit();
-                    var finalStatus = transaction.GetStatus();
-                    if (status != TransactionStatus.Committed || finalStatus != TransactionStatus.Committed)
-                        throw new InvalidOperationException(
-                            $"The set_parameters commit returned {status}; current transaction status is {finalStatus}."
+                    var status = transaction.Commit();
+                    var finalStatus = transaction.GetStatus();
+                    if (status != TransactionStatus.Committed || finalStatus != TransactionStatus.Committed)
+                        throw new InvalidOperationException(
+                            $"The set_parameters commit returned {status}; current transaction status is {finalStatus}."
                             + failureGuard.DescribeErrors());
                 }
                 else
                 {
-                    var status = transaction.RollBack();
-                    if (status != TransactionStatus.RolledBack || transaction.GetStatus() != TransactionStatus.RolledBack)
-                        throw new InvalidOperationException($"The set_parameters rollback returned {status}.");
+                    var status = transaction.RollBack();
+                    if (status != TransactionStatus.RolledBack || transaction.GetStatus() != TransactionStatus.RolledBack)
+                        throw new InvalidOperationException($"The set_parameters rollback returned {status}.");
                 }
             }
-            catch (Exception ex)
-            {
-                throw new InvalidOperationException($"{ex.Message} {FailureGuard.RollBackAndDescribe(transaction)}", ex);
+            catch (Exception ex)
+            {
+                throw new InvalidOperationException($"{ex.Message} {FailureGuard.RollBackAndDescribe(transaction)}", ex);
             }
 
             int elementCount = succeeded.Select(row => row["id"]).Distinct().Count();

package/src/Revit/Tools/ToolSupport.cs

@@ -259,4 +259,4 @@ namespace RevitBridge.Tools
         }
     }
 
-}
+}

package/workspace/AGENTS.md

@@ -1,10 +1,10 @@
 # pi-revit workspace
 
 This folder tree is the working area for Pi + Revit sessions. The pi-revit tools talk to the
-Revit bridge add-in, targeting Revit 2025, 2026, and 2027. The 0.3.0 changes were
-tested live on Revit 2025. Bridge document tools require a project open; `ping` and
-`search_api_docs` work without a document. `read_revit_result` reads saved local
-results without contacting Revit.
+Revit bridge add-in, targeting Revit 2025, 2026, and 2027. The 0.3.0 changes were
+tested live on Revit 2025. Bridge document tools require a project open; `ping` and
+`search_api_docs` work without a document. `read_revit_result` reads saved local
+results without contacting Revit.
 
 ## File rules — where every file goes
 
@@ -16,57 +16,57 @@ Documents\pi-revit\
 ├─ AGENTS.md            <- this file
 ├─ pi-revit.cmd         <- double-click launcher
 └─ Models\
-   └─ <model title>--<identity hash>\  <- selected automatically for the exported document
-      ├─ model.txt      <- document identity/path marker written by the add-in
+   └─ <model title>--<identity hash>\  <- selected automatically for the exported document
+      ├─ model.txt      <- document identity/path marker written by the add-in
       ├─ exports\       <- export_documents output (its default)
       ├─ captures\      <- view snapshots worth keeping
       └─ scripts\       <- generated scripts and analysis for that model
 ```
 
 1. **Let exports sort themselves**: call `export_documents` without `output_dir` — files land
-   in an identity-derived model folder automatically. Treat the returned `outputDir`
-   and file paths as authoritative; do not derive the hash from the model title or
-   opaque `project.documentId`. Save As can change the destination. Existing title-only
-   folders remain untouched. Pass
+   in an identity-derived model folder automatically. Treat the returned `outputDir`
+   and file paths as authoritative; do not derive the hash from the model title or
+   opaque `project.documentId`. Save As can change the destination. Existing title-only
+   folders remain untouched. Pass
    `output_dir` only when the user names a different target.
 2. **Anything else you produce about a model goes into that model's folder**: view captures the
-   user wants to keep in that verified model folder's `captures` subfolder
-   (`capture_view` writes to temp), and scripts and analysis in its `scripts`
-   subfolder. For a default export, the model folder is the parent of returned
-   `outputDir`. If no folder has been established, identify it from existing model
-   markers or choose an explicit destination for the task; do not trigger an
-   unnecessary export or guess a title-only folder. Create subfolders on first use.
+   user wants to keep in that verified model folder's `captures` subfolder
+   (`capture_view` writes to temp), and scripts and analysis in its `scripts`
+   subfolder. For a default export, the model folder is the parent of returned
+   `outputDir`. If no folder has been established, identify it from existing model
+   markers or choose an explicit destination for the task; do not trigger an
+   unnecessary export or guess a title-only folder. Create subfolders on first use.
 3. **Never create files loose in the workspace root.** The root holds `AGENTS.md`,
    `pi-revit.cmd`, `Models\`, and Pi's own session data — nothing else, ever.
 
 ## Tool habits
 
-- Start unfamiliar models with `get_model_overview`; use `get_elements` for any listing or
-  counting; read parameter values with `get_element_details`.
-- Copy the intended model's `project.documentId` unchanged into `expected_document_id`
-  for `set_parameters`, `execute_csharp`, `export_documents`, `open_view`, and
-  selection/zoom changes. Any `manage_selection` call with `isolate_in_view: true`
-  also requires it, including action `get`. Pure reads may omit it; supplied IDs
-  are checked. Legacy `expected_document` titles alone do not satisfy the guard.
-  After a rejection, verify the intended model before refreshing its ID. Closing
-  and reopening a model or restarting Revit invalidates earlier IDs.
-- Before `execute_csharp`, verify unfamiliar API signatures with `search_api_docs`.
-- Write tools (`set_parameters`, `execute_csharp`) change the real model — state clearly what
-  was changed. `set_parameters` commits partial successes: always check its `failed` list.
-  Inspect `commitWarnings` and the actual transaction outcome. A failed
-  `execute_csharp` attempts rollback; do not assume rollback succeeded. A
-  `returnValueError` can follow a committed edit. Earlier UI actions and created
-  files can persist after failure. Read reported effects before retrying.
-- When a result returns `result_id`, use `read_revit_result` from offset zero and
-  follow `next_offset` until `has_more` is false. Join its `text` fragments in order;
-  offsets count UTF-16 code units. The returned absolute file path remains a
-  fallback for `read` after extension reload while the file exists. Tool query
-  pagination and limits still apply separately.
-
-## Upgrade notes
-
-After installing 0.3.0, deploy the matching add-in with Revit closed, restart Revit,
-and start a fresh Pi session to load the new tool schemas. Obtain a new overview
-before changing a document. Setup preserves existing `AGENTS.md`; older workspaces
-need these exact-ID, saved-result, and identity-derived folder rules merged into
-their existing instructions.
+- Start unfamiliar models with `get_model_overview`; use `get_elements` for any listing or
+  counting; read parameter values with `get_element_details`.
+- Copy the intended model's `project.documentId` unchanged into `expected_document_id`
+  for `set_parameters`, `execute_csharp`, `export_documents`, `open_view`, and
+  selection/zoom changes. Any `manage_selection` call with `isolate_in_view: true`
+  also requires it, including action `get`. Pure reads may omit it; supplied IDs
+  are checked. Legacy `expected_document` titles alone do not satisfy the guard.
+  After a rejection, verify the intended model before refreshing its ID. Closing
+  and reopening a model or restarting Revit invalidates earlier IDs.
+- Before `execute_csharp`, verify unfamiliar API signatures with `search_api_docs`.
+- Write tools (`set_parameters`, `execute_csharp`) change the real model — state clearly what
+  was changed. `set_parameters` commits partial successes: always check its `failed` list.
+  Inspect `commitWarnings` and the actual transaction outcome. A failed
+  `execute_csharp` attempts rollback; do not assume rollback succeeded. A
+  `returnValueError` can follow a committed edit. Earlier UI actions and created
+  files can persist after failure. Read reported effects before retrying.
+- When a result returns `result_id`, use `read_revit_result` from offset zero and
+  follow `next_offset` until `has_more` is false. Join its `text` fragments in order;
+  offsets count UTF-16 code units. The returned absolute file path remains a
+  fallback for `read` after extension reload while the file exists. Tool query
+  pagination and limits still apply separately.
+
+## Upgrade notes
+
+After installing 0.3.0, deploy the matching add-in with Revit closed, restart Revit,
+and start a fresh Pi session to load the new tool schemas. Obtain a new overview
+before changing a document. Setup preserves existing `AGENTS.md`; older workspaces
+need these exact-ID, saved-result, and identity-derived folder rules merged into
+their existing instructions.