pi-revit 0.2.5 → 0.2.6

package/CHANGELOG.md

@@ -7,6 +7,22 @@ Format follows [Keep a Changelog](https://keepachangelog.com/); version headers
 Every published version gets an entry with **Added** / **Changed** / **Fixed** sections
 describing what the user will notice — not internal refactors.
 
+## [0.2.6] - 2026-07-20
+
+### Fixed
+- Write transactions (`set_parameters`, `execute_csharp`, and the temporary-isolate
+  branch of `manage_selection`) now register a failures preprocessor. Previously Revit
+  handled commit failures interactively: warnings popped the transient toast and spammed
+  the journal, and an error-severity failure showed the modal resolution dialog, blocking
+  the bridge until a human clicked. Now warnings are auto-dismissed and reported back
+  (`commitWarnings` in the result, e.g. duplicate Mark values), and errors roll the
+  transaction back with the actual Revit failure text in the error message.
+
+### Changed
+- `set_parameters` tool description tells the model to relay `commitWarnings` to the user.
+
+Requires redeploying the Revit add-in (`scripts\deploy.ps1` + Revit restart).
+
 ## [0.2.5] - 2026-07-20
 
 ### Fixed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-revit",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "description": "Native Pi connector for Autodesk Revit. Run npx.cmd -y pi-revit for the full Windows install.",
   "author": "Ahmad Altahlawi",
   "license": "MIT",

package/src/Revit/Tools/ExecuteCsharp.cs

@@ -113,6 +113,7 @@ namespace RevitBridge.Tools
 
             using var dialogGuard = new DialogGuard(uiapp);
             using var transaction = new Transaction(doc, "execute_csharp");
+            var failureGuard = FailureGuard.Attach(transaction);
             if (transaction.Start() != TransactionStatus.Started)
                 throw new InvalidOperationException("Unable to start the execute_csharp transaction.");
 
@@ -142,6 +143,7 @@ namespace RevitBridge.Tools
             if (transaction.Commit() != TransactionStatus.Committed)
                 throw new InvalidOperationException(
                     "Revit rolled back the execute_csharp transaction during commit (failure processing rejected the changes); no model changes were saved."
+                    + failureGuard.DescribeErrors()
                     + DescribeDialogs(dialogGuard.Suppressed));
 
             stopwatch.Stop();
@@ -154,6 +156,8 @@ namespace RevitBridge.Tools
             };
             if (dialogGuard.Suppressed.Count > 0)
                 payload["suppressedDialogs"] = dialogGuard.Suppressed;
+            if (failureGuard.Warnings.Count > 0)
+                payload["commitWarnings"] = failureGuard.Warnings;
             return payload;
         }
 

package/src/Revit/Tools/FailureGuard.cs

@@ -0,0 +1,62 @@
+using Autodesk.Revit.DB;
+
+namespace RevitBridge.Tools
+{
+    /// <summary>
+    /// Deterministic commit-time failure handling for tool-owned transactions. Without a
+    /// preprocessor, Revit resolves commit failures interactively: warnings pop the
+    /// transient toast (and spam the journal), and error-severity failures block the
+    /// Revit API thread behind the modal resolution dialog until a human clicks — past
+    /// the bridge's call budget. Attach() deletes warnings (recorded for the tool
+    /// result) and turns errors into a rollback, so a headless caller always gets an
+    /// answer instead of a hang.
+    /// </summary>
+    internal sealed class FailureGuard : IFailuresPreprocessor
+    {
+        public List<string> Warnings { get; } = new();
+        public List<string> Errors { get; } = new();
+
+        public static FailureGuard Attach(Transaction transaction)
+        {
+            var guard = new FailureGuard();
+            var options = transaction.GetFailureHandlingOptions();
+            options.SetFailuresPreprocessor(guard);
+            options.SetClearAfterRollback(true);
+            transaction.SetFailureHandlingOptions(options);
+            return guard;
+        }
+
+        public FailureProcessingResult PreprocessFailures(FailuresAccessor accessor)
+        {
+            bool hasError = false;
+            foreach (FailureMessageAccessor failure in accessor.GetFailureMessages())
+            {
+                string description;
+                try
+                {
+                    description = failure.GetDescriptionText();
+                }
+                catch
+                {
+                    description = "(failure without description)";
+                }
+
+                if (failure.GetSeverity() == FailureSeverity.Warning)
+                {
+                    Warnings.Add(description);
+                    accessor.DeleteWarning(failure);
+                }
+                else
+                {
+                    hasError = true;
+                    Errors.Add(description);
+                }
+            }
+            return hasError ? FailureProcessingResult.ProceedWithRollBack : FailureProcessingResult.Continue;
+        }
+
+        /// <summary>Formats the recorded errors for a commit-failure message.</summary>
+        public string DescribeErrors()
+            => Errors.Count > 0 ? $" Revit failure(s): {string.Join("; ", Errors)}." : string.Empty;
+    }
+}

package/src/Revit/Tools/ManageSelection.cs

@@ -192,6 +192,7 @@ namespace RevitBridge.Tools
         private static void ApplyTemporaryIsolate(Document doc, View view, ICollection<ElementId> elementIds)
         {
             using var transaction = new Transaction(doc, "manage_selection: temporary isolate");
+            var failureGuard = FailureGuard.Attach(transaction);
             if (transaction.Start() != TransactionStatus.Started)
                 throw new InvalidOperationException("Unable to start the temporary-isolate transaction.");
             try
@@ -201,7 +202,7 @@ namespace RevitBridge.Tools
                 else
                     view.IsolateElementsTemporary(elementIds);
                 if (transaction.Commit() != TransactionStatus.Committed)
-                    throw new InvalidOperationException("The temporary-isolate transaction failed to commit.");
+                    throw new InvalidOperationException("The temporary-isolate transaction failed to commit." + failureGuard.DescribeErrors());
             }
             catch (Autodesk.Revit.Exceptions.InvalidOperationException ex)
             {

package/src/Revit/Tools/SetParameters.cs

@@ -19,7 +19,7 @@ namespace RevitBridge.Tools
 
         public string Name => "set_parameters";
         public string Label => "Set Parameters";
-        public string Description => "Write parameter values on elements — also the home for rename: parameter 'Name' covers levels, views, sheets, types, etc. (falls back to the element's Name property when the Name parameter is read-only). updates apply in ONE transaction: partial success commits and lists the failures; if every update fails the transaction is rolled back and nothing changes. parameter accepts a display name (Comments, Mark, Name), a BuiltInParameter enum name (e.g. ALL_MODEL_MARK), or guid:<GUID> for a shared parameter; type parameters live on the element type, so pass the type's id. Values are validated against the parameter's storage type; numeric values are interpreted in the document's display units for that parameter unless 'unit' (e.g. millimeters, feet, squareMeters) is given.";
+        public string Description => "Write parameter values on elements — also the home for rename: parameter 'Name' covers levels, views, sheets, types, etc. (falls back to the element's Name property when the Name parameter is read-only). updates apply in ONE transaction: partial success commits and lists the failures; if every update fails the transaction is rolled back and nothing changes. parameter accepts a display name (Comments, Mark, Name), a BuiltInParameter enum name (e.g. ALL_MODEL_MARK), or guid:<GUID> for a shared parameter; type parameters live on the element type, so pass the type's id. Values are validated against the parameter's storage type; numeric values are interpreted in the document's display units for that parameter unless 'unit' (e.g. millimeters, feet, squareMeters) is given. Revit warnings raised at commit (e.g. duplicate Mark values) are auto-dismissed and listed in commitWarnings — mention them to the user; error-severity failures roll the whole transaction back.";
         public bool Write => true;
 
         public object ParametersSchema => new
@@ -64,6 +64,7 @@ namespace RevitBridge.Tools
             var failed = new List<Dictionary<string, object?>>();
 
             using var transaction = new Transaction(doc, "set_parameters");
+            var failureGuard = FailureGuard.Attach(transaction);
             if (transaction.Start() != TransactionStatus.Started)
                 throw new InvalidOperationException("Unable to start the set_parameters transaction.");
 
@@ -95,7 +96,9 @@ namespace RevitBridge.Tools
                 if (succeeded.Count > 0)
                 {
                     if (transaction.Commit() != TransactionStatus.Committed)
-                        throw new InvalidOperationException("The set_parameters transaction failed to commit; no changes were saved.");
+                        throw new InvalidOperationException(
+                            "Revit rejected the set_parameters commit and the transaction was rolled back; no changes were saved."
+                            + failureGuard.DescribeErrors());
                 }
                 else
                 {
@@ -118,6 +121,8 @@ namespace RevitBridge.Tools
                 : succeeded.Count == 0
                     ? $"No updates applied; all {failed.Count} failed — transaction rolled back.{failureSample}"
                     : $"Updated {succeeded.Count} parameter value(s) on {elementCount} element(s); {failed.Count} failed.{failureSample}";
+            if (failureGuard.Warnings.Count > 0)
+                compact += $" {failureGuard.Warnings.Count} Revit warning(s) auto-dismissed at commit (see commitWarnings), e.g.: {failureGuard.Warnings[0]}";
 
             return new ToolOutput(new
             {
@@ -125,6 +130,7 @@ namespace RevitBridge.Tools
                 committed = succeeded.Count > 0,
                 succeeded,
                 failed,
+                commitWarnings = failureGuard.Warnings,
             }, compact);
         }