pi-revit 0.2.14 → 0.2.16

package/CHANGELOG.md

@@ -7,6 +7,37 @@ Format follows [Keep a Changelog](https://keepachangelog.com/); version headers
 Every published version gets an entry with **Added** / **Changed** / **Fixed** sections
 describing what the user will notice — not internal refactors.
 
+## [0.2.16] - 2026-08-21
+
+### Fixed
+- `search_api_docs`: an accessor-spelling query combined with `kind: "method"` — e.g.
+  `Element.get_Parameter(BuiltInParameter)` filtered to methods — returned "no matches",
+  because the accessor rewrite found the documented member but the kind filter rejected it:
+  a C# `get_X`/`set_X` accessor is a method to the caller, while the XML documents the
+  underlying member as a property or indexer. For accessor-rewritten candidates the
+  `method` filter now also admits properties, and the result note says so. Found by an
+  agent under a stress test that filtered its doc query to methods. Two benchmark probes
+  added (the widening plus a real-method control).
+
+Requires redeploying the Revit add-in (`scripts\deploy.ps1` with Revit closed, then
+restart Revit).
+
+## [0.2.15] - 2026-08-21
+
+### Fixed
+- `set_parameters`: the "parameter not found" error now mentions that display names are
+  localized and points to the language-independent BuiltInParameter enum name — the same
+  guidance `get_element_details` and `get_elements` already give. Previously it only
+  suggested the type-parameter cause, which sent the caller down the wrong path in
+  non-English UIs.
+- `get_elements`: the "filter parameter not found on any probed element" warning now
+  appears only when the query returned zero matches — that is where it distinguishes
+  "unknown parameter name" from "no matching elements". Next to real matches it was noise
+  (an unscoped query's probe window can simply miss the elements that carry the parameter).
+
+Requires redeploying the Revit add-in (`scripts\deploy.ps1` with Revit closed, then
+restart Revit).
+
 ## [0.2.14] - 2026-08-21
 
 ### Fixed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-revit",
-  "version": "0.2.14",
+  "version": "0.2.16",
   "description": "Native Pi connector for Autodesk Revit. Run npx.cmd -y pi-revit for the full Windows install.",
   "author": "Ahmad Altahlawi",
   "license": "MIT",

package/scripts/benchmark-search-docs.py

@@ -31,8 +31,10 @@ else:
     XML_PATH = candidates[-1]
 
 LAT = []
-def search(query, max_results=10):
-    body = json.dumps({"query": query, "max_results": max_results}).encode("utf-8")
+def search(query, max_results=10, kind=None):
+    args = {"query": query, "max_results": max_results}
+    if kind: args["kind"] = kind
+    body = json.dumps(args).encode("utf-8")
     url = f"{BASE}/tools/search_api_docs/execute?token={TOKEN}&timeout_ms=60000"
     req = urllib.request.Request(url, data=body, headers={"content-type": "application/json"}, method="POST")
     t0 = time.perf_counter()
@@ -180,8 +182,8 @@ R["B signature+spacing"] = B
 
 # --------------------------------------------------------- C: complex syntax shapes
 C = {"cases": []}
-def probe(label, q, expect_nonzero=True):
-    try: matches, total = search(q)
+def probe(label, q, expect_nonzero=True, kind=None):
+    try: matches, total = search(q, kind=kind)
     except Exception as e:
         C["cases"].append((label, q, f"ERROR {e}")); return
     ok = (total > 0) if expect_nonzero else (total == 0)
@@ -213,6 +215,9 @@ probe("factory honesty control", "Document.Create.Banana", expect_nonzero=False)
 probe("accessor indexer", "Element.get_Parameter(BuiltInParameter")
 probe("accessor property", "Element.get_BoundingBox(View")
 probe("literal get_ member", "LocationCurve.get_ElementsAtJoin")
+# 0.2.16: kind=method on an accessor query admits the documented property
+probe("accessor with kind=method", "Element.get_Parameter(BuiltInParameter", kind="method")
+probe("kind=method control (real method)", "Wall.Create(Document, Curve", kind="method")
 print("C done", flush=True)
 R["C complex-syntax"] = C
 

package/src/Revit/Tools/GetElements.cs

@@ -147,7 +147,10 @@ namespace RevitBridge.Tools
             string scope = DescribeScope(categoryInput, classInput, inActiveView);
 
             if (countOnly && postPredicate is null)
-                return CountResult(scope, CreateCollector().GetElementCount(), filterWarnings);
+            {
+                int quickCount = CreateCollector().GetElementCount();
+                return CountResult(scope, quickCount, quickCount > 0 ? Array.Empty<string>() : filterWarnings);
+            }
 
             var rows = countOnly ? null : new List<Dictionary<string, object?>>(Math.Min(limit, 256));
             int total = 0;
@@ -160,6 +163,12 @@ namespace RevitBridge.Tools
                 total++;
             }
 
+            // A found match proves the query worked: the not-found-on-probes warning is
+            // load-bearing only next to a zero, where it distinguishes 'unknown parameter
+            // name' from 'no matching elements'. Beside real matches it is just noise.
+            if (total > 0)
+                filterWarnings = Array.Empty<string>();
+
             if (rows is null)
                 return CountResult(scope, total, filterWarnings);
 

package/src/Revit/Tools/SearchApiDocs.cs

@@ -142,17 +142,17 @@ namespace RevitBridge.Tools
             // member, before giving up. Deterministic rewrites of an exact idiom — never
             // applied unless the literal 'document.create.' / 'application.create.' prefix
             // is present, so ordinary names like Wall.Create are untouched.
-            var candidates = new List<(string Query, string? Note)> { (q, null) };
+            var candidates = new List<(string Query, string? Note, bool AccessorRewrite)> { (q, null, false) };
             foreach (string factory in new[] { "document.create.", "application.create." })
             {
                 if (!q.StartsWith(factory, StringComparison.Ordinal))
                     continue;
                 string owner = factory[..(factory.IndexOf('.') + 1)];         // "document."
                 string rest = q[factory.Length..];
-                candidates.Add((owner + rest, $"'{owner}Create.*' is the Creation factory — matched as '{owner}{rest}'."));
+                candidates.Add((owner + rest, $"'{owner}Create.*' is the Creation factory — matched as '{owner}{rest}'.", false));
                 string bareMember = rest.Split('(')[0];
                 if (bareMember.Length > 0)
-                    candidates.Add((bareMember, $"'{owner}Create.{bareMember}' is a Creation-factory call; its docs live on the factory class (e.g. ItemFactoryBase) — matched by member name '{bareMember}'."));
+                    candidates.Add((bareMember, $"'{owner}Create.{bareMember}' is a Creation-factory call; its docs live on the factory class (e.g. ItemFactoryBase) — matched by member name '{bareMember}'.", false));
             }
 
             // C# spells property and indexer accessors 'get_X'/'set_X' (element.get_Parameter(...),
@@ -166,26 +166,33 @@ namespace RevitBridge.Tools
                 if (accessor.StartsWith("get_", StringComparison.Ordinal) || accessor.StartsWith("set_", StringComparison.Ordinal))
                     accessor = accessor["get_".Length..];
                 if (accessor != q)
-                    candidates.Add((accessor, "'get_X' / 'set_X' is the C# accessor spelling of property or indexer 'X'; matched without the prefix."));
+                    candidates.Add((accessor, "'get_X' / 'set_X' is the C# accessor spelling of property or indexer 'X'; matched without the prefix.", true));
             }
 
-            foreach (var (candidate, note) in candidates)
+            foreach (var (candidate, note, accessorRewrite) in candidates)
             {
-                var (top, total) = RunScoring(index, candidate, kindFilter, maxResults);
+                // A C# accessor IS a method to the caller ('element.get_Parameter(...)'), but
+                // the XML documents the underlying member as a property/indexer — so an
+                // accessor-rewritten candidate lets kind=method admit properties too.
+                bool widenKind = accessorRewrite && kindFilter == 'M';
+                var (top, total) = RunScoring(index, candidate, kindFilter, maxResults, widenKind);
                 if (total > 0)
-                    return (top, total, note);
+                    return (top, total, widenKind
+                        ? note + " The 'method' kind filter also admitted properties here: accessors are documented as properties/indexers."
+                        : note);
             }
             return (new List<ApiMember>(), 0, null);
         }
 
-        private static (List<ApiMember> Top, int Total) RunScoring(DocIndex index, string q, char? kindFilter, int maxResults)
+        private static (List<ApiMember> Top, int Total) RunScoring(DocIndex index, string q, char? kindFilter, int maxResults, bool methodKindAdmitsProperties = false)
         {
             string[] words = q.Split(WordSeparators, StringSplitOptions.RemoveEmptyEntries);
 
             var scored = new List<(ApiMember Member, int Score)>();
             foreach (var member in index.Members)
             {
-                if (kindFilter is { } kind && member.Kind != kind)
+                if (kindFilter is { } kind && member.Kind != kind
+                    && !(methodKindAdmitsProperties && kind == 'M' && member.Kind == 'P'))
                     continue;
                 int score = Score(member, q, words);
                 if (score > 0)

package/src/Revit/Tools/SetParameters.cs

@@ -156,7 +156,7 @@ namespace RevitBridge.Tools
             {
                 if (nameTarget)
                     return SetElementName(element, update);
-                throw new InvalidOperationException($"Parameter '{update.ParameterInput}' not found on element {update.ElementId} ('{element.Name}'). Type parameters live on the element type — pass its id instead.");
+                throw new InvalidOperationException($"Parameter '{update.ParameterInput}' not found on element {update.ElementId} ('{element.Name}'). Display names are localized in non-English Revit UIs — prefer the language-independent BuiltInParameter enum name (e.g. ALL_MODEL_INSTANCE_COMMENTS; get_element_details reports each parameter's builtInParameter). Type parameters live on the element type — pass the type's id instead.");
             }
 
             if (parameter.IsReadOnly)