pi-revit 0.2.13 → 0.2.15

package/CHANGELOG.md

@@ -7,6 +7,44 @@ Format follows [Keep a Changelog](https://keepachangelog.com/); version headers
 Every published version gets an entry with **Added** / **Changed** / **Fixed** sections
 describing what the user will notice — not internal refactors.
 
+## [0.2.15] - 2026-08-21
+
+### Fixed
+- `set_parameters`: the "parameter not found" error now mentions that display names are
+  localized and points to the language-independent BuiltInParameter enum name — the same
+  guidance `get_element_details` and `get_elements` already give. Previously it only
+  suggested the type-parameter cause, which sent the caller down the wrong path in
+  non-English UIs.
+- `get_elements`: the "filter parameter not found on any probed element" warning now
+  appears only when the query returned zero matches — that is where it distinguishes
+  "unknown parameter name" from "no matching elements". Next to real matches it was noise
+  (an unscoped query's probe window can simply miss the elements that carry the parameter).
+
+Requires redeploying the Revit add-in (`scripts\deploy.ps1` with Revit closed, then
+restart Revit).
+
+## [0.2.14] - 2026-08-21
+
+### Fixed
+- `get_elements`: text filter rules now compare case-insensitively on the post-scan path,
+  matching Revit's own collector rules (which ignore case -- verified empirically). The
+  same string rule previously matched case-insensitively when it ran inside the collector
+  but case-sensitively when it fell back to the per-element scan, so merely scoping a
+  query could change its results.
+- `search_api_docs`: queries in C# accessor spelling -- `Element.get_Parameter(BuiltInParameter)`,
+  `get_BoundingBox(View` -- now resolve to the documented property or indexer
+  (`Element.Parameter`, `Element.BoundingBox`), with a note explaining the rewrite. Members
+  documented with a literal `get_`/`set_` prefix still match directly; the rewrite is only
+  a fallback. Three benchmark probes added.
+
+Also investigated and cleared, no change needed: `Element.BoundingBox` and
+`LocationCurve.Curve` document null returns -- not exceptions -- for elements without
+geometry, so the suspected one-bad-element batch failure in `get_element_details` does
+not exist per the API contract.
+
+Requires redeploying the Revit add-in (`scripts\deploy.ps1` with Revit closed, then
+restart Revit).
+
 ## [0.2.13] - 2026-08-21
 
 ### Fixed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-revit",
-  "version": "0.2.13",
+  "version": "0.2.15",
   "description": "Native Pi connector for Autodesk Revit. Run npx.cmd -y pi-revit for the full Windows install.",
   "author": "Ahmad Altahlawi",
   "license": "MIT",

package/scripts/benchmark-search-docs.py

@@ -209,6 +209,10 @@ probe("System-qualified alias", "ParameterFilterElement.Create(Document, System.
 probe("factory rewrite", "Document.Create.NewRoom(Level, UV")
 probe("factory inherited member", "Document.Create.NewFamilyInstance")
 probe("factory honesty control", "Document.Create.Banana", expect_nonzero=False)
+# 0.2.14: C# accessor spelling (get_X/set_X) resolves to the documented property/indexer
+probe("accessor indexer", "Element.get_Parameter(BuiltInParameter")
+probe("accessor property", "Element.get_BoundingBox(View")
+probe("literal get_ member", "LocationCurve.get_ElementsAtJoin")
 print("C done", flush=True)
 R["C complex-syntax"] = C
 

package/src/Revit/Tools/GetElements.cs

@@ -147,7 +147,10 @@ namespace RevitBridge.Tools
             string scope = DescribeScope(categoryInput, classInput, inActiveView);
 
             if (countOnly && postPredicate is null)
-                return CountResult(scope, CreateCollector().GetElementCount(), filterWarnings);
+            {
+                int quickCount = CreateCollector().GetElementCount();
+                return CountResult(scope, quickCount, quickCount > 0 ? Array.Empty<string>() : filterWarnings);
+            }
 
             var rows = countOnly ? null : new List<Dictionary<string, object?>>(Math.Min(limit, 256));
             int total = 0;
@@ -160,6 +163,12 @@ namespace RevitBridge.Tools
                 total++;
             }
 
+            // A found match proves the query worked: the not-found-on-probes warning is
+            // load-bearing only next to a zero, where it distinguishes 'unknown parameter
+            // name' from 'no matching elements'. Beside real matches it is just noise.
+            if (total > 0)
+                filterWarnings = Array.Empty<string>();
+
             if (rows is null)
                 return CountResult(scope, total, filterWarnings);
 
@@ -563,14 +572,18 @@ namespace RevitBridge.Tools
             {
                 case StorageType.String:
                 {
+                    // Case-insensitive to match Revit's own collector: ParameterFilterRuleFactory
+                    // string rules ignore case (verified on Revit 2025 -- a promoted equals rule
+                    // matched 'CaseProbe' for the query 'caseprobe'). The same rule must not turn
+                    // case-sensitive merely because it fell back to the post-scan path.
                     string actual = parameter.AsString() ?? string.Empty;
                     string target = ValueAsString(rule.Value);
                     return rule.Op switch
                     {
-                        RuleOp.Equals => string.Equals(actual, target, StringComparison.Ordinal),
-                        RuleOp.NotEquals => !string.Equals(actual, target, StringComparison.Ordinal),
-                        RuleOp.Contains => actual.Contains(target, StringComparison.Ordinal),
-                        _ => Compare(string.CompareOrdinal(actual, target), rule.Op),
+                        RuleOp.Equals => string.Equals(actual, target, StringComparison.OrdinalIgnoreCase),
+                        RuleOp.NotEquals => !string.Equals(actual, target, StringComparison.OrdinalIgnoreCase),
+                        RuleOp.Contains => actual.Contains(target, StringComparison.OrdinalIgnoreCase),
+                        _ => Compare(string.Compare(actual, target, StringComparison.OrdinalIgnoreCase), rule.Op),
                     };
                 }
                 case StorageType.Double:

package/src/Revit/Tools/SearchApiDocs.cs

@@ -155,6 +155,20 @@ namespace RevitBridge.Tools
                     candidates.Add((bareMember, $"'{owner}Create.{bareMember}' is a Creation-factory call; its docs live on the factory class (e.g. ItemFactoryBase) — matched by member name '{bareMember}'."));
             }
 
+            // C# spells property and indexer accessors 'get_X'/'set_X' (element.get_Parameter(...),
+            // wall.get_BoundingBox(view)), but the XML mostly documents the underlying property
+            // ('Element.Parameter', 'Element.BoundingBox'). Members documented WITH a literal
+            // prefix (LocationCurve.get_ElementsAtJoin) match the untouched query first --
+            // candidates run in order and this rewrite is only reached when the literal
+            // spelling found nothing.
+            {
+                string accessor = q.Replace(".get_", ".", StringComparison.Ordinal).Replace(".set_", ".", StringComparison.Ordinal);
+                if (accessor.StartsWith("get_", StringComparison.Ordinal) || accessor.StartsWith("set_", StringComparison.Ordinal))
+                    accessor = accessor["get_".Length..];
+                if (accessor != q)
+                    candidates.Add((accessor, "'get_X' / 'set_X' is the C# accessor spelling of property or indexer 'X'; matched without the prefix."));
+            }
+
             foreach (var (candidate, note) in candidates)
             {
                 var (top, total) = RunScoring(index, candidate, kindFilter, maxResults);

package/src/Revit/Tools/SetParameters.cs

@@ -156,7 +156,7 @@ namespace RevitBridge.Tools
             {
                 if (nameTarget)
                     return SetElementName(element, update);
-                throw new InvalidOperationException($"Parameter '{update.ParameterInput}' not found on element {update.ElementId} ('{element.Name}'). Type parameters live on the element type — pass its id instead.");
+                throw new InvalidOperationException($"Parameter '{update.ParameterInput}' not found on element {update.ElementId} ('{element.Name}'). Display names are localized in non-English Revit UIs — prefer the language-independent BuiltInParameter enum name (e.g. ALL_MODEL_INSTANCE_COMMENTS; get_element_details reports each parameter's builtInParameter). Type parameters live on the element type — pass the type's id instead.");
             }
 
             if (parameter.IsReadOnly)