pi-review 1.0.0 → 1.1.0

package/README.md

@@ -36,6 +36,12 @@ Add optional focus text:
 /review focus on release safety and backward compatibility
 ```
 
+After the review finishes, return to the reviewed branch and prefill the editor with the review findings:
+
+```text
+/review-back
+```
+
 ## How it works
 
 1. Waits for the current agent turn to finish if needed
@@ -44,6 +50,7 @@ Add optional focus text:
 4. Creates a new branch from the current conversation
 5. Sends a maintainer-style review prompt with optional focus text
 6. Restores your previous thinking level when the review turn ends
+7. `/review-back` returns to the reviewed branch and puts the review findings in the editor
 
 ## Review output
 

package/dist/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,+BAA+B,CAAC;AA8ClE,MAAM,CAAC,OAAO,UAAU,eAAe,CAAC,EAAE,EAAE,YAAY,QA8CvD"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,YAAY,EAAgB,MAAM,+BAA+B,CAAC;AAqFhF,MAAM,CAAC,OAAO,UAAU,eAAe,CAAC,EAAE,EAAE,YAAY,QAmFvD"}

package/dist/index.js

@@ -1,9 +1,12 @@
 import { sendMessageInNewBranch } from "./lib/child-session.js";
-import { extractConversation, formatConversation } from "./lib/conversation-context.js";
+import { extractConversation, extractLatestAssistantText, formatConversation, } from "./lib/conversation-context.js";
 const REVIEW_THINKING_LEVEL = "high";
+const REVIEW_METADATA_TYPE = "pi-review";
 const REVIEW_INSTRUCTION = `Review the available work and context.
 Put your strict maintainer hat on.
 Find concrete, high-confidence, material issues introduced by the work or revealed by the additional context.
+Do not stop after the first few findings; keep reviewing until you have checked the full diff/context, then do one final pass specifically for issues you may have missed.
+Verify completeness against the stated task, requirements, and acceptance criteria; flag missing or partially implemented requirements as findings.
 Focus on correctness, security, performance, operability, and maintainability.
 Do not speculate; point to the affected behavior, invariant, or code path.
 Prefer issues the author would likely fix before merge.
@@ -33,6 +36,30 @@ function buildReviewMessage(args, conversationXml) {
         reviewInstruction,
     ].join("\n");
 }
+function isReviewMetadata(data) {
+    return (!!data &&
+        typeof data === "object" &&
+        "kind" in data &&
+        data.kind === "review" &&
+        "reviewedLeafId" in data &&
+        typeof data.reviewedLeafId === "string");
+}
+function findReviewMetadata(branch) {
+    for (const entry of [...branch].reverse()) {
+        if (entry.type !== "custom" || entry.customType !== REVIEW_METADATA_TYPE)
+            continue;
+        if (isReviewMetadata(entry.data))
+            return entry.data;
+    }
+    return undefined;
+}
+function buildReviewBackEditorText(reviewReport) {
+    return [
+        "<review_findings>",
+        reviewReport.trim(),
+        "</review_findings>",
+    ].join("\n");
+}
 export default function reviewExtension(pi) {
     let originalThinkingLevel;
     function restoreThinkingLevel() {
@@ -51,6 +78,7 @@ export default function reviewExtension(pi) {
                 await ctx.waitForIdle();
             }
             const branch = ctx.sessionManager.getBranch();
+            const reviewedLeafId = ctx.sessionManager.getLeafId();
             const extractedConversation = extractConversation(branch);
             const conversationXml = extractedConversation.length === 0 ? undefined : formatConversation(extractedConversation);
             const reviewMessage = buildReviewMessage(args, conversationXml);
@@ -61,7 +89,11 @@ export default function reviewExtension(pi) {
             }
             let started = false;
             try {
-                started = await sendMessageInNewBranch(pi, ctx, branch, reviewMessage, "review");
+                started = await sendMessageInNewBranch(pi, ctx, branch, reviewMessage, "review", () => {
+                    if (!reviewedLeafId)
+                        return;
+                    pi.appendEntry(REVIEW_METADATA_TYPE, { kind: "review", reviewedLeafId });
+                });
             }
             finally {
                 if (!started)
@@ -74,4 +106,32 @@ export default function reviewExtension(pi) {
             }
         },
     });
+    pi.registerCommand("review-back", {
+        description: "Return to reviewed branch with review findings in the editor",
+        handler: async (_args, ctx) => {
+            if (!ctx.isIdle()) {
+                await ctx.waitForIdle();
+            }
+            if (!ctx.hasUI)
+                return;
+            const branch = ctx.sessionManager.getBranch();
+            const metadata = findReviewMetadata(branch);
+            if (!metadata) {
+                ctx.ui.notify("No review branch metadata found", "warning");
+                return;
+            }
+            const reviewReport = extractLatestAssistantText(branch);
+            if (!reviewReport) {
+                ctx.ui.notify("No assistant review report found", "warning");
+                return;
+            }
+            const result = await ctx.navigateTree(metadata.reviewedLeafId, { summarize: false });
+            if (result.cancelled) {
+                ctx.ui.notify("Return to reviewed branch cancelled", "info");
+                return;
+            }
+            ctx.ui.setEditorText(buildReviewBackEditorText(reviewReport));
+            ctx.ui.notify("Returned to reviewed branch", "info");
+        },
+    });
 }

package/dist/lib/child-session.d.ts

@@ -1,3 +1,3 @@
 import type { ExtensionAPI, ExtensionCommandContext, SessionEntry } from "@mariozechner/pi-coding-agent";
-export declare function sendMessageInNewBranch(pi: ExtensionAPI, ctx: ExtensionCommandContext, branch: SessionEntry[], message: string, purpose: string): Promise<boolean>;
+export declare function sendMessageInNewBranch(pi: ExtensionAPI, ctx: ExtensionCommandContext, branch: SessionEntry[], message: string, purpose: string, beforeSend?: () => void): Promise<boolean>;
 //# sourceMappingURL=child-session.d.ts.map

package/dist/lib/child-session.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"child-session.d.ts","sourceRoot":"","sources":["../../src/lib/child-session.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,YAAY,EACZ,uBAAuB,EACvB,YAAY,EACb,MAAM,+BAA+B,CAAC;AAgBvC,wBAAsB,sBAAsB,CAC1C,EAAE,EAAE,YAAY,EAChB,GAAG,EAAE,uBAAuB,EAC5B,MAAM,EAAE,YAAY,EAAE,EACtB,OAAO,EAAE,MAAM,EACf,OAAO,EAAE,MAAM,GACd,OAAO,CAAC,OAAO,CAAC,CAclB"}
+{"version":3,"file":"child-session.d.ts","sourceRoot":"","sources":["../../src/lib/child-session.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,YAAY,EACZ,uBAAuB,EACvB,YAAY,EACb,MAAM,+BAA+B,CAAC;AAgBvC,wBAAsB,sBAAsB,CAC1C,EAAE,EAAE,YAAY,EAChB,GAAG,EAAE,uBAAuB,EAC5B,MAAM,EAAE,YAAY,EAAE,EACtB,OAAO,EAAE,MAAM,EACf,OAAO,EAAE,MAAM,EACf,UAAU,CAAC,EAAE,MAAM,IAAI,GACtB,OAAO,CAAC,OAAO,CAAC,CAelB"}

package/dist/lib/child-session.js

@@ -9,7 +9,7 @@ function getEmptyBranchTargetId(branch) {
     }
     return undefined;
 }
-export async function sendMessageInNewBranch(pi, ctx, branch, message, purpose) {
+export async function sendMessageInNewBranch(pi, ctx, branch, message, purpose, beforeSend) {
     const targetId = getEmptyBranchTargetId(branch);
     if (targetId) {
         const result = await ctx.navigateTree(targetId, { summarize: false });
@@ -19,6 +19,7 @@ export async function sendMessageInNewBranch(pi, ctx, branch, message, purpose)
             return false;
         }
     }
+    beforeSend?.();
     pi.sendUserMessage(message);
     if (ctx.hasUI)
         ctx.ui.notify(`Started ${purpose} branch`, "info");

package/dist/lib/conversation-context.d.ts

@@ -4,5 +4,6 @@ export type ExtractedMessage = {
     text: string;
 };
 export declare function extractConversation(branch: SessionEntry[]): ExtractedMessage[];
+export declare function extractLatestAssistantText(branch: SessionEntry[]): string;
 export declare function formatConversation(messages: ExtractedMessage[]): string;
 //# sourceMappingURL=conversation-context.d.ts.map

package/dist/lib/conversation-context.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"conversation-context.d.ts","sourceRoot":"","sources":["../../src/lib/conversation-context.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,+BAA+B,CAAC;AAElE,MAAM,MAAM,gBAAgB,GAAG;IAC7B,IAAI,EAAE,MAAM,GAAG,WAAW,CAAC;IAC3B,IAAI,EAAE,MAAM,CAAC;CACd,CAAC;AAkCF,wBAAgB,mBAAmB,CAAC,MAAM,EAAE,YAAY,EAAE,GAAG,gBAAgB,EAAE,CAkB9E;AAED,wBAAgB,kBAAkB,CAAC,QAAQ,EAAE,gBAAgB,EAAE,GAAG,MAAM,CAOvE"}
+{"version":3,"file":"conversation-context.d.ts","sourceRoot":"","sources":["../../src/lib/conversation-context.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,+BAA+B,CAAC;AAElE,MAAM,MAAM,gBAAgB,GAAG;IAC7B,IAAI,EAAE,MAAM,GAAG,WAAW,CAAC;IAC3B,IAAI,EAAE,MAAM,CAAC;CACd,CAAC;AAkCF,wBAAgB,mBAAmB,CAAC,MAAM,EAAE,YAAY,EAAE,GAAG,gBAAgB,EAAE,CAkB9E;AAED,wBAAgB,0BAA0B,CAAC,MAAM,EAAE,YAAY,EAAE,GAAG,MAAM,CASzE;AAED,wBAAgB,kBAAkB,CAAC,QAAQ,EAAE,gBAAgB,EAAE,GAAG,MAAM,CAOvE"}

package/dist/lib/conversation-context.js

@@ -35,6 +35,16 @@ export function extractConversation(branch) {
         return [];
     });
 }
+export function extractLatestAssistantText(branch) {
+    for (const entry of [...branch].reverse()) {
+        if (entry.type !== "message" || entry.message.role !== "assistant")
+            continue;
+        const text = extractText(entry.message.content, false);
+        if (text)
+            return text;
+    }
+    return "";
+}
 export function formatConversation(messages) {
     return messages
         .map((message, index) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-review",
-  "version": "1.0.0",
+  "version": "1.1.0",
   "description": "Review current pi work in a new branch with conversation context",
   "type": "module",
   "keywords": [

package/src/index.ts

@@ -1,15 +1,26 @@
-import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
+import type { ExtensionAPI, SessionEntry } from "@mariozechner/pi-coding-agent";
 
 import { sendMessageInNewBranch } from "./lib/child-session.js";
-import { extractConversation, formatConversation } from "./lib/conversation-context.js";
+import {
+  extractConversation,
+  extractLatestAssistantText,
+  formatConversation,
+} from "./lib/conversation-context.js";
 
 const REVIEW_THINKING_LEVEL = "high";
+const REVIEW_METADATA_TYPE = "pi-review";
 
 type ThinkingLevel = ReturnType<ExtensionAPI["getThinkingLevel"]>;
+type ReviewMetadata = {
+  kind: "review";
+  reviewedLeafId: string;
+};
 
 const REVIEW_INSTRUCTION = `Review the available work and context.
 Put your strict maintainer hat on.
 Find concrete, high-confidence, material issues introduced by the work or revealed by the additional context.
+Do not stop after the first few findings; keep reviewing until you have checked the full diff/context, then do one final pass specifically for issues you may have missed.
+Verify completeness against the stated task, requirements, and acceptance criteria; flag missing or partially implemented requirements as findings.
 Focus on correctness, security, performance, operability, and maintainability.
 Do not speculate; point to the affected behavior, invariant, or code path.
 Prefer issues the author would likely fix before merge.
@@ -44,6 +55,34 @@ function buildReviewMessage(args: string, conversationXml?: string): string {
   ].join("\n");
 }
 
+function isReviewMetadata(data: unknown): data is ReviewMetadata {
+  return (
+    !!data &&
+    typeof data === "object" &&
+    "kind" in data &&
+    data.kind === "review" &&
+    "reviewedLeafId" in data &&
+    typeof data.reviewedLeafId === "string"
+  );
+}
+
+function findReviewMetadata(branch: SessionEntry[]): ReviewMetadata | undefined {
+  for (const entry of [...branch].reverse()) {
+    if (entry.type !== "custom" || entry.customType !== REVIEW_METADATA_TYPE) continue;
+    if (isReviewMetadata(entry.data)) return entry.data;
+  }
+
+  return undefined;
+}
+
+function buildReviewBackEditorText(reviewReport: string): string {
+  return [
+    "<review_findings>",
+    reviewReport.trim(),
+    "</review_findings>",
+  ].join("\n");
+}
+
 export default function reviewExtension(pi: ExtensionAPI) {
   let originalThinkingLevel: ThinkingLevel | undefined;
 
@@ -66,6 +105,7 @@ export default function reviewExtension(pi: ExtensionAPI) {
       }
 
       const branch = ctx.sessionManager.getBranch();
+      const reviewedLeafId = ctx.sessionManager.getLeafId();
       const extractedConversation = extractConversation(branch);
       const conversationXml =
         extractedConversation.length === 0 ? undefined : formatConversation(extractedConversation);
@@ -79,7 +119,10 @@ export default function reviewExtension(pi: ExtensionAPI) {
 
       let started = false;
       try {
-        started = await sendMessageInNewBranch(pi, ctx, branch, reviewMessage, "review");
+        started = await sendMessageInNewBranch(pi, ctx, branch, reviewMessage, "review", () => {
+          if (!reviewedLeafId) return;
+          pi.appendEntry(REVIEW_METADATA_TYPE, { kind: "review", reviewedLeafId });
+        });
       } finally {
         if (!started) restoreThinkingLevel();
       }
@@ -90,4 +133,37 @@ export default function reviewExtension(pi: ExtensionAPI) {
       }
     },
   });
+
+  pi.registerCommand("review-back", {
+    description: "Return to reviewed branch with review findings in the editor",
+    handler: async (_args, ctx) => {
+      if (!ctx.isIdle()) {
+        await ctx.waitForIdle();
+      }
+
+      if (!ctx.hasUI) return;
+
+      const branch = ctx.sessionManager.getBranch();
+      const metadata = findReviewMetadata(branch);
+      if (!metadata) {
+        ctx.ui.notify("No review branch metadata found", "warning");
+        return;
+      }
+
+      const reviewReport = extractLatestAssistantText(branch);
+      if (!reviewReport) {
+        ctx.ui.notify("No assistant review report found", "warning");
+        return;
+      }
+
+      const result = await ctx.navigateTree(metadata.reviewedLeafId, { summarize: false });
+      if (result.cancelled) {
+        ctx.ui.notify("Return to reviewed branch cancelled", "info");
+        return;
+      }
+
+      ctx.ui.setEditorText(buildReviewBackEditorText(reviewReport));
+      ctx.ui.notify("Returned to reviewed branch", "info");
+    },
+  });
 }

package/src/lib/child-session.ts

@@ -24,6 +24,7 @@ export async function sendMessageInNewBranch(
   branch: SessionEntry[],
   message: string,
   purpose: string,
+  beforeSend?: () => void,
 ): Promise<boolean> {
   const targetId = getEmptyBranchTargetId(branch);
   if (targetId) {
@@ -34,6 +35,7 @@ export async function sendMessageInNewBranch(
     }
   }
 
+  beforeSend?.();
   pi.sendUserMessage(message);
 
   if (ctx.hasUI) ctx.ui.notify(`Started ${purpose} branch`, "info");

package/src/lib/conversation-context.ts

@@ -57,6 +57,17 @@ export function extractConversation(branch: SessionEntry[]): ExtractedMessage[]
   });
 }
 
+export function extractLatestAssistantText(branch: SessionEntry[]): string {
+  for (const entry of [...branch].reverse()) {
+    if (entry.type !== "message" || entry.message.role !== "assistant") continue;
+
+    const text = extractText(entry.message.content, false);
+    if (text) return text;
+  }
+
+  return "";
+}
+
 export function formatConversation(messages: ExtractedMessage[]): string {
   return messages
     .map((message, index) => {