pi-review-loop 0.1.1 → 0.2.0

package/README.md

@@ -4,12 +4,10 @@
 
 # Pi Review Loop
 
-Automated code review loop for pi. Repeatedly prompts the agent to review its own work until it confirms no issues remain.
+Automated code review loop for [Pi coding agent](https://buildwithpi.ai/). Repeatedly prompts the agent to review its own work until it confirms no issues remain.
 
 ```
-> implement the plan
-
-[agent implements...]
+> /review-start
 
 Review mode (1/7)  ← status appears in footer
 
@@ -24,13 +22,9 @@ Review mode (2/7)
 Review mode ended: no issues found  ← auto-exits
 ```
 
-## Why
-
-Agents make mistakes. They miss edge cases, introduce typos, forget error handling. Asking them to review their own code catches a surprising number of issues, but you have to remember to ask, and then ask again if they found something.
+Agents make mistakes. They miss edge cases, introduce typos, forget error handling. Asking them to review their own code catches a surprising number of issues, but you have to remember to ask, and then ask again if they found something. This automates that:
 
-Reviewer Loop automates this:
-
-**Auto-Trigger** - Detects phrases like "implement the plan" or the `/double-check` template. No need to manually activate.
+**Auto-Trigger** - Optionally detects phrases like "implement the plan" or the `/double-check` template. Disabled by default; enable with `/review-auto on` or in settings.
 
 **Persistent Loop** - After each response, sends a review prompt. If the agent found and fixed issues, it loops again. Only exits when the agent genuinely finds nothing.
 
@@ -42,9 +36,9 @@ Reviewer Loop automates this:
 
 The loop shines in two scenarios:
 
-**Before implementing** — You've got a plan doc and want to sanity-check it against the actual codebase. Run `/double-check-plan` and let the agent compare the plan to what exists. It'll catch things like outdated assumptions, conflicting patterns, or unnecessary complexity. The funny thing is, it rarely finds everything on the first pass. Second pass catches different issues. Third pass, more still. That's the whole point of the loop.
+**Before implementing** — You've got a plan doc and want to sanity-check it against the actual codebase. Run `/review-start` and let the agent compare the plan to what exists. It'll catch things like outdated assumptions, conflicting patterns, or unnecessary complexity. The funny thing is, it rarely finds everything on the first pass. Second pass catches different issues. Third pass, more still. That's the whole point of the loop.
 
-**After implementing** — You just finished building a feature and want to catch bugs before calling it done. Run `/double-check` and the agent reviews its own work with fresh eyes. Typos, missed edge cases, forgotten error handling — it finds stuff you'd miss staring at the same code. Again, multiple passes tend to surface different issues each time.
+**After implementing** — You just finished building a feature and want to catch bugs before calling it done. Run `/review-start` and the agent reviews its own work with fresh eyes. Typos, missed edge cases, forgotten error handling — it finds stuff you'd miss staring at the same code. Again, multiple passes tend to surface different issues each time.
 
 The pattern is the same: keep reviewing until there's genuinely nothing left to find. The loop handles the "ask again" part automatically. You'll see `Review mode (2/7)` in the footer so you know it's working and how many passes it's done.
 
@@ -80,9 +74,13 @@ The package includes two prompt templates that are automatically installed to `~
 | `double-check-plan.md` | `/double-check-plan` | Review implementation plan against codebase |
 
 These prompts are designed to work with the review loop:
-- They include the "fresh eyes" phrase that auto-triggers the loop
 - They instruct the agent to respond with "No issues found." when done (triggering exit)
 - They tell the agent to end with "Fixed [N] issue(s). Ready for another review." when issues are fixed (continuing the loop)
+- They include the "fresh eyes" phrase that triggers the loop when `autoTrigger` is enabled
+
+**Recommended workflow:** Use `/review-start` to activate review mode, which sends the review prompt automatically. Alternatively, enable auto-trigger (`/review-auto on`) and the `/double-check` template will activate the loop.
+
+You can customize or replace these prompts, change trigger patterns, or use your own entirely. See [Configuration](#configuration). The agent can also start/stop the loop on demand via the `review_loop` tool. See [Tool API](#tool-api).
 
 **Manual installation** (if cloning instead of npm):
 
@@ -92,25 +90,41 @@ cp ~/.pi/agent/extensions/pi-review-loop/prompts/*.md ~/.pi/agent/prompts/
 
 ## Quick Start
 
-### Automatic Activation
+### Manual Activation
 
-Just use trigger phrases naturally:
+```
+/review-start
+```
+
+Activates review mode and immediately sends the review prompt.
+
+### Automatic Activation (Optional)
+
+Auto-trigger is disabled by default. Enable it for the current session:
 
 ```
-> implement the plan
-> implement the spec
-> let's implement this plan
+/review-auto on
 ```
 
-Or use the `/double-check` prompt template.
+Or permanently in `~/.pi/agent/settings.json`:
 
-### Manual Activation
+```json
+{
+  "reviewerLoop": {
+    "autoTrigger": true
+  }
+}
+```
+
+With auto-trigger enabled, trigger phrases activate review mode:
 
 ```
-/review-start
+> implement the plan
+> implement the spec
+> let's implement this plan
 ```
 
-Activates review mode and immediately sends the review prompt.
+Or use the `/double-check` prompt template.
 
 ### Check Status
 
@@ -144,6 +158,7 @@ Configure in `~/.pi/agent/settings.json`. Works out of the box, but everything i
 {
   "reviewerLoop": {
     "maxIterations": 7,
+    "autoTrigger": true,
     "reviewPrompt": "template:double-check",
     "triggerPatterns": {
       "mode": "extend",
@@ -166,8 +181,9 @@ Configure in `~/.pi/agent/settings.json`. Works out of the box, but everything i
 | Option | Description |
 |--------|-------------|
 | `maxIterations` | Max review prompts before auto-exit (default: 7) |
+| `autoTrigger` | Enable keyword-based auto-trigger (default: false) |
 | `reviewPrompt` | The prompt to send each iteration |
-| `triggerPatterns` | What activates review mode |
+| `triggerPatterns` | What activates review mode (requires autoTrigger: true) |
 | `exitPatterns` | What indicates "review complete" |
 | `issuesFixedPatterns` | What indicates issues were fixed (prevents false exits) |
 
@@ -228,7 +244,7 @@ The loop exits when:
 
 1. **Exit phrase without fixes** - Agent says "no issues" and didn't fix anything
 2. **Max iterations** - Safety limit reached (default: 7)
-3. **User interrupts** - You type something that isn't a trigger
+3. **User interrupts** - You type something (only trigger phrases are ignored, and only when auto-trigger is on)
 4. **Manual exit** - `/review-exit` command
 5. **Abort** - Press ESC or agent response is empty
 
@@ -239,11 +255,12 @@ The loop exits when:
 | `/review-start` | Activate and send review prompt immediately |
 | `/review-exit` | Exit review mode |
 | `/review-max <n>` | Set max iterations (session only) |
+| `/review-auto [on\|off]` | Toggle auto-trigger from keywords (session only) |
 | `/review-status` | Show current state |
 
 ## Tool API
 
-The `review_loop` tool lets the agent programmatically control review mode:
+The `review_loop` tool lets the agent control review mode directly:
 
 ```typescript
 // Check status (default)
@@ -260,6 +277,10 @@ review_loop({ stop: true })
 
 // Just update max iterations
 review_loop({ maxIterations: 10 })
+
+// Enable/disable auto-trigger
+review_loop({ autoTrigger: true })
+review_loop({ autoTrigger: false })
 ```
 
 **Returns:**
@@ -268,6 +289,7 @@ review_loop({ maxIterations: 10 })
   "active": true,
   "currentIteration": 2,
   "maxIterations": 7,
+  "autoTrigger": false,
   "message": "Review mode active: iteration 2/7"
 }
 ```
@@ -279,7 +301,7 @@ review_loop({ maxIterations: 10 })
 ```
 input event
     ↓
-matches trigger? → enter review mode
+autoTrigger on + matches trigger? → enter review mode
     ↓
 agent responds
     ↓
@@ -294,14 +316,14 @@ otherwise → exit (max reached)
 
 **Events used:**
 - `session_start` - Reload settings
-- `input` - Detect triggers, handle interrupts
-- `before_agent_start` - Check expanded prompts for triggers
+- `input` - Detect triggers (if autoTrigger enabled), handle interrupts
+- `before_agent_start` - Check expanded prompts for triggers (if autoTrigger enabled)
 - `agent_end` - Analyze response, decide to loop or exit
 
 ## Limitations
 
 - **User templates only** - `template:name` loads from `~/.pi/agent/prompts/`, not project templates
-- **Session-scoped /review-max** - Doesn't persist across sessions
+- **Session-scoped settings** - `/review-max` and `/review-auto` don't persist across sessions (use settings.json for persistence)
 - **Pattern failures are silent** - Invalid regex patterns are skipped without error
 
 ## File Structure
@@ -325,8 +347,6 @@ pi-review-loop/
 
 ## Credits
 
-Inspired by and built on ideas from:
-
-- **[Ralph Wiggum Loop](https://ghuntley.com/ralph/)** by [@GeoffreyHuntley](https://x.com/GeoffreyHuntley) - Loosely based on the "Ralph" loop
+- **[Ralph Wiggum Loop](https://ghuntley.com/ralph/)** by [@GeoffreyHuntley](https://x.com/GeoffreyHuntley)
 - **["Fresh eyes" review prompt](https://x.com/doodlestein/status/1956228999945806049)** by [@doodlestein](https://x.com/doodlestein)
-- **[pi](https://github.com/badlogic/pi-mono/)** by [@badlogicgames](https://x.com/badlogicgames) — The agent framework powering all of this
+- **[pi](https://github.com/badlogic/pi-mono/)** by [@badlogicgames](https://x.com/badlogicgames)

package/index.ts

@@ -39,7 +39,7 @@ export default function (pi: ExtensionAPI) {
   pi.on("input", async (event, ctx) => {
     if (!ctx.hasUI) return { action: "continue" as const };
 
-    const isTrigger = settings.triggerPatterns.some((p) => p.test(event.text));
+    const isTrigger = settings.autoTrigger && settings.triggerPatterns.some((p) => p.test(event.text));
 
     if (reviewModeActive && event.source === "interactive" && !isTrigger) {
       exitReviewMode(ctx, "user interrupted");
@@ -56,6 +56,7 @@ export default function (pi: ExtensionAPI) {
   pi.on("before_agent_start", async (event, ctx) => {
     if (!ctx.hasUI) return;
     if (reviewModeActive) return;
+    if (!settings.autoTrigger) return;
 
     const isTrigger = settings.triggerPatterns.some((p) => p.test(event.prompt));
     if (isTrigger) {
@@ -153,17 +154,38 @@ export default function (pi: ExtensionAPI) {
         );
       } else {
         ctx.ui.notify(
-          `Review mode inactive (max: ${settings.maxIterations})`,
+          `Review mode inactive (max: ${settings.maxIterations}, auto-trigger: ${settings.autoTrigger ? "on" : "off"})`,
           "info"
         );
       }
     },
   });
 
+  pi.registerCommand("review-auto", {
+    description: "Toggle auto-trigger from keywords (off by default)",
+    handler: async (args, ctx) => {
+      const arg = args.trim().toLowerCase();
+      if (arg === "on" || arg === "true" || arg === "1") {
+        settings.autoTrigger = true;
+      } else if (arg === "off" || arg === "false" || arg === "0") {
+        settings.autoTrigger = false;
+      } else if (arg === "") {
+        settings.autoTrigger = !settings.autoTrigger;
+      } else {
+        ctx.ui.notify("Usage: /review-auto [on|off]", "error");
+        return;
+      }
+      ctx.ui.notify(
+        `Auto-trigger ${settings.autoTrigger ? "enabled" : "disabled"}`,
+        "info"
+      );
+    },
+  });
+
   pi.registerTool({
     name: "review_loop",
     description:
-      "Control the automated code review loop. Start/stop review mode or check status. When started, the loop repeatedly prompts for code review until 'No issues found' or max iterations reached.",
+      "Control the automated code review loop. Start/stop review mode, toggle auto-trigger, or check status. When started, the loop repeatedly prompts for code review until 'No issues found' or max iterations reached.",
     parameters: Type.Object({
       start: Type.Optional(
         Type.Boolean({
@@ -175,6 +197,11 @@ export default function (pi: ExtensionAPI) {
           description: "Stop review mode",
         })
       ),
+      autoTrigger: Type.Optional(
+        Type.Boolean({
+          description: "Enable/disable auto-trigger from keywords (disabled by default)",
+        })
+      ),
       maxIterations: Type.Optional(
         Type.Number({
           description: "Set max iterations (can be combined with start)",
@@ -189,6 +216,15 @@ export default function (pi: ExtensionAPI) {
         settings.maxIterations = params.maxIterations;
       }
 
+      // Update autoTrigger if provided
+      if (typeof params.autoTrigger === "boolean") {
+        settings.autoTrigger = params.autoTrigger;
+        ctx.ui.notify(
+          `Auto-trigger ${settings.autoTrigger ? "enabled" : "disabled"}`,
+          "info"
+        );
+      }
+
       // Mode: start > stop > status
       if (params.start) {
         if (reviewModeActive) {
@@ -200,6 +236,7 @@ export default function (pi: ExtensionAPI) {
                   active: true,
                   currentIteration,
                   maxIterations: settings.maxIterations,
+                  autoTrigger: settings.autoTrigger,
                   message: "Review mode is already active",
                 }),
               },
@@ -218,6 +255,7 @@ export default function (pi: ExtensionAPI) {
                 active: true,
                 currentIteration,
                 maxIterations: settings.maxIterations,
+                autoTrigger: settings.autoTrigger,
                 message: "Review mode started. Review prompt sent.",
               }),
             },
@@ -235,6 +273,7 @@ export default function (pi: ExtensionAPI) {
                   active: false,
                   currentIteration: 0,
                   maxIterations: settings.maxIterations,
+                  autoTrigger: settings.autoTrigger,
                   message: "Review mode is not active",
                 }),
               },
@@ -252,6 +291,7 @@ export default function (pi: ExtensionAPI) {
                 active: false,
                 currentIteration: 0,
                 maxIterations: settings.maxIterations,
+                autoTrigger: settings.autoTrigger,
                 message: "Review mode stopped",
               }),
             },
@@ -268,6 +308,7 @@ export default function (pi: ExtensionAPI) {
               active: reviewModeActive,
               currentIteration,
               maxIterations: settings.maxIterations,
+              autoTrigger: settings.autoTrigger,
               message: reviewModeActive
                 ? `Review mode active: iteration ${currentIteration}/${settings.maxIterations}`
                 : "Review mode inactive",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-review-loop",
-  "version": "0.1.1",
+  "version": "0.2.0",
   "description": "Automated code review loop extension for pi coding agent",
   "scripts": {
     "postinstall": "node scripts/install.js",

package/settings.ts

@@ -60,6 +60,7 @@ export interface ReviewPromptConfig {
 export interface ReviewerLoopSettingsRaw {
   maxIterations?: number;
   reviewPrompt?: string;
+  autoTrigger?: boolean;
   triggerPatterns?: PatternConfig;
   exitPatterns?: PatternConfig;
   issuesFixedPatterns?: PatternConfig;
@@ -68,6 +69,7 @@ export interface ReviewerLoopSettingsRaw {
 export interface ReviewerLoopSettings {
   maxIterations: number;
   reviewPromptConfig: ReviewPromptConfig;
+  autoTrigger: boolean;
   triggerPatterns: RegExp[];
   exitPatterns: RegExp[];
   issuesFixedPatterns: RegExp[];
@@ -201,6 +203,7 @@ export function loadSettings(): ReviewerLoopSettings {
         ? raw.maxIterations
         : DEFAULT_MAX_ITERATIONS,
     reviewPromptConfig: parseReviewPromptConfig(raw.reviewPrompt),
+    autoTrigger: raw.autoTrigger === true,
     triggerPatterns: loadPatterns(raw.triggerPatterns, DEFAULT_TRIGGER_PATTERNS),
     exitPatterns: loadPatterns(raw.exitPatterns, DEFAULT_EXIT_PATTERNS),
     issuesFixedPatterns: loadPatterns(