pi-readseek 0.4.29 → 0.5.0

package/src/syntax-validate-mode.ts

@@ -1,25 +1,15 @@
+import { resolveReadSeekSyntaxValidation } from "./readseek-settings.js";
+
 export type SyntaxValidateMode = "warn" | "block" | "off";
 
 export interface SyntaxValidateOptions {
   syntaxValidate?: SyntaxValidateMode;
 }
 
-const VALID = new Set<SyntaxValidateMode>(["warn", "block", "off"]);
 const DEFAULT: SyntaxValidateMode = "warn";
 
-function coerce(value: unknown): SyntaxValidateMode | undefined {
-  if (typeof value !== "string") return undefined;
-  return VALID.has(value as SyntaxValidateMode)
-    ? (value as SyntaxValidateMode)
-    : undefined;
-}
-
 export function resolveSyntaxValidateMode(
   opts: SyntaxValidateOptions,
 ): SyntaxValidateMode {
-  const fromOpt = coerce(opts.syntaxValidate);
-  if (fromOpt) return fromOpt;
-  const fromEnv = coerce(process.env.READSEEK_SYNTAX_VALIDATE);
-  if (fromEnv) return fromEnv;
-  return DEFAULT;
+  return opts.syntaxValidate ?? resolveReadSeekSyntaxValidation() ?? DEFAULT;
 }

package/src/tool-prompt-metadata.ts

@@ -4,7 +4,7 @@ import { DEFAULT_MAX_BYTES, DEFAULT_MAX_LINES, formatSize } from "@earendil-work
 
 const COMPACT_DESCRIPTIONS: Record<string, string> = {
   "read.md": "Read text files/images by path; text has LINE:HASH anchors, images return the attachment plus OCR-extracted text.",
-  "edit.md": "Edit existing text files using fresh LINE:HASH anchors from read, grep, search, or write.",
+  "edit.md": "Edit existing text files using fresh LINE:HASH anchors from readSeek_read, readSeek_grep, readSeek_search, or readSeek_write.",
   "grep.md": "Search file contents; non-summary results include LINE:HASH anchors for edits.",
 
   "write.md": "Create or overwrite a complete file and return anchors.",
@@ -14,30 +14,30 @@ const COMPACT_DESCRIPTIONS: Record<string, string> = {
 
 const COMPACT_GUIDELINES: Record<string, string[]> = {
   "read.md": [
-    "Use read for file contents, images/screenshots, ranges, symbols, and edit anchors.",
+    "Use readSeek_read for file contents, images/screenshots, ranges, symbols, and edit anchors.",
     "Use map or symbol mode before pulling large code files into context.",
-    "Use read for images; it returns the image attachment plus OCR-extracted text, so you don't need separate OCR tools.",
+    "Use readSeek_read for images; it returns the image attachment plus OCR-extracted text, so you don't need separate OCR tools.",
   ],
   "edit.md": [
-    "Use edit with fresh LINE:HASH anchors for existing files.",
+    "Use readSeek_edit with fresh LINE:HASH anchors for existing files.",
     "Prefer set_line, replace_lines, and insert_after; use replace only when anchors are impractical.",
   ],
   "grep.md": [
-    "Use grep for text search and edit-ready matching anchors.",
-    "Use grep summary mode for broad count/file discovery before narrowing.",
+    "Use readSeek_grep for text search and edit-ready matching anchors.",
+    "Use readSeek_grep summary mode for broad count/file discovery before narrowing.",
   ],
 
   "write.md": [
-    "Use write to create files or intentionally overwrite whole files.",
-    "Use edit rather than write for small changes or appends to existing files.",
+    "Use readSeek_write to create files or intentionally overwrite whole files.",
+    "Use readSeek_edit rather than readSeek_write for small changes or appends to existing files.",
   ],
   "sg.md": [
-    "Use search for AST-shaped code patterns.",
-    "Use grep instead of search for plain text.",
+    "Use readSeek_search for AST-shaped code patterns.",
+    "Use readSeek_grep instead of readSeek_search for plain text.",
   ],
   "refs.md": [
-    "Use refs to find every usage of an identifier before renaming or deleting it.",
-    "Use refs with scope plus line/column to follow a specific binding instead of every same-named identifier.",
+    "Use readSeek_refs to find every usage of an identifier before renaming or deleting it.",
+    "Use readSeek_refs with scope plus line/column to follow a specific binding instead of every same-named identifier.",
   ],
 };
 

package/src/tui-render-utils.ts

@@ -238,10 +238,10 @@ export function renderAnchoredFilesResult(
   const textContent = content?.type === "text" ? content.text : "";
   if (isError || result.isError) return renderErrorResult(textContent, { expanded, width });
 
-  const readseekValue = (result.details as any)?.readseekValue as
+  const readSeekValue = (result.details as any)?.readSeekValue as
     | { files: Array<{ path: string; lines: any[] }> }
     | undefined;
-  const files = readseekValue?.files ?? [];
+  const files = readSeekValue?.files ?? [];
   if (files.length === 0) return new Text(summaryLine(labels.emptyLabel), 0, 0);
 
   const fileCount = files.length;

package/src/write.ts

@@ -1,13 +1,13 @@
 import { access, mkdir, readFile, writeFile } from "node:fs/promises";
 import { dirname, relative } from "node:path";
 
-import { withFileMutationQueue, type ExtensionAPI, type ToolRenderResultOptions } from "@earendil-works/pi-coding-agent";
+import { withFileMutationQueue, truncateHead, type ExtensionAPI, type ToolRenderResultOptions } from "@earendil-works/pi-coding-agent";
 import { Text } from "@earendil-works/pi-tui";
 import { Type } from "@sinclair/typebox";
 
 import { resolveToCwd } from "./path-utils.js";
 import { ensureHashInit, formatHashlineDisplay } from "./hashline.js";
-import { buildReadSeekError, buildReadSeekLine, buildReadSeekWarning, buildToolErrorResult, type ReadSeekLine, type ReadSeekWarning } from "./readseek-value.js";
+import { buildReadSeekLine, buildReadSeekWarning, buildToolErrorResult, type ReadSeekLine, type ReadSeekWarning, type ToolErrorResult } from "./readseek-value.js";
 import { looksLikeBinary } from "./binary-detect.js";
 import { formatFsError } from "./fs-error.js";
 import { getOrGenerateMap } from "./file-map.js";
@@ -66,8 +66,6 @@ function pendingWritePreviewParts(summary: string, preview: PendingDiffPreviewRe
   return { lines: [summary, headerLine], diffData: expanded ? diffData : undefined };
 }
 
-const MAX_LINES = 2000;
-const MAX_BYTES = 50 * 1024;
 const WRITE_PROMPT_METADATA = defineToolPromptMetadata({
   promptUrl: new URL("../prompts/write.md", import.meta.url),
   promptSnippet: "Create or overwrite a complete file and return edit anchors",
@@ -82,7 +80,7 @@ export interface WriteResult extends WriteDiffFields {
   text: string;
   warnings: string[];
   writeState?: "created" | "overwritten";
-  readseekValue: {
+  readSeekValue: {
     tool: "write";
     path: string;
     lines: ReadSeekLine[];
@@ -93,6 +91,13 @@ export interface WriteResult extends WriteDiffFields {
   };
 }
 
+
+type ExecuteWriteResult = WriteResult | ToolErrorResult;
+
+function isToolErrorResult(result: ExecuteWriteResult): result is ToolErrorResult {
+  return "isError" in result;
+}
+
 async function readPreviousTextForDiff(filePath: string): Promise<string> {
   try {
     const previous = await readFile(filePath);
@@ -133,41 +138,30 @@ export async function executeWrite(opts: {
   content: string;
   map?: boolean;
   cwd?: string;
-}): Promise<WriteResult> {
+}): Promise<ExecuteWriteResult> {
   await ensureHashInit();
 
   const { path: filePath, content, map: requestMap, cwd } = opts;
   const warnings: string[] = [];
-  const readseekWarnings: ReadSeekWarning[] = [];
+  const readSeekWarnings: ReadSeekWarning[] = [];
 
   if (hasBareCarriageReturn(content)) {
-    const message = "File content contains bare CR (\\r) line endings; write refuses to emit anchors that read/edit would normalize differently.";
+    const message = "File content contains bare CR (\\r) line endings; readSeek_write refuses to emit anchors that readSeek_read/readSeek_edit would normalize differently.";
     warnings.push(message);
-    readseekWarnings.push(buildReadSeekWarning("bare-cr", message));
-    return {
-      text: `Cannot write ${filePath}\n⚠️ ${message}`,
-      warnings,
-      readseekValue: {
-        tool: "write",
-        path: filePath,
-        lines: [],
-        warnings: readseekWarnings,
-      },
-    };
+    readSeekWarnings.push(buildReadSeekWarning("bare-cr", message));
+    return buildToolErrorResult("write", "bare-cr", `Cannot write ${filePath}\n⚠️ ${message}`, {
+      path: filePath,
+      extra: { lines: [], warnings: readSeekWarnings },
+    });
   }
   if (looksLikeBinary(Buffer.from(content, "utf-8"))) {
-    warnings.push("File content appears to be binary.");
-    readseekWarnings.push(buildReadSeekWarning("binary-content", "File content appears to be binary."));
-    return {
-      text: `Cannot write ${filePath}\n⚠️ File content appears to be binary — refusing to write.`,
-      warnings,
-      readseekValue: {
-        tool: "write",
-        path: filePath,
-        lines: [],
-        warnings: readseekWarnings,
-      },
-    };
+    const message = "File content appears to be binary.";
+    warnings.push(message);
+    readSeekWarnings.push(buildReadSeekWarning("binary-content", message));
+    return buildToolErrorResult("write", "binary-content", `Cannot write ${filePath}\n⚠️ ${message} — refusing to write.`, {
+      path: filePath,
+      extra: { lines: [], warnings: readSeekWarnings },
+    });
   }
 
   const previousContent = await readPreviousTextForDiff(filePath);
@@ -179,25 +173,25 @@ export async function executeWrite(opts: {
 	await writeFile(filePath, content, "utf-8");
   // Compute hashlines
   const rawLines = content.split("\n");
-  const readseekLines: ReadSeekLine[] = [];
+  const readSeekLines: ReadSeekLine[] = [];
   const displayLines: string[] = [];
 
   for (let i = 0; i < rawLines.length; i++) {
     const lineNum = i + 1;
-    const readseekLine = buildReadSeekLine(lineNum, rawLines[i]);
-    readseekLines.push(readseekLine);
+    const readSeekLine = buildReadSeekLine(lineNum, rawLines[i]);
+    readSeekLines.push(readSeekLine);
     displayLines.push(formatHashlineDisplay(lineNum, rawLines[i]));
   }
 
-  let text = displayLines.join("\n");
-  if (rawLines.length > MAX_LINES) {
-    text = displayLines.slice(0, MAX_LINES).join("\n");
-    text += `\n[… ${rawLines.length - MAX_LINES} more lines not shown — full anchors in readseekValue]`;
-  }
-  const bytes = Buffer.byteLength(text, "utf8");
-  if (bytes > MAX_BYTES) {
-    text = Buffer.from(text, "utf8").subarray(0, MAX_BYTES).toString("utf8");
-    text += "\n[… output truncated at 50 KB — full anchors in readseekValue]";
+  const fullText = displayLines.join("\n");
+  const truncated = truncateHead(fullText);
+  let text = truncated.content;
+  if (truncated.truncated) {
+    if (truncated.truncatedBy === "lines") {
+      text += `\n[… ${truncated.totalLines - truncated.outputLines} more lines not shown — full anchors in readSeekValue]`;
+    } else {
+      text += "\n[… output truncated at 50 KB — full anchors in readSeekValue]";
+    }
   }
 
   // Optional structural map
@@ -234,11 +228,11 @@ export async function executeWrite(opts: {
     writeState: existedBeforeWrite ? "overwritten" : "created",
     diff: diffResult.diff,
     diffData,
-    readseekValue: {
+    readSeekValue: {
       tool: "write",
       path: displayPath,
-      lines: readseekLines,
-      warnings: readseekWarnings,
+      lines: readSeekLines,
+      warnings: readSeekWarnings,
       diff: diffResult.diff,
       diffData,
       ...(requestMap ? { map: { appended: mapAppended } } : {}),
@@ -248,11 +242,7 @@ export async function executeWrite(opts: {
 
 export function registerWriteTool(pi: ExtensionAPI, options: WriteToolOptions = {}) {
   const tool = registerReadSeekTool(pi, {
-    policy: "mutating",
-    pythonName: "write",
-    defaultExposure: "not-safe-by-default",
-  }, {
-    name: "write",
+    name: "readSeek_write",
     label: "write",
     description: WRITE_PROMPT_METADATA.description,
     promptSnippet: WRITE_PROMPT_METADATA.promptSnippet,
@@ -267,7 +257,7 @@ export function registerWriteTool(pi: ExtensionAPI, options: WriteToolOptions =
       const absolutePath = resolveToCwd(params.path, cwd);
       try {
         return await withFileMutationQueue(absolutePath, async () => {
-          let result: WriteResult;
+          let result: ExecuteWriteResult;
           try {
             result = await executeWrite({
               path: absolutePath,
@@ -279,30 +269,10 @@ export function registerWriteTool(pi: ExtensionAPI, options: WriteToolOptions =
             return buildWriteFsErrorResult(err, absolutePath);
           }
 
-          if (result.readseekValue.lines.length > 0) {
-            options.onFileAnchored?.(absolutePath);
-          }
+          if (isToolErrorResult(result)) return result;
 
-          // Lift binary-content signal into a fatal readseekValue.error envelope so
-          // downstream consumers get the same taxonomy shape as every other tool.
-          // The existing ReadSeekWarning entry is preserved on readseekValue.warnings for
-          // backward compatibility.
-          for (const code of ["binary-content", "bare-cr"] as const) {
-            const warning = result.readseekValue.warnings.find((w) => w.code === code);
-            if (warning) {
-              return {
-                content: [{ type: "text" as const, text: result.text }],
-                isError: true,
-                details: {
-                  readseekValue: {
-                    ...result.readseekValue,
-                    ok: false,
-                    error: buildReadSeekError(code, warning.message),
-                  },
-                  warnings: result.warnings,
-                },
-              };
-            }
+          if (result.readSeekValue.lines.length > 0) {
+            options.onFileAnchored?.(absolutePath);
           }
 
           return {
@@ -311,7 +281,7 @@ export function registerWriteTool(pi: ExtensionAPI, options: WriteToolOptions =
               ...(result.diff !== undefined ? { diff: result.diff } : {}),
               ...(result.diffData !== undefined ? { diffData: result.diffData } : {}),
               ...(result.writeState ? { writeState: result.writeState } : {}),
-              readseekValue: result.readseekValue,
+              readSeekValue: result.readSeekValue,
               warnings: result.warnings,
             },
           };
@@ -352,7 +322,7 @@ export function registerWriteTool(pi: ExtensionAPI, options: WriteToolOptions =
       if (isPartial) return renderPendingResult("pending write", width);
       const details = result.details ?? {};
       const output = result.content?.[0]?.type === "text" ? result.content[0].text : "";
-      if (result.isError || details.readseekValue?.ok === false) {
+      if (result.isError || details.readSeekValue?.ok === false) {
         return renderErrorResult(output, { expanded, width, fallback: "write failed" });
       }
       const diffData = details.diffData;
@@ -361,12 +331,12 @@ export function registerWriteTool(pi: ExtensionAPI, options: WriteToolOptions =
       // instead of a diff body — every line is an add, so the gutter, line
       // numbers, and red/green tinting are noise.
       if (state === "created") {
-        const readseekLines = (details.readseekValue?.lines ?? []) as Array<{ raw: string }>;
-        const hasContent = readseekLines.length > 0;
+        const readSeekLines = (details.readSeekValue?.lines ?? []) as Array<{ raw: string }>;
+        const hasContent = readSeekLines.length > 0;
         const header = summaryLine(state, { hidden: hasContent && !expanded });
         const lines = header.split("\n");
         if (expanded && hasContent) {
-          const content = readseekLines.map((l) => l.raw).join("\n");
+          const content = readSeekLines.map((l) => l.raw).join("\n");
           lines.push(...formatContentPreviewLines(content, theme));
         }
         return new Text(clampLinesToWidth(lines, width).join("\n"), 0, 0);