pi-readseek 0.3.24 → 0.4.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-readseek",
-  "version": "0.3.24",
+  "version": "0.4.1",
   "description": "Pi extension for readseek-backed hash-anchored read/edit/grep, structural code maps, structural search, and file exploration",
   "type": "module",
   "exports": {
@@ -39,7 +39,7 @@
     "node": ">=20.0.0"
   },
   "dependencies": {
-    "@jarkkojs/readseek": "^0.3.20",
+    "@jarkkojs/readseek": "^0.4.4",
     "diff": "^8.0.3",
     "ignore": "^7.0.5",
     "picomatch": "^4.0.4",

package/src/edit.ts

@@ -36,14 +36,6 @@ function pendingPreviewLines(summary: string, preview: PendingDiffPreviewResult
 	return { lines: [summary, headerLine], diffData: expanded ? diffData : undefined, headerLabel: preview.data.headerLabel };
 }
 
-export function wrapWriteError(err: any, path: string): Error {
-	const code = err?.code;
-	if (code === "EACCES" || code === "EPERM") {
-		return new Error(`Permission denied: ${path}`);
-	}
-	return new Error(`Failed to write file: ${path}`);
-}
-
 
 const hashlineEditItemSchema = Type.Union([
 	Type.Object({ set_line: Type.Object({ anchor: Type.String(), new_text: Type.String() }) }, { additionalProperties: true }),
@@ -269,16 +261,16 @@ export async function executeEdit(opts: ExecuteEditOptions): Promise<any> {
 		}
 	}
 	let preAnchorContent = originalNormalized;
-	// AC 26: reject anchored edits that target a line inside any replace_symbol
+	// reject anchored edits that target a line inside any replace_symbol
 	// pre-replace range. Resolve each target against the ORIGINAL content so the
 	// user-provided anchor line numbers (which reference the file as read) are
 	// compared against the pre-replace coordinates.
 	//
-	// F2: surface replace_symbol symbol-resolution errors (not-found, ambiguous)
-	// BEFORE the AC 26 overlap check and before any write (C1 preserved).
+	// surface replace_symbol symbol-resolution errors (not-found, ambiguous)
+	// before the overlap check and before any write.
 	// Error-precedence order: replace_symbol resolution > anchor-overlap > anchored-edit.
 	//
-	// AC 4: store successful probe results and reuse them in the apply loop so
+	// store successful probe results and reuse them in the apply loop so
 	// readseekMapContent is invoked at most once per replace_symbol edit.
 	const replaceSymbolRanges: { start: number; end: number }[] = [];
 	const rsProbeResults: { type: "ok"; content: string; replacement: string; warnings: string[]; range: { start: number; end: number } }[] = [];
@@ -290,7 +282,7 @@ export async function executeEdit(opts: ExecuteEditOptions): Promise<any> {
 			newBody: rs.replace_symbol.new_body,
 		});
 		if (probe.type !== "ok") {
-			// F2: symbol-resolution errors surface before AC 26 overlap check.
+			// symbol-resolution errors surface before the overlap check.
 			return buildEditError(absolutePath, "invalid-edit-variant", probe.message);
 		}
 		rsProbeResults.push(probe);
@@ -349,7 +341,7 @@ export async function executeEdit(opts: ExecuteEditOptions): Promise<any> {
 			}
 		}
 	}
-	// Apply pass: reuse all probe results (AC 4). The probe pass resolved every
+	// Apply pass: reuse all probe results. The probe pass resolved every
 	// replace_symbol against originalNormalized; apply those replacements in
 	// reverse source order so original line ranges stay valid and no second
 	// replaceSymbol/readseekMapContent call is needed.
@@ -445,7 +437,7 @@ export async function executeEdit(opts: ExecuteEditOptions): Promise<any> {
 		if (regression) {
 			const lines = regression.errorLines.join(", ");
 			const message = `syntax-regression: lines ${lines}`;
-			// Task 7 (AC 12): block mode aborts with syntax-regression code; file is left untouched.
+			// block mode aborts with syntax-regression code; file is left untouched.
 			if (syntaxMode === "block") {
 				return buildEditError(absolutePath, "syntax-regression", message);
 			}

package/src/readseek/formatter.ts

@@ -233,22 +233,6 @@ export function formatFileMap(map: FileMap, level?: DetailLevel): string {
   return lines.join("\n");
 }
 
-/**
- * Get the appropriate detail level for a map based on size.
- */
-export function getDetailLevelForSize(currentSize: number): DetailLevel {
-  if (currentSize <= THRESHOLDS.FULL_TARGET_BYTES) {
-    return DetailLevel.Full;
-  }
-  if (currentSize <= THRESHOLDS.COMPACT_TARGET_BYTES) {
-    return DetailLevel.Compact;
-  }
-  if (currentSize <= THRESHOLDS.MAX_MAP_BYTES) {
-    return DetailLevel.Minimal;
-  }
-  return DetailLevel.Outline;
-}
-
 /**
  * Reduce detail level of a file map.
  */

package/src/readseek/symbol-lookup.ts

@@ -136,7 +136,7 @@ export function findSymbol(map: FileMap, query: string): SymbolLookupResult {
     } else {
       pool = allSymbols.filter((c) => c.symbol.name === namePart);
     }
-    // AC 16 + AC 17: drop candidates without usable startLine. If that empties
+    // drop candidates without usable startLine. If that empties
     // the pool entirely, surface any same-leaf-name decls elsewhere in the file
     // so the user can see real candidate lines.
     pool = pool.filter((c) => Number.isFinite(c.symbol.startLine) && c.symbol.startLine > 0);

package/src/readseek-client.ts

@@ -375,15 +375,7 @@ function parseReadOutput(value: unknown): ReadseekReadOutput {
 		file_hash: requireString(output.file_hash, "file_hash"),
 		start_line: requireNumber(output.start_line, "start_line"),
 		end_line: requireNumber(output.end_line, "end_line"),
-		hashlines: hashlines.map((line) => {
-			if (!line || typeof line !== "object") throw new Error("invalid readseek hashline");
-			const item = line as Record<string, unknown>;
-			return {
-				line: requireNumber(item.line, "hashline.line"),
-				hash: requireString(item.hash, "hashline.hash"),
-				text: requireString(item.text, "hashline.text"),
-			};
-		}),
+		hashlines: hashlines.map((line) => parseHashline(line, "hashline")),
 	};
 }
 
@@ -413,17 +405,19 @@ function parseMapOutput(value: unknown): ReadseekMapOutput {
 	};
 }
 
+function parseHashline(value: unknown, field: string): ReadseekHashline {
+	if (!value || typeof value !== "object") throw new Error(`invalid readseek ${field}`);
+	const item = value as Record<string, unknown>;
+	return {
+		line: requireNumber(item.line, `${field}.line`),
+		hash: requireString(item.hash, `${field}.hash`),
+		text: requireString(item.text, `${field}.text`),
+	};
+}
+
 function parseSearchHashlines(value: unknown, field: string): ReadseekHashline[] {
 	if (!Array.isArray(value)) throw new Error(`invalid readseek ${field}`);
-	return value.map((line) => {
-		if (!line || typeof line !== "object") throw new Error(`invalid readseek ${field}`);
-		const item = line as Record<string, unknown>;
-		return {
-			line: requireNumber(item.line, `${field}.line`),
-			hash: requireString(item.hash, `${field}.hash`),
-			text: requireString(item.text, `${field}.text`),
-		};
-	});
+	return value.map((line) => parseHashline(line, field));
 }
 
 function parseSearchOutput(value: unknown): ReadseekSearchOutput {
@@ -444,7 +438,7 @@ function parseSearchOutput(value: unknown): ReadseekSearchOutput {
 					const item = match as Record<string, unknown>;
 					if (!Array.isArray(item.captures)) throw new Error("invalid readseek search captures");
 					return {
-						pattern_index: requireNumber(item.pattern_index, "search.match.pattern_index"),
+						pattern_index: item.pattern_index === undefined ? 0 : requireNumber(item.pattern_index, "search.match.pattern_index"),
 						start_line: requireNumber(item.start_line, "search.match.start_line"),
 						end_line: requireNumber(item.end_line, "search.match.end_line"),
 						start_hash: requireString(item.start_hash, "search.match.start_hash"),
@@ -471,7 +465,7 @@ function parseSearchOutput(value: unknown): ReadseekSearchOutput {
 
 export async function readseekRead(filePath: string, startLine?: number, endLine?: number): Promise<ReadseekReadOutput> {
 	const args = ["read", filePath];
-	if (startLine !== undefined) args.push("--offset", String(startLine));
+	if (startLine !== undefined) args.push("--start", String(startLine));
 	if (endLine !== undefined) args.push("--end", String(endLine));
 	return parseReadOutput(await runReadseek(args));
 }

package/src/refs.ts

@@ -69,6 +69,14 @@ function groupReferences(references: ReadseekReference[], cwd: string): RefsOutp
   return [...files.values()];
 }
 
+function isReadseekCursorValidationFailure(message: string): boolean {
+  return (
+    /line and column must be greater than zero/i.test(message) ||
+    /line \d+ not found/i.test(message) ||
+    /column \d+ exceeds maximum column \d+ for line \d+/i.test(message)
+  );
+}
+
 /**
  * Executes identifier reference lookup and returns readseek-anchored matches.
  */
@@ -125,6 +133,9 @@ export async function executeRefs(opts: ExecuteRefsOptions): Promise<any> {
     };
   } catch (err: any) {
     const failure = classifyReadseekFailure(err);
+    if (p.scope && isReadseekCursorValidationFailure(failure.message)) {
+      return buildToolErrorResult("refs", "invalid-parameter", failure.message);
+    }
     return buildToolErrorResult("refs", failure.code, failure.message, failure.hint ? { hint: failure.hint } : {});
   }
 }

package/src/tui-render-utils.ts

@@ -80,15 +80,6 @@ export function clampLinesToWidth(lines: string[], width: number | undefined): s
   return lines.map((line) => clampLineToWidth(line, width));
 }
 
-export function wrapLinesToWidth(lines: string[], width: number | undefined): string[] {
-  if (width === undefined || width === null) return lines;
-  const normalized = normalizeWidth(width);
-  return lines.flatMap((line) => {
-    if (visibleWidth(line) <= normalized) return [line];
-    return wrapTextWithAnsi(line, normalized).map((wrapped) => clampLineToWidth(wrapped, normalized));
-  });
-}
-
 export interface WrapWithHangingIndentOptions {
   /** Optional transform applied to each produced line (e.g. theme tinting). */
   tint?: (text: string) => string;

package/src/write.ts

@@ -365,37 +365,23 @@ export function registerWriteTool(pi: ExtensionAPI, options: WriteToolOptions =
           // Lift binary-content signal into a fatal readseekValue.error envelope so
           // downstream consumers get the same taxonomy shape as every other tool.
           // The existing ReadseekWarning entry is preserved on readseekValue.warnings for
-          // backward compatibility (see AC 12 — warnings namespace alignment).
-          const binaryWarning = result.readseekValue.warnings.find((w) => w.code === "binary-content");
-          if (binaryWarning) {
-            return {
-              content: [{ type: "text" as const, text: result.text }],
-              isError: true,
-              details: {
-                readseekValue: {
-                  ...result.readseekValue,
-                  ok: false,
-                  error: buildReadseekError("binary-content", binaryWarning.message),
+          // backward compatibility.
+          for (const code of ["binary-content", "bare-cr"] as const) {
+            const warning = result.readseekValue.warnings.find((w) => w.code === code);
+            if (warning) {
+              return {
+                content: [{ type: "text" as const, text: result.text }],
+                isError: true,
+                details: {
+                  readseekValue: {
+                    ...result.readseekValue,
+                    ok: false,
+                    error: buildReadseekError(code, warning.message),
+                  },
+                  warnings: result.warnings,
                 },
-                warnings: result.warnings,
-              },
-            };
-          }
-
-          const bareCrWarning = result.readseekValue.warnings.find((w) => w.code === "bare-cr");
-          if (bareCrWarning) {
-            return {
-              content: [{ type: "text" as const, text: result.text }],
-              isError: true,
-              details: {
-                readseekValue: {
-                  ...result.readseekValue,
-                  ok: false,
-                  error: buildReadseekError("bare-cr", bareCrWarning.message),
-                },
-                warnings: result.warnings,
-              },
-            };
+              };
+            }
           }
 
           return {