pi-quests 0.8.0 → 0.9.0

package/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## [Unreleased]
 
+## [0.9.0] - 2026-09-17
+
+- feat: quest tool results follow pi's compact view — collapsed rows show a 10-line preview with a `ctrl+o` (`app.tools.expand`) hint, expanded rows show everything
+- fix: RangeError crash when position labels exceed the reserved column width in `formatQuestRow`
+- fix: wrap batch add and split in a `runTransaction` guard to roll back partial state on ID exhaustion
+
 ## [0.8.0] - 2026-05-26
 
 - feat: migrate to `@earendil-works`

package/README.md

@@ -1,6 +1,6 @@
 # pi-quests
 
-[![version 0.8.0](https://img.shields.io/badge/version-0.8.0-blue)](CHANGELOG.md)
+[![version 0.9.0](https://img.shields.io/badge/version-0.9.0-blue)](CHANGELOG.md)
 [![MIT license](https://img.shields.io/badge/license-MIT-green)](LICENSE.md)
 [![pi extension](https://img.shields.io/badge/pi-extension-purple)](https://github.com/badlogic/pi-mono/tree/main/packages/coding-agent)
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-quests",
-  "version": "0.8.0",
+  "version": "0.9.0",
   "description": "A quest-log for your pi. Keep your agent on track, one quest at a time.",
   "type": "module",
   "keywords": [

package/src/quest/dataplane.ts

@@ -146,6 +146,30 @@ export class QuestLog {
     this.usedIds.add(id);
     return id;
   }
+
+  /*
+   * Runs `fn` and, if it throws, restores all mutable state to the snapshot
+   * taken beforehand. Makes multi-step mutations (batch add, split) atomic so a
+   * partial failure (e.g. ID exhaustion mid-loop) cannot leave orphaned quests,
+   * steps, history, or used IDs behind.
+   */
+  private runTransaction<T>(fn: () => T): T {
+    const quests = [...this.quests];
+    const steps = [...this.steps];
+    const history = [...this.history];
+    const usedIds = new Set(this.usedIds);
+    const redoStack = [...this.redoStack];
+    try {
+      return fn();
+    } catch (err) {
+      this.quests = quests;
+      this.steps = steps;
+      this.history = history;
+      this.usedIds = usedIds;
+      this.redoStack = redoStack;
+      throw err;
+    }
+  }
   private undoHandlers: {
     [K in HistoryEntry["type"]]: (entry: Extract<HistoryEntry, { type: K }>) => {
       success: boolean;
@@ -533,11 +557,14 @@ export class QuestLog {
     const parent = this.quests.find((q) => q.id === id);
     if (!parent) throw new Error(formatNotFound(id));
     if (parent.done) throw new Error(formatParentDoneError(id));
-    const created: Step[] = [];
-    for (const desc of descriptions) {
-      created.push(this.addStep(desc, id));
-    }
-    return created;
+
+    return this.runTransaction(() => {
+      const created: Step[] = [];
+      for (const desc of descriptions) {
+        created.push(this.addStep(desc, id));
+      }
+      return created;
+    });
   }
 
   toggle(id: string): Quest | Step | null | undefined {
@@ -878,12 +905,16 @@ export class QuestLog {
               };
             }
           }
+          const descriptions = action.descriptions;
           try {
-            const added: { id: string; description: string }[] = [];
-            for (const desc of action.descriptions) {
-              const q = this.add(desc);
-              added.push({ id: q.id, description: q.description });
-            }
+            const added = this.runTransaction(() => {
+              const result: { id: string; description: string }[] = [];
+              for (const desc of descriptions) {
+                const q = this.add(desc);
+                result.push({ id: q.id, description: q.description });
+              }
+              return result;
+            });
 
             return { success: true, message: formatBatchAddResult(added) };
           } catch (err) {

package/src/renderers/quests.ts

@@ -15,8 +15,10 @@ export function formatQuestRow(
   const posWidth = visibleWidth(posText);
   const idText = `[${q.id}]`;
 
-  // spacing is added to keep text aligned
-  const spacing = " ".repeat(visibleWidth(`${16 ** idLength}`) - posWidth);
+  // Reserve width for the widest position label ("#" + up to `16 ** idLength`)
+  // and clamp so an unexpectedly wide label can never crash the renderer.
+  const posColWidth = visibleWidth(`#${16 ** idLength}`);
+  const spacing = " ".repeat(Math.max(0, posColWidth - posWidth));
   const idStr = `${theme.fg("muted", idText)} ${theme.fg(q.done ? "dim" : "accent", `${posText}`)}${spacing}`;
 
   // for steps, use a different marker and indent
@@ -36,8 +38,9 @@ export function formatQuestRow(
 
 export function formatStepSpacerLine(theme: Theme, idLength: number): string {
   const idTextLength = visibleWidth(`${16 ** idLength}`);
+  const posColWidth = visibleWidth(`#${16 ** idLength}`);
   // spacing for `[id](position string)`
-  const spacerStr = `${" ".repeat(idTextLength + 2)}${" ".repeat(idTextLength)}`;
+  const spacerStr = `${" ".repeat(idTextLength + 2)}${" ".repeat(posColWidth)}`;
 
   const marker = theme.fg("muted", " │   ");
 

package/src/renderers/tools.ts

@@ -1,4 +1,4 @@
-import type { AgentToolResult, Theme } from "@earendil-works/pi-coding-agent";
+import { type AgentToolResult, keyHint, type Theme } from "@earendil-works/pi-coding-agent";
 import { Text } from "@earendil-works/pi-tui";
 import type { ResolvedConfig } from "../config.js";
 import { logger } from "../logger.js";
@@ -15,6 +15,28 @@ type QuestArgs = {
   all?: boolean;
 };
 
+/**
+ * Maximum number of result lines shown while a tool row is collapsed.
+ * Matches pi's default fallback preview so quest output behaves like built-in tools.
+ */
+export const COLLAPSED_PREVIEW_LINES = 10;
+
+/**
+ * Applies pi's standard compact-view treatment: the collapsed view shows a preview and an
+ * expand hint (`app.tools.expand`, ctrl+o by default); the expanded view shows every line.
+ */
+function collapseLines(lines: string[], expanded: boolean, theme: Theme): string {
+  if (expanded || lines.length <= COLLAPSED_PREVIEW_LINES) return lines.join("\n");
+
+  const displayLines = lines.slice(0, COLLAPSED_PREVIEW_LINES);
+  const remaining = lines.length - displayLines.length;
+  const hint =
+    theme.fg("muted", `... (${remaining} more lines,`) +
+    ` ${keyHint("app.tools.expand", "to expand")}${theme.fg("muted", ")")}`;
+
+  return `${displayLines.join("\n")}\n${hint}`;
+}
+
 export function renderQuestCall(args: QuestArgs, theme: Theme, _context: unknown): Text {
   const id = "id" in args ? args.id : undefined;
   logger.debug("quests:tool", "renderCall", { action: args.action, id });
@@ -88,8 +110,12 @@ export function renderQuestResult(config: ResolvedConfig) {
       questsToRender.length === 0 ||
       !Array.isArray(allQuests)
     ) {
-      const text = result.content.map((c) => (c.type === "text" ? c.text : "[image]")).join("\n");
-      return new Text(theme.fg("text", text), 0, 0);
+      const textLines = result.content
+        .map((c) => (c.type === "text" ? c.text : "[image]"))
+        .join("\n")
+        .split("\n")
+        .map((line) => theme.fg("text", line));
+      return new Text(collapseLines(textLines, options.expanded, theme), 0, 0);
     }
 
     const quests = allQuests;
@@ -134,6 +160,6 @@ export function renderQuestResult(config: ResolvedConfig) {
       }
     }
 
-    return new Text(lines.join("\n"), 0, 0);
+    return new Text(collapseLines(lines, options.expanded, theme), 0, 0);
   };
 }