pi-pr-review 1.17.7 → 1.17.8

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [1.17.8](https://github.com/10ego/pi-pr-review/compare/v1.17.7...v1.17.8) (2026-09-01)
+
+
+### Bug Fixes
+
+* **review:** publish retained incomplete findings ([#138](https://github.com/10ego/pi-pr-review/issues/138)) ([586205b](https://github.com/10ego/pi-pr-review/commit/586205bbe46b50e04f00d53d43b3c353c3bea95e))
+
 ## [1.17.7](https://github.com/10ego/pi-pr-review/compare/v1.17.6...v1.17.7) (2026-09-01)
 
 

package/README.md

@@ -195,7 +195,7 @@ Every invocation has a host-owned monotonic 15-minute hard cap, including the tw
 
 A timed-out or retryable quota/rate-limit/capacity lane may start at most one configured fallback attempt. It starts only when at least `minimumFallbackMs` plus cleanup reserve remains; the host never changes the configured model, thinking level, or tool policy to save time. If a tier is unset, its existing nearest-configured-tier/Pi-default behavior is unchanged.
 
-On an attempt deadline the host records timeout separately from user cancellation, sends TERM to the original child, waits only `terminationGraceMs`, then sends KILL if no exit was observed and stops draining after the cleanup reserve. Partial assistant text and telemetry survive this lifecycle. The synthesis cap arms only once review work goes quiet: any turn that starts or any review tool that runs again while the cap is armed defers it, and it re-arms from the next turn end, so early review-tool turns (for example verification discovery) cannot starve later heavy lanes. Batch/total expiry stops queued work and waiting lanes; completed and partial artifacts proceed to Markdown synthesis or deterministic lane assembly, identify every incomplete reviewer, and remain eligible for concise `COMMENT` publication. Complete contract-valid candidate blocks retained before a timeout are deterministically recovered as canonical findings, including when terminal synthesis is absent; a truncated final block and arbitrary lane prose remain private. A timed-out lane is never reported as `NO FINDINGS` or full coverage, and a lane ended by the host total or synthesis deadline is disclosed with that kind (`deadline_expired`) instead of being mistaken for its own attempt deadline expiring. Host lane artifacts are authoritative for completeness in both directions: a false assistant completion claim cannot upgrade incomplete lanes, and a paraphrased or omitted `Lane completeness` line cannot downgrade a host-complete batch away from the concise renderer.
+On an attempt deadline the host records timeout separately from user cancellation, sends TERM to the original child, waits only `terminationGraceMs`, then sends KILL if no exit was observed and stops draining after the cleanup reserve. Partial assistant text and telemetry survive this lifecycle. The synthesis cap arms only once review work goes quiet: any turn that starts or any review tool that runs again while the cap is armed defers it, and it re-arms from the next turn end, so early review-tool turns (for example verification discovery) cannot starve later heavy lanes. Batch/total expiry stops queued work and waiting lanes; completed and partial artifacts proceed to Markdown synthesis or deterministic lane assembly, identify every incomplete reviewer, and remain eligible for concise `COMMENT` publication. Complete contract-valid candidate blocks retained before a timeout are deterministically recovered as canonical findings from the terminal lane output and retained primary/fallback attempt history, including when a later attempt or terminal synthesis is empty or malformed. Host-recorded attempt ordinals—not array position—define chronology; duplicate ordinals disable history recovery, a later exact clean contract supersedes older provisional findings, and truncated blocks or arbitrary lane prose remain private. A timed-out lane is never reported as `NO FINDINGS` or full coverage, and a lane ended by the host total or synthesis deadline is disclosed with that kind (`deadline_expired`) instead of being mistaken for its own attempt deadline expiring. Host lane artifacts are authoritative for completeness in both directions: a false assistant completion claim cannot upgrade incomplete lanes, and a paraphrased or omitted `Lane completeness` line cannot downgrade a host-complete batch away from the concise renderer.
 
 Initial operating targets are ordinary-review p50 ≤ 6 minutes and p95 ≤ 12 minutes, and large-review p50 ≤ 10 minutes and p95 ≤ 14 minutes, with the 15-minute hard cap authoritative. Invocation telemetry starts before GitHub preflight and records configured deadline source/caps, termination grace, cleanup reserve, and active wall time; batch details record invocation time consumed before each attempt, batch/total time remaining at dispatch, first event/output timing, lifecycle counts, configured and effective batch-truncated attempt deadlines, fallback starts/budget rejections, external total/synthesis deadline expiries per lane, and termination grace/escalation data. These are initial production targets, not a promise that every provider completes before its host deadline.
 
@@ -231,7 +231,7 @@ Review semantics are Markdown-first. A deterministic tolerant parser normalizes
 
 You can publish the cache later with `/pr-review-publish 123`, or directly ask the agent to “post the inline review,” “manually post the review comments,” “post it as an inline review,” or “publish the review for PR #123.” The extension handles that request directly before an agent turn. `/pr-review-publish` and a matching direct request publish only the cache; they never start or rerun review agents. Unnumbered direct requests select the latest cached review for the current repository. Only fresh interactive/RPC input can use the direct path.
 
-Every authorized publish path builds one GitHub review payload and sends at most one review `POST`; it never submits `REQUEST_CHANGES` or retries a rejected write with a fallback POST. Fully parsed Markdown with one complete retained artifact for every host-registered dispatch may emit a gated `APPROVE` through the same host binding, priority, lifecycle, self-author, and stale checks as strict JSON. Host lane evidence is authoritative for completeness: a paraphrased or omitted `All requested lanes completed.` disclosure cannot downgrade a host-complete batch, and a false disclosure cannot upgrade incomplete or missing lane coverage; the assistant's canonical line is consulted only when no batch evidence exists. Verdict fields outside the document preamble, hidden in CommonMark code/HTML blocks, or inside lazy container continuations, severity-tagged headings outside `Findings`, incomplete or missing host lane coverage, malformed or unsafe output, and lane-fallback artifacts remain `COMMENT` reviews; their safely parsed findings keep inline placement, while unparsable output publishes body-only. Cache restore reclassifies persisted lane output and requires the exact host-recorded artifact key set, with every complete artifact matching the frozen invocation generation, tier, and minor-hygiene contract, and re-synthesizes the retained raw text under that frozen binding before retaining approval eligibility. For a current, open PR, the first 50 eligible P0–P3 findings with valid, unique diff anchors are inline. The concise top-level body starts with the verdict, points readers to inline findings, and places nits, off-diff findings, unavailable diff metadata, duplicate anchors, and overflow under `Other Notes`; overview, verification, strengths, completion warnings, and transport diagnostics stay out of the public summary. The complete original Markdown and retained lane evidence remain internal and are never substituted for a concise GitHub review, including degraded, incomplete, cached, direct, and stale `COMMENT` publication. If the concise body plus its canonical marker exceeds GitHub's limit, publication fails closed rather than dumping the full report. Stale or authorized non-open reviews are body-only. A stale approval additionally requires `allowStaleApprovals: true`.
+Every authorized publish path builds one GitHub review payload and sends at most one review `POST`; it never submits `REQUEST_CHANGES` or retries a rejected write with a fallback POST. Fully parsed Markdown with one complete retained artifact for every host-registered dispatch may emit a gated `APPROVE` through the same host binding, priority, lifecycle, self-author, and stale checks as strict JSON. Host lane evidence is authoritative for completeness: a paraphrased or omitted `All requested lanes completed.` disclosure cannot downgrade a host-complete batch, and a false disclosure cannot upgrade incomplete or missing lane coverage; the assistant's canonical line is consulted only when no batch evidence exists. Verdict fields outside the document preamble, hidden in CommonMark code/HTML blocks, or inside lazy container continuations, severity-tagged headings outside `Findings`, incomplete or missing host lane coverage, malformed or unsafe output, and lane-fallback artifacts remain `COMMENT` reviews; their safely parsed findings keep inline placement, while unparsable output publishes body-only. Cache restore reclassifies persisted lane output and requires the exact host-recorded artifact key set, with every complete artifact matching the frozen invocation generation, tier, and minor-hygiene contract, and re-synthesizes the retained raw text under that frozen binding before retaining approval eligibility. For a current, open PR, the first 50 eligible P0–P3 findings with valid, unique diff anchors are inline. The concise top-level body starts with the verdict, points readers to inline findings, and places nits, off-diff findings, unavailable diff metadata, duplicate anchors, and overflow under `Other Notes`; overview, verification, strengths, completion warnings, and transport diagnostics stay out of the public summary. Incomplete/degraded reviews publish whenever synthesis, retained attempts, or validated extraction produced at least one canonical finding. If none did, the completed record remains available privately and GitHub publication is skipped rather than creating a verdict-only review. The complete original Markdown and retained lane evidence remain internal and are never substituted for a concise GitHub review, including degraded, incomplete, cached, direct, and stale `COMMENT` publication. If the concise body plus its canonical marker exceeds GitHub's limit, publication fails closed rather than dumping the full report. Stale or authorized non-open reviews are body-only. A stale approval additionally requires `allowStaleApprovals: true`.
 
 All publication paths apply host-enforced safety gates: captured posting authority, repository and requested-PR binding, reviewed/current-head and stale policy, bounded bodies and payloads, draft and lifecycle checks, non-open authorization, authenticated-identity same-head duplicate detection, and a final head check. Fully or partially parsed review paths additionally enforce safe inline locations, including degraded incomplete-lane reviews whose findings still parse. Raw and lane-assembled fallbacks without parsed findings are body-only; every degraded path is `COMMENT`-only, and assistant text cannot select event, commit, repository, hostname, API path, or inline anchors. Unknown or invalid host states fail closed before a write.
 

package/extensions/review-table.ts

@@ -461,6 +461,14 @@ async function publishCompletedReview(
 	}
 	const degradedPublication = record.completeness === "incomplete" ||
 		(record.synthesisQuality !== undefined && record.synthesisQuality !== "fully_parsed");
+	const findings = Array.isArray(record.review.findings) ? record.review.findings : [];
+	if (degradedPublication && findings.length === 0) {
+		// A result-less degraded record remains cached for private diagnostics and a
+		// later rerun, but must not create a verdict-only GitHub review. Incomplete
+		// reviews with any validated synthesis/lane/extraction finding still publish.
+		ctx.ui.notify("PR review was not posted: the incomplete review retained no validated findings", "warning");
+		return undefined;
+	}
 	const result = await publishPullReview({
 		cwd: ctx.cwd,
 		prNumber: record.invocation.prNumber,
@@ -475,9 +483,6 @@ async function publishCompletedReview(
 		// inline findings. Retained raw synthesis and lane evidence remain private
 		// completion diagnostics, including for degraded/incomplete COMMENT runs.
 		// If the concise payload cannot fit, publication fails closed.
-		forceBodyOnly: record.synthesisQuality !== undefined &&
-			record.synthesisQuality !== "fully_parsed" &&
-			!(Array.isArray(record.review.findings) && record.review.findings.length > 0),
 		// A publication body identifies Markdown-derived or degraded synthesis.
 		// Enforce COMMENT again at the final publication boundary so restored
 		// canonical artifacts created by an older parser cannot inherit APPROVE.
@@ -1076,7 +1081,7 @@ export default function registerReviewTable(
 			}
 		}
 		const publishResult = await publishCompletedReview(pending.record, { kind: "frozen-invocation" }, ctx);
-		if (pending.extraction) {
+		if (pending.extraction && publishResult) {
 			try {
 				// `published` decorates exactly the attempt whose merged event it
 				// follows: the spread carries that attempt's identity, so tooling can

package/lib/pr-review-artifacts.ts

@@ -480,6 +480,15 @@ function parseIntegratedCompletion(text: string): boolean {
  * output. A timed-out final block may be truncated; earlier complete blocks
  * remain usable, while arbitrary prose and unsafe containers recover nothing.
  */
+export function isValidatedReviewLaneNoFindings(
+	rawText: string,
+	expectedOutput: "review_lane" | "nonempty" = "review_lane",
+): boolean {
+	const text = normalizeReviewText(rawText);
+	if (expectedOutput === "review_lane") return /^NO FINDINGS\.?$/.test(text.trim());
+	return parseIntegratedCompletion(text) && text.split("\n").some((line) => line === NO_FINDINGS_SENTINEL);
+}
+
 export function extractValidatedReviewLaneCandidates(
 	rawText: string,
 	expectedOutput: "review_lane" | "nonempty" = "review_lane",

package/lib/pr-review-markdown.ts

@@ -2,6 +2,7 @@ import { Buffer } from "node:buffer";
 import { createHash } from "node:crypto";
 import {
 	extractValidatedReviewLaneCandidates,
+	isValidatedReviewLaneNoFindings,
 	type ExpectedReviewLane,
 	type ReviewLaneArtifact,
 } from "./pr-review-artifacts.ts";
@@ -492,6 +493,39 @@ function retainedLaneText(lane: ReviewLaneArtifact): string {
 	return "";
 }
 
+function retainedLaneCandidateTexts(
+	lane: ReviewLaneArtifact,
+	contract: "review_lane" | "nonempty",
+): string[] {
+	const texts: string[] = [];
+	const seen = new Set<string>();
+	const retain = (value: string): "continue" | "stop" => {
+		const text = value.trim();
+		if (!text || seen.has(text)) return "continue";
+		seen.add(text);
+		// A later exact clean contract supersedes provisional findings from older
+		// attempts. Malformed or empty later output does not.
+		if (isValidatedReviewLaneNoFindings(text, contract)) return "stop";
+		texts.push(text);
+		return "continue";
+	};
+	// The lane-level text is the latest authoritative output. Earlier attempts
+	// remain eligible only for independently contract-valid findings; malformed
+	// prose can neither become a finding nor poison a valid earlier attempt.
+	if (retain(lane.rawText) === "stop") return texts;
+	const ordinals = new Set<number>();
+	for (const attempt of lane.attempts) {
+		if (ordinals.has(attempt.ordinal)) return texts;
+		ordinals.add(attempt.ordinal);
+	}
+	const newestFirst = [...lane.attempts].sort((left, right) =>
+		left.ordinal === right.ordinal ? 0 : left.ordinal > right.ordinal ? -1 : 1);
+	for (const attempt of newestFirst) {
+		if (retain(attempt.rawText) === "stop") break;
+	}
+	return texts;
+}
+
 function retainedLaneFindings(
 	lanes: readonly ReviewLaneArtifact[],
 	expected: readonly ExpectedReviewLane[],
@@ -500,32 +534,34 @@ function retainedLaneFindings(
 	const seen = new Set<string>();
 	for (const lane of lanes) {
 		const contract = expected.find((descriptor) => descriptor.key === lane.key)?.expectedOutput ?? "review_lane";
-		for (const candidate of extractValidatedReviewLaneCandidates(retainedLaneText(lane), contract)) {
-			if (!candidate.prRelated) continue;
-			const parsedLocation = candidate.location === "repo-wide"
-				? { status: "absent" as const, location: null }
-				: parseLocation(`${candidate.location} ${candidate.side}`);
-			if (parsedLocation.status === "unsafe") continue;
-			const codeLocation = parsedLocation.location
-				? { ...parsedLocation.location, commentable: candidate.inDiff }
-				: null;
-			const key = JSON.stringify([
-				candidate.severity,
-				candidate.title,
-				candidate.why,
-				candidate.location,
-				candidate.side,
-			]);
-			if (seen.has(key)) continue;
-			seen.add(key);
-			findings.push({
-				title: candidate.title,
-				severity: candidate.severity,
-				blocking: candidate.severity === "P0" || candidate.severity === "P1",
-				body: candidate.why,
-				confidence_score: candidate.confidence,
-				code_location: codeLocation,
-			});
+		for (const text of retainedLaneCandidateTexts(lane, contract)) {
+			for (const candidate of extractValidatedReviewLaneCandidates(text, contract)) {
+				if (!candidate.prRelated) continue;
+				const parsedLocation = candidate.location === "repo-wide"
+					? { status: "absent" as const, location: null }
+					: parseLocation(`${candidate.location} ${candidate.side}`);
+				if (parsedLocation.status === "unsafe") continue;
+				const codeLocation = parsedLocation.location
+					? { ...parsedLocation.location, commentable: candidate.inDiff }
+					: null;
+				const key = JSON.stringify([
+					candidate.severity,
+					candidate.title,
+					candidate.why,
+					candidate.location,
+					candidate.side,
+				]);
+				if (seen.has(key)) continue;
+				seen.add(key);
+				findings.push({
+					title: candidate.title,
+					severity: candidate.severity,
+					blocking: candidate.severity === "P0" || candidate.severity === "P1",
+					body: candidate.why,
+					confidence_score: candidate.confidence,
+					code_location: codeLocation,
+				});
+			}
 		}
 	}
 	return findings;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-pr-review",
-  "version": "1.17.7",
+  "version": "1.17.8",
   "description": "Parallel AI code review for GitHub pull requests in the Pi coding agent, with model-agnostic tiered subagents, structured findings, optional verification, and host-gated COMMENT or qualified APPROVE publishing.",
   "keywords": [
     "pi-package",