pi-pr-review 1.14.0 → 1.14.2

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## [1.14.2](https://github.com/10ego/pi-pr-review/compare/v1.14.1...v1.14.2) (2026-08-23)
+
+
+### Bug Fixes
+
+* **extract:** scan lane evidence past the synthesis findings framing ([#77](https://github.com/10ego/pi-pr-review/issues/77)) ([dfebc36](https://github.com/10ego/pi-pr-review/commit/dfebc3632910fdde46581d4a48d236d72c7046df))
+
+## [1.14.1](https://github.com/10ego/pi-pr-review/compare/v1.14.0...v1.14.1) (2026-08-22)
+
+
+### Bug Fixes
+
+* **extract:** harden provenance and retained-binding handling from sample review ([#75](https://github.com/10ego/pi-pr-review/issues/75)) ([ff5206a](https://github.com/10ego/pi-pr-review/commit/ff5206ad94ec0a901c1a8398149d31445d49874b))
+
 ## [1.14.0](https://github.com/10ego/pi-pr-review/compare/v1.13.0...v1.14.0) (2026-08-22)
 
 

package/extensions/pr-review-subagent.ts

@@ -56,7 +56,7 @@ import {
 } from "../lib/pr-review-artifacts.ts";
 import { runWithConcurrency } from "../lib/pr-review-concurrency.ts";
 import { attemptDeadline, fallbackBudget, type ReviewBudget } from "../lib/pr-review-deadlines.ts";
-import { buildExtractionSystemPrompt, MAX_EXTRACTION_OUTPUT_BYTES } from "../lib/pr-review-extract.ts";
+import { buildExtractionSystemPrompt, buildExtractionTask, MAX_EXTRACTION_OUTPUT_BYTES } from "../lib/pr-review-extract.ts";
 import { loadReviewContext, shardUnifiedDiff } from "../lib/pr-review-context.ts";
 import {
 	combineAbortSignals,
@@ -2727,7 +2727,7 @@ export async function runFindingExtraction(
 			invocation.command,
 			invocation.args,
 			ctx.cwd,
-			input,
+			buildExtractionTask(input),
 			lease.signal,
 			undefined,
 			undefined,
@@ -2738,7 +2738,8 @@ export async function runFindingExtraction(
 			},
 		);
 		// Output blast-radius bound: reject oversized documents before parsing.
-		if (result.text.length > MAX_EXTRACTION_OUTPUT_BYTES) {
+		// Measured in UTF-8 bytes to match the parser's own budget.
+		if (Buffer.byteLength(result.text, "utf8") > MAX_EXTRACTION_OUTPUT_BYTES) {
 			return { text: "", exitCode: result.exitCode || 1, errorMessage: "extraction output exceeded the size cap" };
 		}
 		return {

package/extensions/review-table.ts

@@ -552,10 +552,14 @@ export default function registerReviewTable(
 				// Telemetry is best-effort and must never affect the review.
 			}
 		};
-		// A stale generation (replacement, cancellation, session switch) drops
-		// the merge entirely; the deterministic artifact was never completed.
 		if (!loopCoordinator.isLeaseActive(deferred.lease, ctx)) {
+			// Deadline expiry retains the same generation for deterministic
+			// degraded synthesis, so completion proceeds with the deterministic
+			// artifact. Only a genuine replacement (new generation) drops it.
 			recordOutcome("aborted");
+			if (loopCoordinator.retainedGenerationIs(deferred.lease.generation, ctx)) {
+				return { artifact: deferred.artifact };
+			}
 			return undefined;
 		}
 		let result: Awaited<PendingExtraction["promise"]>;
@@ -570,8 +574,12 @@ export default function registerReviewTable(
 		// Re-check ownership after the suspension: a replacement, cancellation,
 		// or session switch that landed while awaiting must not have this review
 		// consume the successor's invocation, publish, or revoke its binding.
+		// Same-generation deadline expiry still completes deterministically.
 		if (!loopCoordinator.isLeaseActive(deferred.lease, ctx)) {
 			recordOutcome("aborted");
+			if (loopCoordinator.retainedGenerationIs(deferred.lease.generation, ctx)) {
+				return { artifact: deferred.artifact };
+			}
 			return undefined;
 		}
 		if (result.timedOut) {
@@ -1091,7 +1099,10 @@ export default function registerReviewTable(
 		if (active && artifact && artifact.quality !== "fully_parsed") {
 			const setting = resolveExtractionSetting(getAgentDir());
 			if (setting.warning) ctx.ui.notify(setting.warning, "warning");
-			if (setting.enabled && !pendingExtraction) {
+			if (setting.enabled && !pendingExtraction && !loopCoordinator.deadlineExpired()) {
+				// acquire() must never see a deadline-expired binding: it would
+				// clear the retained invocation that degraded synthesis still
+				// needs. An expired deadline leaves no window for extraction.
 				const lease = loopCoordinator.acquire(ctx);
 				if (lease) {
 					const input = buildExtractionInput(artifact.rawText, laneArtifacts);

package/lib/pr-review-extract.ts

@@ -89,6 +89,8 @@ export function buildExtractionSystemPrompt(): string {
 		"When the document names a file for the finding, also include: path (repo-relative file path exactly as written), start_line and end_line (integers from the document when stated), side (\"RIGHT\" for added lines, \"LEFT\" for removed lines), and location_quote (a verbatim substring of the document containing that path).",
 		"Optionally include source (the lane or section the finding came from).",
 		"Rules: report only findings actually stated in the document; never invent, merge, or upgrade severity; keep the reviewer's own wording in title and body; omit path fields when no location is stated; do not report strengths, summaries, or coverage notes as findings.",
+		"The synthesis's own Findings section is NOT authoritative about what the document states: a review summary saying \"No findings\" while a retained lane section states a concrete defect means that defect IS stated in the document and must be extracted.",
+		"Findings appear in any format: ### severity blocks, bulleted field lists (title/severity/why/location), or prose. Scan every section, including retained lane output, before deciding the document states no findings.",
 		"If the document states no findings, return {\"findings\":[]}.",
 		"Do not use tools, read files, or modify anything.",
 	].join("\n");
@@ -112,6 +114,23 @@ function truncateWithMarker(text: string, maxBytes: number, omittedBytes?: numbe
 }
 
 /** Assemble the bounded extraction payload: synthesis first, then lanes in order, each truncated with its own byte-count marker. */
+/**
+ * Host-authored framing wrapped around the data document. Without it the
+ * child treats the synthesis's own "Findings: No findings." framing as
+ * authoritative and misses defects stated in retained lane output (observed
+ * in the first production extraction run).
+ */
+export function buildExtractionTask(input: string): string {
+	return [
+		"Objective: Extract every concrete defect finding stated anywhere in this review document, including inside the retained lane output sections.",
+		"A \"No findings\" line written by the summary does not mean the document states no findings: check the lane sections too.",
+		"",
+		"--- Review document ---",
+		input,
+		"--- End of review document ---",
+	].join("\n");
+}
+
 export function buildExtractionInput(
 	rawText: string,
 	lanes: readonly ReviewLaneArtifact[],
@@ -189,7 +208,11 @@ function safeRelativePath(value: string): boolean {
 /** Verify a verbatim quote against the normalized input. */
 export function verifyQuote(quote: string, normalizedInput: string): boolean {
 	if (!quote || quote.length < MIN_QUOTE_CHARS || byteLength(quote) > MAX_QUOTE_BYTES) return false;
-	return normalizedInput.includes(normalizeForQuote(quote));
+	const normalized = normalizeForQuote(quote);
+	// Whitespace-only or control-heavy quotes normalize away; the normalized
+	// form must itself clear the minimum length before it can match.
+	if (normalized.length < MIN_QUOTE_CHARS) return false;
+	return normalizedInput.includes(normalized);
 }
 
 function deriveBlocking(severity: string): boolean {
@@ -197,8 +220,10 @@ function deriveBlocking(severity: string): boolean {
 }
 
 function normalizeFinding(wire: ExtractedFindingWire): ReviewFindingLike | undefined {
-	const title = String(wire.title ?? "").trim();
-	const body = String(wire.body ?? "").trim();
+	// Non-string fields are contract violations, not values to stringify.
+	if (typeof wire.title !== "string" || typeof wire.body !== "string") return undefined;
+	const title = wire.title.trim();
+	const body = wire.body.trim();
 	const severity = String(wire.severity ?? "");
 	if (!title || byteLength(title) > MAX_TITLE_BYTES) return undefined;
 	if (!body || byteLength(body) > MAX_BODY_BYTES) return undefined;
@@ -263,6 +288,10 @@ export function parseExtractionOutput(text: string, input: string): ExtractionPa
 	if (!Array.isArray(record.findings)) {
 		return { ok: false, rejection: { kind: "rejected", reason: "findings was not an array" } };
 	}
+	// Bound the scan before any per-record provenance work.
+	if (record.findings.length > MAX_EXTRACTED_FINDINGS) {
+		return { ok: false, rejection: { kind: "rejected", reason: `more than ${MAX_EXTRACTED_FINDINGS} findings` } };
+	}
 	const normalizedInput = normalizeForQuote(input);
 	const findings: ReviewFindingLike[] = [];
 	let rejectedProvenance = 0;
@@ -308,9 +337,6 @@ export function parseExtractionOutput(text: string, input: string): ExtractionPa
 		}
 		findings.push(finding);
 	}
-	if (findings.length > MAX_EXTRACTED_FINDINGS) {
-		return { ok: false, rejection: { kind: "rejected", reason: `more than ${MAX_EXTRACTED_FINDINGS} findings` } };
-	}
 	return {
 		ok: true,
 		value: {

package/lib/pr-review-loop.ts

@@ -413,6 +413,21 @@ export class ReviewLoopCoordinator {
 		return this.binding?.deadlineKind !== undefined;
 	}
 
+	/**
+	 * Whether `generation` still names the deadline-expired binding that is
+	 * deliberately retained for deterministic degraded synthesis. True only for
+	 * the same session/cwd binding with an active deadline kind — never for a
+	 * replacement generation, a cleared loop, or a live lease.
+	 */
+	retainedGenerationIs(
+		generation: number,
+		ctx: Pick<ExtensionContext, "cwd" | "sessionManager">,
+	): boolean {
+		const binding = this.binding;
+		return !!binding && binding.generation === generation &&
+			binding.deadlineKind !== undefined && sameBinding(binding, ctx);
+	}
+
 	totalDeadlineExpired(): boolean {
 		return this.binding?.deadlineKind === "total";
 	}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-pr-review",
-  "version": "1.14.0",
+  "version": "1.14.2",
   "description": "Parallel AI code review for GitHub pull requests in the Pi coding agent, with model-agnostic tiered subagents, structured findings, optional verification, and host-gated COMMENT or qualified APPROVE publishing.",
   "keywords": [
     "pi-package",