pi-pr-review 1.10.3 → 1.10.4

package/.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "1.10.3"
+  ".": "1.10.4"
 }

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [1.10.4](https://github.com/10ego/pi-pr-review/compare/v1.10.3...v1.10.4) (2026-07-15)
+
+
+### Bug Fixes
+
+* **publish:** summarize findings without diff patches ([#29](https://github.com/10ego/pi-pr-review/issues/29)) ([bdee1ff](https://github.com/10ego/pi-pr-review/commit/bdee1ff024863019a2f357b04cffe944006a5726))
+
 ## [1.10.3](https://github.com/10ego/pi-pr-review/compare/v1.10.2...v1.10.3) (2026-07-15)
 
 

package/README.md

@@ -186,7 +186,7 @@ The extension—not the model—owns publishing. It creates one formal review wi
 
 If the agent's final review is not valid exact-contract JSON, the extension logs the validation reason and automatically asks the same agent to correct its completed output once, with all tools disabled and without changing the captured posting authority. A valid correction is cached and publication is attempted under the original flags/config. If that single correction is also invalid or attempts to call a tool, publication stops and reports the error instead of looping. Overlapping input cancels the correction, remains unqueued, and must be retried after the agent settles.
 
-Closed or merged PRs use a body-only review. Open PRs attach eligible P0–P3 findings as inline comments and keep nits or off-diff findings in the review body. When multiple findings target the same diff anchor, the first is attached inline and later findings remain in the review body so publication neither fails nor drops review content.
+Closed or merged PRs use a body-only review. Open PRs attach eligible P0–P3 findings as inline comments and keep nits or off-diff findings in the review body. When GitHub omits patch metadata needed to validate an inline anchor, the affected finding remains in the review summary instead of blocking publication. When multiple findings target the same diff anchor, the first is attached inline and later findings remain in the review body so publication neither fails nor drops review content.
 
 After a review completes, you can directly ask the agent to “post the inline review” or “post it as an inline review.” The extension handles that request directly before an agent turn, selecting the latest cached review for an unnumbered request or the named PR in “publish the review for PR #123.” Only fresh interactive/RPC input can trigger this path; extension-generated, queued, or steering input cannot. The extension publishes only validated cached content, never replacement model-authored text, and never starts or reruns review agents. A direct request permits stale publication.
 

package/lib/pr-review-publish.ts

@@ -837,6 +837,7 @@ function isInlineSeverity(finding: ReviewFindingLike): boolean {
 export interface CommentValidationResult {
 	comments: PublishComment[];
 	errors: string[];
+	warnings?: string[];
 }
 
 export function validateInlineComments(
@@ -844,6 +845,7 @@ export function validateInlineComments(
 	changedFiles: ChangedFileLike[],
 ): CommentValidationResult {
 	const errors: string[] = [];
+	const warnings: string[] = [];
 	const comments: PublishComment[] = [];
 	const files = new Map<string, ChangedFileLike>();
 	for (const file of changedFiles) {
@@ -876,7 +878,9 @@ export function validateInlineComments(
 			continue;
 		}
 		if (!file.patch) {
-			errors.push(`${label}: diff patch is unavailable for anchor validation`);
+			// GitHub legitimately omits patch metadata for some large, binary, or transiently unavailable diffs.
+			// Keep the complete finding in the review summary rather than sending an unvalidated inline anchor.
+			warnings.push(`${label}: diff patch is unavailable; kept in the review summary`);
 			continue;
 		}
 		const sideKey = side === "LEFT" ? "left" : "right";
@@ -913,7 +917,7 @@ export function validateInlineComments(
 	if (comments.length > MAX_INLINE_COMMENTS) {
 		errors.push(`too many inline comments (${comments.length}; max ${MAX_INLINE_COMMENTS})`);
 	}
-	return { comments, errors };
+	return { comments, errors, warnings };
 }
 
 export function collectFoldedComments(review: ReviewLike): CommentValidationResult {
@@ -954,7 +958,7 @@ export function collectFoldedComments(review: ReviewLike): CommentValidationResu
 			...(Number(start) < Number(end) ? { start_line: Number(start), start_side: side } : {}),
 		});
 	}
-	return { comments, errors };
+	return { comments, errors, warnings: [] };
 }
 
 export function foldInlineComments(summary: string, comments: PublishComment[]): string {
@@ -1244,6 +1248,7 @@ export async function publishPullReview(input: {
 		if (!lifecycle.lifecycle) return { status: "failed", message: lifecycle.error ?? "invalid PR lifecycle" };
 		const isOpen = lifecycle.lifecycle === "open";
 		let comments: PublishComment[] = [];
+		let inlineWarningCount = 0;
 		if (!isOpen) {
 			const candidates = collectFoldedComments(review);
 			if (candidates.errors.length > 0) {
@@ -1270,6 +1275,7 @@ export async function publishPullReview(input: {
 					return { status: "failed", message: `inline validation failed: ${validated.errors.join("; ")}` };
 				}
 				comments = validated.comments;
+				inlineWarningCount = validated.warnings?.length ?? 0;
 			}
 		}
 
@@ -1316,6 +1322,10 @@ export async function publishPullReview(input: {
 			return { status: "failed", message: `final head check failed: ${String(error)}` };
 		}
 
+		const inlineWarning = inlineWarningCount > 0
+			? `; ${inlineWarningCount} inline finding${inlineWarningCount === 1 ? "" : "s"} kept in the summary because GitHub omitted diff patch metadata`
+			: "";
+		const degraded = !isOpen || headPlan.stale || inlineWarningCount > 0;
 		const post = await runGh(
 			githubApiArgs(hostname, "--method", "POST", `repos/${repository}/pulls/${prNumber}/reviews`, "--input", "-"),
 			cwd,
@@ -1328,13 +1338,12 @@ export async function publishPullReview(input: {
 			} catch {
 				/* accepted response without parseable metadata */
 			}
-			const degraded = !isOpen || headPlan.stale;
 			return {
 				status: degraded ? "posted_degraded" : "posted",
 				message: headPlan.stale
 					? `body-only stale COMMENT review posted (${headPlan.reviewedHeadSha} -> ${headPlan.currentHeadSha})`
 					: isOpen
-						? "GitHub COMMENT review posted"
+						? `GitHub COMMENT review posted${inlineWarning}`
 						: "body-only COMMENT review posted for non-open PR",
 				reviewId: response.id,
 				url: response.html_url,
@@ -1344,8 +1353,8 @@ export async function publishPullReview(input: {
 		try {
 			if (await hasExistingMarker(cwd, hostname, repository, prNumber, identity, normalizedHeadSha)) {
 				return {
-					status: !isOpen || headPlan.stale ? "posted_degraded" : "posted",
-					message: "GitHub review found during failure reconciliation",
+					status: degraded ? "posted_degraded" : "posted",
+					message: `GitHub review found during failure reconciliation${inlineWarning}`,
 					reconciled: true,
 				};
 			}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-pr-review",
-  "version": "1.10.3",
+  "version": "1.10.4",
   "description": "Parallel AI code review for GitHub pull requests in the Pi coding agent, with model-agnostic tiered subagents, structured findings, optional verification, and safe COMMENT-only publishing.",
   "keywords": [
     "pi-package",

package/prompts/pr-review.md

@@ -194,7 +194,7 @@ The orchestrator must never call `gh` to post comments or reviews. Always finish
 - `--comment` → force publication for this run, but never bypass validation, stale-head checks, or duplicate checks
 - `--no-comment` → suppress publication for this run
 
-When enabled, the extension creates exactly one formal GitHub pull-request review. Its top-level body contains the overview, verification, strengths, suggested verdict, counts, nits, and findings that cannot be attached inline. Eligible P0–P3 diff-anchored findings are attached as inline comments within that same review and are omitted from the top-level issue list to avoid duplication. If multiple findings share one diff anchor, the first is attached inline and later findings remain in the top-level body instead of failing publication or dropping content. The API event is hardcoded to `COMMENT`: publication never sends `APPROVE` or `REQUEST_CHANGES`, even when the suggested verdict is `request_changes`. It appends the same-head marker, verifies the current head, validates every inline anchor against GitHub diff metadata, and refuses partial open-PR publication. For a known closed/merged PR it requires either trusted `--include-closed`/`--review-closed` invocation authority or the one-shot affirmative confirmation flow, then posts one body-only `COMMENT` review with each inline finding folded into the body exactly once. Unknown lifecycle states and unconfirmed non-open writes fail without posting or falling back to an issue comment.
+When enabled, the extension creates exactly one formal GitHub pull-request review. Its top-level body contains the overview, verification, strengths, suggested verdict, counts, nits, and findings that cannot be attached inline. Eligible P0–P3 diff-anchored findings are attached as inline comments within that same review and are omitted from the top-level issue list to avoid duplication. If GitHub omits patch metadata needed to validate an anchor, that finding remains in the top-level body instead of blocking publication. If multiple findings share one diff anchor, the first is attached inline and later findings remain in the top-level body instead of failing publication or dropping content. The API event is hardcoded to `COMMENT`: publication never sends `APPROVE` or `REQUEST_CHANGES`, even when the suggested verdict is `request_changes`. It appends the same-head marker, verifies the current head, validates every attempted inline anchor against GitHub diff metadata, and refuses partial open-PR publication. For a known closed/merged PR it requires either trusted `--include-closed`/`--review-closed` invocation authority or the one-shot affirmative confirmation flow, then posts one body-only `COMMENT` review with each inline finding folded into the body exactly once. Unknown lifecycle states and unconfirmed non-open writes fail without posting or falling back to an issue comment.
 
 The extension caches the latest valid completed review per repository and PR before publication preflight in the current Pi session. The session-backed cache survives extension reloads and session resumes but is bound to the originating session instance and repository. On a later turn, the extension intercepts that direct input before an agent turn, publishes only extension-cached content, permits stale publication, and cannot rerun review agents. Stale publication is also enabled by default through the invocation-captured `allowStalePublish` setting. Every stale review is body-only, displays a warning with the reviewed and preflight-observed commit hashes, and omits potentially invalid inline anchors. If the captured setting disabled stale publication, the user can still run `/pr-review-publish <PR-NUM> --allow-stale`. Never rerun the review merely to change posting intent, and never attempt a direct GitHub write yourself.
 

package/tests/pr-review-extension-lifecycle.test.ts

@@ -118,11 +118,12 @@ fi
 	return dir;
 }
 
-function installFakePublishingGh(currentHead = "a".repeat(40)): string {
+function installFakePublishingGh(currentHead = "a".repeat(40), patchless = false): string {
 	const dir = mkdtempSync(join(tmpdir(), "pi-pr-review-publish-tool-"));
 	tempDirs.push(dir);
 	const gh = join(dir, "gh");
 	const payloadPath = join(dir, "payload.json");
+	const changedFiles = patchless ? '[[{"filename":"src/parser.ts","status":"modified"}]]' : "[[]]";
 	writeFileSync(
 		gh,
 		`#!/usr/bin/env bash
@@ -137,6 +138,8 @@ elif [[ "$args" == *"pulls/7/reviews?per_page=100"* || "$args" == *"issues/7/com
 elif [[ "$args" == *"--method POST"* ]]; then
   cat > '${payloadPath}'
   echo '{"id":42,"html_url":"https://github.com/owner/repo/pull/7#pullrequestreview-42"}'
+elif [[ "$args" == *"pulls/7/files?per_page=100"* ]]; then
+  echo '${changedFiles}'
 elif [[ "$args" == *"repos/owner/repo/pulls/7"* ]]; then
   printf '{"state":"open","draft":false,"merged_at":null,"head":{"sha":"%s"}}\n' '${currentHead}'
 else
@@ -555,6 +558,41 @@ describe("completed review extension lifecycle", () => {
 		expect(payload.body).toContain(currentHead);
 	});
 
+	test("surfaces patchless inline fallback in the posted notification", async () => {
+		const patchlessReview: ReviewLike = {
+			...review,
+			findings: [
+				{
+					title: "[P2] Patchless finding",
+					severity: "P2",
+					blocking: false,
+					body: "This finding must remain visible in the summary.",
+					confidence_score: 0.9,
+					code_location: {
+						absolute_file_path: "src/parser.ts",
+						line_range: { start: 2, end: 2 },
+						side: "RIGHT",
+						commentable: true,
+					},
+				},
+			],
+		};
+		const cache = new CompletedReviewCache();
+		const record = cache.remember(patchlessReview, invocation, repository);
+		const persisted = cache.persist(record, session);
+		const cacheEntry = { type: "custom", id: "cache", customType: COMPLETED_REVIEW_ENTRY_TYPE, data: persisted };
+		const harness = createHarness([cacheEntry]);
+		await harness.emit("session_start", { reason: "reload" });
+		const payloadPath = installFakePublishingGh("a".repeat(40), true);
+
+		await harness.commands.get("pr-review-publish")!("7", harness.ctx);
+
+		expect(harness.notifications.some((message) => message.includes("1 inline finding kept in the summary"))).toBeTrue();
+		const payload = JSON.parse(readFileSync(payloadPath, "utf8"));
+		expect(payload.comments).toBeUndefined();
+		expect(payload.body).toContain("[P2] Patchless finding");
+	});
+
 	test("rejects extension-generated, queued, and steering publish requests", async () => {
 		const persisted = persistedInlineReview();
 		const cacheEntry = { type: "custom", id: "cache", customType: COMPLETED_REVIEW_ENTRY_TYPE, data: persisted };

package/tests/pr-review-publish.test.ts

@@ -536,6 +536,68 @@ fi
 		}
 	});
 
+	test("publishes a current review with patchless findings in the summary", async () => {
+		const dir = mkdtempSync(join(tmpdir(), "pi-pr-review-gh-"));
+		const gh = join(dir, "gh");
+		const payloadPath = join(dir, "payload.json");
+		writeFileSync(
+			gh,
+			`#!/usr/bin/env bash
+set -euo pipefail
+args="$*"
+if [[ "$args" == "repo view --json nameWithOwner,url" ]]; then
+  echo '{"nameWithOwner":"owner/repo","url":"https://github.com/owner/repo"}'
+elif [[ "$args" == *" user --jq .login"* ]]; then
+  echo 'reviewer'
+elif [[ "$args" == *"--method POST"* ]]; then
+  cat > "$GH_FAKE_PAYLOAD"
+  echo '{"id":43,"html_url":"https://github.com/owner/repo/pull/7#pullrequestreview-43"}'
+elif [[ "$args" == *"pulls/7/reviews?per_page=100"* || "$args" == *"issues/7/comments?per_page=100"* ]]; then
+  echo '[]'
+elif [[ "$args" == *"pulls/7/files?per_page=100"* ]]; then
+  echo '[[{"filename":"src/parser.ts","status":"modified"}]]'
+elif [[ "$args" == *"repos/owner/repo/pulls/7"* ]]; then
+  printf '{"state":"open","draft":false,"merged_at":null,"head":{"sha":"%s"}}\n' "$GH_FAKE_CURRENT"
+else
+  echo "unexpected gh args: $args" >&2
+  exit 1
+fi
+`,
+		);
+		chmodSync(gh, 0o755);
+		const previousPath = process.env.PATH;
+		const previousPayload = process.env.GH_FAKE_PAYLOAD;
+		const previousCurrent = process.env.GH_FAKE_CURRENT;
+		const current = "a".repeat(40);
+		process.env.PATH = `${dir}:${previousPath ?? ""}`;
+		process.env.GH_FAKE_PAYLOAD = payloadPath;
+		process.env.GH_FAKE_CURRENT = current;
+		try {
+			const posted = await publishPullReview({
+				cwd: dir,
+				prNumber: 7,
+				headSha: current,
+				allowNonOpen: false,
+				expectedRepository: { hostname: "github.com", repository: "owner/repo" },
+				review,
+			});
+			expect(posted.status).toBe("posted_degraded");
+			expect(posted.message).toContain("1 inline finding kept in the summary");
+			const payload = JSON.parse(readFileSync(payloadPath, "utf8"));
+			expect(payload.comments).toBeUndefined();
+			expect(payload.body).toContain("[P2] Handle empty input");
+			expect(payload.body).toContain("Empty input currently returns the wrong value.");
+		} finally {
+			if (previousPath === undefined) delete process.env.PATH;
+			else process.env.PATH = previousPath;
+			if (previousPayload === undefined) delete process.env.GH_FAKE_PAYLOAD;
+			else process.env.GH_FAKE_PAYLOAD = previousPayload;
+			if (previousCurrent === undefined) delete process.env.GH_FAKE_CURRENT;
+			else process.env.GH_FAKE_CURRENT = previousCurrent;
+			rmSync(dir, { recursive: true, force: true });
+		}
+	});
+
 	test("preserves inline publication when the reviewed head is still current", () => {
 		const head = "a".repeat(40);
 		expect(planHeadPublication(head, head.toUpperCase(), false).plan).toMatchObject({
@@ -685,6 +747,18 @@ describe("atomic COMMENT review payload", () => {
 		expect(result.errors[0]).toContain("not inside one diff hunk");
 	});
 
+	test("keeps findings in the summary when GitHub omits patch metadata", () => {
+		const result = validateInlineComments(review, [{ filename: "src/parser.ts" }]);
+		expect(result.errors).toEqual([]);
+		expect(result.comments).toEqual([]);
+		expect(result.warnings).toEqual([
+			"finding 1: diff patch is unavailable; kept in the review summary",
+		]);
+		const summary = buildReviewSummary(review, result.comments);
+		expect(summary).toContain("2 total (0 inline, 2 summary-only)");
+		expect(summary).toContain("[P2] Handle empty input");
+	});
+
 	test("folds inline findings exactly once into a body-only non-open review", () => {
 		const folded = collectFoldedComments(review);
 		expect(folded.errors).toEqual([]);