pi-orchestrator-config 4.8.5 → 4.9.0

package/README.md

@@ -75,6 +75,7 @@ for `git-expert` to commit.
 | `/refine-review <url>`                                                                          | Refine and improve existing PR review comments                                                                                                                                                                                                                                                                                                                                                                                                             |
 | `/coderabbit-rate-limit [number\|url]`                                                          | Handle CodeRabbit rate limiting on PRs                                                                                                                                                                                                                                                                                                                                                                                                                     |
 | `/create-coms-feature-manager`                                                                  | Generate a coms feature-manager prompt customized for the current project (source template: `templates/coms-feature-manager-prompt.md`)                                                                                                                                                                                                                                                                                                                    |
+| `/create-commit <message>`                                                                      | Commit and push the current change set via git-expert (source template: `templates/commit-prompt.md` — stage exact files, commit, push, report sha)                                                                                                                                                                                                                                                                                                       |
 | `/query-db <command>`                                                                           | Query the review comments database                                                                                                                                                                                                                                                                                                                                                                                                                         |
 | `/external-ai <agent> [--model <model>] [--session-id <id>] [--fix\|--peer\|--resume] <prompt>` | Run prompts via AI CLIs directly (cursor, claude, gemini) — full model access                                                                                                                                                                                                                                                                                                                                                                              |
 | `/external-ai-models-refresh`                                                                   | Refresh cached AI CLI models for autocomplete                                                                                                                                                                                                                                                                                                                                                                                                              |
@@ -767,12 +768,30 @@ PI_PIDIFF_ENABLE=false pi
 | `myk-pi-tools pr claude-md`            | Fetch `CLAUDE.md` and `AGENTS.md` content for a PR's repository                                                                                |
 | `myk-pi-tools release create`          | Create a GitHub release with changelog                                                                                                         |
 | `myk-pi-tools db`                      | Review database query commands                                                                                                                 |
-| `myk-pi-tools reviews`                 | Review handling commands                                                                                                                       |
+| `myk-pi-tools reviews`                 | Review handling commands (fetch, poll, address, post, store)                                                                                   |
+| `myk-pi-tools reviews address`         | Apply replies/statuses to a fetched reviews JSON, then post and store it (see below)                                                           |
 | `myk-pi-tools memory`                  | Project memory commands — persistent per-repo learning                                                                                         |
 | `myk-pi-tools ai-cli`                  | AI CLI commands (cursor, claude, gemini)                                                                                                       |
 | `myk-pi-tools coderabbit`              | CodeRabbit commands (check, trigger, retry)                                                                                                    |
 | `myk-pi-tools settings get [key ...]`  | Resolve settings (project → global → env → default). No args = all keys                                                                        |
 
+`reviews address` — bulk-apply replies to a fetched reviews JSON, then post and store it:
+
+```bash
+myk-pi-tools reviews address [--json <reviews.json>] [--replies <mapping.txt>] [--set <status>]
+```
+
+- `--json`: reviews JSON to process (default: newest `pr-*-reviews.json` in `.pi/tmp`)
+- `--replies`: mapping file, one rule per line — `<path>:<line>|<reply>` or `*|<reply>` (matches all pending findings);
+  `#` comments and blank lines ignored
+- `--set`: target status for matched findings — `addressed` (default), `skipped`, `not_addressed`, or `failed`
+- Without `--replies`, pending findings that already carry a reply only get their status flipped (status-only mode)
+- Exit code `0` = replies posted and stored; non-zero = nothing matched, validation failed, or posting failed
+  (the JSON is kept for retry — re-running with the same or a corrected mapping resumes unposted entries)
+- Validation failures change nothing: a rule matching several distinct findings at one location, or a status `post`
+  rejects for Qodo sticky findings (`not_addressed`/`failed`; `skipped` only with an issue-spec-update reply),
+  exits non-zero before the JSON is saved
+
 ### What's protected
 
 **Filesystem isolation** — the container cannot access anything outside the mounted volumes:

package/agents/git-expert.md

@@ -135,7 +135,7 @@ Format rules:
 **Commit changes:**
 
 1. `git status` to see changes
-2. `git add <specific files>` for each file (NEVER `git add .`)
+2. `git add -- <specific files>` for each file (NEVER `git add .`; the `--` terminator prevents paths being read as options)
 3. Commit with proper format
 4. Report the result
 

package/extensions/pidiff/pidiff-ui/package.json

@@ -1,7 +1,7 @@
 {
   "name": "pidiff-ui",
   "private": true,
-  "version": "4.8.5",
+  "version": "4.9.0",
   "type": "module",
   "scripts": {
     "dev": "vite",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-orchestrator-config",
-  "version": "4.8.5",
+  "version": "4.9.0",
   "description": "Orchestrator pattern for pi: specialist subagents, enforcement, code review loop, workflow commands",
   "keywords": [
     "pi-package"

package/prompts/create-commit.md

@@ -0,0 +1,58 @@
+---
+description: "Commit and push the current change set via git-expert — /create-commit <message>"
+argument-hint: "<message>"
+---
+
+## Raw Arguments
+
+```text
+$ARGUMENTS
+```
+
+# Create Commit Prompt
+
+Generates the git-expert commit delegation from the template instead of composing
+the instruction prose. Only the file list and message vary per commit.
+
+## Workflow
+
+### Step 1: Read the Template
+
+Read the template file:
+
+```text
+~/.pi/agent/npm/node_modules/pi-orchestrator-config/templates/commit-prompt.md
+```
+
+Developer checkout fallback: `templates/commit-prompt.md` in the pi-config repo.
+This is the immutable source template. NEVER modify it.
+
+### Step 2: Fill Placeholders
+
+| Placeholder | Value |
+|-------------|-------|
+| `{{FILES}}` | Every file to commit, one hyphen bullet per file, exact paths — parse `git status --porcelain=v1 -z` per the rules below |
+| `{{MESSAGE}}` | Commit subject — the FIRST LINE of the raw arguments, nothing more. If empty, draft a conventional `type(scope): description` subject from the change set and confirm with the user |
+| `{{BODY}}` | The remainder of the raw arguments after the first line, if any — never duplicates `{{MESSAGE}}` content. Empty by default |
+
+**Parsing `git status --porcelain=v1 -z`** (NUL-delimited; avoids quote ambiguity):
+
+- Rename (`R`) and copy (`C`) records: list only the NEW/destination path
+- C-escaped quoted paths: decode to the real path; deleted paths: keep as-is
+- Paths containing newlines or control characters: render them in `printf '%q'` shell-escaped form so the bullet keeps one line — git-expert decodes before staging
+
+If `git status` shows files that clearly should not be committed (generated
+artifacts, `.env`, secrets), exclude them from `{{FILES}}` and say so.
+
+Never leave a `{{...}}` token in the output. If the commit text contains a run of
+four or more backticks, lengthen the template's code fences to exceed it
+(fences must always out-length any backtick run inside).
+
+### Step 3: Delegate
+
+Delegate the filled template to `git-expert` **verbatim** — no extra prose,
+no re-wording, no added instructions.
+
+### Step 4: Report
+
+Report git-expert's result: commit sha, branch, push outcome.

package/prompts/review-handler.md

@@ -371,11 +371,27 @@ No "this looks similar to the one I already fixed."**
 
 If any approved tasks weren't implemented, review with user.
 
-### Phase 5: Persist Decisions
+### Phase 5: Prepare Reply Mappings
 
-Update each JSON entry with `status` and `reply` fields before posting.
+🚨 **NEVER hand-edit the reviews JSON.** No python heredocs, no `jq`, no manual
+`status`/`reply` field mutation. The `myk-pi-tools reviews address` command applies
+replies, flips statuses, posts, and stores in one step — you only prepare mapping files.
 
-**Valid status values:**
+Write one mapping file per target status. Each line targets one finding:
+
+```text
+<path>:<line>|<reply>
+```
+
+- `<path>:<line>` — the finding's fetched `path` and `line`. A thread finding and its
+  paired sticky finding are addressed together automatically (the command handles
+  dedupe and pairing — you never target stickies separately).
+- `*` — matches ALL pending findings (single-line mapping file).
+- Group findings by their target status — Phase 8 runs one `reviews address` call per
+  status group.
+- Posting happens in Phase 8, AFTER commit/push — do not post before the fixes are pushed.
+
+**Valid status values (the `--set` flag for each mapping group):**
 
 | Status | Behavior |
 |--------|----------|
@@ -438,44 +454,52 @@ Skip asking the user — commit and push automatically.
 Code must be pushed before posting replies so that reviewers can see the fixes
 when threads are resolved.
 
-### Phase 8: Post Replies
+### Phase 8: Post Replies (via reviews address)
 
-Post all replies to GitHub and store results in the database.
-
-**Body comments (outside-diff, major, minor, nitpick, duplicate, qodo sticky):**
-
-Comments that don't have GitHub review threads (e.g., CodeRabbit outside-diff,
-major, minor, nitpick, and duplicate comments) are replied to via a single
-consolidated PR comment per reviewer. The comment mentions the reviewer (e.g., `@coderabbitai`)
-and includes sections for each comment with the decision made. This ensures
-automated reviewers know their comments were reviewed and won't re-raise them.
-
-Post replies to GitHub:
+Run one `reviews address` call per status group prepared in Phase 5 — each call applies
+the mapping, posts replies, resolves threads, and stores to the database:
 
 ```bash
-myk-pi-tools reviews post {json_path}
+myk-pi-tools reviews address --json {json_path} --replies {mapping_file} --set addressed
+myk-pi-tools reviews address --json {json_path} --replies {mapping_file} --set skipped
 ```
 
-If the command exits with a non-zero code, some threads failed to post.
-The command prints an ACTION REQUIRED message with the exact retry command.
-Re-run it to retry — only unposted entries are retried. Repeat until all succeed.
-
-**Output verification (MANDATORY):**
-
-After `reviews post` completes successfully, check the output:
+The command picks the newest `pr-*-reviews.json` in `.pi/tmp` when `--json` is omitted.
 
-- `Processed N threads` — N should equal the number of entries with status `addressed`, `not_addressed`, `skipped`, or `failed` (everything except `pending`)
-- `Resolved: N` — should be non-zero if any entries have status `addressed` or if AI-source entries have status `skipped`/`not_addressed`
-- If `Processed 0 threads`, the status values in the JSON are wrong — fix them to use valid values from the table above and re-run before proceeding
-- If output shows `Warning: Unknown status`, fix those entries — e.g., `"done"` or `"completed"` are not valid, use `"addressed"` instead
+**Multi-group retention:** while any findings remain pending (unposted, not
+auto-skipped), a successful run posts its group but does NOT store — the JSON is
+kept on disk for the remaining status-group runs. The final run (nothing pending)
+stores to the database and consumes the JSON. Run the groups in any order.
 
-Do NOT proceed to `reviews store` until `reviews post` shows the expected thread count.
-
-Store to database:
+**Body comments (outside-diff, major, minor, nitpick, duplicate, qodo sticky):**
 
-```bash
-myk-pi-tools reviews store {json_path}
-```
+Comments that don't have GitHub review threads (e.g., CodeRabbit outside-diff,
+major, minor, nitpick, and duplicate comments) are replied to via a single
+consolidated PR comment per reviewer — `reviews address` handles this exactly like
+`reviews post` did: the comment mentions the reviewer (e.g., `@coderabbitai`) and
+includes sections for each comment with the decision made. This ensures automated
+reviewers know their comments were reviewed and won't re-raise them.
+
+**Failure semantics (MANDATORY):**
+
+- **Exit 0** → all matched findings posted. Threads are resolved per the
+  Phase 5 status table — `addressed` (and AI-source `skipped`/`not_addressed`) threads
+  are resolved; **human `skipped`/`not_addressed` threads intentionally stay open** for
+  follow-up. Exit 0 never means every thread is resolved.
+  Storage happens only on the FINAL group: while pending findings remain the run posts
+  without storing (results live in the retained JSON until the last group's run stores
+  and consumes it).
+- **Non-zero exit** → the JSON is RETAINED on disk for a corrected re-run.
+  Read the printed error:
+  - `no findings matched` → a mapping `path:line` matches no pending finding — fix the
+    mapping file and re-run. Already-posted entries are never touched again, so re-runs
+    are always safe.
+  - Post/resolve failures → the output names the entries that failed; re-run the same
+    command. Re-runs retry BOTH unposted entries AND posted-but-unresolved threads
+    (entries with `posted_at` but no resolution are resumed automatically — a failed
+    resolve retries the already-posted thread).
+- **NEVER delete or hand-edit a retained JSON** — correct the mapping file and re-run
+  `reviews address`.
 
 ### Phase 9: Auto Polling Loop (--autorabbit / --autoqodo mode)
 

package/templates/commit-prompt.md

@@ -0,0 +1,38 @@
+# Commit Delegation — Template
+
+> **Usage:** The orchestrator fills every `{{PLACEHOLDER}}` and delegates the
+> filled text to git-expert. Delete this usage block when done.
+
+---
+
+Commit and push the current change set.
+
+**Files to stage — EXACTLY these, never `git add .` or `git add -A`:**
+
+{{FILES}}
+
+**Commit message** (subject only — never body content):
+
+````text
+{{MESSAGE}}
+````
+
+**Commit body** (omit entirely if empty):
+
+````text
+{{BODY}}
+````
+
+**Steps:**
+
+1. Stage each file listed above individually — always `git add -- <file>`
+   (the `--` terminator is mandatory; never let a path be read as an option),
+   one command naming every file is fine. Quote paths containing spaces or
+   special characters; if a path contains glob characters or pathspec magic
+   (`*`, `?`, `:` …), stage it as `git add -- ':(literal)<file>'` so it is
+   treated as an exact path, never a pattern. If a path was rendered in
+   shell-escaped form (`printf '%q'`), decode it before staging.
+2. Commit with the message (and body if present) above — use a HEREDOC for multi-line.
+   The message and body must never duplicate each other.
+3. Push the current branch to origin (set upstream with `-u` if the branch has none).
+4. Report: commit sha, branch, push result.