pi-open-agents 0.1.14 → 0.1.15

package/README.md

@@ -91,8 +91,10 @@ permission:
   "subagent": deny        # no delegation
 ```
 
-Tool names are normalized automatically: `write` → `edit`, `task` → `subagent`,
-`vscode` → `read`.
+Tool names are normalized automatically: `task` → `subagent`, `vscode` → `read`,
+`apply_patch` → `edit` (OpenCode-only tool). In pi, `write` and `edit` are
+**separate** tools — `write` creates/overwrites files, `edit` does search-and-
+replace — so they have separate permission categories.
 
 ### Auto-injected delegation guidance
 
@@ -118,6 +120,11 @@ This means:
 - Each subagent runs with exactly the model and tools it declares
 - Skills load per-agent, with wildcard support (`security-*`, `git-*`)
 
+The `--tools` whitelist is derived from both explicit `tools:` arrays and
+permission allow-lists. An agent with `permission: { read: allow, edit: allow }`
+will only get `read` and `edit` in the child process. Wildcard permissions
+(`*: allow`) cannot produce a finite whitelist — the child gets all tools.
+
 ### OpenCode compatibility
 
 Your `.opencode/agent/` files work as-is. The `tools` map format is auto-converted
@@ -133,6 +140,10 @@ tools:
   bash: false
 ```
 
+The `tools` map is converted to permission rules and **also restricts the
+subagent child process** — a subagent with `tools: { read: true, bash: false }`
+will only have access to the `read` tool when spawned.
+
 ### Mode-based visibility
 
 | `mode` | TUI selector | `subagent` tool | `set_agent` tool |
@@ -249,9 +260,12 @@ Optional cleanup:
 
 ## Development
 
+**Contributing?** Please read the [Contributing Guide](./CONTRIBUTING.md) before
+opening an issue or pull request.
+
 ```bash
 npm install
-npm test          # 84 tests
+npm test          # 117 tests
 npm run typecheck # tsc --noEmit
 ```
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-open-agents",
-  "version": "0.1.14",
+  "version": "0.1.15",
   "description": "Unified agent and subagent management for pi coding agent, with OpenCode-compatible agent definitions.",
   "keywords": [
     "pi-package",
@@ -64,6 +64,7 @@
   "devDependencies": {
     "@types/node": "^24.0.0",
     "tsx": "^4.19.0",
+    "typebox": "^1.3.10",
     "typescript": "^5.6.0"
   }
 }

package/src/tui/tools.ts

@@ -14,6 +14,7 @@ import { Type } from "typebox";
 import type { AgentDefinition } from "../types.ts";
 import { selectableAgents } from "../discovery/loader.ts";
 import type { AgentManager } from "../primary/manager.ts";
+import { isSubagentProcess } from "../subagent/env.ts";
 import { updateBanner } from "./banner.ts";
 
 /**
@@ -32,6 +33,10 @@ export function registerAgentTools(manager: AgentManager, pi: ExtensionAPI): voi
       reason: Type.Optional(Type.String({ description: "Reason for switching agents" })),
     }),
     async execute(_toolCallId, params, _signal, _onUpdate, ctx: ExtensionContext) {
+      if (isSubagentProcess(process.env)) {
+        throw new Error("set_agent is only available to the primary agent, not subagents.");
+      }
+
       const { agent: name, reason } = params;
 
       const agent = manager.getAgent(name);
@@ -40,6 +45,10 @@ export function registerAgentTools(manager: AgentManager, pi: ExtensionAPI): voi
         throw new Error(`Unknown agent "${name}". Available: ${available}`);
       }
 
+      if (agent.mode === "subagent") {
+        throw new Error(`Agent "${name}" is a subagent and cannot be set as the primary agent.`);
+      }
+
       const success = await manager.apply(name, pi, ctx);
       if (!success) {
         throw new Error(`Failed to apply agent "${name}"`);